105358 2012-12-18 15:55:16 -0800 Popupmenu on Windows should fade in instead of sliding in 2012-12-19 11:34:41 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned dglazkov jonlee roger_fong thorton webkit.review.bot oldest_to_newest 794123 0 roger_fong 2012-12-18 15:55:16 -0800 Most Windows applications use a dissolve when showing popup menus, we should match that. 794135 1 180049 roger_fong 2012-12-18 16:11:16 -0800 Created attachment 180049 patch 794138 2 roger_fong 2012-12-18 16:12:03 -0800 <rdar://problem/7611211> 794244 3 180049 webkit.review.bot 2012-12-18 18:19:40 -0800 Comment on attachment 180049 patch Attachment 180049 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15409407 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 794816 4 180049 thorton 2012-12-19 11:17:10 -0800 Comment on attachment 180049 patch View in context: https://bugs.webkit.org/attachment.cgi?id=180049&action=review > Source/WebCore/platform/win/PopupMenuWin.cpp:172 > + ::AnimateWindow(m_popup, defaultAnimationDuration, AW_BLEND); Does this exist on XP? Is it the expected behavior there? 794820 5 roger_fong 2012-12-19 11:20:25 -0800 It does unless we have WS_EX_COMPOSITED enabled as well, which we don't. According to the radar this is the behavior we want. 794829 6 roger_fong 2012-12-19 11:34:41 -0800 http://trac.webkit.org/changeset/138182 180049 2012-12-18 16:11:16 -0800 2012-12-19 11:21:13 -0800 patch popupmenupatch.patch text/plain 1803 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODA3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTE4ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUG9wdXAgbWVudSBvbiBXaW5k b3dzIHNob3VsZCBmYWRlIGluIGluc3RlYWQgb2Ygc2xpZGluZyBpbi4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTM1OAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNzYxMTIxMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDaGFuZ2luZyBwb3B1cCBtZW51IGRpc3BsYXkgYW5pbWF0aW9uIHRvIG1hdGNo IHdoYXQgbW9zdCBvdGhlciBXaW5kb3dzIGFwcGxpY2F0aW9ucyBkby4KKworICAgICAgICAqIHBs YXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBNZW51 V2luOjpzaG93KToKKwogMjAxMi0xMi0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBwb3NpdGlvbjpzdGlja3kgZWxlbWVudHMgdG8gYmUg bW92ZWQgYnkgdGhlIHNjcm9sbGluZyB0aHJlYWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCShyZXZpc2lvbiAxMzc3ODUpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTY4LDE0ICsxNjgsOCBAQCB2b2lkIFBvcHVwTWVudVdpbjo6c2hvdyhjb25zdCBJbnRSZWN0JiBy CiAgICAgaWYgKHNob3VsZEFuaW1hdGUpIHsKICAgICAgICAgUkVDVCB2aWV3UmVjdCA9IHswfTsK ICAgICAgICAgOjpHZXRXaW5kb3dSZWN0KGhvc3RXaW5kb3csICZ2aWV3UmVjdCk7Ci0KLSAgICAg ICAgaWYgKCE6OklzUmVjdEVtcHR5KCZ2aWV3UmVjdCkpIHsKLSAgICAgICAgICAgIC8vIFBvcHVw cyBzaG91bGQgc2xpZGUgaW50byB2aWV3IGF3YXkgZnJvbSB0aGUgPHNlbGVjdD4gYm94Ci0gICAg ICAgICAgICAvLyBOT1RFOiBUaGlzIG1heSBoYXZlIHRvIGNoYW5nZSBmb3IgVmlzdGEKLSAgICAg ICAgICAgIERXT1JEIHNsaWRlRGlyZWN0aW9uID0gKG1fd2luZG93UmVjdC55KCkgPCB2aWV3UmVj dC50b3AgKyB2aWV3LT5jb250ZW50c1RvV2luZG93KHIubG9jYXRpb24oKSkueSgpKSA/IEFXX1ZF Ul9ORUdBVElWRSA6IEFXX1ZFUl9QT1NJVElWRTsKLQotICAgICAgICAgICAgOjpBbmltYXRlV2lu ZG93KG1fcG9wdXAsIGRlZmF1bHRBbmltYXRpb25EdXJhdGlvbiwgQVdfU0xJREUgfCBzbGlkZURp cmVjdGlvbik7Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKCE6OklzUmVjdEVtcHR5KCZ2aWV3UmVj dCkpCisgICAgICAgICAgICA6OkFuaW1hdGVXaW5kb3cobV9wb3B1cCwgZGVmYXVsdEFuaW1hdGlv bkR1cmF0aW9uLCBBV19CTEVORCk7CiAgICAgfSBlbHNlCiAjZW5kaWYKICAgICAgICAgOjpTaG93 V2luZG93KG1fcG9wdXAsIFNXX1NIT1dOT0FDVElWQVRFKTsK