105349 2012-12-18 14:21:57 -0800 [Chromium/Skia] Check whether bitmap has pixels in image encoders 2012-12-19 09:17:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon senorblanco webkit.review.bot oldest_to_newest 794044 0 bsalomon 2012-12-18 14:21:57 -0800 [Chromium/Skia] Check whether bitmap has pixels in image encoders 794048 1 180026 bsalomon 2012-12-18 14:24:52 -0800 Created attachment 180026 Patch 794050 2 bsalomon 2012-12-18 14:27:28 -0800 Related cr bug: http://crbug.com/162551 794574 3 180144 bsalomon 2012-12-19 05:37:13 -0800 Created attachment 180144 Patch 794576 4 bsalomon 2012-12-19 05:38:49 -0800 The failure case was toDataURL on canvas2D when the allocating the readback bitmap failed. 794725 5 180144 senorblanco 2012-12-19 09:06:36 -0800 Comment on attachment 180144 Patch Looks good. r=me For testing this type of thing in the future, perhaps we could think about creating a mock SkPixelRef that leaves its pixels NULL when locked. 794734 6 180144 webkit.review.bot 2012-12-19 09:17:54 -0800 Comment on attachment 180144 Patch Clearing flags on attachment: 180144 Committed r138170: <http://trac.webkit.org/changeset/138170> 794735 7 webkit.review.bot 2012-12-19 09:17:57 -0800 All reviewed patches have been landed. Closing bug. 180026 2012-12-18 14:24:52 -0800 2012-12-19 05:37:10 -0800 Patch bug-105349-20121218172209.patch text/plain 3309 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODA2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTE4ICBCcmlhbiBT YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ2hyb21pdW0vU2tpYV0g Q2hlY2sgd2hldGhlciBiaXRtYXAgaGFzIHBpeGVscyBpbiBpbWFnZSBlbmNvZGVycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzQ5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhZGRzIE5VTEwg Y2hlY2tzIHRvIHRoZSBKUEVHLCBQTkcsIFdFQlAgZW5jb2RlcnMuCisKKyAgICAgICAgRGlmZmlj dWx0IHRvIHRlc3QgYXMgY29uZGl0aW9uIG9jY3VycyB3aGVuIE9PTS4KKworICAgICAgICAqIHBs YXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvSlBFR0ltYWdlRW5jb2Rlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpKUEVHSW1hZ2VFbmNvZGVyOjplbmNvZGUpOgorICAgICAgICAqIHBsYXRmb3Jt L2ltYWdlLWVuY29kZXJzL3NraWEvUE5HSW1hZ2VFbmNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBOR0ltYWdlRW5jb2Rlcjo6ZW5jb2RlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9za2lhL1dFQlBJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V0VC UEltYWdlRW5jb2Rlcjo6ZW5jb2RlKToKKwogMjAxMi0xMi0xOCAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEFkZCBCdWlsZCBQaGFzZSB0byBD aGVjayBIZWFkZXJzIGZvciBJbmFwcHJvcHJpYXRlIE1hY3JvcyAoUGxhdGZvcm0uaCBtYWNyb3Mp CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL0pQRUdJ bWFnZUVuY29kZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lt YWdlLWVuY29kZXJzL3NraWEvSlBFR0ltYWdlRW5jb2Rlci5jcHAJKHJldmlzaW9uIDEzODA2NykK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvSlBFR0ltYWdl RW5jb2Rlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4OCw3ICsxODgsNyBAQCBib29sIEpQRUdJ bWFnZUVuY29kZXI6OmVuY29kZShjb25zdCBTa0JpCiB7CiAgICAgU2tBdXRvTG9ja1BpeGVscyBi aXRtYXBMb2NrKGJpdG1hcCk7CiAKLSAgICBpZiAoYml0bWFwLmNvbmZpZygpICE9IFNrQml0bWFw OjprQVJHQl84ODg4X0NvbmZpZykKKyAgICBpZiAoYml0bWFwLmNvbmZpZygpICE9IFNrQml0bWFw OjprQVJHQl84ODg4X0NvbmZpZyB8fCAhYml0bWFwLmdldFBpeGVscygpKQogICAgICAgICByZXR1 cm4gZmFsc2U7IC8vIE9ubHkgc3VwcG9ydCAzMiBiaXQvcGl4ZWwgc2tpYSBiaXRtYXBzLgogCiAg ICAgcmV0dXJuIGVuY29kZVBpeGVscyhJbnRTaXplKGJpdG1hcC53aWR0aCgpLCBiaXRtYXAuaGVp Z2h0KCkpLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyICo+KGJpdG1hcC5nZXRQaXhlbHMoKSks IHRydWUsIHF1YWxpdHksIG91dHB1dCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1lbmNvZGVycy9za2lhL1BOR0ltYWdlRW5jb2Rlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIu Y3BwCShyZXZpc2lvbiAxMzgwNjcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9za2lhL1BOR0ltYWdlRW5jb2Rlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOCw3 ICsxMTgsNyBAQCBib29sIFBOR0ltYWdlRW5jb2Rlcjo6ZW5jb2RlKGNvbnN0IFNrQml0CiB7CiAg ICAgU2tBdXRvTG9ja1BpeGVscyBiaXRtYXBMb2NrKGJpdG1hcCk7CiAKLSAgICBpZiAoYml0bWFw LmNvbmZpZygpICE9IFNrQml0bWFwOjprQVJHQl84ODg4X0NvbmZpZykKKyAgICBpZiAoYml0bWFw LmNvbmZpZygpICE9IFNrQml0bWFwOjprQVJHQl84ODg4X0NvbmZpZyB8fCAhYml0bWFwLmdldFBp eGVscygpKQogICAgICAgICByZXR1cm4gZmFsc2U7IC8vIE9ubHkgc3VwcG9ydCAzMiBiaXQvcGl4 ZWwgc2tpYSBiaXRtYXBzLgogCiAgICAgcmV0dXJuIGVuY29kZVBpeGVscyhJbnRTaXplKGJpdG1h cC53aWR0aCgpLCBiaXRtYXAuaGVpZ2h0KCkpLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyKj4o Yml0bWFwLmdldFBpeGVscygpKSwgdHJ1ZSwgb3V0cHV0KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvV0VCUEltYWdlRW5jb2Rlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9XRUJQ SW1hZ2VFbmNvZGVyLmNwcAkocmV2aXNpb24gMTM4MDY3KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9XRUJQSW1hZ2VFbmNvZGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTIyLDcgKzEyMiw3IEBAIGJvb2wgV0VCUEltYWdlRW5jb2Rlcjo6ZW5jb2RlKGNv bnN0IFNrQmkKIHsKICAgICBTa0F1dG9Mb2NrUGl4ZWxzIGJpdG1hcExvY2soYml0bWFwKTsKIAot ICAgIGlmIChiaXRtYXAuY29uZmlnKCkgIT0gU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmlnKQor ICAgIGlmIChiaXRtYXAuY29uZmlnKCkgIT0gU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmlnIHx8 ICFiaXRtYXAuZ2V0UGl4ZWxzKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsgLy8gT25seSBzdXBw b3J0IDMyIGJpdC9waXhlbCBza2lhIGJpdG1hcHMuCiAKICAgICByZXR1cm4gZW5jb2RlUGl4ZWxz KEludFNpemUoYml0bWFwLndpZHRoKCksIGJpdG1hcC5oZWlnaHQoKSksIHN0YXRpY19jYXN0PHVu c2lnbmVkIGNoYXIgKj4oYml0bWFwLmdldFBpeGVscygpKSwgdHJ1ZSwgcXVhbGl0eSwgb3V0cHV0 KTsK 180144 2012-12-19 05:37:13 -0800 2012-12-19 09:17:53 -0800 Patch bug-105349-20121219083429.patch text/plain 3265 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODA3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTE4ICBCcmlhbiBT YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ2hyb21pdW0vU2tpYV0g Q2hlY2sgd2hldGhlciBiaXRtYXAgaGFzIHBpeGVscyBpbiBpbWFnZSBlbmNvZGVycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzQ5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhZGRzIE5VTEwg Y2hlY2tzIHRvIHRoZSBKUEVHLCBQTkcsIFdFQlAgZW5jb2RlcnMuCisKKyAgICAgICAgRGlmZmlj dWx0IHRvIHRlc3QgYXMgY29uZGl0aW9uIG9jY3VycyB3aGVuIE9PTS4KKworICAgICAgICAqIHBs YXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvSlBFR0ltYWdlRW5jb2Rlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpKUEVHSW1hZ2VFbmNvZGVyOjplbmNvZGUpOgorICAgICAgICAqIHBsYXRmb3Jt L2ltYWdlLWVuY29kZXJzL3NraWEvUE5HSW1hZ2VFbmNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBOR0ltYWdlRW5jb2Rlcjo6ZW5jb2RlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9za2lhL1dFQlBJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V0VC UEltYWdlRW5jb2Rlcjo6ZW5jb2RlKToKKwogMjAxMi0xMi0xOCAgQmV0aCBEYWtpbiAgPGJkYWtp bkBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMjU3OQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2Rl cnMvc2tpYS9KUEVHSW1hZ2VFbmNvZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL0pQRUdJbWFnZUVuY29kZXIuY3BwCShyZXZp c2lvbiAxMzgxNDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9z a2lhL0pQRUdJbWFnZUVuY29kZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsNyArMTg4LDcg QEAgYm9vbCBKUEVHSW1hZ2VFbmNvZGVyOjplbmNvZGUoY29uc3QgU2tCaQogewogICAgIFNrQXV0 b0xvY2tQaXhlbHMgYml0bWFwTG9jayhiaXRtYXApOwogCi0gICAgaWYgKGJpdG1hcC5jb25maWco KSAhPSBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcpCisgICAgaWYgKGJpdG1hcC5jb25maWco KSAhPSBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcgfHwgIWJpdG1hcC5nZXRQaXhlbHMoKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOyAvLyBPbmx5IHN1cHBvcnQgMzIgYml0L3BpeGVsIHNraWEg Yml0bWFwcy4KIAogICAgIHJldHVybiBlbmNvZGVQaXhlbHMoSW50U2l6ZShiaXRtYXAud2lkdGgo KSwgYml0bWFwLmhlaWdodCgpKSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgY2hhciAqPihiaXRtYXAu Z2V0UGl4ZWxzKCkpLCB0cnVlLCBxdWFsaXR5LCBvdXRwdXQpOwpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvUE5H SW1hZ2VFbmNvZGVyLmNwcAkocmV2aXNpb24gMTM4MTQ2KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMTgsNyArMTE4LDcgQEAgYm9vbCBQTkdJbWFnZUVuY29kZXI6OmVuY29kZShjb25z dCBTa0JpdAogewogICAgIFNrQXV0b0xvY2tQaXhlbHMgYml0bWFwTG9jayhiaXRtYXApOwogCi0g ICAgaWYgKGJpdG1hcC5jb25maWcoKSAhPSBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcpCisg ICAgaWYgKGJpdG1hcC5jb25maWcoKSAhPSBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcgfHwg IWJpdG1hcC5nZXRQaXhlbHMoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOyAvLyBPbmx5IHN1cHBv cnQgMzIgYml0L3BpeGVsIHNraWEgYml0bWFwcy4KIAogICAgIHJldHVybiBlbmNvZGVQaXhlbHMo SW50U2l6ZShiaXRtYXAud2lkdGgoKSwgYml0bWFwLmhlaWdodCgpKSwgc3RhdGljX2Nhc3Q8dW5z aWduZWQgY2hhcio+KGJpdG1hcC5nZXRQaXhlbHMoKSksIHRydWUsIG91dHB1dCk7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL1dFQlBJbWFnZUVuY29k ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29k ZXJzL3NraWEvV0VCUEltYWdlRW5jb2Rlci5jcHAJKHJldmlzaW9uIDEzODE0NikKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvV0VCUEltYWdlRW5jb2Rlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsNyBAQCBib29sIFdFQlBJbWFnZUVuY29k ZXI6OmVuY29kZShjb25zdCBTa0JpCiB7CiAgICAgU2tBdXRvTG9ja1BpeGVscyBiaXRtYXBMb2Nr KGJpdG1hcCk7CiAKLSAgICBpZiAoYml0bWFwLmNvbmZpZygpICE9IFNrQml0bWFwOjprQVJHQl84 ODg4X0NvbmZpZykKKyAgICBpZiAoYml0bWFwLmNvbmZpZygpICE9IFNrQml0bWFwOjprQVJHQl84 ODg4X0NvbmZpZyB8fCAhYml0bWFwLmdldFBpeGVscygpKQogICAgICAgICByZXR1cm4gZmFsc2U7 IC8vIE9ubHkgc3VwcG9ydCAzMiBiaXQvcGl4ZWwgc2tpYSBiaXRtYXBzLgogCiAgICAgcmV0dXJu IGVuY29kZVBpeGVscyhJbnRTaXplKGJpdG1hcC53aWR0aCgpLCBiaXRtYXAuaGVpZ2h0KCkpLCBz dGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyICo+KGJpdG1hcC5nZXRQaXhlbHMoKSksIHRydWUsIHF1 YWxpdHksIG91dHB1dCk7Cg==