105332 2012-12-18 11:23:22 -0800 TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac 2012-12-18 12:09:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae jchaffraix noel.gordon oldest_to_newest 793861 0 eae 2012-12-18 11:23:22 -0800 [ RUN ] WebCore.LayoutUnitDivision ../src/gtest.cc:2022: Failure Failed All tests in the same test case must use the same test fixture class, so mixing TEST_F and TEST in the same test case is illegal. In test case WebCore, test KURLConstructorDefault is defined using TEST_F but test LayoutUnitDivision is defined using TEST. You probably want to change the TEST to TEST_F or move it to another test case. 793864 1 179984 eae 2012-12-18 11:24:49 -0800 Created attachment 179984 Patch 793878 2 179984 leviw 2012-12-18 11:33:40 -0800 Comment on attachment 179984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179984&action=review > Tools/ChangeLog:10 > + compatible with KURL tests as one cannot mix the two types in > + the same test suite. Sad panda! 793898 3 179994 eae 2012-12-18 11:55:17 -0800 Created attachment 179994 Patch for landing 793907 4 eae 2012-12-18 12:05:16 -0800 Moved to separate test suite instead as suggested. 793909 5 eae 2012-12-18 12:08:54 -0800 Committed r138050: <http://trac.webkit.org/changeset/138050> 179984 2012-12-18 11:24:49 -0800 2012-12-18 11:55:15 -0800 Patch bug-105332-20121218112206.patch text/plain 3101 eae SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzODA0NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDEyLTEyLTE4ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4K KworICAgICAgICBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5b3V0VW5pdCBmYWlscyBv biBtYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NTMzMgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBDaGFuZ2UgTGF5b3V0VW5pdCB1bml0IHRlc3RzIGZyb20gVEVTVCB0byBU RVNUX0YgdG8gYmUKKyAgICAgICAgY29tcGF0aWJsZSB3aXRoIEtVUkwgdGVzdHMgYXMgb25lIGNh bm5vdCBtaXggdGhlIHR3byB0eXBlcyBpbgorICAgICAgICB0aGUgc2FtZSB0ZXN0IHN1aXRlLgor CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwOgor ICAgICAgICAoVGVzdFdlYktpdEFQSSk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0Yp OgorCiAyMDEyLTEyLTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJ1bm5pbmcgYSBza2lwcGVkIHRlc3Qgd2l0aCBydW4tcGVyZi10ZXN0cyBjb3VsZCBhbGVy dCB0aGUgdXNlcgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0xheW91 dFVuaXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29y ZS9MYXlvdXRVbml0LmNwcAkocmV2aXNpb24gMTM4MDQwKQorKysgVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw4ICsz NywxNSBAQAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBUZXN0V2ViS2l0 QVBJIHsKKyAgICAKK2NsYXNzIFdlYkNvcmU6IHB1YmxpYyB0ZXN0aW5nOjpUZXN0IHsKK3B1Ymxp YzoKKyAgICB2aXJ0dWFsIHZvaWQgU2V0VXAoKQorICAgIHsKKyAgICB9Cit9OwogCi1URVNUKFdl YkNvcmUsIExheW91dFVuaXRJbnQpCitURVNUX0YoV2ViQ29yZSwgTGF5b3V0VW5pdEludCkKIHsK ICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdChJTlRfTUlOKS50b0ludCgpLCBpbnRNaW5Gb3JMYXlv dXRVbml0KTsKICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdChJTlRfTUlOIC8gMikudG9JbnQoKSwg aW50TWluRm9yTGF5b3V0VW5pdCk7CkBAIC02NCw3ICs3MSw3IEBAIFRFU1QoV2ViQ29yZSwgTGF5 b3V0VW5pdEludCkKICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdChJTlRfTUFYKS50b0ludCgpLCBp bnRNYXhGb3JMYXlvdXRVbml0KTsKIH0KIAotVEVTVChXZWJDb3JlLCBMYXlvdXRVbml0RmxvYXQp CitURVNUX0YoV2ViQ29yZSwgTGF5b3V0VW5pdEZsb2F0KQogewogICAgIGNvbnN0IGZsb2F0IHRv bGVyYW5jZSA9IDEuMGYgLyBrRml4ZWRQb2ludERlbm9taW5hdG9yOwogICAgIEFTU0VSVF9GTE9B VF9FUShMYXlvdXRVbml0KDEuMGYpLnRvRmxvYXQoKSwgMS4wZik7CkBAIC03OSw3ICs4Niw3IEBA IFRFU1QoV2ViQ29yZSwgTGF5b3V0VW5pdEZsb2F0KQogICAgIEFTU0VSVF9ORUFSKExheW91dFVu aXQoLTM0NTYzNCkudG9GbG9hdCgpLCAtMzQ1NjM0LjBmLCB0b2xlcmFuY2UpOyAgICAKIH0KIAot VEVTVChXZWJDb3JlLCBMYXlvdXRVbml0Um91bmRpbmcpCitURVNUX0YoV2ViQ29yZSwgTGF5b3V0 VW5pdFJvdW5kaW5nKQogewogICAgIEFTU0VSVF9FUShMYXlvdXRVbml0KC0xLjVmKS5yb3VuZCgp LCAtMik7CiAgICAgQVNTRVJUX0VRKExheW91dFVuaXQoLTEuNDlmKS5yb3VuZCgpLCAtMSk7CkBA IC05OCw3ICsxMDUsNyBAQCBURVNUKFdlYkNvcmUsIExheW91dFVuaXRSb3VuZGluZykKICAgICBB U1NFUlRfRVEoTGF5b3V0VW5pdCgxLjVmKS5yb3VuZCgpLCAyKTsKIH0KIAotVEVTVChXZWJDb3Jl LCBMYXlvdXRVbml0U25hcFNpemVUb1BpeGVsKQorVEVTVF9GKFdlYkNvcmUsIExheW91dFVuaXRT bmFwU2l6ZVRvUGl4ZWwpCiB7CiAgICAgQVNTRVJUX0VRKHNuYXBTaXplVG9QaXhlbChMYXlvdXRV bml0KDEpLCBMYXlvdXRVbml0KDApKSwgMSk7CiAgICAgQVNTRVJUX0VRKHNuYXBTaXplVG9QaXhl bChMYXlvdXRVbml0KDEpLCBMYXlvdXRVbml0KDAuNSkpLCAxKTsKQEAgLTEyMCw3ICsxMjcsNyBA QCBURVNUKFdlYkNvcmUsIExheW91dFVuaXRTbmFwU2l6ZVRvUGl4ZWwpCiAgICAgQVNTRVJUX0VR KHNuYXBTaXplVG9QaXhlbChMYXlvdXRVbml0KGludE1pbkZvckxheW91dFVuaXQpLCBMYXlvdXRV bml0KC0wLjMpKSwgaW50TWluRm9yTGF5b3V0VW5pdCk7CiB9CiAKLVRFU1QoV2ViQ29yZSwgTGF5 b3V0VW5pdE11bHRpcGxpY2F0aW9uKQorVEVTVF9GKFdlYkNvcmUsIExheW91dFVuaXRNdWx0aXBs aWNhdGlvbikKIHsKICAgICBBU1NFUlRfRVEoKExheW91dFVuaXQoMSkgKiBMYXlvdXRVbml0KDEp KS50b0ludCgpLCAxKTsKICAgICBBU1NFUlRfRVEoKExheW91dFVuaXQoMSkgKiBMYXlvdXRVbml0 KDIpKS50b0ludCgpLCAyKTsKQEAgLTE1NCw3ICsxNjEsNyBAQCBURVNUKFdlYkNvcmUsIExheW91 dFVuaXRNdWx0aXBsaWNhdGlvbikKICAgICBBU1NFUlRfRVEoKExheW91dFVuaXQocXVhcnRlck1h eCkgKiBMYXlvdXRVbml0KDUpKS50b0ludCgpLCBpbnRNYXhGb3JMYXlvdXRVbml0KTsKIH0KIAot VEVTVChXZWJDb3JlLCBMYXlvdXRVbml0RGl2aXNpb24pCitURVNUX0YoV2ViQ29yZSwgTGF5b3V0 VW5pdERpdmlzaW9uKQogewogICAgIEFTU0VSVF9FUSgoTGF5b3V0VW5pdCgxKSAvIExheW91dFVu aXQoMSkpLnRvSW50KCksIDEpOwogICAgIEFTU0VSVF9FUSgoTGF5b3V0VW5pdCgxKSAvIExheW91 dFVuaXQoMikpLnRvSW50KCksIDApOwo= 179994 2012-12-18 11:55:17 -0800 2012-12-18 12:09:06 -0800 Patch for landing bug-105332-20121218115234.patch text/plain 2999 eae SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzODA0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTEyLTE4ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4K KworICAgICAgICBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5b3V0VW5pdCBmYWlscyBv biBtYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NTMzMgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTGV2aSBXZWludHJhdWIuCisgICAg ICAgIAorICAgICAgICBDcmVhdGUgbmV3IHRlc3Qgc3VpdGUgZm9yIExheW91dFVuaXQgdGVzdHMg YXMgdGhlIEtVUkwgdGVzdHMgYXJlCisgICAgICAgIG9mIHRoZSBpbmNvbXBhdGlibGUgVEVTVF9G IHR5cGUuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5b3V0VW5p dC5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6 OlRFU1RfRik6CisKIDIwMTItMTItMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUnVubmluZyBhIHNraXBwZWQgdGVzdCB3aXRoIHJ1bi1wZXJmLXRlc3RzIGNv dWxkIGFsZXJ0IHRoZSB1c2VyCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNv cmUvTGF5b3V0VW5pdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwCShyZXZpc2lvbiAxMzgwNDYpCisrKyBUb29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTGF5b3V0VW5pdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTM4LDcgKzM4LDcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBUZXN0 V2ViS2l0QVBJIHsKIAotVEVTVChXZWJDb3JlLCBMYXlvdXRVbml0SW50KQorVEVTVChXZWJDb3Jl TGF5b3V0VW5pdCwgTGF5b3V0VW5pdEludCkKIHsKICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdChJ TlRfTUlOKS50b0ludCgpLCBpbnRNaW5Gb3JMYXlvdXRVbml0KTsKICAgICBBU1NFUlRfRVEoTGF5 b3V0VW5pdChJTlRfTUlOIC8gMikudG9JbnQoKSwgaW50TWluRm9yTGF5b3V0VW5pdCk7CkBAIC02 NCw3ICs2NCw3IEBAIFRFU1QoV2ViQ29yZSwgTGF5b3V0VW5pdEludCkKICAgICBBU1NFUlRfRVEo TGF5b3V0VW5pdChJTlRfTUFYKS50b0ludCgpLCBpbnRNYXhGb3JMYXlvdXRVbml0KTsKIH0KIAot VEVTVChXZWJDb3JlLCBMYXlvdXRVbml0RmxvYXQpCitURVNUKFdlYkNvcmVMYXlvdXRVbml0LCBM YXlvdXRVbml0RmxvYXQpCiB7CiAgICAgY29uc3QgZmxvYXQgdG9sZXJhbmNlID0gMS4wZiAvIGtG aXhlZFBvaW50RGVub21pbmF0b3I7CiAgICAgQVNTRVJUX0ZMT0FUX0VRKExheW91dFVuaXQoMS4w ZikudG9GbG9hdCgpLCAxLjBmKTsKQEAgLTc5LDcgKzc5LDcgQEAgVEVTVChXZWJDb3JlLCBMYXlv dXRVbml0RmxvYXQpCiAgICAgQVNTRVJUX05FQVIoTGF5b3V0VW5pdCgtMzQ1NjM0KS50b0Zsb2F0 KCksIC0zNDU2MzQuMGYsIHRvbGVyYW5jZSk7ICAgIAogfQogCi1URVNUKFdlYkNvcmUsIExheW91 dFVuaXRSb3VuZGluZykKK1RFU1QoV2ViQ29yZUxheW91dFVuaXQsIExheW91dFVuaXRSb3VuZGlu ZykKIHsKICAgICBBU1NFUlRfRVEoTGF5b3V0VW5pdCgtMS41Zikucm91bmQoKSwgLTIpOwogICAg IEFTU0VSVF9FUShMYXlvdXRVbml0KC0xLjQ5Zikucm91bmQoKSwgLTEpOwpAQCAtOTgsNyArOTgs NyBAQCBURVNUKFdlYkNvcmUsIExheW91dFVuaXRSb3VuZGluZykKICAgICBBU1NFUlRfRVEoTGF5 b3V0VW5pdCgxLjVmKS5yb3VuZCgpLCAyKTsKIH0KIAotVEVTVChXZWJDb3JlLCBMYXlvdXRVbml0 U25hcFNpemVUb1BpeGVsKQorVEVTVChXZWJDb3JlTGF5b3V0VW5pdCwgTGF5b3V0VW5pdFNuYXBT aXplVG9QaXhlbCkKIHsKICAgICBBU1NFUlRfRVEoc25hcFNpemVUb1BpeGVsKExheW91dFVuaXQo MSksIExheW91dFVuaXQoMCkpLCAxKTsKICAgICBBU1NFUlRfRVEoc25hcFNpemVUb1BpeGVsKExh eW91dFVuaXQoMSksIExheW91dFVuaXQoMC41KSksIDEpOwpAQCAtMTIwLDcgKzEyMCw3IEBAIFRF U1QoV2ViQ29yZSwgTGF5b3V0VW5pdFNuYXBTaXplVG9QaXhlbCkKICAgICBBU1NFUlRfRVEoc25h cFNpemVUb1BpeGVsKExheW91dFVuaXQoaW50TWluRm9yTGF5b3V0VW5pdCksIExheW91dFVuaXQo LTAuMykpLCBpbnRNaW5Gb3JMYXlvdXRVbml0KTsKIH0KIAotVEVTVChXZWJDb3JlLCBMYXlvdXRV bml0TXVsdGlwbGljYXRpb24pCitURVNUKFdlYkNvcmVMYXlvdXRVbml0LCBMYXlvdXRVbml0TXVs dGlwbGljYXRpb24pCiB7CiAgICAgQVNTRVJUX0VRKChMYXlvdXRVbml0KDEpICogTGF5b3V0VW5p dCgxKSkudG9JbnQoKSwgMSk7CiAgICAgQVNTRVJUX0VRKChMYXlvdXRVbml0KDEpICogTGF5b3V0 VW5pdCgyKSkudG9JbnQoKSwgMik7CkBAIC0xNTQsNyArMTU0LDcgQEAgVEVTVChXZWJDb3JlLCBM YXlvdXRVbml0TXVsdGlwbGljYXRpb24pCiAgICAgQVNTRVJUX0VRKChMYXlvdXRVbml0KHF1YXJ0 ZXJNYXgpICogTGF5b3V0VW5pdCg1KSkudG9JbnQoKSwgaW50TWF4Rm9yTGF5b3V0VW5pdCk7CiB9 CiAKLVRFU1QoV2ViQ29yZSwgTGF5b3V0VW5pdERpdmlzaW9uKQorVEVTVChXZWJDb3JlTGF5b3V0 VW5pdCwgTGF5b3V0VW5pdERpdmlzaW9uKQogewogICAgIEFTU0VSVF9FUSgoTGF5b3V0VW5pdCgx KSAvIExheW91dFVuaXQoMSkpLnRvSW50KCksIDEpOwogICAgIEFTU0VSVF9FUSgoTGF5b3V0VW5p dCgxKSAvIExheW91dFVuaXQoMikpLnRvSW50KCksIDApOwo=