105329 2012-12-18 11:15:35 -0800 [BlackBerry] Use midpoint for fixed position heuristic 2012-12-18 12:52:13 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 793852 0 anlo 2012-12-18 11:15:35 -0800 Currently we use a heuristic to determine whether a fixed position element is at the bottom or top of the screen. We check if the top edge of the layer is in the bottom or top half of the screen. A better heuristic would be to check if the midpoint of the layer is in the top or bottom half. 793865 1 179985 anlo 2012-12-18 11:24:59 -0800 Created attachment 179985 Patch 793868 2 179985 rwlbuis 2012-12-18 11:27:15 -0800 Comment on attachment 179985 Patch LGTM. 793871 3 179985 webkit.review.bot 2012-12-18 11:30:00 -0800 Comment on attachment 179985 Patch Rejecting attachment 179985 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp Hunk #1 FAILED at 731. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15401273 793915 4 179998 anlo 2012-12-18 12:14:28 -0800 Created attachment 179998 Patch 793922 5 179998 rwlbuis 2012-12-18 12:17:05 -0800 Comment on attachment 179998 Patch Another try. 793952 6 179998 webkit.review.bot 2012-12-18 12:52:10 -0800 Comment on attachment 179998 Patch Clearing flags on attachment: 179998 Committed r138056: <http://trac.webkit.org/changeset/138056> 793953 7 webkit.review.bot 2012-12-18 12:52:13 -0800 All reviewed patches have been landed. Closing bug. 179985 2012-12-18 11:24:59 -0800 2012-12-18 12:14:26 -0800 Patch bug-105329-20121218142218.patch text/plain 2606 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGRjNzFmMTRkNmY1ODc5 YTRhODBjNWVhZjUzMmM5NWExYmEzNDA3NC4uMDBiOTgzYWI1M2YxMDFjYTUxODI0YWUzYmZmMzk3 YWI1NDBmYjYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTE4ICBBbmRy ZXcgTG8gIDxhbmxvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVzZSBtaWRwb2lu dCBmb3IgZml4ZWQgcG9zaXRpb24gaGV1cmlzdGljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUzMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBKb2UgTWFzb24uCisK KyAgICAgICAgVXNlIHRoZSBtaWRwb2ludCBvZiB0aGUgbGF5ZXIgd2hlbiBkZXRlcm1pbmluZyB3 aGV0aGVyIHRoZQorICAgICAgICBmaXhlZC1wb3NpdGlvbiBsYXllciBpcyBvbiB0aGUgdG9wIG9y IGJvdHRvbSBoYWxmIG9mIHRoZSBzY3JlZW4KKyAgICAgICAgcmF0aGVyIHRoYW4gdGhlIHRvcCBv ZiB0aGUgbGF5ZXIuCisgICAgICAgIEludGVybmFsIFBSIDIzNzA3My4KKworICAgICAgICBObyBu ZXcgdGVzdHMgYXJlIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTGF5ZXJSZW5kZXJlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVy Ojp1cGRhdGVMYXllcnNSZWN1cnNpdmUpOgorCiAyMDEyLTEyLTExICBKYWNreSBKaWFuZyAgPHpo YWppYW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIENsZWFuIHVwIHVudXNlZCBk ZWZhdWx0Vmlld3BvcnRBcmd1bWVudHMgaW4gUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXll clJlbmRlcmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVy cnkvTGF5ZXJSZW5kZXJlci5jcHAKaW5kZXggMmJhZTU4OTE3OTI3NDcyMzBlMDRmYjhmYmQ2OWZh ZmIzYjAxOGIyMC4uOTJhNzZlODhhN2EwYmQyZGM2MzcwNzBjMmJlMTVjNTJlOGJlMjgxZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXll clJlbmRlcmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFj a2JlcnJ5L0xheWVyUmVuZGVyZXIuY3BwCkBAIC03MzEsMTAgKzczMSwxMCBAQCB2b2lkIExheWVy UmVuZGVyZXI6OnVwZGF0ZUxheWVyc1JlY3Vyc2l2ZShMYXllckNvbXBvc2l0aW5nVGhyZWFkKiBs YXllciwgY29uc3QgVAogICAgICAgICAvLyBUaGlzIHRyaWNrIGFsbG93cyB1cyB0byBkaXNwbGF5 IGZpeGVkIHBvc2l0aW9uZWQgZWxlbWVudHMgYWxpZ25lZCB0byB0b3Agb3IKICAgICAgICAgLy8g Ym90dG9tIGNvcnJlY3RseSB3aGVuIHBhbm5pbmcgYW5kIHpvb21pbmcsIHdpdGhvdXQgYWN0dWFs bHkga25vd2luZyB0aGUKICAgICAgICAgLy8gbnVtZXJpYyB2YWx1ZXMgb2YgdGhlIHRvcCBhbmQg Ym90dG9tIENTUyBhdHRyaWJ1dGVzLgotICAgICAgICAvLyBJbiBmYWN0LCB0aGUgcG9zaXRpb24g aXMgdGhlIGxvY2F0aW9uIG9mIHRoZSBhbmNob3IsIHNvIHRvIGZpbmQgdGhlIHRvcCBsZWZ0Ci0g ICAgICAgIC8vIHdlIGhhdmUgdG8gc3VidHJhY3QgdGhlIGFuY2hvciB0aW1lcyB0aGUgYm91bmRz LiBUaGUgYW5jaG9yIGRlZmF1bHRzIHRvCi0gICAgICAgIC8vICgwLjUsIDAuNSkgZm9yIG1vc3Qg bGF5ZXJzLgotICAgICAgICBpZiAocG9zaXRpb24ueSgpIC0gYW5jaG9yUG9pbnQueSgpICogYm91 bmRzLmhlaWdodCgpID4gbGF5b3V0WSArIGxheW91dFJlY3QuaGVpZ2h0KCkgLyAyKSB7CisgICAg ICAgIC8vIEluIGZhY3QsIHRoZSBwb3NpdGlvbiBpcyB0aGUgbG9jYXRpb24gb2YgdGhlIGFuY2hv ciwgc28gdG8gZmluZCB0aGUgbWlkLXBvaW50CisgICAgICAgIC8vIHdlIGhhdmUgdG8gc3VidHJh Y3QgdGhlIGFuY2hvciBvZmZzZXQgZnJvbSB0aGUgbWlkZGxlICgwLjUpIHRpbWVzIHRoZSBib3Vu ZHMuCisgICAgICAgIC8vIFRoZSBhbmNob3IgZGVmYXVsdHMgdG8gKDAuNSwgMC41KSBmb3IgbW9z dCBsYXllcnMuCisgICAgICAgIGlmIChwb3NpdGlvbi55KCkgKyAoMC41IC0gYW5jaG9yUG9pbnQu eSgpKSAqIGJvdW5kcy5oZWlnaHQoKSA+IGxheW91dFkgKyBsYXlvdXRSZWN0LmhlaWdodCgpIC8g MikgewogICAgICAgICAgICAgdmlzaWJsZVkgPSBtaW48ZmxvYXQ+KGNvbnRlbnRzU2l6ZS5oZWln aHQoKSwgdmlzaWJsZVJlY3QueSgpICsgdmlzaWJsZVJlY3QuaGVpZ2h0KCkpOwogICAgICAgICAg ICAgbGF5b3V0WSA9IG1pbihjb250ZW50c1NpemUuaGVpZ2h0KCksIG1heCgwLCBsYXlvdXRSZWN0 LnkoKSkgKyBsYXlvdXRSZWN0LmhlaWdodCgpKTsKICAgICAgICAgfQo= 179998 2012-12-18 12:14:28 -0800 2012-12-18 12:52:10 -0800 Patch bug-105329-20121218151148.patch text/plain 2613 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA5NGJhZWVlNjZiOTA3 OGFlMzk1MWI2NjlmM2RlMDc5NGQ2ZWY1NS4uNDMyNzczMTUxOTU3M2RiNjE2M2UxMjBlN2YxNTkw NTcwNTJjYzg0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTE4ICBBbmRy ZXcgTG8gIDxhbmxvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVzZSBtaWRwb2lu dCBmb3IgZml4ZWQgcG9zaXRpb24gaGV1cmlzdGljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUzMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBKb2UgTWFzb24uCisK KyAgICAgICAgVXNlIHRoZSBtaWRwb2ludCBvZiB0aGUgbGF5ZXIgd2hlbiBkZXRlcm1pbmluZyB3 aGV0aGVyIHRoZQorICAgICAgICBmaXhlZC1wb3NpdGlvbiBsYXllciBpcyBvbiB0aGUgdG9wIG9y IGJvdHRvbSBoYWxmIG9mIHRoZSBzY3JlZW4KKyAgICAgICAgcmF0aGVyIHRoYW4gdGhlIHRvcCBv ZiB0aGUgbGF5ZXIuCisgICAgICAgIEludGVybmFsIFBSIDIzNzA3My4KKworICAgICAgICBObyBu ZXcgdGVzdHMgYXJlIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTGF5ZXJSZW5kZXJlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVy Ojp1cGRhdGVMYXllcnNSZWN1cnNpdmUpOgorCiAyMDEyLTEyLTE4ICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFm dGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzODA0MQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclJlbmRlcmVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJS ZW5kZXJlci5jcHAKaW5kZXggZmY4NmYzOGUxMTc2ZmFjNGEwYmViOTkxNGY5ZDRjYWFkNTg0YWJj ZC4uNDI3ZTRiMjAzZGI3NjA1OTUyMTNhYzgwMzM3NTljZjY2NmNmNjI3YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclJlbmRlcmVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xh eWVyUmVuZGVyZXIuY3BwCkBAIC02OTQsMTAgKzY5NCwxMCBAQCB2b2lkIExheWVyUmVuZGVyZXI6 OnVwZGF0ZUxheWVyc1JlY3Vyc2l2ZShMYXllckNvbXBvc2l0aW5nVGhyZWFkKiBsYXllciwgY29u c3QgVAogICAgICAgICAvLyBUaGlzIHRyaWNrIGFsbG93cyB1cyB0byBkaXNwbGF5IGZpeGVkIHBv c2l0aW9uZWQgZWxlbWVudHMgYWxpZ25lZCB0byB0b3Agb3IKICAgICAgICAgLy8gYm90dG9tIGNv cnJlY3RseSB3aGVuIHBhbm5pbmcgYW5kIHpvb21pbmcsIHdpdGhvdXQgYWN0dWFsbHkga25vd2lu ZyB0aGUKICAgICAgICAgLy8gbnVtZXJpYyB2YWx1ZXMgb2YgdGhlIHRvcCBhbmQgYm90dG9tIENT UyBhdHRyaWJ1dGVzLgotICAgICAgICAvLyBJbiBmYWN0LCB0aGUgcG9zaXRpb24gaXMgdGhlIGxv Y2F0aW9uIG9mIHRoZSBhbmNob3IsIHNvIHRvIGZpbmQgdGhlIHRvcCBsZWZ0Ci0gICAgICAgIC8v IHdlIGhhdmUgdG8gc3VidHJhY3QgdGhlIGFuY2hvciB0aW1lcyB0aGUgYm91bmRzLiBUaGUgYW5j aG9yIGRlZmF1bHRzIHRvCi0gICAgICAgIC8vICgwLjUsIDAuNSkgZm9yIG1vc3QgbGF5ZXJzLgot ICAgICAgICBpZiAocG9zaXRpb24ueSgpIC0gYW5jaG9yUG9pbnQueSgpICogYm91bmRzLmhlaWdo dCgpID4gbGF5b3V0WSArIG1fbGF5b3V0UmVjdC5oZWlnaHQoKSAvIDIpIHsKKyAgICAgICAgLy8g SW4gZmFjdCwgdGhlIHBvc2l0aW9uIGlzIHRoZSBsb2NhdGlvbiBvZiB0aGUgYW5jaG9yLCBzbyB0 byBmaW5kIHRoZSBtaWQtcG9pbnQKKyAgICAgICAgLy8gd2UgaGF2ZSB0byBzdWJ0cmFjdCB0aGUg YW5jaG9yIG9mZnNldCBmcm9tIHRoZSBtaWRkbGUgKDAuNSkgdGltZXMgdGhlIGJvdW5kcy4KKyAg ICAgICAgLy8gVGhlIGFuY2hvciBkZWZhdWx0cyB0byAoMC41LCAwLjUpIGZvciBtb3N0IGxheWVy cy4KKyAgICAgICAgaWYgKHBvc2l0aW9uLnkoKSArICgwLjUgLSBhbmNob3JQb2ludC55KCkpICog Ym91bmRzLmhlaWdodCgpID4gbGF5b3V0WSArIG1fbGF5b3V0UmVjdC5oZWlnaHQoKSAvIDIpIHsK ICAgICAgICAgICAgIHZpc2libGVZID0gbWluPGZsb2F0PihtX2NvbnRlbnRzU2l6ZS5oZWlnaHQo KSwgbV92aXNpYmxlUmVjdC55KCkgKyBtX3Zpc2libGVSZWN0LmhlaWdodCgpKTsKICAgICAgICAg ICAgIGxheW91dFkgPSBtaW4obV9jb250ZW50c1NpemUuaGVpZ2h0KCksIG1heCgwLCBtX2xheW91 dFJlY3QueSgpKSArIG1fbGF5b3V0UmVjdC5oZWlnaHQoKSk7CiAgICAgICAgIH0K