105318 2012-12-18 09:48:32 -0800 [GTK] Tests that time out are not considered as failures. 2012-12-19 02:20:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned cgarcia webkit.review.bot oldest_to_newest 793745 0 berto 2012-12-18 09:48:32 -0800 A test should not timeout, and if it does it has to be fixed. See https://bugs.webkit.org/show_bug.cgi?id=49246#c84 793758 1 179970 berto 2012-12-18 09:57:26 -0800 Created attachment 179970 Patch The script that parses the GTK API test results only counts lines starting with ERROR as mistakes. This patch also counts lines that end with TIMEOUT. The run-gtk-tests script also counts the number of timeouts when returning the number of tests that fail. 793803 2 179970 webkit.review.bot 2012-12-18 10:33:26 -0800 Comment on attachment 179970 Patch Clearing flags on attachment: 179970 Committed r138038: <http://trac.webkit.org/changeset/138038> 793804 3 webkit.review.bot 2012-12-18 10:33:30 -0800 All reviewed patches have been landed. Closing bug. 794132 4 180048 berto 2012-12-18 16:08:30 -0800 Created attachment 180048 Patch #2 There was actually a mistake in the previous patch, this new one fixes it (to be applied on top of the other one). Sorry for the noise. 794467 5 cgarcia 2012-12-19 02:19:25 -0800 Committed r138133: <http://trac.webkit.org/changeset/138133> 179970 2012-12-18 09:57:26 -0800 2012-12-18 10:33:26 -0800 Patch timeout.diff text/plain 2036 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDBiOTIwMjEuLmZkNjU0MmEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNTQyLDcgKzU0Miw3IEBAIGNsYXNzIFJ1bkd0a0FQSVRlc3RzKHNoZWxsLlRl c3QpOgogICAgICAgICBsb2dUZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCiAgICAg ICAgIGluY29ycmVjdExpbmVzID0gW10KICAgICAgICAgZm9yIGxpbmUgaW4gbG9nVGV4dC5zcGxp dGxpbmVzKCk6Ci0gICAgICAgICAgICBpZiBsaW5lLnN0YXJ0c3dpdGgoJ0VSUk9SJyk6CisgICAg ICAgICAgICBpZiBsaW5lLnN0YXJ0c3dpdGgoJ0VSUk9SJykgb3IgbGluZS5lbmRzd2l0aCgnVElN RU9VVFxuJyk6CiAgICAgICAgICAgICAgICAgaW5jb3JyZWN0TGluZXMuYXBwZW5kKGxpbmUpCiAK ICAgICAgICAgc2VsZi5pbmNvcnJlY3RMaW5lcyA9IGluY29ycmVjdExpbmVzCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2MzZDdjMC4uYmE1YmY3 OCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE5IEBACisyMDEyLTEyLTE4ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBUZXN0cyB0aGF0IHRpbWUgb3V0IGFyZSBub3QgY29uc2lk ZXJlZCBhcyBmYWlsdXJlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNTMxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZzoKKyAgICAgICAgKFJ1bkd0a0FQSVRlc3RzLmNvbW1hbmRDb21wbGV0ZSk6CisgICAg ICAgIENvbnNpZGVyIGxvZyBsaW5lcyB0aGF0IGVuZCB3aXRoIFRJTUVPVVQgYXMgZXJyb3JzLgor CisgICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOgorICAgICAgICAoVGVzdFJ1bm5lci5y dW5fdGVzdHMpOgorICAgICAgICBDb25zaWRlciB0aW1lb3V0cyBhcyBmYWlsdXJlcyB3aGVuIHJl dHVybmluZyB0aGUgbnVtYmVyIG9mIGZhaWxlZAorICAgICAgICB0ZXN0cy4KKwogMjAxMi0xMi0x OCAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hy b21pdW1dIG1vdmUgd2ViaW50ZW50IHJlbGF0ZWQgbWV0aG9kcyB0byBUZXN0UnVubmVyIGxpYnJh cnkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBiL1Rvb2xzL1Njcmlw dHMvcnVuLWd0ay10ZXN0cwppbmRleCBhMjI3M2NmLi5iZTBhMTE1IDEwMDc1NQotLS0gYS9Ub29s cy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3Rz CkBAIC0zNDcsNyArMzQ3LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgIHN5cy5z dGRvdXQud3JpdGUoIlRlc3RzIHNraXBwZWQ6XG4lc1xuIiAlICJcbiIuam9pbihbc3RyKHNraXBw ZWQpIGZvciBza2lwcGVkIGluIHNlbGYuX3NraXBwZWRfdGVzdHNdKSkKICAgICAgICAgICAgIHN5 cy5zdGRvdXQuZmx1c2goKQogCi0gICAgICAgIHJldHVybiBsZW4oZmFpbGVkX3Rlc3RzKQorICAg ICAgICByZXR1cm4gbGVuKGZhaWxlZF90ZXN0cykgKyBsZW4odGltZWRfb3V0X3Rlc3RzKQogCiBp ZiBfX25hbWVfXyA9PSAiX19tYWluX18iOgogICAgIGlmIG5vdCBqaGJ1aWxkdXRpbHMuZW50ZXJf amhidWlsZF9lbnZpcm9ubWVudF9pZl9hdmFpbGFibGUoImd0ayIpOgo= 180048 2012-12-18 16:08:30 -0800 2012-12-19 02:20:18 -0800 Patch #2 timeout.diff text/plain 1366 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGZkNjU0MmEuLmU2NDc4ZGIgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNTQyLDcgKzU0Miw3IEBAIGNsYXNzIFJ1bkd0a0FQSVRlc3RzKHNoZWxsLlRl c3QpOgogICAgICAgICBsb2dUZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCiAgICAg ICAgIGluY29ycmVjdExpbmVzID0gW10KICAgICAgICAgZm9yIGxpbmUgaW4gbG9nVGV4dC5zcGxp dGxpbmVzKCk6Ci0gICAgICAgICAgICBpZiBsaW5lLnN0YXJ0c3dpdGgoJ0VSUk9SJykgb3IgbGlu ZS5lbmRzd2l0aCgnVElNRU9VVFxuJyk6CisgICAgICAgICAgICBpZiBsaW5lLnN0YXJ0c3dpdGgo J0VSUk9SJykgb3IgbGluZS5lbmRzd2l0aCgnVElNRU9VVCcpOgogICAgICAgICAgICAgICAgIGlu Y29ycmVjdExpbmVzLmFwcGVuZChsaW5lKQogCiAgICAgICAgIHNlbGYuaW5jb3JyZWN0TGluZXMg PSBpbmNvcnJlY3RMaW5lcwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IGExMjYzN2EuLmUwMzYwY2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMi0xOCAgQWxi ZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVGVzdHMg dGhhdCB0aW1lIG91dCBhcmUgbm90IGNvbnNpZGVyZWQgYXMgZmFpbHVyZXMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUzMTgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcGFyc2luZyBvZiB0aGUg R1RLIEFQSSB0ZXN0cyBsb2cgZmlsZXMuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoUnVuR3RrQVBJVGVz dHMuY29tbWFuZENvbXBsZXRlKToKKwogMjAxMi0xMi0xOCAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEFkZCBCdWlsZCBQaGFzZSB0byBDaGVj ayBIZWFkZXJzIGZvciBJbmFwcHJvcHJpYXRlIE1hY3JvcyAoUGxhdGZvcm0uaCBtYWNyb3MpCg==