105317 2012-12-18 09:37:05 -0800 Web Inspector: Add frameId to frame owner nodes 2012-12-18 10:05:51 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kkania kkania apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 793732 0 kkania 2012-12-18 09:37:05 -0800 We'd like to be able to get the frame ID from a frame owner node, so that we can find its execution context for evaluating scripts in the associated frame. I propose adding a 'frameId' to DOM.Node. 793734 1 179963 kkania 2012-12-18 09:39:39 -0800 Created attachment 179963 Patch 793780 2 179963 webkit.review.bot 2012-12-18 10:05:47 -0800 Comment on attachment 179963 Patch Clearing flags on attachment: 179963 Committed r138034: <http://trac.webkit.org/changeset/138034> 793781 3 webkit.review.bot 2012-12-18 10:05:51 -0800 All reviewed patches have been landed. Closing bug. 179963 2012-12-18 09:39:39 -0800 2012-12-18 10:05:47 -0800 Patch bug-105317-20121218093656.patch text/plain 3007 kkania U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJiZDA0Njk2ZWE4ZDE3 YmRlNWUzMTgwYWJmODk2NTY3NDkyYzZjNC4uN2VhMWQzZGFkZjFkYjcyM2JjMWJkZTA3NWJmY2Mz MGJmMTg4MzExMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTE4ICBLZW4g S2FuaWEgIDxra2FuaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtJbnNwZWN0b3JdIEFkZCBm cmFtZUlkIGZvciBmcmFtZSBvd25lciBub2Rlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTMxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgbmVlZGVkIHRvIHRyYW5zbGF0ZSBmcm9tIGEg bm9kZSBJRCB0byB0aGUgZXhlY3V0aW9uIGNvbnRleHQgSUQgZm9yCisgICAgICAgIGV2YWx1YXRp bmcgc2NyaXB0cyBpbiB0aGUgYXNzb2NpYXRlZCBmcmFtZS4KKworICAgICAgICAqIGluc3BlY3Rv ci9JbnNwZWN0b3IuanNvbjoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9y Tm9kZSk6CisKIDIwMTItMTItMTcgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+ CiAKICAgICAgICAgW0NTUyBFeGNsdXNpb25zXSBzaGFwZS1vdXRzaWRlIG9uIGZsb2F0cyBmb3Ig cmVjdGFuZ2xlIHNoYXBlcyBoZWlnaHQvd2lkdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbiBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3IuanNvbgppbmRleCA5ZDM5Mjc5OTQ2YTA1MmQwNTg3MTk4MmZhNGQzMjY2NmUzODE2Y2Nk Li43YTM4N2RkMjE4Nzk5NDVmNzNiZTdmZjZiMmQ5NzI3NzQ3NTgzNmU4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24KKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uCkBAIC0xNjQyLDYgKzE2NDIsNyBAQAogICAgICAg ICAgICAgICAgICAgICB7ICJuYW1lIjogInhtbFZlcnNpb24iLCAidHlwZSI6ICJzdHJpbmciLCAi b3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiPGNvZGU+RG9jdW1lbnQ8L2NvZGU+J3Mg WE1MIHZlcnNpb24gaW4gY2FzZSBvZiBYTUwgZG9jdW1lbnRzLiIgfSwKICAgICAgICAgICAgICAg ICAgICAgeyAibmFtZSI6ICJuYW1lIiwgInR5cGUiOiAic3RyaW5nIiwgIm9wdGlvbmFsIjogdHJ1 ZSwgImRlc2NyaXB0aW9uIjogIjxjb2RlPkF0dHI8L2NvZGU+J3MgbmFtZS4iIH0sCiAgICAgICAg ICAgICAgICAgICAgIHsgIm5hbWUiOiAidmFsdWUiLCAidHlwZSI6ICJzdHJpbmciLCAib3B0aW9u YWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiPGNvZGU+QXR0cjwvY29kZT4ncyB2YWx1ZS4iIH0s CisgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiZnJhbWVJZCIsICIkcmVmIjogIk5ldHdv cmsuRnJhbWVJZCIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJGcmFtZSBJRCBm b3IgZnJhbWUgb3duZXIgZWxlbWVudHMuIiB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1l IjogImNvbnRlbnREb2N1bWVudCIsICIkcmVmIjogIk5vZGUiLCAib3B0aW9uYWwiOiB0cnVlLCAi ZGVzY3JpcHRpb24iOiAiQ29udGVudCBkb2N1bWVudCBmb3IgZnJhbWUgb3duZXIgZWxlbWVudHMu IiB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInNoYWRvd1Jvb3RzIiwgInR5cGUi OiAiYXJyYXkiLCAib3B0aW9uYWwiOiB0cnVlLCAiaXRlbXMiOiB7ICIkcmVmIjogIk5vZGUiIH0s ICJkZXNjcmlwdGlvbiI6ICJTaGFkb3cgcm9vdCBsaXN0IGZvciBnaXZlbiBlbGVtZW50IGhvc3Qu IiB9CiAgICAgICAgICAgICAgICAgXSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDE2MWI3MmI2ZjkwZGI3MjdjZjE0MDdiNjgxN2U1N2Ri YjY2YTllZGMuLmE0MWQxOTgwNDdhOTlkOGM2YzZhMjgyODdjZTc2YzFkYWNkZGMwOGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtMTI3 OSw2ICsxMjc5LDkgQEAgUGFzc1JlZlB0cjxUeXBlQnVpbGRlcjo6RE9NOjpOb2RlPiBJbnNwZWN0 b3JET01BZ2VudDo6YnVpbGRPYmplY3RGb3JOb2RlKE5vZGUqIG4KICAgICAgICAgdmFsdWUtPnNl dEF0dHJpYnV0ZXMoYnVpbGRBcnJheUZvckVsZW1lbnRBdHRyaWJ1dGVzKGVsZW1lbnQpKTsKICAg ICAgICAgaWYgKG5vZGUtPmlzRnJhbWVPd25lckVsZW1lbnQoKSkgewogICAgICAgICAgICAgSFRN TEZyYW1lT3duZXJFbGVtZW50KiBmcmFtZU93bmVyID0gc3RhdGljX2Nhc3Q8SFRNTEZyYW1lT3du ZXJFbGVtZW50Kj4obm9kZSk7CisgICAgICAgICAgICBGcmFtZSogZnJhbWUgPSBmcmFtZU93bmVy LT5jb250ZW50RnJhbWUoKTsKKyAgICAgICAgICAgIGlmIChmcmFtZSkKKyAgICAgICAgICAgICAg ICB2YWx1ZS0+c2V0RnJhbWVJZChtX3BhZ2VBZ2VudC0+ZnJhbWVJZChmcmFtZSkpOwogICAgICAg ICAgICAgRG9jdW1lbnQqIGRvYyA9IGZyYW1lT3duZXItPmNvbnRlbnREb2N1bWVudCgpOwogICAg ICAgICAgICAgaWYgKGRvYykKICAgICAgICAgICAgICAgICB2YWx1ZS0+c2V0Q29udGVudERvY3Vt ZW50KGJ1aWxkT2JqZWN0Rm9yTm9kZShkb2MsIDAsIG5vZGVzTWFwKSk7Cg==