105279 2012-12-18 04:54:48 -0800 Web Inspector: Document* should be used directly in WebSocket Instrumentation 2012-12-19 07:44:27 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pan.deng webkit-unassigned apavlov keishi loislo pfeldman pmuellr toyoshim vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 793554 0 pan.deng 2012-12-18 04:54:48 -0800 In inspectorInstrumentation.h, first arg of some WebSocket instrumentation functions are ScriptExecutionContext, (didCreateWebSocket, willSendWebSocketHandshakeRequest, didReceiveWebSocketHandshakeResponse, didCloseWebSocket), however they are all feed with Document* in their client (WebSocketChannel.cpp) accurately, and handled as Document* again in instrumentingAgentsForContext(). in addition, if Document* is adopted as arg, more info can be accessed, frame info for example. 793562 1 179924 pan.deng 2012-12-18 05:04:42 -0800 Created attachment 179924 Patch 793569 2 pfeldman 2012-12-18 05:19:13 -0800 What about web sockets in web workers? 794325 3 pan.deng 2012-12-18 21:20:15 -0800 (In reply to comment #2) > What about web sockets in web workers? Nice consideration, thanks a lot for your comments :) Actually, "WebSocketChannel" is the backend of "WorkerThreadableWebSocketChannel", and ScriptExecutionContext* in the former class is always a Document* rather than WorkerContext* (even when play as a backend of worker) add Toyoshima-san to review it. thanks Pan 794546 4 toyoshim 2012-12-19 05:08:09 -0800 (In reply to comment #3) > Actually, "WebSocketChannel" is the backend of "WorkerThreadableWebSocketChannel", and ScriptExecutionContext* in the former class is always a Document* rather than WorkerContext* (even when play as a backend of worker) Right. In the case of Workers, WebSocket objects in the workers have proxy objects in the main thread respectively. The proxy objects always own WebSocketChannel which has Document object as a ScriptExecutionContext. AFAIK, Inspector code exists in this WebSocketChannel. So, Document object is always available for these interfaces. 794550 5 toyoshim 2012-12-19 05:12:21 -0800 By the way, currently DevTools doesn't handle WebSocket objects in SharedWorkers and (dedicated) Workers seemingly, right? Also DevTools for Workers doesn't contain Network tab for now. I guess WebSocket is the only object which uses networking in Workers now. 794558 6 toyoshim 2012-12-19 05:21:02 -0800 (In reply to comment #5) > By the way, currently DevTools doesn't handle WebSocket objects in SharedWorkers and (dedicated) Workers seemingly, right? > Also DevTools for Workers doesn't contain Network tab for now. I guess WebSocket is the only object which uses networking in Workers now. https://bugs.webkit.org/show_bug.cgi?id=105419 I filed a bug though I don't have time to work on this for now. 794582 7 pfeldman 2012-12-19 05:44:36 -0800 > Right. In the case of Workers, WebSocket objects in the workers have proxy objects in the main thread respectively. The proxy objects always own WebSocketChannel which has Document object as a ScriptExecutionContext. So you are saying that having main thread in the tight loop will prevent workers from dispatching the data? Is this a short term thing or will it be so long term? 794604 8 toyoshim 2012-12-19 06:13:04 -0800 (In reply to comment #7) > So you are saying that having main thread in the tight loop will prevent workers from dispatching the data? Is this a short term thing or will it be so long term? Yes. We have no plan to change this design. In the design was not changed, Chrome port handles all network requests in an IO thread in a browser process. So, distributing requests from workers to threads looks very difficult and could be essential change. http://www.chromium.org/developers/design-documents/multi-process-resource-loading 794607 9 toyoshim 2012-12-19 06:14:04 -0800 (In reply to comment #8) > In the design was not changed, Sorry, it means 'If the design was not changed,' 794661 10 179924 webkit.review.bot 2012-12-19 07:44:23 -0800 Comment on attachment 179924 Patch Clearing flags on attachment: 179924 Committed r138163: <http://trac.webkit.org/changeset/138163> 794662 11 webkit.review.bot 2012-12-19 07:44:27 -0800 All reviewed patches have been landed. Closing bug. 179924 2012-12-18 05:04:42 -0800 2012-12-19 07:44:23 -0800 Patch bug-105279-20121218210754.patch text/plain 6089 pan.deng U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDJlMzBiZjBkNjMzY2Vh NjU3YjQwM2QyOTI0MGZjZmI2ZGZlZDZhMC4uM2QxYjIwZjgxMzczZmQ5MjVmMDc5YzRmMzZkMmNh Y2M0NDI0YTcyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTE4ICBQYW4g RGVuZyAgPHBhbi5kZW5nQGludGVsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBVc2Ug RG9jdW1lbnQqIGFzIGFyZ3VtZW50IGluIFdlYlNvY2tldCBJbnN0cnVtZW50YXRpb24uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNzkuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSBXZWJTb2Nr ZXQgaW5zdHJ1bWVudGF0aW9uIGZ1Y3Rpb25zIGFkb3B0ZWQgU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCogYXMgYXJndW1lbnQsIGl0IGlzIG5vdCBjbGVhciB0aGF0CisgICAgICAgIHRoZWlyIGNsaWVu dHMgYW5kIGltcGxlbWVudGF0aW9ucyBhcmUgYWxsIHVzaW5nIERvY3VtZW50Ki4gVGhpcyBwYXRj aCBhZG9wdCBEb2N1bWVudCogYXMgYXJndW1lbnQsIGFuZCAKKyAgICAgICAgRG9jdW1lbnQqIGNv dWxkIHN1cHBseSBtb3JlIGluZm9ybWF0aW9uIGluIGZ1dHVyZS4KKworICAgICAgICBObyBmdW5j dGlvbmFsaXR5IGNoYW5nZWQsIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIGluc3BlY3Rvci9J bnNwZWN0b3JJbnN0cnVtZW50YXRpb24uaDoKKyAgICAgICAgKEluc3BlY3Rvckluc3RydW1lbnRh dGlvbik6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZENy ZWF0ZVdlYlNvY2tldCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JJbnN0cnVtZW50YXRp b246OndpbGxTZW5kV2ViU29ja2V0SGFuZHNoYWtlUmVxdWVzdCk6CisgICAgICAgIChXZWJDb3Jl OjpJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZFJlY2VpdmVXZWJTb2NrZXRIYW5kc2hha2VS ZXNwb25zZSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRp ZENsb3NlV2ViU29ja2V0KToKKwogMjAxMi0xMi0xNyAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbV2ViR0xdIGhhbmRsZSB2 aWRlbyBlbGVtZW50cyB1c2VkIGluIFdlYkdMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmgKaW5kZXggMTE2Y2M0MmUwZGUwZDRlYzFj MWJhNDMwNzM5MGEwNWM0NTM1NmY5MS4uMzI4NTNlZDljYTliMjJlYzIxMjMzMmQyYjAxYWQxOGYz ZTIwMmZhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvcklu c3RydW1lbnRhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJ bnN0cnVtZW50YXRpb24uaApAQCAtMjQwLDEwICsyNDAsMTAgQEAgcHVibGljOgogI2VuZGlmCiAK ICNpZiBFTkFCTEUoV0VCX1NPQ0tFVFMpCi0gICAgc3RhdGljIHZvaWQgZGlkQ3JlYXRlV2ViU29j a2V0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNv bnN0IEtVUkwmIHJlcXVlc3RVUkwsIGNvbnN0IEtVUkwmIGRvY3VtZW50VVJMKTsKLSAgICBzdGF0 aWMgdm9pZCB3aWxsU2VuZFdlYlNvY2tldEhhbmRzaGFrZVJlcXVlc3QoU2NyaXB0RXhlY3V0aW9u Q29udGV4dCosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgY29uc3QgV2ViU29ja2V0SGFuZHNo YWtlUmVxdWVzdCYpOwotICAgIHN0YXRpYyB2b2lkIGRpZFJlY2VpdmVXZWJTb2NrZXRIYW5kc2hh a2VSZXNwb25zZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgdW5zaWduZWQgbG9uZyBpZGVudGlm aWVyLCBjb25zdCBXZWJTb2NrZXRIYW5kc2hha2VSZXNwb25zZSYpOwotICAgIHN0YXRpYyB2b2lk IGRpZENsb3NlV2ViU29ja2V0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCB1bnNpZ25lZCBsb25n IGlkZW50aWZpZXIpOworICAgIHN0YXRpYyB2b2lkIGRpZENyZWF0ZVdlYlNvY2tldChEb2N1bWVu dCosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgY29uc3QgS1VSTCYgcmVxdWVzdFVSTCwgY29u c3QgS1VSTCYgZG9jdW1lbnRVUkwpOworICAgIHN0YXRpYyB2b2lkIHdpbGxTZW5kV2ViU29ja2V0 SGFuZHNoYWtlUmVxdWVzdChEb2N1bWVudCosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgY29u c3QgV2ViU29ja2V0SGFuZHNoYWtlUmVxdWVzdCYpOworICAgIHN0YXRpYyB2b2lkIGRpZFJlY2Vp dmVXZWJTb2NrZXRIYW5kc2hha2VSZXNwb25zZShEb2N1bWVudCosIHVuc2lnbmVkIGxvbmcgaWRl bnRpZmllciwgY29uc3QgV2ViU29ja2V0SGFuZHNoYWtlUmVzcG9uc2UmKTsKKyAgICBzdGF0aWMg dm9pZCBkaWRDbG9zZVdlYlNvY2tldChEb2N1bWVudCosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmll cik7CiAgICAgc3RhdGljIHZvaWQgZGlkUmVjZWl2ZVdlYlNvY2tldEZyYW1lKERvY3VtZW50Kiwg dW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBjb25zdCBXZWJTb2NrZXRGcmFtZSYpOwogICAgIHN0 YXRpYyB2b2lkIGRpZFNlbmRXZWJTb2NrZXRGcmFtZShEb2N1bWVudCosIHVuc2lnbmVkIGxvbmcg aWRlbnRpZmllciwgY29uc3QgV2ViU29ja2V0RnJhbWUmKTsKICAgICBzdGF0aWMgdm9pZCBkaWRS ZWNlaXZlV2ViU29ja2V0RnJhbWVFcnJvcihEb2N1bWVudCosIHVuc2lnbmVkIGxvbmcgaWRlbnRp ZmllciwgY29uc3QgU3RyaW5nJiBlcnJvck1lc3NhZ2UpOwpAQCAtMTc1OSw1MCArMTc1OSw1MCBA QCBpbmxpbmUgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OndvcmtlckNvbnRleHRUZXJt aW5hdGVkKFNjcmlwdEV4ZWN1dGlvbkNvbgogCiAKICNpZiBFTkFCTEUoV0VCX1NPQ0tFVFMpCi1p bmxpbmUgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZENyZWF0ZVdlYlNvY2tldChT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIs IGNvbnN0IEtVUkwmIHJlcXVlc3RVUkwsIGNvbnN0IEtVUkwmIGRvY3VtZW50VVJMKQoraW5saW5l IHZvaWQgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRDcmVhdGVXZWJTb2NrZXQoRG9jdW1l bnQqIGRvY3VtZW50LCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IEtVUkwmIHJlcXVl c3RVUkwsIGNvbnN0IEtVUkwmIGRvY3VtZW50VVJMKQogewogI2lmIEVOQUJMRShJTlNQRUNUT1Ip Ci0gICAgaWYgKEluc3RydW1lbnRpbmdBZ2VudHMqIGluc3RydW1lbnRpbmdBZ2VudHMgPSBpbnN0 cnVtZW50aW5nQWdlbnRzRm9yQ29udGV4dChjb250ZXh0KSkKKyAgICBpZiAoSW5zdHJ1bWVudGlu Z0FnZW50cyogaW5zdHJ1bWVudGluZ0FnZW50cyA9IGluc3RydW1lbnRpbmdBZ2VudHNGb3JEb2N1 bWVudChkb2N1bWVudCkpCiAgICAgICAgIGRpZENyZWF0ZVdlYlNvY2tldEltcGwoaW5zdHJ1bWVu dGluZ0FnZW50cywgaWRlbnRpZmllciwgcmVxdWVzdFVSTCwgZG9jdW1lbnRVUkwpOwogI2Vsc2UK LSAgICBVTlVTRURfUEFSQU0oY29udGV4dCk7CisgICAgVU5VU0VEX1BBUkFNKGRvY3VtZW50KTsK ICAgICBVTlVTRURfUEFSQU0oaWRlbnRpZmllcik7CiAgICAgVU5VU0VEX1BBUkFNKHJlcXVlc3RV UkwpOwogICAgIFVOVVNFRF9QQVJBTShkb2N1bWVudFVSTCk7CiAjZW5kaWYKIH0KIAotaW5saW5l IHZvaWQgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjp3aWxsU2VuZFdlYlNvY2tldEhhbmRzaGFr ZVJlcXVlc3QoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgdW5zaWduZWQgbG9uZyBp ZGVudGlmaWVyLCBjb25zdCBXZWJTb2NrZXRIYW5kc2hha2VSZXF1ZXN0JiByZXF1ZXN0KQoraW5s aW5lIHZvaWQgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjp3aWxsU2VuZFdlYlNvY2tldEhhbmRz aGFrZVJlcXVlc3QoRG9jdW1lbnQqIGRvY3VtZW50LCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIs IGNvbnN0IFdlYlNvY2tldEhhbmRzaGFrZVJlcXVlc3QmIHJlcXVlc3QpCiB7CiAjaWYgRU5BQkxF KElOU1BFQ1RPUikKLSAgICBpZiAoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1bWVudGluZ0Fn ZW50cyA9IGluc3RydW1lbnRpbmdBZ2VudHNGb3JDb250ZXh0KGNvbnRleHQpKQorICAgIGlmIChJ bnN0cnVtZW50aW5nQWdlbnRzKiBpbnN0cnVtZW50aW5nQWdlbnRzID0gaW5zdHJ1bWVudGluZ0Fn ZW50c0ZvckRvY3VtZW50KGRvY3VtZW50KSkKICAgICAgICAgd2lsbFNlbmRXZWJTb2NrZXRIYW5k c2hha2VSZXF1ZXN0SW1wbChpbnN0cnVtZW50aW5nQWdlbnRzLCBpZGVudGlmaWVyLCByZXF1ZXN0 KTsKICNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKGNvbnRleHQpOworICAgIFVOVVNFRF9QQVJBTShk b2N1bWVudCk7CiAgICAgVU5VU0VEX1BBUkFNKGlkZW50aWZpZXIpOwogICAgIFVOVVNFRF9QQVJB TShyZXF1ZXN0KTsKICNlbmRpZgogfQogCi1pbmxpbmUgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50 YXRpb246OmRpZFJlY2VpdmVXZWJTb2NrZXRIYW5kc2hha2VSZXNwb25zZShTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBjb250ZXh0LCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IFdlYlNv Y2tldEhhbmRzaGFrZVJlc3BvbnNlJiByZXNwb25zZSkKK2lubGluZSB2b2lkIEluc3BlY3Rvcklu c3RydW1lbnRhdGlvbjo6ZGlkUmVjZWl2ZVdlYlNvY2tldEhhbmRzaGFrZVJlc3BvbnNlKERvY3Vt ZW50KiBkb2N1bWVudCwgdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBjb25zdCBXZWJTb2NrZXRI YW5kc2hha2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7CiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKLSAg ICBpZiAoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1bWVudGluZ0FnZW50cyA9IGluc3RydW1l bnRpbmdBZ2VudHNGb3JDb250ZXh0KGNvbnRleHQpKQorICAgIGlmIChJbnN0cnVtZW50aW5nQWdl bnRzKiBpbnN0cnVtZW50aW5nQWdlbnRzID0gaW5zdHJ1bWVudGluZ0FnZW50c0ZvckRvY3VtZW50 KGRvY3VtZW50KSkKICAgICAgICAgZGlkUmVjZWl2ZVdlYlNvY2tldEhhbmRzaGFrZVJlc3BvbnNl SW1wbChpbnN0cnVtZW50aW5nQWdlbnRzLCBpZGVudGlmaWVyLCByZXNwb25zZSk7CiAjZWxzZQot ICAgIFVOVVNFRF9QQVJBTShjb250ZXh0KTsKKyAgICBVTlVTRURfUEFSQU0oZG9jdW1lbnQpOwog ICAgIFVOVVNFRF9QQVJBTShpZGVudGlmaWVyKTsKICAgICBVTlVTRURfUEFSQU0ocmVzcG9uc2Up OwogI2VuZGlmCiB9CiAKLWlubGluZSB2b2lkIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlk Q2xvc2VXZWJTb2NrZXQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgdW5zaWduZWQg bG9uZyBpZGVudGlmaWVyKQoraW5saW5lIHZvaWQgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpk aWRDbG9zZVdlYlNvY2tldChEb2N1bWVudCogZG9jdW1lbnQsIHVuc2lnbmVkIGxvbmcgaWRlbnRp ZmllcikKIHsKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQotICAgIGlmIChJbnN0cnVtZW50aW5nQWdl bnRzKiBpbnN0cnVtZW50aW5nQWdlbnRzID0gaW5zdHJ1bWVudGluZ0FnZW50c0ZvckNvbnRleHQo Y29udGV4dCkpCisgICAgaWYgKEluc3RydW1lbnRpbmdBZ2VudHMqIGluc3RydW1lbnRpbmdBZ2Vu dHMgPSBpbnN0cnVtZW50aW5nQWdlbnRzRm9yRG9jdW1lbnQoZG9jdW1lbnQpKQogICAgICAgICBk aWRDbG9zZVdlYlNvY2tldEltcGwoaW5zdHJ1bWVudGluZ0FnZW50cywgaWRlbnRpZmllcik7CiAj ZWxzZQotICAgIFVOVVNFRF9QQVJBTShjb250ZXh0KTsKKyAgICBVTlVTRURfUEFSQU0oZG9jdW1l bnQpOwogICAgIFVOVVNFRF9QQVJBTShpZGVudGlmaWVyKTsKICNlbmRpZgogfQo=