<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>105275</bug_id>
          
          <creation_ts>2012-12-18 03:42:23 -0800</creation_ts>
          <short_desc>REGRESSION (r118044): CSSParser crashes, when no context is available, and the value is a valid keyword</short_desc>
          <delta_ts>2013-06-03 09:04:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Regression</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>116980</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Renata Hodovan">rhodovan.u-szeged</reporter>
          <assigned_to name="Renata Hodovan">rhodovan.u-szeged</assigned_to>
          <cc>cmarcelo</cc>
    
    <cc>koivisto</cc>
    
    <cc>macpherson</cc>
    
    <cc>menard</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>793514</commentid>
    <comment_count>0</comment_count>
    <who name="Renata Hodovan">rhodovan.u-szeged</who>
    <bug_when>2012-12-18 03:42:23 -0800</bug_when>
    <thetext>My SVGFuzzer crashes on this svg test:

&lt;svg xmlns=&quot;http://www.w3.org/2000/svg&quot;&gt;
    &lt;circle&gt;
        &lt;animate attributeName=&quot;display&quot; to=&quot;bevel&quot;&gt;&lt;/animate&gt;
    &lt;/circle&gt;
&lt;/svg&gt;


The crash comes from the CSSParser.
StylePropertySet::setProperty was called with 0 (what is 0 by default too) contextStyleSheet from SVGAnimateElement. This zero was propageted to CSSParser::isValidKeywordPropertyAndValue() where parserContext.isCSSGridLayoutEnabled was NULL too and caused a segfault.


Backtrace:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff3d05012 in isValidKeywordPropertyAndValue (propertyId=WebCore::CSSPropertyDisplay, valueID=724, parserContext=...)
    at /home/reni/WebKit-git/Source/WebCore/css/CSSParser.cpp:632
632	        if (parserContext.isCSSGridLayoutEnabled &amp;&amp; (valueID == CSSValueWebkitGrid || valueID == CSSValueWebkitInlineGrid))
(gdb) bt 8 
#0  0x00007ffff3d05012 in isValidKeywordPropertyAndValue (propertyId=WebCore::CSSPropertyDisplay, valueID=724, parserContext=...)
    at /home/reni/WebKit-git/Source/WebCore/css/CSSParser.cpp:632
#1  0x00007ffff3d06119 in parseKeywordValue (declaration=0x9926f0, propertyId=WebCore::CSSPropertyDisplay, string=..., important=false, parserContext=...)
    at /home/reni/WebKit-git/Source/WebCore/css/CSSParser.cpp:1119
#2  0x00007ffff3d0690a in WebCore::CSSParser::parseValue (declaration=0x9926f0, propertyID=WebCore::CSSPropertyDisplay, string=..., important=false, 
    cssParserMode=WebCore::SVGAttributeMode, contextStyleSheet=0x0) at /home/reni/WebKit-git/Source/WebCore/css/CSSParser.cpp:1232
#3  0x00007ffff3e01d11 in WebCore::StylePropertySet::setProperty (this=0x9926f0, propertyID=WebCore::CSSPropertyDisplay, value=..., important=false, 
    contextStyleSheet=0x0) at /home/reni/WebKit-git/Source/WebCore/css/StylePropertySet.cpp:661
#4  0x00007ffff4ac098d in applyCSSPropertyToTarget (targetElement=0x98c0c0, id=WebCore::CSSPropertyDisplay, value=...)
    at /home/reni/WebKit-git/Source/WebCore/svg/SVGAnimateElement.cpp:242
#5  0x00007ffff4ac0b4a in applyCSSPropertyToTargetAndInstances (targetElement=0x98c0c0, attributeName=..., valueAsString=...)
    at /home/reni/WebKit-git/Source/WebCore/svg/SVGAnimateElement.cpp:264
#6  0x00007ffff4ac129f in WebCore::SVGAnimateElement::applyResultsToTarget (this=0x9985b0) at /home/reni/WebKit-git/Source/WebCore/svg/SVGAnimateElement.cpp:359
#7  0x00007ffff4a5e516 in WebCore::SMILTimeContainer::updateAnimations (this=0x96a280, elapsed=..., seekToTime=false)
    at /home/reni/WebKit-git/Source/WebCore/svg/animation/SMILTimeContainer.cpp:319
(More stack frames follow...)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>793522</commentid>
    <comment_count>1</comment_count>
    <who name="Renata Hodovan">rhodovan.u-szeged</who>
    <bug_when>2012-12-18 03:47:25 -0800</bug_when>
    <thetext>Maybe we could simply extend it to

if(contextSytleSheet &amp;&amp; parseKeyWordValue()) {}

in parseValue(). But I&apos;m not really familiar with CSS. Ideas?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>793524</commentid>
    <comment_count>2</comment_count>
    <who name="Renata Hodovan">rhodovan.u-szeged</who>
    <bug_when>2012-12-18 03:49:31 -0800</bug_when>
    <thetext>We get the same crash with &lt;set&gt; svg tag too:


&lt;svg xmlns=&quot;http://www.w3.org/2000/svg&quot;&gt;
    &lt;rect&gt;
        &lt;set attributeName=&quot;display&quot; to=&quot;round&quot;&gt;&lt;/set&gt;
    &lt;/rect&gt;
&lt;/svg&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>793739</commentid>
    <comment_count>3</comment_count>
      <attachid>179965</attachid>
    <who name="Renata Hodovan">rhodovan.u-szeged</who>
    <bug_when>2012-12-18 09:41:20 -0800</bug_when>
    <thetext>Created attachment 179965
Speculative fix

Maybe I should add a new test case too (?).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>793746</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-12-18 09:49:18 -0800</bug_when>
    <thetext>Regressed in &lt;http://trac.webkit.org/changeset/118044&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>793749</commentid>
    <comment_count>5</comment_count>
      <attachid>179965</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-18 09:51:39 -0800</bug_when>
    <thetext>Comment on attachment 179965
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=179965&amp;action=review

&gt; Source/WebCore/ChangeLog:10
&gt; +        No new tests (OOPS!).

Please add a test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>793836</commentid>
    <comment_count>6</comment_count>
      <attachid>179965</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-12-18 10:57:43 -0800</bug_when>
    <thetext>Comment on attachment 179965
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=179965&amp;action=review

&gt; Source/WebCore/css/CSSParser.cpp:1232
&gt; -    if (parseKeywordValue(declaration, propertyID, string, important, contextStyleSheet-&gt;parserContext()))
&gt; +    if (contextStyleSheet &amp;&amp; parseKeywordValue(declaration, propertyID, string, important, contextStyleSheet-&gt;parserContext()))

I don&apos;t think this is correct.  A few lines below, we create a CSSParserContext or use contextStyleSheet-&gt;parserContext() if it&apos;s available.  We should try moving that code block here.  This might have a perf impact.  Try running run-perf-tests Dromaeo/jslib-style-prototype to check.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>794151</commentid>
    <comment_count>7</comment_count>
      <attachid>180052</attachid>
    <who name="Renata Hodovan">rhodovan.u-szeged</who>
    <bug_when>2012-12-18 16:26:06 -0800</bug_when>
    <thetext>Created attachment 180052
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>794158</commentid>
    <comment_count>8</comment_count>
    <who name="Renata Hodovan">rhodovan.u-szeged</who>
    <bug_when>2012-12-18 16:28:50 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 179965 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=179965&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/css/CSSParser.cpp:1232
&gt; &gt; -    if (parseKeywordValue(declaration, propertyID, string, important, contextStyleSheet-&gt;parserContext()))
&gt; &gt; +    if (contextStyleSheet &amp;&amp; parseKeywordValue(declaration, propertyID, string, important, contextStyleSheet-&gt;parserContext()))
&gt; 
&gt; I don&apos;t think this is correct.  A few lines below, we create a CSSParserContext or use contextStyleSheet-&gt;parserContext() if it&apos;s available.  We should try moving that code block here.  This might have a perf impact.  Try running run-perf-tests Dromaeo/jslib-style-prototype to check.

I&apos;ve runned both versions a few times and it&apos;s seems that there is no measureable difference between them (+/-1 %). This way I choosed you idea.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>794166</commentid>
    <comment_count>9</comment_count>
      <attachid>180052</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-12-18 16:32:26 -0800</bug_when>
    <thetext>Comment on attachment 180052
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180052&amp;action=review

&gt; LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt:1
&gt; +Excellent - did not crash. See bug https://bugs.webkit.org/show_bug.cgi?id=105275

Nit: Normally we write something like &quot;This test passes if it does not crash.&quot; or just PASS, but this is also OK.

&gt; LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg:10
&gt; +        testRunner.dumpAsText();

Please indent the dumpAsText() line 4 more spaces.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>794499</commentid>
    <comment_count>10</comment_count>
    <who name="Renata Hodovan">rhodovan.u-szeged</who>
    <bug_when>2012-12-19 03:57:38 -0800</bug_when>
    <thetext>Committed r138141: &lt;http://trac.webkit.org/changeset/138141&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>179965</attachid>
            <date>2012-12-18 09:41:20 -0800</date>
            <delta_ts>2012-12-18 16:26:06 -0800</delta_ts>
            <desc>Speculative fix</desc>
            <filename>0001-css-crash.patch</filename>
            <type>text/plain</type>
            <size>1839</size>
            <attacher name="Renata Hodovan">rhodovan.u-szeged</attacher>
            
              <data encoding="base64">RnJvbSA5Y2VkOGQ3MDMzZGE5MzFhYmRkMDM3M2Q5N2VkNTJlMWY3YTUyMGUyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW5hdGEgSG9kb3ZhbiA8cmVuaUB3ZWJraXQub3JnPgpEYXRl
OiBUdWUsIDE4IERlYyAyMDEyIDE4OjI1OjE1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gY3NzIGNy
YXNoCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgIHwgICAxNCArKysrKysr
KysrKysrKwogU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgfCAgICAyICstCiAyIGZp
bGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu
ZGV4IDk4YmE0MDguLmJkOTRiMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0x
Mi0xOCAgUmVuYXRhIEhvZG92YW4gIDxyZW5pQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ1NTUGFy
c2VyIGNyYXNlcywgd2hlbiBubyBjb250ZXh0IGlzIGF2YWlsYWJsZSwgYW5kIHRoZSB2YWx1ZSBp
cyBhIHZhbGlkIGtleXdvcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTEwNTI3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFBhcnNlckNvbnRleHQgY291bGQgYmUgbnVsbCBldmVuIGlmIHRoZSBrZXl3b3Jk
IGlzIHZhbGlkLiBXZSBoYXZlIHRvIGNoZWNrIGl0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAo
T09QUyEpLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOgorCiAyMDEyLTEyLTE4ICBFcmljIENhcmxzb24gIDxl
cmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBpbi1iYW5kIHRleHQgdHJhY2sg
Y3VlcyBvbmx5IG9uY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu
Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNjk5NWIzMS4uMGQ1
Zjg3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIv
U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTEyMjksNyArMTIyOSw3IEBAIGJv
b2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKFN0eWxlUHJvcGVydHlTZXQqIGRlY2xhcmF0aW9uLCBD
U1NQcm9wZXJ0eUlEIHByb3BlcnR5CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIGlmIChwYXJz
ZUNvbG9yVmFsdWUoZGVjbGFyYXRpb24sIHByb3BlcnR5SUQsIHN0cmluZywgaW1wb3J0YW50LCBj
c3NQYXJzZXJNb2RlKSkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgaWYgKHBhcnNlS2V5d29y
ZFZhbHVlKGRlY2xhcmF0aW9uLCBwcm9wZXJ0eUlELCBzdHJpbmcsIGltcG9ydGFudCwgY29udGV4
dFN0eWxlU2hlZXQtPnBhcnNlckNvbnRleHQoKSkpCisgICAgaWYgKGNvbnRleHRTdHlsZVNoZWV0
ICYmIHBhcnNlS2V5d29yZFZhbHVlKGRlY2xhcmF0aW9uLCBwcm9wZXJ0eUlELCBzdHJpbmcsIGlt
cG9ydGFudCwgY29udGV4dFN0eWxlU2hlZXQtPnBhcnNlckNvbnRleHQoKSkpCiAgICAgICAgIHJl
dHVybiB0cnVlOwogICAgIGlmIChwYXJzZVRyYW5zbGF0ZVRyYW5zZm9ybVZhbHVlKGRlY2xhcmF0
aW9uLCBwcm9wZXJ0eUlELCBzdHJpbmcsIGltcG9ydGFudCkpCiAgICAgICAgIHJldHVybiB0cnVl
OwotLSAKMS43LjIuNQoK
</data>
<flag name="review"
          id="197068"
          type_id="1"
          status="-"
          setter="rniwa"
    />
    <flag name="commit-queue"
          id="197069"
          type_id="3"
          status="-"
          setter="rniwa"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>180052</attachid>
            <date>2012-12-18 16:26:06 -0800</date>
            <delta_ts>2012-12-18 16:32:26 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>0001-css_crash_3.patch</filename>
            <type>text/plain</type>
            <size>4565</size>
            <attacher name="Renata Hodovan">rhodovan.u-szeged</attacher>
            
              <data encoding="base64">RnJvbSBiYjEwNGY3ZDRjNzgzMmJlN2EyNWQyMGIyZjM1ZDlhYmYyYWE2MjQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBoYWNra2l0dGVuIDxoYWNra2l0dGVuQGhhY2traXR0ZW4uKG5v
bmUpPgpEYXRlOiBXZWQsIDE5IERlYyAyMDEyIDAxOjE3OjQ1ICswMTAwClN1YmplY3Q6IFtQQVRD
SF0gY3NzX2NyYXNoXzMKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uLXBhcnNlcmNvbnRleHQtdmFs
aWQta2V5d29yZC1jcmFzaC1leHBlY3RlZC50eHQgfCAgICAxICsKIC4uLi9pbnZhbGlkLXBhcnNl
cmNvbnRleHQtdmFsaWQta2V5d29yZC1jcmFzaC5zdmcgIHwgICAxMyArKysrKysrKysrKysrCiBT
b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQg
KysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwICAgICAgICAg
ICAgICAgICAgIHwgICAxMCArKysrKystLS0tCiA1IGZpbGVzIGNoYW5nZWQsIDQ2IGluc2VydGlv
bnMoKyksIDQgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFz
dC9jc3MvaW52YWxpZC1wYXJzZXJjb250ZXh0LXZhbGlkLWtleXdvcmQtY3Jhc2gtZXhwZWN0ZWQu
dHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxpZC1wYXJz
ZXJjb250ZXh0LXZhbGlkLWtleXdvcmQtY3Jhc2guc3ZnCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDcxMjY1MGEuLjY3YjBl
YWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMi0xOCAgUmVuYXRhIEhvZG92YW4gIDxy
ZW5pQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ1NTUGFyc2VyIGNyYXNlcywgd2hlbiBubyBjb250
ZXh0IGlzIGF2YWlsYWJsZSwgYW5kIHRoZSB2YWx1ZSBpcyBhIHZhbGlkIGtleXdvcmQKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTI3NQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhcnNlckNvbnRleHQg
Y291bGQgYmUgbnVsbCBldmVuIGlmIHRoZSBrZXl3b3JkIGlzIHZhbGlkLiBXZSBoYXZlIHRvIGNo
ZWNrIGl0LgorCisgICAgICAgICogZmFzdC9jc3MvaW52YWxpZC1wYXJzZXJjb250ZXh0LXZhbGlk
LWtleXdvcmQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9p
bnZhbGlkLXBhcnNlcmNvbnRleHQtdmFsaWQta2V5d29yZC1jcmFzaC5zdmc6IEFkZGVkLgorCiAy
MDEyLTEyLTE4ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwu
Y29tPgogCiAgICAgICAgIFtXSzJdIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEv
TGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxpZC1wYXJzZXJjb250ZXh0LXZhbGlkLWtleXdvcmQt
Y3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxpZC1wYXJzZXJj
b250ZXh0LXZhbGlkLWtleXdvcmQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw
NjQ0CmluZGV4IDAwMDAwMDAuLjc3YzcxOGUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0
cy9mYXN0L2Nzcy9pbnZhbGlkLXBhcnNlcmNvbnRleHQtdmFsaWQta2V5d29yZC1jcmFzaC1leHBl
Y3RlZC50eHQKQEAgLTAsMCArMSBAQAorRXhjZWxsZW50IC0gZGlkIG5vdCBjcmFzaC4gU2VlIGJ1
ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1Mjc1CmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLXBhcnNlcmNvbnRleHQtdmFsaWQta2V5
d29yZC1jcmFzaC5zdmcgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLXBhcnNlcmNvbnRl
eHQtdmFsaWQta2V5d29yZC1jcmFzaC5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw
MDAwMC4uOTEzZGRhYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2lu
dmFsaWQtcGFyc2VyY29udGV4dC12YWxpZC1rZXl3b3JkLWNyYXNoLnN2ZwpAQCAtMCwwICsxLDEz
IEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CisgICAgPCEtLSBU
aGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoLiAtLT4KKyAgICA8cmVjdD4KKwkg
ICAgPGFuaW1hdGUgYXR0cmlidXRlTmFtZT0iZGlzcGxheSIgdG89ImJldmVsIj48L2FuaW1hdGU+
CisgICAgPC9yZWN0PgorCisgICAgPHRleHQgeD0iMTAiIHk9IjIwIj5FeGNlbGxlbnQgLSBkaWQg
bm90IGNyYXNoLiBTZWUgYnVnIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xMDUyNzU8L3RleHQ+CisgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVu
bmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICA8L3NjcmlwdD4KKzwv
c3ZnPgorCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cKaW5kZXggN2E4MGQyNS4uNjI1ZjA0ZSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE3IEBACisyMDEyLTEyLTE4ICBSZW5hdGEgSG9kb3ZhbiAgPHJlbmlAd2Via2l0Lm9yZz4K
KworICAgICAgICBDU1NQYXJzZXIgY3Jhc2VzLCB3aGVuIG5vIGNvbnRleHQgaXMgYXZhaWxhYmxl
LCBhbmQgdGhlIHZhbHVlIGlzIGEgdmFsaWQga2V5d29yZAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1Mjc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFyc2VyQ29udGV4dCBjb3VsZCBiZSBudWxsIGV2
ZW4gaWYgdGhlIGtleXdvcmQgaXMgdmFsaWQuIFdlIGhhdmUgdG8gY2hlY2sgaXQuCisKKyAgICAg
ICAgVGVzdDogZmFzdC9jc3MvaW52YWxpZC1wYXJzZXJjb250ZXh0LXZhbGlkLWtleXdvcmQtY3Jh
c2guc3ZnCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6
OkNTU1BhcnNlcjo6cGFyc2VWYWx1ZSk6CisKIDIwMTItMTItMTggIEFsZXhhbmRlciBQYXZsb3Yg
IDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91
dCByMTM4MDExLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCA2OTk1YjMxLi5kZDEwMTk1
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMTIyOSwxNiArMTIyOSwxOCBAQCBib29s
IENTU1BhcnNlcjo6cGFyc2VWYWx1ZShTdHlsZVByb3BlcnR5U2V0KiBkZWNsYXJhdGlvbiwgQ1NT
UHJvcGVydHlJRCBwcm9wZXJ0eQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAocGFyc2VD
b2xvclZhbHVlKGRlY2xhcmF0aW9uLCBwcm9wZXJ0eUlELCBzdHJpbmcsIGltcG9ydGFudCwgY3Nz
UGFyc2VyTW9kZSkpCiAgICAgICAgIHJldHVybiB0cnVlOwotICAgIGlmIChwYXJzZUtleXdvcmRW
YWx1ZShkZWNsYXJhdGlvbiwgcHJvcGVydHlJRCwgc3RyaW5nLCBpbXBvcnRhbnQsIGNvbnRleHRT
dHlsZVNoZWV0LT5wYXJzZXJDb250ZXh0KCkpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBp
ZiAocGFyc2VUcmFuc2xhdGVUcmFuc2Zvcm1WYWx1ZShkZWNsYXJhdGlvbiwgcHJvcGVydHlJRCwg
c3RyaW5nLCBpbXBvcnRhbnQpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIENTU1BhcnNl
ckNvbnRleHQgY29udGV4dChjc3NQYXJzZXJNb2RlKTsKICAgICBpZiAoY29udGV4dFN0eWxlU2hl
ZXQpIHsKICAgICAgICAgY29udGV4dCA9IGNvbnRleHRTdHlsZVNoZWV0LT5wYXJzZXJDb250ZXh0
KCk7CiAgICAgICAgIGNvbnRleHQubW9kZSA9IGNzc1BhcnNlck1vZGU7CiAgICAgfQorCisgICAg
aWYgKHBhcnNlS2V5d29yZFZhbHVlKGRlY2xhcmF0aW9uLCBwcm9wZXJ0eUlELCBzdHJpbmcsIGlt
cG9ydGFudCwgY29udGV4dCkpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmIChwYXJzZVRy
YW5zbGF0ZVRyYW5zZm9ybVZhbHVlKGRlY2xhcmF0aW9uLCBwcm9wZXJ0eUlELCBzdHJpbmcsIGlt
cG9ydGFudCkpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgQ1NTUGFyc2VyIHBhcnNlcihj
b250ZXh0KTsKICAgICByZXR1cm4gcGFyc2VyLnBhcnNlVmFsdWUoZGVjbGFyYXRpb24sIHByb3Bl
cnR5SUQsIHN0cmluZywgaW1wb3J0YW50LCBjb250ZXh0U3R5bGVTaGVldCk7CiB9Ci0tIAoxLjcu
OS41Cgo=
</data>
<flag name="review"
          id="197187"
          type_id="1"
          status="+"
          setter="tony"
    />
    <flag name="commit-queue"
          id="197188"
          type_id="3"
          status="-"
          setter="tony"
    />
          </attachment>
      

    </bug>

</bugzilla>