105270 2012-12-18 02:25:35 -0800 [Qt] Fix the ARMv7 build after r137976 2012-12-18 09:56:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 105237 1 ossy webkit-unassigned fpizlo gaborb galpeter hausmann laszlo.gombos loki msaboff ossy rgabor webkit.review.bot zherczeg oldest_to_newest 793487 0 ossy 2012-12-18 02:25:35 -0800 The ARMv7 build is failing on r138001 with the following error message: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGOSRExit.cpp: In member function 'JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump JSC::DFG::OSRExit::getPatchableCodeOffsetAsJump() const': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGOSRExit.cpp:60:70: error: no matching function for call to 'JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump::Jump(JSC::AssemblerLabel)' /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGOSRExit.cpp:60:70: note: candidates are: In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:33:0, from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/MacroAssembler.h:34, from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/ValueRecovery.h:31, from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CodeOrigin.h:31, from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGOSRExit.h:33, from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGOSRExit.cpp:27: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:513:9: note: JSC::AbstractMacroAssembler<AssemblerType>::Jump::Jump(JSC::AssemblerLabel, JSC::ARMv7Assembler::JumpType, JSC::ARMv7Assembler::Condition) [with AssemblerType = JSC::ARMv7Assembler] /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:513:9: note: candidate expects 3 arguments, 1 provided /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:507:9: note: JSC::AbstractMacroAssembler<AssemblerType>::Jump::Jump() [with AssemblerType = JSC::ARMv7Assembler] /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:507:9: note: candidate expects 0 arguments, 1 provided /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:500:11: note: JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump::Jump(const JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump&) /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:500:11: note: no known conversion for argument 1 from 'JSC::AssemblerLabel' to 'const JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump&' /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGOSRExit.cpp:61:1: warning: control reaches end of non-void function [-Wreturn-type] 793491 1 ossy 2012-12-18 02:33:59 -0800 I managed to find the culprit - https://trac.webkit.org/changeset/137976 broke the build. 793709 2 179957 msaboff 2012-12-18 09:10:13 -0800 Created attachment 179957 Patch Could someone on the Qt team verify that this fixes the build? 793711 3 ossy 2012-12-18 09:16:24 -0800 (In reply to comment #2) > Created an attachment (id=179957) [details] > Patch > > Could someone on the Qt team verify that this fixes the build? Sure, I'll check it. 793720 4 179957 ossy 2012-12-18 09:23:33 -0800 Comment on attachment 179957 Patch Build works fine with it, so r=me. Thanks for the quick fix. 793723 5 msaboff 2012-12-18 09:25:15 -0800 (In reply to comment #4) > (From update of attachment 179957 [details]) > Build works fine with it, so r=me. Thanks for the quick fix. Great. Sorry I didn't check the ARMv7 case before posting the original. 793755 6 179957 webkit.review.bot 2012-12-18 09:56:46 -0800 Comment on attachment 179957 Patch Clearing flags on attachment: 179957 Committed r138032: <http://trac.webkit.org/changeset/138032> 793756 7 webkit.review.bot 2012-12-18 09:56:50 -0800 All reviewed patches have been landed. Closing bug. 179957 2012-12-18 09:10:13 -0800 2012-12-18 09:56:46 -0800 Patch 105270.patch text/plain 1537 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM4MDI3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTEyLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFtRdF0gRml4IHRoZSBBUk12NyBidWlsZCBhZnRlciByMTM3OTc2CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgZGVmYXVsdCB2YWx1ZSBmb3Ig SnVtcCBwYXJhbWV0ZXIgdG8gZml4IGJ1aWxkLgorCisgICAgICAgICogYXNzZW1ibGVyL0Fic3Ry YWN0TWFjcm9Bc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6QWJzdHJhY3RNYWNyb0Fzc2VtYmxl cjo6SnVtcDo6SnVtcCk6CisKIDIwMTItMTItMTcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFw cGxlLmNvbT4KIAogICAgICAgICBDb25zdGFudCBmb2xkICF7bnVtYmVyfSBpbiB0aGUgcGFyc2Vy CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3Nl bWJsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fi c3RyYWN0TWFjcm9Bc3NlbWJsZXIuaAkocmV2aXNpb24gMTM4MDI3KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9BYnN0cmFjdE1hY3JvQXNzZW1ibGVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTUxMCw3ICs1MTAsNyBAQCBwdWJsaWM6CiAgICAgICAgIAogI2lmIENQVShBUk1fVEhV TUIyKQogICAgICAgICAvLyBGaXhtZTogdGhpcyBpbmZvcm1hdGlvbiBzaG91bGQgYmUgc3RvcmVk IGluIHRoZSBpbnN0cnVjdGlvbiBzdHJlYW0sIG5vdCBpbiB0aGUgSnVtcCBvYmplY3QuCi0gICAg ICAgIEp1bXAoQXNzZW1ibGVyTGFiZWwgam1wLCBBUk12N0Fzc2VtYmxlcjo6SnVtcFR5cGUgdHlw ZSwgQVJNdjdBc3NlbWJsZXI6OkNvbmRpdGlvbiBjb25kaXRpb24gPSBBUk12N0Fzc2VtYmxlcjo6 Q29uZGl0aW9uSW52YWxpZCkKKyAgICAgICAgSnVtcChBc3NlbWJsZXJMYWJlbCBqbXAsIEFSTXY3 QXNzZW1ibGVyOjpKdW1wVHlwZSB0eXBlID0gQVJNdjdBc3NlbWJsZXI6Okp1bXBOb0NvbmRpdGlv biwgQVJNdjdBc3NlbWJsZXI6OkNvbmRpdGlvbiBjb25kaXRpb24gPSBBUk12N0Fzc2VtYmxlcjo6 Q29uZGl0aW9uSW52YWxpZCkKICAgICAgICAgICAgIDogbV9sYWJlbChqbXApCiAgICAgICAgICAg ICAsIG1fdHlwZSh0eXBlKQogICAgICAgICAgICAgLCBtX2NvbmRpdGlvbihjb25kaXRpb24pCg==