105267 2012-12-18 01:58:34 -0800 [EFL] Add guard around ContextMenuItemTagInspectElement 2012-12-21 06:52:43 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 793475 0 seokju 2012-12-18 01:58:34 -0800 Need INSPECTOR guard for using ContextMenuItemTagInspectElement. 793589 1 179930 seokju 2012-12-18 06:22:51 -0800 Created attachment 179930 Patch 794455 2 179930 tmpsantos 2012-12-19 01:53:33 -0800 Comment on attachment 179930 Patch LGTM. 795185 3 179930 rniwa 2012-12-19 21:59:56 -0800 Comment on attachment 179930 Patch rs=me. 795188 4 179930 gyuyoung.kim 2012-12-19 22:06:56 -0800 Comment on attachment 179930 Patch Sorry for free cq+. I would like to check if we can use ENABLE_XXX macro in public header a little further. 795194 5 179930 gyuyoung.kim 2012-12-19 22:28:55 -0800 Comment on attachment 179930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179930&action=review > Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.h:118 > +#if defined ENABLE_INSPECTOR && ENABLE_INSPECTOR If app want to use this INSPECT_ELEMENT type, app should define ENABLE_INSPECTOR macro, isn't it ? It looks app should do unnecessary job. I would suggest not to use ENABLE_INSPECTOR macro in public header as chromium port. Chromium port only uses macro in internal implementation. Any other comments ? 795261 6 179930 vivekg 2012-12-20 01:14:59 -0800 Comment on attachment 179930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179930&action=review > Source/WebKit/efl/ewk/ewk_contextmenu.h:112 > +#if defined ENABLE_INSPECTOR && ENABLE_INSPECTOR Wouldn't the use of #if ENABLE(INSPECTOR) do the same thing as above? I think its better to use the ENABLE(INSPECTOR) macro for consistency. 795266 7 gyuyoung.kim 2012-12-20 01:22:03 -0800 (In reply to comment #6) > (From update of attachment 179930 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179930&action=review > > > Source/WebKit/efl/ewk/ewk_contextmenu.h:112 > > +#if defined ENABLE_INSPECTOR && ENABLE_INSPECTOR > > Wouldn't the use of #if ENABLE(INSPECTOR) do the same thing as above? I think its better to use the ENABLE(INSPECTOR) macro for consistency. ENABLE(XXX) is defined to WTF/wtf/Platform.h. So, application which uses ewk_contextmenu.h should include the Platform.h to use ENABLE(XXX) macro. But, we don't install Platform.h file. We can't use ENABLE() in public header. Beside, as we already talked, to use macro in public header will make unneeded overhead when using public header. 796274 8 180512 seokju 2012-12-21 06:28:24 -0800 Created attachment 180512 Patch 796276 9 180512 seokju 2012-12-21 06:30:33 -0800 Comment on attachment 180512 Patch No #ifdefs in public header. I have removed them. Thank you for review :) 796281 10 180512 webkit.review.bot 2012-12-21 06:52:39 -0800 Comment on attachment 180512 Patch Clearing flags on attachment: 180512 Committed r138370: <http://trac.webkit.org/changeset/138370> 796282 11 webkit.review.bot 2012-12-21 06:52:43 -0800 All reviewed patches have been landed. Closing bug. 179930 2012-12-18 06:22:51 -0800 2012-12-21 06:28:16 -0800 Patch bug-105267-20121218232007.patch text/plain 5829 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggY2I1NmEwODMx ZmRhYjZmNWM3MTRmYjBkZTRjMGQ3Y2I3MDI5YTk4NS4uYzM0ZTYxNWEzYjc3ZWFlNjA0M2IzMTY0 ZjViMWI2MWUzZjNjMzNlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTEyLTE4ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBb RUZMXSBBZGQgZ3VhcmQgYXJvdW5kIENvbnRleHRNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNjcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIElOU1BF Q1RPUiBndWFyZCBmb3IgdXNpbmcgQ29udGV4dE1lbnVJdGVtVGFnSW5zcGVjdEVsZW1lbnQuCisK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Bc3NlcnRNYXRjaGluZ0VudW1zLmNwcDoKKyAgICAg ICAgKiBld2svZXdrX2NvbnRleHRtZW51Lmg6CisKIDIwMTItMTItMTYgIFNlb2tqdSBLd29uICA8 c2Vva2p1Lmt3b25AZ21haWwuY29tPgogCiAgICAgICAgIEZpeCB1bnVzZWQgcGFyYW1ldGVyIGNv bXBpbGUgd2FybmluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAxMDhlYmMxYTVlZTk2NzEwNzBiMTMzZGEyMDEz MmJkYTZmNDhhNzcxLi41Y2MyYjgwYmVlM2UzNGUyMjg5NmU5MWY5OTUxZDg2ZTBmZjQ0ZjkyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTItMTggIFNlb2tqdSBLd29uICA8c2Vv a2p1Lmt3b25AZ21haWwuY29tPgorCisgICAgICAgIFtFRkxdIEFkZCBndWFyZCBhcm91bmQgQ29u dGV4dE1lbnVJdGVtVGFnSW5zcGVjdEVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgSU5TUEVDVE9SIGd1YXJkIGZvciB1c2luZyBDb250 ZXh0TWVudUl0ZW1UYWdJbnNwZWN0RWxlbWVudC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv ZWZsL2V3a19jb250ZXh0X21lbnVfaXRlbS5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX2NvbnRleHRfbWVudV9pdGVtLmg6CisKIDIwMTItMTItMTcgIFNhbSBXZWluaWcgIDxz YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBUcnkgdG8gZml4IHRoZSBNYWMgYnVpbGQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Bc3NlcnRNYXRjaGluZ0Vu dW1zLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Fzc2VydE1hdGNoaW5n RW51bXMuY3BwCmluZGV4IDNmMjM2MDRjN2MxODY3YzdhYjRlYTU3OTFhZTczNTgwNmNiOTYwZTMu LjVkMjA2YTQzM2JiNDk5NTE0ZTg4YjJiMTMyOGY1MDIzZmJjNTM5NDEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Fzc2VydE1hdGNoaW5nRW51bXMuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Fzc2VydE1hdGNoaW5nRW51bXMu Y3BwCkBAIC0xNDYsNyArMTQ2LDkgQEAgQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tf Q09OVEVYVF9NRU5VX0lURU1fVEFHX0xFRlRfVE9fUklHSFQsIENvbnRleHRNZW4KIENPTVBJTEVf QVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19SSUdIVF9UT19M RUZULCBDb250ZXh0TWVudUl0ZW1UYWdSaWdodFRvTGVmdCk7CiBDT01QSUxFX0FTU0VSVF9NQVRD SElOR19FTlVNKEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfUERGU0lOR0xFX1BBR0VfU0NST0xM SU5HLCBDb250ZXh0TWVudUl0ZW1UYWdQREZTaW5nbGVQYWdlU2Nyb2xsaW5nKTsKIENPTVBJTEVf QVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19QREZGQUNJTkdf UEFHRVNfU0NST0xMSU5HLCBDb250ZXh0TWVudUl0ZW1UYWdQREZGYWNpbmdQYWdlc1Njcm9sbGlu Zyk7CisjaWYgRU5BQkxFKElOU1BFQ1RPUikKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0o RVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19JTlNQRUNUX0VMRU1FTlQsIENvbnRleHRNZW51SXRl bVRhZ0luc3BlY3RFbGVtZW50KTsKKyNlbmRpZgogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5V TShFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1RFWFRfRElSRUNUSU9OX01FTlUsIENvbnRleHRN ZW51SXRlbVRhZ1RleHREaXJlY3Rpb25NZW51KTsKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VO VU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19URVhUX0RJUkVDVElPTl9ERUZBVUxULCBDb250 ZXh0TWVudUl0ZW1UYWdUZXh0RGlyZWN0aW9uRGVmYXVsdCk7CiBDT01QSUxFX0FTU0VSVF9NQVRD SElOR19FTlVNKEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfVEVYVF9ESVJFQ1RJT05fTEVGVF9U T19SSUdIVCwgQ29udGV4dE1lbnVJdGVtVGFnVGV4dERpcmVjdGlvbkxlZnRUb1JpZ2h0KTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuaCBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuaAppbmRleCA0OWViYWQ5Mjk4YjhiYTU2 YTU4ZmVmODk2MTVhYzU5ZmNmMjViN2E0Li41M2EyNTI5MjM1NDI3MTYyYmZmODM1MzgwMjViNzIx OGExMzM0NDJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2NvbnRleHRt ZW51LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19jb250ZXh0bWVudS5oCkBAIC0x MDksNyArMTA5LDkgQEAgZW51bSBfRXdrX0NvbnRleHRfTWVudV9BY3Rpb24gewogICAgIEVXS19D T05URVhUX01FTlVfSVRFTV9UQUdfUklHSFRfVE9fTEVGVCwKICAgICBFV0tfQ09OVEVYVF9NRU5V X0lURU1fVEFHX1BERlNJTkdMRV9QQUdFX1NDUk9MTElORywKICAgICBFV0tfQ09OVEVYVF9NRU5V X0lURU1fVEFHX1BERkZBQ0lOR19QQUdFU19TQ1JPTExJTkcsCisjaWYgZGVmaW5lZCBFTkFCTEVf SU5TUEVDVE9SICYmIEVOQUJMRV9JTlNQRUNUT1IKICAgICBFV0tfQ09OVEVYVF9NRU5VX0lURU1f VEFHX0lOU1BFQ1RfRUxFTUVOVCwKKyNlbmRpZgogICAgIEVXS19DT05URVhUX01FTlVfSVRFTV9U QUdfVEVYVF9ESVJFQ1RJT05fTUVOVSwgLyoqPCB0ZXh0IGRpcmVjdGlvbiBzdWItbWVudSAqLwog ICAgIEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfVEVYVF9ESVJFQ1RJT05fREVGQVVMVCwKICAg ICBFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1RFWFRfRElSRUNUSU9OX0xFRlRfVE9fUklHSFQs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4 dF9tZW51X2l0ZW0uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Nv bnRleHRfbWVudV9pdGVtLmNwcAppbmRleCBkNTdkYmY2MmE3MDk1OGQ1MTM2N2FmZDA4YWY2OGZm OTM2OTdhZGY0Li4xZmY4NjUyOGJhYWYyMzk2YTIyMzlmMzZlZGRkMDdkNmE0MjdlNmI0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dF9tZW51 X2l0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250 ZXh0X21lbnVfaXRlbS5jcHAKQEAgLTIwNCw3ICsyMDQsOSBAQCBDT01QSUxFX0FTU0VSVF9NQVRD SElOR19FTlVNKEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfTEVGVF9UT19SSUdIVCwgV2ViQ29y ZTo6QwogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfQ09OVEVYVF9NRU5VX0lURU1f VEFHX1JJR0hUX1RPX0xFRlQsIFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbVRhZ1JpZ2h0VG9MZWZ0 KTsKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RB R19QREZTSU5HTEVfUEFHRV9TQ1JPTExJTkcsIFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbVRhZ1BE RlNpbmdsZVBhZ2VTY3JvbGxpbmcpOwogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tf Q09OVEVYVF9NRU5VX0lURU1fVEFHX1BERkZBQ0lOR19QQUdFU19TQ1JPTExJTkcsIFdlYkNvcmU6 OkNvbnRleHRNZW51SXRlbVRhZ1BERkZhY2luZ1BhZ2VzU2Nyb2xsaW5nKTsKKyNpZiBFTkFCTEUo SU5TUEVDVE9SKQogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfQ09OVEVYVF9NRU5V X0lURU1fVEFHX0lOU1BFQ1RfRUxFTUVOVCwgV2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtVGFnSW5z cGVjdEVsZW1lbnQpOworI2VuZGlmCiBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19D T05URVhUX01FTlVfSVRFTV9UQUdfVEVYVF9ESVJFQ1RJT05fTUVOVSwgV2ViQ29yZTo6Q29udGV4 dE1lbnVJdGVtVGFnVGV4dERpcmVjdGlvbk1lbnUpOwogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdf RU5VTShFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1RFWFRfRElSRUNUSU9OX0RFRkFVTFQsIFdl YkNvcmU6OkNvbnRleHRNZW51SXRlbVRhZ1RleHREaXJlY3Rpb25EZWZhdWx0KTsKIENPTVBJTEVf QVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19URVhUX0RJUkVD VElPTl9MRUZUX1RPX1JJR0hULCBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1UYWdUZXh0RGlyZWN0 aW9uTGVmdFRvUmlnaHQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX2NvbnRleHRfbWVudV9pdGVtLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfY29udGV4dF9tZW51X2l0ZW0uaAppbmRleCA5NjEyYTIxZjVjMTg5YWEyODAw ZWFiMjFkZTZlZmZmOWY1YWNkMDVmLi42NTMxZGU0ZmVmMzlkNzFkN2JhNjAxMDgwZmUwOTNjYzE4 ZDYyNmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf Y29udGV4dF9tZW51X2l0ZW0uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfY29udGV4dF9tZW51X2l0ZW0uaApAQCAtMTE1LDcgKzExNSw5IEBAIHR5cGVkZWYgZW51 bSB7CiAgICAgRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19SSUdIVF9UT19MRUZULAogICAgIEVX S19DT05URVhUX01FTlVfSVRFTV9UQUdfUERGU0lOR0xFX1BBR0VfU0NST0xMSU5HLAogICAgIEVX S19DT05URVhUX01FTlVfSVRFTV9UQUdfUERGRkFDSU5HX1BBR0VTX1NDUk9MTElORywKKyNpZiBk ZWZpbmVkIEVOQUJMRV9JTlNQRUNUT1IgJiYgRU5BQkxFX0lOU1BFQ1RPUgogICAgIEVXS19DT05U RVhUX01FTlVfSVRFTV9UQUdfSU5TUEVDVF9FTEVNRU5ULAorI2VuZGlmCiAgICAgRVdLX0NPTlRF WFRfTUVOVV9JVEVNX1RBR19URVhUX0RJUkVDVElPTl9NRU5VLCAvKio8IHRleHQgZGlyZWN0aW9u IHN1Yi1tZW51ICovCiAgICAgRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19URVhUX0RJUkVDVElP Tl9ERUZBVUxULAogICAgIEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfVEVYVF9ESVJFQ1RJT05f TEVGVF9UT19SSUdIVCwK 180512 2012-12-21 06:28:24 -0800 2012-12-21 06:52:39 -0800 Patch bug-105267-20121221232539.patch text/plain 4193 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZGNkZmJjMzI3 NjcwNWI4ZThmNDQyMzIxMDkxOTMyMjIzNzE3YjIyNS4uYzkyZWZhOTc5MTEwMjUzYzRlNDJlMjFl YWUxMDhhOWRhZDY0NmZjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEy LTEyLTIxICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBb RUZMXSBBZGQgZ3VhcmQgYXJvdW5kIENvbnRleHRNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNjcKKwor ICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgTmVlZCBJTlNQRUNU T1IgZ3VhcmQgZm9yIHVzaW5nIENvbnRleHRNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50LgorCisg ICAgICAgICogV2ViQ29yZVN1cHBvcnQvQXNzZXJ0TWF0Y2hpbmdFbnVtcy5jcHA6CisKIDIwMTIt MTItMjEgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtF RkxdW1dLMV0gT2Jzb2xldGUgYSBjYXNlIGluIHRlc3RfZXdrX2ZyYW1lIGFwaSB0ZXN0IHRvIG5v dCBtYWtlIGJvdCBzaWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzkzYzdiODc1MjQ3MTUwM2NlMGZmNWI1NWJk YzUyYTYzYmVmMDc3Yy4uMDcyYzFlMzQ5MjM5NmIyM2FjNzgxYjM3NDA5Yzc3OTVhYTM3YzE0MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEyLTIxICBTZW9ranUgS3dvbiAgPHNl b2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbRUZMXSBBZGQgZ3VhcmQgYXJvdW5kIENv bnRleHRNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNjcKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9z dWtlIE5pd2EuCisKKyAgICAgICAgTmVlZCBJTlNQRUNUT1IgZ3VhcmQgZm9yIHVzaW5nIENvbnRl eHRNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX2NvbnRleHRfbWVudV9pdGVtLmNwcDoKKwogMjAxMi0xMi0yMSAgTWlraGFpbCBQb3pk bnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAgICBbV0syXSBU aWxlZEJhY2tpbmdTdG9yZTogU2Nyb2xsIHBvc2l0aW9uIGlzIG5vdCByZXNldCB3aGVuIG5ldyBw YWdlIGlzIGxvYWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBv cnQvQXNzZXJ0TWF0Y2hpbmdFbnVtcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3Vw cG9ydC9Bc3NlcnRNYXRjaGluZ0VudW1zLmNwcAppbmRleCAzZjIzNjA0YzdjMTg2N2M3YWI0ZWE1 NzkxYWU3MzU4MDZjYjk2MGUzLi41ZDIwNmE0MzNiYjQ5OTUxNGU4OGIyYjEzMjhmNTAyM2ZiYzUz OTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Bc3NlcnRN YXRjaGluZ0VudW1zLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9B c3NlcnRNYXRjaGluZ0VudW1zLmNwcApAQCAtMTQ2LDcgKzE0Niw5IEBAIENPTVBJTEVfQVNTRVJU X01BVENISU5HX0VOVU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19MRUZUX1RPX1JJR0hULCBD b250ZXh0TWVuCiBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19DT05URVhUX01FTlVf SVRFTV9UQUdfUklHSFRfVE9fTEVGVCwgQ29udGV4dE1lbnVJdGVtVGFnUmlnaHRUb0xlZnQpOwog Q09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1BE RlNJTkdMRV9QQUdFX1NDUk9MTElORywgQ29udGV4dE1lbnVJdGVtVGFnUERGU2luZ2xlUGFnZVNj cm9sbGluZyk7CiBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19DT05URVhUX01FTlVf SVRFTV9UQUdfUERGRkFDSU5HX1BBR0VTX1NDUk9MTElORywgQ29udGV4dE1lbnVJdGVtVGFnUERG RmFjaW5nUGFnZXNTY3JvbGxpbmcpOworI2lmIEVOQUJMRShJTlNQRUNUT1IpCiBDT01QSUxFX0FT U0VSVF9NQVRDSElOR19FTlVNKEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfSU5TUEVDVF9FTEVN RU5ULCBDb250ZXh0TWVudUl0ZW1UYWdJbnNwZWN0RWxlbWVudCk7CisjZW5kaWYKIENPTVBJTEVf QVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVNX1RBR19URVhUX0RJUkVD VElPTl9NRU5VLCBDb250ZXh0TWVudUl0ZW1UYWdUZXh0RGlyZWN0aW9uTWVudSk7CiBDT01QSUxF X0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfVEVYVF9ESVJF Q1RJT05fREVGQVVMVCwgQ29udGV4dE1lbnVJdGVtVGFnVGV4dERpcmVjdGlvbkRlZmF1bHQpOwog Q09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1RF WFRfRElSRUNUSU9OX0xFRlRfVE9fUklHSFQsIENvbnRleHRNZW51SXRlbVRhZ1RleHREaXJlY3Rp b25MZWZ0VG9SaWdodCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfY29udGV4dF9tZW51X2l0ZW0uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX2NvbnRleHRfbWVudV9pdGVtLmNwcAppbmRleCBkNTdkYmY2MmE3MDk1OGQ1 MTM2N2FmZDA4YWY2OGZmOTM2OTdhZGY0Li4xZmY4NjUyOGJhYWYyMzk2YTIyMzlmMzZlZGRkMDdk NmE0MjdlNmI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfY29udGV4dF9tZW51X2l0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a19jb250ZXh0X21lbnVfaXRlbS5jcHAKQEAgLTIwNCw3ICsyMDQsOSBAQCBDT01Q SUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfTEVGVF9U T19SSUdIVCwgV2ViQ29yZTo6QwogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfQ09O VEVYVF9NRU5VX0lURU1fVEFHX1JJR0hUX1RPX0xFRlQsIFdlYkNvcmU6OkNvbnRleHRNZW51SXRl bVRhZ1JpZ2h0VG9MZWZ0KTsKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0NPTlRF WFRfTUVOVV9JVEVNX1RBR19QREZTSU5HTEVfUEFHRV9TQ1JPTExJTkcsIFdlYkNvcmU6OkNvbnRl eHRNZW51SXRlbVRhZ1BERlNpbmdsZVBhZ2VTY3JvbGxpbmcpOwogQ09NUElMRV9BU1NFUlRfTUFU Q0hJTkdfRU5VTShFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1BERkZBQ0lOR19QQUdFU19TQ1JP TExJTkcsIFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbVRhZ1BERkZhY2luZ1BhZ2VzU2Nyb2xsaW5n KTsKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShF V0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX0lOU1BFQ1RfRUxFTUVOVCwgV2ViQ29yZTo6Q29udGV4 dE1lbnVJdGVtVGFnSW5zcGVjdEVsZW1lbnQpOworI2VuZGlmCiBDT01QSUxFX0FTU0VSVF9NQVRD SElOR19FTlVNKEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfVEVYVF9ESVJFQ1RJT05fTUVOVSwg V2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtVGFnVGV4dERpcmVjdGlvbk1lbnUpOwogQ09NUElMRV9B U1NFUlRfTUFUQ0hJTkdfRU5VTShFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1RFWFRfRElSRUNU SU9OX0RFRkFVTFQsIFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbVRhZ1RleHREaXJlY3Rpb25EZWZh dWx0KTsKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0NPTlRFWFRfTUVOVV9JVEVN X1RBR19URVhUX0RJUkVDVElPTl9MRUZUX1RPX1JJR0hULCBXZWJDb3JlOjpDb250ZXh0TWVudUl0 ZW1UYWdUZXh0RGlyZWN0aW9uTGVmdFRvUmlnaHQpOwo=