105254 2012-12-17 22:04:55 -0800 [BlackBerry] Add support for setMuted() for media 2012-12-18 03:58:32 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mfeil mfeil eric.carlson feature-media-reviews mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 793356 0 mfeil 2012-12-17 22:04:55 -0800 Simply pass the API call through to the platform layer. Covered by existing tests. 793365 1 179879 mfeil 2012-12-17 22:20:54 -0800 Created attachment 179879 Patch 793366 2 mfeil 2012-12-17 22:23:16 -0800 There are also some minor changes in the patch to satisfy the style checker. 793525 3 179879 webkit.review.bot 2012-12-18 03:58:28 -0800 Comment on attachment 179879 Patch Clearing flags on attachment: 179879 Committed r138006: <http://trac.webkit.org/changeset/138006> 793526 4 webkit.review.bot 2012-12-18 03:58:32 -0800 All reviewed patches have been landed. Closing bug. 179879 2012-12-17 22:20:54 -0800 2012-12-18 03:58:28 -0800 Patch bug-105254-20121218011811.patch text/plain 5462 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY2YWI1MDJkZTdmY2Iy YzhiM2Q1ZTA3MDliY2I4NzUzN2U5MjRlZi4uMmEyYzE3ZDIxOTRiZjAxOWZlNTJmNTk4Yjc0NjBl OTZiNGEyYTc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTE3ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEFkZCBzdXBwb3J0 IGZvciBzZXRNdXRlZCgpIGZvciBtZWRpYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2ltcGx5IHBhc3MgdGhlIEFQSSBjYWxsIHRocm91Z2ggdG8gdGhl IHBsYXRmb3JtIGxheWVyLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0 ZUJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpz ZXRNdXRlZCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxh eWVyUHJpdmF0ZTo6bXV0ZWQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVy cnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5oOgorICAgICAgICAoTWVkaWFQbGF5ZXJQ cml2YXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6c3VwcG9ydHNN dXRpbmcpOgorCiAyMDEyLTEyLTE3ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgQWRkIEFTU0VSVGlvbnMgdG8gZW5zdXJlIHRoYXQgQ1NTUHJv cGVydHlzIHRoYXQgYXJlIHZhcmlhYmxlcyBvbmx5IGV2ZXIgcmVmZXIgdG8gQ1NTVmFsdWVzIHRo YXQgYXJlIHZhcmlhYmxlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0 ZUJsYWNrQmVycnkuY3BwCmluZGV4IDI2ZjU3N2I2ZjA1NjU0MzY1ZmZmZTgxNjliYWM3M2IxMTI5 MTMwMzQuLjlkZGViZWJmYzdlNjI2NjZhZmNiZjUxYTZkMzJkMTYyZDRjY2E0MTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5 ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcApAQCAtMTMw LDkgKzEzMCw4IEBAIE1lZGlhUGxheWVyUHJpdmF0ZTo6fk1lZGlhUGxheWVyUHJpdmF0ZSgpCiAg ICAgaWYgKG1faXNBdXRoZW50aWNhdGlvbkNoYWxsZW5naW5nKQogICAgICAgICBBdXRoZW50aWNh dGlvbkNoYWxsZW5nZU1hbmFnZXI6Omluc3RhbmNlKCktPmNhbmNlbEF1dGhlbnRpY2F0aW9uQ2hh bGxlbmdlKHRoaXMpOwogCi0gICAgaWYgKGlzRnVsbHNjcmVlbigpKSB7CisgICAgaWYgKGlzRnVs bHNjcmVlbigpKQogICAgICAgICBtX3dlYkNvcmVQbGF5ZXItPm1lZGlhUGxheWVyQ2xpZW50KCkt Pm1lZGlhUGxheWVyRXhpdEZ1bGxzY3JlZW4oKTsKLSAgICB9CiAjaWYgVVNFKEFDQ0VMRVJBVEVE X0NPTVBPU0lUSU5HKQogICAgIC8vIFJlbW92ZSBtZWRpYSBwbGF5ZXIgZnJvbSBwbGF0Zm9ybSBs YXllci4KICAgICBpZiAobV9wbGF0Zm9ybUxheWVyKQpAQCAtMzE1LDYgKzMxNCwxOSBAQCB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0Vm9sdW1lKGZsb2F0IHZvbHVtZSkKICAgICAgICAgbV9w bGF0Zm9ybVBsYXllci0+c2V0Vm9sdW1lKHZvbHVtZSk7CiB9CiAKK3ZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlOjpzZXRNdXRlZChib29sIG11dGVkKQoreworICAgIGlmIChtX3BsYXRmb3JtUGxheWVy KQorICAgICAgICBtX3BsYXRmb3JtUGxheWVyLT5zZXRNdXRlZChtdXRlZCk7Cit9CisKK2Jvb2wg TWVkaWFQbGF5ZXJQcml2YXRlOjptdXRlZCgpIGNvbnN0Cit7CisgICAgaWYgKG1fcGxhdGZvcm1Q bGF5ZXIpCisgICAgICAgIHJldHVybiBtX3BsYXRmb3JtUGxheWVyLT5tdXRlZCgpOworICAgIHJl dHVybiBmYWxzZTsKK30KKwogTWVkaWFQbGF5ZXI6Ok5ldHdvcmtTdGF0ZSBNZWRpYVBsYXllclBy aXZhdGU6Om5ldHdvcmtTdGF0ZSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fbmV0d29ya1N0YXRl OwpAQCAtNzE5LDkgKzczMSw5IEBAIHN0YXRpYyBQcm90ZWN0aW9uU3BhY2UgZ2VuZXJhdGVQcm90 ZWN0aW9uU3BhY2VGcm9tTU1SQXV0aENoYWxsZW5nZShjb25zdCBNTVJBdXRoCiAgICAgQVNTRVJU KHVybC5pc1ZhbGlkKCkpOwogCiAgICAgcmV0dXJuIFByb3RlY3Rpb25TcGFjZSh1cmwuaG9zdCgp LCB1cmwucG9ydCgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8UHJv dGVjdGlvblNwYWNlU2VydmVyVHlwZT4oYXV0aENoYWxsZW5nZS5zZXJ2ZXJUeXBlKCkpLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgYXV0aENoYWxsZW5nZS5yZWFsbSgpLmNfc3RyKCksCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxQcm90ZWN0aW9uU3BhY2VBdXRo ZW50aWNhdGlvblNjaGVtZT4oYXV0aENoYWxsZW5nZS5hdXRoU2NoZW1lKCkpKTsKKyAgICAgICAg c3RhdGljX2Nhc3Q8UHJvdGVjdGlvblNwYWNlU2VydmVyVHlwZT4oYXV0aENoYWxsZW5nZS5zZXJ2 ZXJUeXBlKCkpLAorICAgICAgICBhdXRoQ2hhbGxlbmdlLnJlYWxtKCkuY19zdHIoKSwKKyAgICAg ICAgc3RhdGljX2Nhc3Q8UHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWU+KGF1dGhD aGFsbGVuZ2UuYXV0aFNjaGVtZSgpKSk7CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpv bkF1dGhlbnRpY2F0aW9uTmVlZGVkKE1NUkF1dGhDaGFsbGVuZ2UmIGF1dGhDaGFsbGVuZ2UpCkBA IC03NTMsOCArNzY1LDggQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6Om5vdGlmeUNoYWxsZW5n ZVJlc3VsdChjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFByb3RlY3Rpb24KICAgICAgICAgcmV0dXJu OwogCiAgICAgbV9wbGF0Zm9ybVBsYXllci0+cmVsb2FkV2l0aENyZWRlbnRpYWwoY3JlZGVudGlh bC51c2VyKCkudXRmOChTdHJpbmc6OlN0cmljdENvbnZlcnNpb24pLmRhdGEoKSwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcmVkZW50aWFsLnBhc3N3b3JkKCkudXRm OChTdHJpbmc6OlN0cmljdENvbnZlcnNpb24pLmRhdGEoKSwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxNTVJBdXRoQ2hhbGxlbmdlOjpDcmVkZW50 aWFsUGVyc2lzdGVuY2U+KGNyZWRlbnRpYWwucGVyc2lzdGVuY2UoKSkpOworICAgICAgICBjcmVk ZW50aWFsLnBhc3N3b3JkKCkudXRmOChTdHJpbmc6OlN0cmljdENvbnZlcnNpb24pLmRhdGEoKSwK KyAgICAgICAgc3RhdGljX2Nhc3Q8TU1SQXV0aENoYWxsZW5nZTo6Q3JlZGVudGlhbFBlcnNpc3Rl bmNlPihjcmVkZW50aWFsLnBlcnNpc3RlbmNlKCkpKTsKIH0KIAogdm9pZCBNZWRpYVBsYXllclBy aXZhdGU6Om9uQXV0aGVudGljYXRpb25BY2NlcHRlZChjb25zdCBNTVJBdXRoQ2hhbGxlbmdlJiBh dXRoQ2hhbGxlbmdlKSBjb25zdApAQCAtOTMzLDkgKzk0NSw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlOjpzZXRCdWZmZXJpbmcoYm9vbCBidWZmZXJpbmcpCiAgICAgfQogfQogCi1zdGF0aWMg dW5zaWduZWQgaW50IGFsbG9jYXRlVGV4dHVyZUlkKCkKK3N0YXRpYyB1bnNpZ25lZCBhbGxvY2F0 ZVRleHR1cmVJZCgpCiB7Ci0gICAgdW5zaWduZWQgaW50IHRleGlkOworICAgIHVuc2lnbmVkIHRl eGlkOwogICAgIGdsR2VuVGV4dHVyZXMoMSwgJnRleGlkKTsKICAgICBnbEJpbmRUZXh0dXJlKEdM X1RFWFRVUkVfMkQsIHRleGlkKTsKICAgICAvLyBEbyBiYXNpYyBsaW5lYXIgZmlsdGVyaW5nIG9u IHJlc2l6ZS4KQEAgLTk1OCw3ICs5NzAsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6ZHJh d0J1ZmZlcmluZ0FuaW1hdGlvbihjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cgogICAg ICAgICByZW5kZXJNYXRyaXgucm90YXRlKHRpbWUudHZfbnNlYyAvIDEwMDAwMDAwMDAuMCAqIDM2 MC4wKTsKIAogICAgICAgICBzdGF0aWMgYm9vbCBpbml0aWFsaXplZCA9IGZhbHNlOwotICAgICAg ICBzdGF0aWMgdW5zaWduZWQgaW50IHRleElkID0gYWxsb2NhdGVUZXh0dXJlSWQoKTsKKyAgICAg ICAgc3RhdGljIHVuc2lnbmVkIHRleElkID0gYWxsb2NhdGVUZXh0dXJlSWQoKTsKICAgICAgICAg Z2xCaW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCB0ZXhJZCk7CiAgICAgICAgIGlmICghaW5pdGlh bGl6ZWQpIHsKICAgICAgICAgICAgIGluaXRpYWxpemVkID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2 YXRlQmxhY2tCZXJyeS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmgKaW5kZXggMzAzYzU3YTUxZTQ1Yjlk ZTNhODQyY2VjMTBkMzFjZGRkMzY3YzA2MC4uMGQzZDliZWViMmE2NWNlMzU4NDQ2MTRjMzQ0ZWEy MDczNGQ4NmQ4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFj a0JlcnJ5LmgKQEAgLTc5LDggKzc5LDExIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0 UmF0ZShmbG9hdCk7CiAKICAgICB2aXJ0dWFsIGJvb2wgcGF1c2VkKCkgY29uc3Q7CisgICAgdmly dHVhbCBib29sIG11dGVkKCkgY29uc3Q7CisgICAgdmlydHVhbCBib29sIHN1cHBvcnRzTXV0aW5n KCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogCiAgICAgdmlydHVhbCB2b2lkIHNldFZvbHVtZShm bG9hdCk7CisgICAgdmlydHVhbCB2b2lkIHNldE11dGVkKGJvb2wpOwogCiAgICAgdmlydHVhbCBN ZWRpYVBsYXllcjo6TmV0d29ya1N0YXRlIG5ldHdvcmtTdGF0ZSgpIGNvbnN0OwogICAgIHZpcnR1 YWwgTWVkaWFQbGF5ZXI6OlJlYWR5U3RhdGUgcmVhZHlTdGF0ZSgpIGNvbnN0Owo=