105253 2012-12-17 22:00:47 -0800 2 clampTo unit tests are failing 2012-12-19 09:46:56 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix eae noel.gordon webkit.review.bot oldest_to_newest 793352 0 jchaffraix 2012-12-17 22:00:47 -0800 clampToUnsigned is failing on 2 bots and clampToFloat is failing only on Apple Win: http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/30528/steps/run-api-tests/logs/stdio http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/31009/steps/run-api-tests/logs/stdio Here are the failures: Note: Google Test filter = WTF.clampToIntegerFloat [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WTF [ RUN ] WTF.clampToIntegerFloat ..\Tests\WTF\MathExtras.cpp(103): error: Value of: maxInt Actual: 2147483648 Expected: clampToInteger(maxInt) Which is: 2147483647 ..\Tests\WTF\MathExtras.cpp(106): error: Value of: maxInt Actual: 2147483648 Expected: clampToInteger(overflowInt) Which is: 2147483647 [ FAILED ] WTF.clampToIntegerFloat (0 ms) [----------] 1 test from WTF (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] WTF.clampToIntegerFloat 1 FAILED TEST Note: Google Test filter = WTF.clampToUnsigned [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WTF [ RUN ] WTF.clampToUnsigned ..\Tests\WTF\MathExtras.cpp(153): error: Value of: maxUnsigned Actual: 4294967295 Expected: clampTo<unsigned>(overflowUnsigned) Which is: 0 [ FAILED ] WTF.clampToUnsigned (0 ms) [----------] 1 test from WTF (0 ms total) 793359 1 jchaffraix 2012-12-17 22:12:11 -0800 Disabled the test in http://trac.webkit.org/changeset/137986. 793839 2 eae 2012-12-18 11:03:17 -0800 The windows unsigned failure is due to sizeof(unsigned long) == sizeof(unsigned) on windows 64bit (as it used the LLP64 memory model). Adding a sizeof check as you have for clampToIntLong should do the trick. The chromium mac failure seems to be due to float imprecision, EXPECT_NEAR with a tolerance of 1 should do the trick. 794202 3 jchaffraix 2012-12-18 17:11:24 -0800 (In reply to comment #2) > The windows unsigned failure is due to sizeof(unsigned long) == sizeof(unsigned) on windows 64bit (as it used the LLP64 memory model). > > Adding a sizeof check as you have for clampToIntLong should do the trick. True, but clampToUnsigned is testing the same case as clampToUnsignedLong as we can't test overflowing without a type that is wider than unsigned. This makes me lean towards just removing this test (FWIW we don't have a clampToInt for this very reason). > The chromium mac failure seems to be due to float imprecision, EXPECT_NEAR with a tolerance of 1 should do the trick. Good catch, that should fix the issue. 794231 4 180069 jchaffraix 2012-12-18 18:03:22 -0800 Created attachment 180069 Proposed fix. 794754 5 180069 jchaffraix 2012-12-19 09:43:30 -0800 Comment on attachment 180069 Proposed fix. Thanks, Emil! 794759 6 180069 webkit.review.bot 2012-12-19 09:46:52 -0800 Comment on attachment 180069 Proposed fix. Clearing flags on attachment: 180069 Committed r138176: <http://trac.webkit.org/changeset/138176> 794760 7 webkit.review.bot 2012-12-19 09:46:56 -0800 All reviewed patches have been landed. Closing bug. 180069 2012-12-18 18:03:22 -0800 2012-12-19 09:46:52 -0800 Proposed fix. bug-105253-20121218180039.patch text/plain 2677 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MDkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjA4ZGIxNDBhZDgyN2NkY2JjZDNkOGNjMGQwMTc0NGZj MzVhNWNjYi4uOTc1MTRlMTg1MTk0YTRiZDU5OWY5Mjk4M2Y1Mzk4ODhhN2M1NWNjMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEyLTE4ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3Jn PgorCisgICAgICAgIDIgY2xhbXBUbyB1bml0IHRlc3RzIGFyZSBmYWlsaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIGNsYW1wVG9VbnNp Z25lZCBhcyBpdCB3YXMgYWN0dWFsbHkgdGVzdGluZyBleGFjdGx5IHdoYXQKKyAgICAgICAgY2xh bXBUb1Vuc2lnbmVkTG9uZyB3YXMgZG9pbmcuIEFsc28gbWFkZSBjbGFtcFRvSW50RmxvYXQgbW9y ZSByb2J1c3QKKyAgICAgICAgdG8gcHJlY2lzaW9uIGxvc3MgKGZpeCBzdWdnZXN0ZWQgYnkgRW1p bCkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NYXRoRXh0cmFzLmNwcDoK KwogMjAxMi0xMi0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBEaXNhYmxlIHRoZSBTaW1wbGlmeU1hcmt1cCBBUEkgdGVzdCwgd2ljaCBhc3NlcnRz IGluIGRlYnVnIGJ1aWxkcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL01hdGhFeHRyYXMuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4 dHJhcy5jcHAKaW5kZXggYTMwZTViMjNmMmI3ODkwNWY0ZWQxZDQ1MDZhYjYzY2M3N2UxNzIwZS4u N2NiYjI5NzY2MjNmZTk3YjU1ZWM4YzczMmI0ODhmZjI0YTFhNmZlYSAxMDA2NDQKLS0tIGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHAKKysrIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHAKQEAgLTg3LDggKzg3LDcgQEAgVEVT VChXVEYsIGNsYW1wVG9JbnRMb25nTG9uZykKICAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQ+KHVu ZGVyZmxvd0ludCksIG1pbkludCk7CiB9CiAKLS8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDUyNTMKLVRFU1QoV1RGLCBESVNBQkxFRF9jbGFtcFRvSW50ZWdlckZs b2F0KQorVEVTVChXVEYsIGNsYW1wVG9JbnRlZ2VyRmxvYXQpCiB7CiAgICAgLy8gVGhpcyB0ZXN0 IGlzIGluYWNjdXJhdGUgYXMgZmxvYXRzIHdpbGwgcm91bmQgdGhlIG1pbiAvIG1heCBpbnRlZ2Vy CiAgICAgLy8gZHVlIHRvIHRoZSBuYXJyb3cgbWFudGlzc2EuIEhvd2V2ZXIgaXQgd2lsbCBwcm9w ZXJseSBjaGVja3Mgd2l0aGluCkBAIC0xMDEsMTAgKzEwMCwxMSBAQCBURVNUKFdURiwgRElTQUJM RURfY2xhbXBUb0ludGVnZXJGbG9hdCkKICAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dJbnQsIG1heElu dCk7CiAgICAgRVhQRUNUX0xUKHVuZGVyZmxvd0ludCwgbWluSW50KTsKIAotICAgIEVYUEVDVF9F UShjbGFtcFRvSW50ZWdlcihtYXhJbnQpLCBtYXhJbnQpOworICAgIC8vIElmIG1heEludCA9PSAy XjMxIC0gMSAoaWUgb24gSTMyIGFyY2hpdGVjdHVyZSksIHRoZSBjbG9zZXN0IGZsb2F0IHVzZWQg dG8gcmVwcmVzZW50IGl0IGlzIDJeMzEuCisgICAgRVhQRUNUX05FQVIoY2xhbXBUb0ludGVnZXIo bWF4SW50KSwgbWF4SW50LCAxKTsKICAgICBFWFBFQ1RfRVEoY2xhbXBUb0ludGVnZXIobWluSW50 KSwgbWluSW50KTsKIAotICAgIEVYUEVDVF9FUShjbGFtcFRvSW50ZWdlcihvdmVyZmxvd0ludCks IG1heEludCk7CisgICAgRVhQRUNUX05FQVIoY2xhbXBUb0ludGVnZXIob3ZlcmZsb3dJbnQpLCBt YXhJbnQsIDEpOwogICAgIEVYUEVDVF9FUShjbGFtcFRvSW50ZWdlcih1bmRlcmZsb3dJbnQpLCBt aW5JbnQpOwogfQogCkBAIC0xNDUsMTcgKzE0NSw2IEBAIFRFU1QoV1RGLCBjbGFtcFRvRmxvYXQp CiAgICAgRVhQRUNUX0VRKGNsYW1wVG9GbG9hdCgtc3RkOjpudW1lcmljX2xpbWl0czxmbG9hdD46 OmluZmluaXR5KCkpLCBtaW5GbG9hdCk7CiB9CiAKLS8vIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDUyNTMKLVRFU1QoV1RGLCBESVNBQkxFRF9jbGFtcFRvVW5zaWdu ZWQpCi17Ci0gICAgdW5zaWduZWQgbG9uZyBtYXhVbnNpZ25lZCA9IHN0ZDo6bnVtZXJpY19saW1p dHM8dW5zaWduZWQ+OjptYXgoKTsKLSAgICB1bnNpZ25lZCBsb25nIG92ZXJmbG93VW5zaWduZWQg PSBtYXhVbnNpZ25lZCArIDE7Ci0gICAgRVhQRUNUX0VRKGNsYW1wVG88dW5zaWduZWQ+KG1heFVu c2lnbmVkKSwgbWF4VW5zaWduZWQpOwotCi0gICAgRVhQRUNUX0VRKGNsYW1wVG88dW5zaWduZWQ+ KG92ZXJmbG93VW5zaWduZWQpLCBtYXhVbnNpZ25lZCk7Ci0gICAgRVhQRUNUX0VRKGNsYW1wVG88 dW5zaWduZWQ+KC0xKSwgMHUpOwotfQotCiBURVNUKFdURiwgY2xhbXBUb1Vuc2lnbmVkTG9uZykK IHsKICAgICBpZiAoc2l6ZW9mKHVuc2lnbmVkIGxvbmcpID09IHNpemVvZih1bnNpZ25lZCkpCg==