105247 2012-12-17 20:53:06 -0800 Chrome Android java output is too verbose 2012-12-18 13:28:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yfriedman yfriedman eric peter tony webkit.review.bot oldest_to_newest 793321 0 yfriedman 2012-12-17 20:53:06 -0800 Chrome Android java output is too verbose 793322 1 179873 yfriedman 2012-12-17 20:53:47 -0800 Created attachment 179873 Patch 793511 2 179873 peter 2012-12-18 03:26:26 -0800 Comment on attachment 179873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179873&action=review Seems good to me, thanks Yaron. Please wait for Eric, Tony or someone else to do a formal review. > Source/WebKit/chromium/ChangeLog:3 > + Chrome Android java output is too verbose nit for next time: Since this only touches Chromium files, we generally prefix the title with "[Chromium]". 793819 3 179873 tony 2012-12-18 10:46:49 -0800 Comment on attachment 179873 Patch Seems fine. In the long run, you may want to put common command line flags into a variable and use that instead of having to duplicate the flags. Another way to do this would be to make a .gypi for the action. See build/grit_action.gypi for an example of this. 793821 4 yfriedman 2012-12-18 10:48:04 -0800 There's actually a lot of shared infra on the chromium side (e.g. we have build/java_apk.gypi and testing/android/native_test.gyp). It wasn't clear to me whether we could use those in webkit. 793822 5 179873 webkit.review.bot 2012-12-18 10:48:43 -0800 Comment on attachment 179873 Patch Rejecting attachment 179873 from commit-queue. yfriedman@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 793825 6 179873 peter 2012-12-18 10:50:26 -0800 Comment on attachment 179873 Patch I'll look into that. 793848 7 179873 webkit.review.bot 2012-12-18 11:13:33 -0800 Comment on attachment 179873 Patch Clearing flags on attachment: 179873 Committed r138044: <http://trac.webkit.org/changeset/138044> 793849 8 webkit.review.bot 2012-12-18 11:13:36 -0800 All reviewed patches have been landed. Closing bug. 793873 9 179873 eric 2012-12-18 11:30:29 -0800 Comment on attachment 179873 Patch Fantastic! Thank you. 793990 10 tony 2012-12-18 13:28:17 -0800 (In reply to comment #4) > There's actually a lot of shared infra on the chromium side (e.g. we have build/java_apk.gypi and testing/android/native_test.gyp). It wasn't clear to me whether we could use those in webkit. You can use stuff on the chromium side, but it's normally frowned upon since it's annoying to make a change in chromium and learn a day later that it breaks something in WebKit. Instead, what you could do is make a .gypi file in src/webkit/support that includes build/java_apk.gypi. src/webkit/support is the API directory for things in WebKit that depend on chromium. That way, if someone needs to change build/java_apk.gypi, it's possible to provide backwards compat for WebKit dependencies in src/webkit/support. This might be too tricky. The other option would be to just fork the build/java_apk.gypi file into WebKit. 179873 2012-12-17 20:53:47 -0800 2012-12-18 11:30:29 -0800 Patch bug-105247-20121217205104.patch text/plain 3753 yfriedman U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDllMWU2YmRkNTk1OTMxZTJjMjNhNTA3ZGEzM2FjMTYwN2I5Mjk0OTguLmQwOWI4NzM2YWQyODUw MmJlMDViNzMyZTcwZDJkMWYxOWViYjZhY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMTItMTcgIFlhcm9uIEZyaWVkbWFuICA8eWZyaWVkbWFuQGNo cm9taXVtLm9yZz4KKworICAgICAgICBDaHJvbWUgQW5kcm9pZCBqYXZhIG91dHB1dCBpcyB0b28g dmVyYm9zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA1MjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UGFzcyAtcXVpZXQgdG8gYW50IHRvIHN1cHByZXNzIGV4dHJhbmVvdXMgb3V0cHV0LgorCisgICAg ICAgICogV2ViS2l0VW5pdFRlc3RzLmd5cDoKKwogMjAxMi0xMi0xNyAgTGV2aSBXZWludHJhdWIg IDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHRyYWNraW5n IGhpdCB0ZXN0IHJlY3RhbmdsZXMgdG8gZW5hYmxlIGZhc3QgZXZlbnQgcmVqZWN0aW9uIGluIHRo ZSBjb21wb3NpdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVu aXRUZXN0cy5neXAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAK aW5kZXggNjkxY2I1YzY1MDI2ZjlkODQ3NzM4MmZjMmYzNmI0MzRkY2NkYTc4Zi4uYjRhZjRkMjg5 Yzg5MzZkYzc4NjQ3OTY4MTIxYzNmMzEwNmIzYjUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vV2ViS2l0VW5pdFRlc3RzLmd5cApAQCAtMTg3LDYgKzE4Nyw4IEBACiAgICAgICAgICAgICAg ICAgICAgICAgICAnPChQUk9EVUNUX0RJUikvd2Via2l0X3VuaXRfdGVzdHNfYXBrJywKICAgICAg ICAgICAgICAgICAgICAgICAgICctLXN0cmlwLWJpbmFyeT08KGFuZHJvaWRfc3RyaXApJywKICAg ICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKKyAgICAgICAgICAgICAgICAgICAg ICAgICctcXVpZXQnLAorICAgICAgICAgICAgICAgICAgICAgICAgJy0tYW50LWFyZ3MnLAogICAg ICAgICAgICAgICAgICAgICAgICAgJy1EQU5EUk9JRF9TREs9PChhbmRyb2lkX3NkayknLAogICAg ICAgICAgICAgICAgICAgICAgICAgJy0tYW50LWFyZ3MnLAogICAgICAgICAgICAgICAgICAgICAg ICAgJy1EQU5EUk9JRF9TREtfUk9PVD08KGFuZHJvaWRfc2RrX3Jvb3QpJywKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzYzczMjNiMzQwZTY3NTJm OTUwNDkzMTk5MzUwMDg3OTlmNGRmNjBmLi5iZDI5NzYzOTk5MTU5NDRhZjkxZTM3N2E5ZTI2ZDMy MTgzMzZiNmU3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTItMTcgIFlhcm9uIEZyaWVkbWFuICA8eWZyaWVk bWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaHJvbWUgQW5kcm9pZCBqYXZhIG91dHB1dCBp cyB0b28gdmVyYm9zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA1MjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUGFzcyAtcXVpZXQgdG8gYW50IHRvIHN1cHByZXNzIGV4dHJhbmVvdXMgb3V0cHV0Lgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJU cmVlLmd5cDoKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RX ZWJLaXRBUEkuZ3lwOgorCiAyMDEyLTEyLTE3ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIGJ1aWxkLXdlYmtpdDogcmVuYW1lIC0tdGVtcGxhdGUtdGFnIHRvIC0t dGVtcGxhdGUtZWxlbWVudCB0byBtYXRjaCBFTkFCTEUgI2RlZmluZSBuYW1lCmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUu Z3lwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJU cmVlLmd5cAppbmRleCBjYzgzMzMyMDk5ODE0NzNmMzk2YjdhNzIzMjRlZjEwMDNjYjNlOWYxLi5j ZGEzZjJhZGFmMmJiYTVlM2M5OWEwMWQyMTUyOGRkNGU3NTYxODdkIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCisr KyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJl ZS5neXAKQEAgLTUxMCw2ICs1MTAsOCBAQAogICAgICAgICAgICAgICAgICAgICAgICAgJzwoUFJP RFVDVF9ESVIpL0R1bXBSZW5kZXJUcmVlX2FwaycsCiAgICAgICAgICAgICAgICAgICAgICAgICAn LS1zdHJpcC1iaW5hcnk9PChhbmRyb2lkX3N0cmlwKScsCiAgICAgICAgICAgICAgICAgICAgICAg ICAnLS1hbnQtYXJncycsCisgICAgICAgICAgICAgICAgICAgICAgICAnLXF1aWV0JywKKyAgICAg ICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAgICAgICAgICAgICAgICAgICAgICAg ICctREFORFJPSURfU0RLPTwoYW5kcm9pZF9zZGspJywKICAgICAgICAgICAgICAgICAgICAgICAg ICctLWFudC1hcmdzJywKICAgICAgICAgICAgICAgICAgICAgICAgICctREFORFJPSURfU0RLX1JP T1Q9PChhbmRyb2lkX3Nka19yb290KScsCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RXZWJLaXRBUEkuZ3lwIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0V2ViS2l0QVBJLmd5cC9UZXN0V2ViS2l0QVBJLmd5cAppbmRleCAxYjM5YTM3NGRlMzg1 NGU0YjQ0YTNkNDA0NzFhMjFhZDcyODNkN2YyLi4wYmU3NjExZDRmZjY5ZDFjYWViZjliZjVkZmVh NjhlMjBlMTJkZDNlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRB UEkuZ3lwL1Rlc3RXZWJLaXRBUEkuZ3lwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdFdl YktpdEFQSS5neXAvVGVzdFdlYktpdEFQSS5neXAKQEAgLTE0Miw2ICsxNDIsOCBAQAogICAgICAg ICAgICAgICAgICAgICAgICAgJzwoUFJPRFVDVF9ESVIpL1Rlc3RXZWJLaXRBUElfYXBrJywKICAg ICAgICAgICAgICAgICAgICAgICAgICctLXN0cmlwLWJpbmFyeT08KGFuZHJvaWRfc3RyaXApJywK ICAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKKyAgICAgICAgICAgICAgICAg ICAgICAgICctcXVpZXQnLAorICAgICAgICAgICAgICAgICAgICAgICAgJy0tYW50LWFyZ3MnLAog ICAgICAgICAgICAgICAgICAgICAgICAgJy1EQU5EUk9JRF9TREs9PChhbmRyb2lkX3NkayknLAog ICAgICAgICAgICAgICAgICAgICAgICAgJy0tYW50LWFyZ3MnLAogICAgICAgICAgICAgICAgICAg ICAgICAgJy1EQU5EUk9JRF9TREtfUk9PVD08KGFuZHJvaWRfc2RrX3Jvb3QpJywK