105242 2012-12-17 19:20:31 -0800 [Shadow] LargeDistributionWithLayout.html should be updated 2012-12-17 23:30:00 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102646 1 shinyak shinyak rniwa webcomponents-bugzilla webkit.review.bot oldest_to_newest 793274 0 shinyak 2012-12-17 19:20:31 -0800 This test was written when distribution was O(N^2). Now it's almost O(N), this test should have more loops. 793276 1 179864 shinyak 2012-12-17 19:23:38 -0800 Created attachment 179864 Patch 793281 2 179864 rniwa 2012-12-17 19:32:40 -0800 Comment on attachment 179864 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179864&action=review > PerformanceTests/ChangeLog:9 > + Since this test was written when distribution took O(N^2). However, now it's almost O(N), so this test finishes > + in very short time. Also, this test contains a some error to cause test failure, it also should be fixed. We should use run/s in this test instead. 793332 3 179875 shinyak 2012-12-17 21:20:07 -0800 Created attachment 179875 Patch 793350 4 179875 rniwa 2012-12-17 21:41:28 -0800 Comment on attachment 179875 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179875&action=review > PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:26 > + window.content = document.createElement('content'); Why don't we just declare this variable outside of the function? So this test wasn't doing anything useful before? > PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:27 > + window.shadowRoot = host.webkitCreateShadowRoot(); I don't think we need to expose this variable. It's not used elsewhere. 793379 5 shinyak 2012-12-17 22:48:25 -0800 > Why don't we just declare this variable outside of the function? So this test wasn't doing anything useful before? Unfortunately it is true... It's my fault. Maybe I wrongly uploaded a bit old version and it's committed... Basically this test and all tests in ShadowDOM/ are off by default, but they're used in our environment to track ShadowDOM performance. 793383 6 179880 shinyak 2012-12-17 22:57:00 -0800 Created attachment 179880 Patch for landing 793400 7 179880 webkit.review.bot 2012-12-17 23:29:56 -0800 Comment on attachment 179880 Patch for landing Clearing flags on attachment: 179880 Committed r137990: <http://trac.webkit.org/changeset/137990> 793401 8 webkit.review.bot 2012-12-17 23:30:00 -0800 All reviewed patches have been landed. Closing bug. 179864 2012-12-17 19:23:38 -0800 2012-12-17 21:20:04 -0800 Patch bug-105242-20121218122056.patch text/plain 1932 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTYyCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZjOTYzY2ZkZmU3 M2YwZTBlOWIzNWMzYzEwNDNkOTkxNzk0NjhjYTkuLmU2MjVkZTY5ZjcyNGZhMWZjYTBjZjQzZDQx NGJhZmQ3MmZhOTM5ZTIgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTIt MTcgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtT aGFkb3ddIExhcmdlRGlzdHJpYnV0aW9uV2l0aExheW91dC5odG1sIHNob3VsZCBiZSB1cGRhdGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSB0 aGlzIHRlc3Qgd2FzIHdyaXR0ZW4gd2hlbiBkaXN0cmlidXRpb24gdG9vayBPKE5eMikuIEhvd2V2 ZXIsIG5vdyBpdCdzIGFsbW9zdCBPKE4pLCBzbyB0aGlzIHRlc3QgZmluaXNoZXMKKyAgICAgICAg aW4gdmVyeSBzaG9ydCB0aW1lLiBBbHNvLCB0aGlzIHRlc3QgY29udGFpbnMgYSBzb21lIGVycm9y IHRvIGNhdXNlIHRlc3QgZmFpbHVyZSwgaXQgYWxzbyBzaG91bGQgYmUgZml4ZWQuCisKKyAgICAg ICAgKiBTaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25XaXRoTGF5b3V0Lmh0bWw6CisKIDIwMTIt MTItMTMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2Nocm9t aXVtIHBlcmZdIERPTS9ET01XYWxrLmh0bWwgZmFpbHVyZXMKZGlmZiAtLWdpdCBhL1BlcmZvcm1h bmNlVGVzdHMvU2hhZG93RE9NL0xhcmdlRGlzdHJpYnV0aW9uV2l0aExheW91dC5odG1sIGIvUGVy Zm9ybWFuY2VUZXN0cy9TaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25XaXRoTGF5b3V0Lmh0bWwK aW5kZXggOWYxZTYyNWJhOThmMTQxYzNjYTUyYzYzYTlkNTk5ZGUxNDRiMDcyOS4uNjBkN2U1OGRk MDFhNTBiMGY2NDMzYjBmZTVjYWIwOGJjNGM5NDU3MiAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VU ZXN0cy9TaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25XaXRoTGF5b3V0Lmh0bWwKKysrIGIvUGVy Zm9ybWFuY2VUZXN0cy9TaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25XaXRoTGF5b3V0Lmh0bWwK QEAgLTExLDcgKzExLDcgQEAKIAogPHNjcmlwdD4KIHZhciBudW1EaXZzSW5Ib3N0ID0gMTAwMDsK LXZhciBuTG9vcHMgPSAzMDsKK3ZhciBuTG9vcHMgPSAzMDAwOwogCiBmdW5jdGlvbiBzZXR1cCgp CiB7CkBAIC0yMywxNCArMjMsMTYgQEAgZnVuY3Rpb24gc2V0dXAoKQogICAgICAgICBob3N0LmFw cGVuZENoaWxkKGRpdik7CiAgICAgfQogCi0gICAgdmFyIGNvbnRlbnQgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdjb250ZW50Jyk7Ci0gICAgdmFyIHNoYWRvd1Jvb3QgPSBuZXcgV2ViS2l0U2hh ZG93Um9vdChob3N0KTsKKyAgICB3aW5kb3cuY29udGVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoJ2NvbnRlbnQnKTsKKyAgICB3aW5kb3cuc2hhZG93Um9vdCA9IG5ldyBXZWJLaXRTaGFkb3dS b290KGhvc3QpOwogICAgIHNoYWRvd1Jvb3QuYXBwZW5kQ2hpbGQoY29udGVudCk7CiB9CiAKIGZ1 bmN0aW9uIHJ1bigpCiB7CiAgICAgdmFyIGhvc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn aG9zdCcpOworICAgIHZhciBjb250ZW50ID0gd2luZG93LmNvbnRlbnQ7CisgICAgdmFyIHNoYWRv d1Jvb3QgPSB3aW5kb3cuc2hhZG93Um9vdDsKICAgICB2YXIgbkxvb3BzID0gd2luZG93Lm5Mb29w czsKIAogICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsK 179875 2012-12-17 21:20:07 -0800 2012-12-17 22:56:57 -0800 Patch bug-105242-20121218141724.patch text/plain 2125 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTYyCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZjOTYzY2ZkZmU3 M2YwZTBlOWIzNWMzYzEwNDNkOTkxNzk0NjhjYTkuLjNmNjZhYTcwZWFiN2VmODVkMjRkMWRmMTk2 YjNjNjRmY2Y3NDg4OTkgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTIt MTcgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtT aGFkb3ddIExhcmdlRGlzdHJpYnV0aW9uV2l0aExheW91dC5odG1sIHNob3VsZCBiZSB1cGRhdGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSB0 aGlzIHRlc3Qgd2FzIHdyaXR0ZW4gd2hlbiBkaXN0cmlidXRpb24gdG9vayBPKE5eMikuIEhvd2V2 ZXIsIG5vdyBpdCdzIGFsbW9zdCBPKE4pLCBzbyB0aGlzIHRlc3QgZmluaXNoZXMKKyAgICAgICAg aW4gdmVyeSBzaG9ydCB0aW1lLiBXZSBzaG91bGQgY29udmVydCBpdCB1bml0IHRvIHJ1bnMvcy4K KworICAgICAgICBUaGlzIHRlc3QgY29udGFpbnMgYSBzb21lIGVycm9yIHRvIGNhdXNlIHRlc3Qg ZmFpbHVyZSwgZS5nLiB1c2luZyBvYnNvbGV0ZSBBUEksIHNvIHRoZXkgYWxzbyBzaG91bGQgYmUg Zml4ZWQuCisKKyAgICAgICAgKiBTaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25XaXRoTGF5b3V0 Lmh0bWw6CisKIDIwMTItMTItMTMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW2Nocm9taXVtIHBlcmZdIERPTS9ET01XYWxrLmh0bWwgZmFpbHVyZXMKZGlmZiAt LWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvU2hhZG93RE9NL0xhcmdlRGlzdHJpYnV0aW9uV2l0aExh eW91dC5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9TaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25X aXRoTGF5b3V0Lmh0bWwKaW5kZXggOWYxZTYyNWJhOThmMTQxYzNjYTUyYzYzYTlkNTk5ZGUxNDRi MDcyOS4uYTFiNDAxNzVhNzBmNDY2OWNmM2I5M2I5MGIzMzU1NDM0Yzk4NDk2MyAxMDA2NDQKLS0t IGEvUGVyZm9ybWFuY2VUZXN0cy9TaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25XaXRoTGF5b3V0 Lmh0bWwKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9TaGFkb3dET00vTGFyZ2VEaXN0cmlidXRpb25X aXRoTGF5b3V0Lmh0bWwKQEAgLTIzLDE0ICsyMywxNiBAQCBmdW5jdGlvbiBzZXR1cCgpCiAgICAg ICAgIGhvc3QuYXBwZW5kQ2hpbGQoZGl2KTsKICAgICB9CiAKLSAgICB2YXIgY29udGVudCA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2NvbnRlbnQnKTsKLSAgICB2YXIgc2hhZG93Um9vdCA9IG5l dyBXZWJLaXRTaGFkb3dSb290KGhvc3QpOworICAgIHdpbmRvdy5jb250ZW50ID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgnY29udGVudCcpOworICAgIHdpbmRvdy5zaGFkb3dSb290ID0gaG9zdC53 ZWJraXRDcmVhdGVTaGFkb3dSb290KCk7CiAgICAgc2hhZG93Um9vdC5hcHBlbmRDaGlsZChjb250 ZW50KTsKIH0KIAogZnVuY3Rpb24gcnVuKCkKIHsKICAgICB2YXIgaG9zdCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdob3N0Jyk7CisgICAgdmFyIGNvbnRlbnQgPSB3aW5kb3cuY29udGVudDsK KyAgICB2YXIgc2hhZG93Um9vdCA9IHdpbmRvdy5zaGFkb3dSb290OwogICAgIHZhciBuTG9vcHMg PSB3aW5kb3cubkxvb3BzOwogCiAgICAgdmFyIGRpdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J2RpdicpOwpAQCAtNDksNyArNTEsNyBAQCBmdW5jdGlvbiBkb25lKCkKIAogc2V0dXAoKTsKIAot UGVyZlRlc3RSdW5uZXIubWVhc3VyZVRpbWUoeworUGVyZlRlc3RSdW5uZXIubWVhc3VyZVJ1bnNQ ZXJTZWNvbmQoewogICAgIGRlc2NyaXB0aW9uOiAiTWVhc3VyZSBEaXN0cmlidXRpb24gYW5kIExh eW91dCB0aW1lICh3aXRoIGEgbG90IG9mIGhvc3QgY2hpbGRyZW4pIiwKICAgICBydW46IHJ1biwK ICAgICBkb25lOiBkb25lCg== 179880 2012-12-17 22:57:00 -0800 2012-12-17 23:29:56 -0800 Patch for landing bug-105242-20121218155417.patch text/plain 2114 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTYyCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZjOTYzY2ZkZmU3 M2YwZTBlOWIzNWMzYzEwNDNkOTkxNzk0NjhjYTkuLmRmMzc3Yjg1MWM3N2Y2ODVjYzBkMGZkNGE1 ZjZiMzI5OGIxZDUyNGYgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTIt MTcgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtT aGFkb3ddIExhcmdlRGlzdHJpYnV0aW9uV2l0aExheW91dC5odG1sIHNob3VsZCBiZSB1cGRhdGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNDIK KworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgU2luY2UgdGhp cyB0ZXN0IHdhcyB3cml0dGVuIHdoZW4gZGlzdHJpYnV0aW9uIHRvb2sgTyhOXjIpLiBIb3dldmVy LCBub3cgaXQncyBhbG1vc3QgTyhOKSwgc28gdGhpcyB0ZXN0IGZpbmlzaGVzCisgICAgICAgIGlu IHZlcnkgc2hvcnQgdGltZS4gV2Ugc2hvdWxkIGNvbnZlcnQgaXQgdW5pdCB0byBydW5zL3MuCisK KyAgICAgICAgVGhpcyB0ZXN0IGNvbnRhaW5zIGEgc29tZSBlcnJvciB0byBjYXVzZSB0ZXN0IGZh aWx1cmUsIGUuZy4gdXNpbmcgb2Jzb2xldGUgQVBJLCBzbyB0aGV5IGFsc28gc2hvdWxkIGJlIGZp eGVkLgorCisgICAgICAgICogU2hhZG93RE9NL0xhcmdlRGlzdHJpYnV0aW9uV2l0aExheW91dC5o dG1sOgorCiAyMDEyLTEyLTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFtjaHJvbWl1bSBwZXJmXSBET00vRE9NV2Fsay5odG1sIGZhaWx1cmVzCmRpZmYgLS1n aXQgYS9QZXJmb3JtYW5jZVRlc3RzL1NoYWRvd0RPTS9MYXJnZURpc3RyaWJ1dGlvbldpdGhMYXlv dXQuaHRtbCBiL1BlcmZvcm1hbmNlVGVzdHMvU2hhZG93RE9NL0xhcmdlRGlzdHJpYnV0aW9uV2l0 aExheW91dC5odG1sCmluZGV4IDlmMWU2MjViYTk4ZjE0MWMzY2E1MmM2M2E5ZDU5OWRlMTQ0YjA3 MjkuLmJhOThmYmNlNzM0Y2IyZTIyMTJkZGNmYWJiZTYyMjg0YzcyYzFhNTEgMTAwNjQ0Ci0tLSBh L1BlcmZvcm1hbmNlVGVzdHMvU2hhZG93RE9NL0xhcmdlRGlzdHJpYnV0aW9uV2l0aExheW91dC5o dG1sCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvU2hhZG93RE9NL0xhcmdlRGlzdHJpYnV0aW9uV2l0 aExheW91dC5odG1sCkBAIC0yMywxNCArMjMsMTUgQEAgZnVuY3Rpb24gc2V0dXAoKQogICAgICAg ICBob3N0LmFwcGVuZENoaWxkKGRpdik7CiAgICAgfQogCi0gICAgdmFyIGNvbnRlbnQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdjb250ZW50Jyk7Ci0gICAgdmFyIHNoYWRvd1Jvb3QgPSBuZXcg V2ViS2l0U2hhZG93Um9vdChob3N0KTsKKyAgICB3aW5kb3cuY29udGVudCA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoJ2NvbnRlbnQnKTsKKyAgICB2YXIgc2hhZG93Um9vdCA9IGhvc3Qud2Via2l0 Q3JlYXRlU2hhZG93Um9vdCgpOwogICAgIHNoYWRvd1Jvb3QuYXBwZW5kQ2hpbGQoY29udGVudCk7 CiB9CiAKIGZ1bmN0aW9uIHJ1bigpCiB7CiAgICAgdmFyIGhvc3QgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnaG9zdCcpOworICAgIHZhciBjb250ZW50ID0gd2luZG93LmNvbnRlbnQ7CiAgICAg dmFyIG5Mb29wcyA9IHdpbmRvdy5uTG9vcHM7CiAKICAgICB2YXIgZGl2ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgnZGl2Jyk7CkBAIC00NiwxMCArNDcsOSBAQCBmdW5jdGlvbiBkb25lKCkKICAg ICB3cmFwcGVyLmlubmVySFRNTCA9ICcnOwogfQogCi0KIHNldHVwKCk7CiAKLVBlcmZUZXN0UnVu bmVyLm1lYXN1cmVUaW1lKHsKK1BlcmZUZXN0UnVubmVyLm1lYXN1cmVSdW5zUGVyU2Vjb25kKHsK ICAgICBkZXNjcmlwdGlvbjogIk1lYXN1cmUgRGlzdHJpYnV0aW9uIGFuZCBMYXlvdXQgdGltZSAo d2l0aCBhIGxvdCBvZiBob3N0IGNoaWxkcmVuKSIsCiAgICAgcnVuOiBydW4sCiAgICAgZG9uZTog ZG9uZQo=