105240 2012-12-17 19:03:42 -0800 [BlackBerry] Editable text element can't be selected 2012-12-17 23:35:29 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 xuewen.ok webkit-unassigned allan.jensen mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 793263 0 xuewen.ok 2012-12-17 19:03:42 -0800 DESCRIPTION: It can't select text in a <input> or <textarea> now. HOW TO REPRODUCE: Touch hold on the word in a editable element to try to trigger the text selection. EXPECTED: The word under finger should be selected, selection handles and overlay should be shown. ACTUAL: Selection is not triggered, but the FCC caret and the CCM are shown. 793271 1 179861 xuewen.ok 2012-12-17 19:18:01 -0800 Created attachment 179861 patch 793283 2 179861 rwlbuis 2012-12-17 19:35:36 -0800 Comment on attachment 179861 patch LGTM. 793402 3 179861 webkit.review.bot 2012-12-17 23:35:26 -0800 Comment on attachment 179861 patch Clearing flags on attachment: 179861 Committed r137991: <http://trac.webkit.org/changeset/137991> 793403 4 webkit.review.bot 2012-12-17 23:35:29 -0800 All reviewed patches have been landed. Closing bug. 179861 2012-12-17 19:18:01 -0800 2012-12-17 23:35:26 -0800 patch 0001-BlackBerry-Editable-text-element-can-t-be-selected.patch text/plain 2544 xuewen.ok RnJvbSAyZWU0M2YyOWZjZWQ3NmY2Y2JhYTlkMDYxMTM5ODVmZDgyYWViMjhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWFuIFdhbmcgPFh1ZXdlbi5XYW5nQHRvcmNobW9iaWxlLmNv bS5jbj4KRGF0ZTogVHVlLCAxOCBEZWMgMjAxMiAxMToxMzo0OSArMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFtCbGFja0JlcnJ5XSBFZGl0YWJsZSB0ZXh0IGVsZW1lbnQgY2FuJ3QgYmUgc2VsZWN0ZWQK IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNDAKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgpJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEdlbmV2aWV2ZSBNYWsg YW5kIE1pa2UgRmVudG9uLgoKSW50ZXJuYWwgUFIyNjY3NTUKV2hlbiB0aGUgdGFyZ2V0IGlzIFRl eHQsIHdlIHNob3VsZCBhbGxvdyBpdCB0byBjb2xsZWN0IHRleHQgbm9kZXMgaW4KdGhlIHNoYWRv dyB0cmVlIG9mIHRleHQgZWRpdGFibGUgZWxlbWVudHMuCgoqIFdlYktpdFN1cHBvcnQvRmF0Rmlu Z2Vycy5jcHA6CihCbGFja0JlcnJ5OjpXZWJLaXQ6OkZhdEZpbmdlcnM6OmdldE5vZGVzRnJvbVJl Y3QpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgIHwgICAxNSArKysrKysrKysrKysrKysKIC4uLi9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0ZhdEZpbmdlcnMuY3BwIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5k ZXggMzMzMTlkYy4uNGVmZWNhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTItMTItMTcgIFNlYW4gV2FuZyAgPFh1ZXdlbi5XYW5nQHRvcmNobW9i aWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRWRpdGFibGUgdGV4dCBlbGVtZW50 IGNhbid0IGJlIHNlbGVjdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDUyNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBHZW5ldmlldmUgTWFrIGFuZCBNaWtlIEZl bnRvbi4KKworICAgICAgICBJbnRlcm5hbCBQUjI2Njc1NQorICAgICAgICBXaGVuIHRoZSB0YXJn ZXQgaXMgVGV4dCwgd2Ugc2hvdWxkIGFsbG93IGl0IHRvIGNvbGxlY3QgdGV4dCBub2RlcyBpbgor ICAgICAgICB0aGUgc2hhZG93IHRyZWUgb2YgdGV4dCBlZGl0YWJsZSBlbGVtZW50cy4KKworICAg ICAgICAqIFdlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5 OjpXZWJLaXQ6OkZhdEZpbmdlcnM6OmdldE5vZGVzRnJvbVJlY3QpOgorCiAyMDEyLTEyLTE3ICBZ b25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBOdWxsIHBvaW50 ZXIgYWNjZXNzIGluIGNvbXBvc2l0b3JEcmF3c1Jvb3RMYXllcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAppbmRleCA5NWY4 ZTlmLi43YzRmOWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcApAQCAtNDk2LDcgKzQ5Niw3IEBAIHZvaWQgRmF0Rmlu Z2Vyczo6Z2V0Tm9kZXNGcm9tUmVjdChEb2N1bWVudCogZG9jdW1lbnQsIGNvbnN0IEludFBvaW50 JiBjb250ZW50UG9zCiAgICAgLy8gVGhlIHVzZXIgZnVuY3Rpb25zIGNoZWNrRm9yVGV4dCgpIGFu ZCBmaW5kSW50ZXJzZWN0aW5nUmVnaW9ucygpIHVzZXMgdGhlIE5vZGUud2hvbGVUZXh0KCkgdG8g Y2hlY2tGaW5nZXJJbnRlcnNlY3Rpb24oKQogICAgIC8vIG5vdCB0aGUgdGV4dCBpbiBpdHMgc2hh ZG93IHRyZWUuCiAgICAgSGl0VGVzdFJlcXVlc3Q6OkhpdFRlc3RSZXF1ZXN0VHlwZSByZXF1ZXN0 VHlwZSA9IEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRlc3RSZXF1ZXN0OjpBY3RpdmUg fCBIaXRUZXN0UmVxdWVzdDo6SWdub3JlQ2xpcHBpbmc7Ci0gICAgaWYgKG1fdGFyZ2V0VHlwZSAh PSBUZXh0KQorICAgIGlmIChtX3RhcmdldFR5cGUgPT0gVGV4dCkKICAgICAgICAgcmVxdWVzdFR5 cGUgfD0gSGl0VGVzdFJlcXVlc3Q6OkFsbG93U2hhZG93Q29udGVudDsKICAgICBIaXRUZXN0UmVz dWx0IHJlc3VsdChjb250ZW50UG9zLCB0b3BQYWRkaW5nLCByaWdodFBhZGRpbmcsIGJvdHRvbVBh ZGRpbmcsIGxlZnRQYWRkaW5nKTsKIAotLSAKMS43LjkuNQoK