105238 2012-12-17 18:22:02 -0800 [chromium] Add the GL_CHROMIUM_lose_context to WebGraphicsContext3D 2012-12-17 19:32:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth dglazkov fishd jamesr piman tkent+wkapi webkit.review.bot oldest_to_newest 793227 0 danakj 2012-12-17 18:22:02 -0800 [chromium] Add the GL_CHROMIUM_lose_context to WebGraphicsContext3D 793228 1 179846 danakj 2012-12-17 18:22:17 -0800 Created attachment 179846 Patch 793230 2 179846 jamesr 2012-12-17 18:23:59 -0800 Comment on attachment 179846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179846&action=review > Source/Platform/chromium/public/WebGraphicsContext3D.h:244 > + virtual void loseContext() { } can we call it lostContextCHROMIUM() to be consistent with the naming for other extensions? 793231 3 webkit.review.bot 2012-12-17 18:24:04 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 793233 4 179847 danakj 2012-12-17 18:27:57 -0800 Created attachment 179847 Patch for landing 793234 5 danakj 2012-12-17 18:28:07 -0800 (In reply to comment #2) > (From update of attachment 179846 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179846&action=review > > > Source/Platform/chromium/public/WebGraphicsContext3D.h:244 > > + virtual void loseContext() { } > > can we call it lostContextCHROMIUM() to be consistent with the naming for other extensions? Oops, definitely. 793265 6 179847 danakj 2012-12-17 19:06:53 -0800 Comment on attachment 179847 Patch for landing Maybe these lost context tests are useless now. 793280 7 danakj 2012-12-17 19:32:06 -0800 Committed r137970: <http://trac.webkit.org/changeset/137970> 179846 2012-12-17 18:22:17 -0800 2012-12-17 18:27:53 -0800 Patch bug-105238-20121217211935.patch text/plain 1507 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBjYmJkNzEzYTMxYTAx Y2FhNmJjMDFmM2YzMjZhNWZkYjRiNTdlNmRjLi44ZWM1ODk1ZjE4MWVkMTBkMTlmMmFhMDYwNGJi MWE0YzY4ZjY4Y2U5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMi0xNyAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEFkZCB0aGUgR0xfQ0hST01JVU1fbG9zZV9jb250ZXh0IHRvIFdlYkdyYXBoaWNzQ29udGV4dDNE CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyMzgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oOgorICAgICAgICAoV2ViR3JhcGhpY3ND b250ZXh0M0QpOgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRDo6bG9zZUNv bnRleHQpOgorCiAyMDEyLTEyLTEyICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgc3VwcG9ydCBmb3IgVFJBQ0VfRVZFTlRf SUZfTE9OR0VSX1RIQU54IG1hY3JvcwpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCmluZGV4IDdmNTcyNjYzN2M5MThhZmQ4 OGY0Nzc2Y2JkMzdhMjYyNDMyNTVjMzkuLjM4MDcwYmQ2NTU0ZWZjMGY5NTFlMzE2NmQ1YmQ4Y2Qx YTZmOTZhOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi R3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGlj L1dlYkdyYXBoaWNzQ29udGV4dDNELmgKQEAgLTI0MCw2ICsyNDAsOSBAQCBwdWJsaWM6CiAgICAg Ly8gRGVzdHJveXMgdGhlIHN0cmVhbSBmb3IgdGhlIGdpdmVuIHRleHR1cmUuCiAgICAgdmlydHVh bCB2b2lkIGRlc3Ryb3lTdHJlYW1UZXh0dXJlQ0hST01JVU0oV2ViR0xJZCB0ZXh0dXJlKSB7IH0K IAorICAgIC8vIEdMX0NIUk9NSVVNX2xvc2VfY29udGV4dAorICAgIHZpcnR1YWwgdm9pZCBsb3Nl Q29udGV4dCgpIHsgfQorCiAgICAgLy8gVGhlIGVudHJ5IHBvaW50cyBiZWxvdyBtYXAgZGlyZWN0 bHkgdG8gdGhlIE9wZW5HTCBFUyAyLjAgQVBJLgogICAgIC8vIFNlZTogaHR0cDovL3d3dy5raHJv bm9zLm9yZy9yZWdpc3RyeS9nbGVzLwogICAgIC8vIGFuZDogaHR0cDovL3d3dy5raHJvbm9zLm9y Zy9vcGVuZ2xlcy9zZGsvZG9jcy9tYW4vCg== 179847 2012-12-17 18:27:57 -0800 2012-12-17 19:06:53 -0800 Patch for landing bug-105238-20121217212515.patch text/plain 1549 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBjYmJkNzEzYTMxYTAx Y2FhNmJjMDFmM2YzMjZhNWZkYjRiNTdlNmRjLi45MTU5ZGQ0YmI2Yzk0MjA4NzI0NDM4ZjQxYjRl MDJiY2E3NTRiMTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMi0xNyAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEFkZCB0aGUgR0xfQ0hST01JVU1fbG9zZV9jb250ZXh0IHRvIFdlYkdyYXBoaWNzQ29udGV4dDNE CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyMzgK KworICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KKworICAgICAgICAqIGNocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oOgorICAgICAgICAoV2ViR3JhcGhpY3ND b250ZXh0M0QpOgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRDo6bG9zZUNv bnRleHQpOgorCiAyMDEyLTEyLTEyICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgc3VwcG9ydCBmb3IgVFJBQ0VfRVZFTlRf SUZfTE9OR0VSX1RIQU54IG1hY3JvcwpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCmluZGV4IDdmNTcyNjYzN2M5MThhZmQ4 OGY0Nzc2Y2JkMzdhMjYyNDMyNTVjMzkuLmM2YmZiMzAzNjhkZjkzNzdkMzcxMTcwM2VkZjVlMDZj YzQ3MjRiM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi R3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGlj L1dlYkdyYXBoaWNzQ29udGV4dDNELmgKQEAgLTI0MCw2ICsyNDAsOSBAQCBwdWJsaWM6CiAgICAg Ly8gRGVzdHJveXMgdGhlIHN0cmVhbSBmb3IgdGhlIGdpdmVuIHRleHR1cmUuCiAgICAgdmlydHVh bCB2b2lkIGRlc3Ryb3lTdHJlYW1UZXh0dXJlQ0hST01JVU0oV2ViR0xJZCB0ZXh0dXJlKSB7IH0K IAorICAgIC8vIEdMX0NIUk9NSVVNX2xvc2VfY29udGV4dAorICAgIHZpcnR1YWwgdm9pZCBsb3Nl Q29udGV4dENIUk9NSVVNKFdHQzNEZW51bSBjdXJyZW50LCBXR0MzRGVudW0gb3RoZXIpIHsgfQor CiAgICAgLy8gVGhlIGVudHJ5IHBvaW50cyBiZWxvdyBtYXAgZGlyZWN0bHkgdG8gdGhlIE9wZW5H TCBFUyAyLjAgQVBJLgogICAgIC8vIFNlZTogaHR0cDovL3d3dy5raHJvbm9zLm9yZy9yZWdpc3Ry eS9nbGVzLwogICAgIC8vIGFuZDogaHR0cDovL3d3dy5raHJvbm9zLm9yZy9vcGVuZ2xlcy9zZGsv ZG9jcy9tYW4vCg==