105236 2012-12-17 18:00:23 -0800 run-perf-tests should warn (loudly) if you're using a Debug build 2013-11-14 07:36:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned commit-queue dpranke glenn ossy pdr rniwa oldest_to_newest 793217 0 eric 2012-12-17 18:00:23 -0800 run-perf-tests should warn (loudly) if you're using a Debug build Trying to get perf numbers out of a Debug build is folly. Sure, we can support people running with run-perf-tests --debug, but we should scream at them to make sure the innocent bystanders don't get confused by their checkout being in --debug mode (set-webkit-configuration --debug) and run-perf-tests giving them debug numbers. pdr was bitten by this earlier today. 950593 1 216916 evab.u-szeged 2013-11-14 04:10:53 -0800 Created attachment 216916 Patch 950596 2 216916 ossy 2013-11-14 04:30:04 -0800 Comment on attachment 216916 Patch The idea is good, but this patch has an issue: I get this warning too if the default configuration is Debug, but I passed --relase as command line argument. 950629 3 216929 evab.u-szeged 2013-11-14 06:56:41 -0800 Created attachment 216929 Patch 950635 4 216929 ossy 2013-11-14 07:10:34 -0800 Comment on attachment 216929 Patch It sounds much more better, r=me. 950646 5 216929 commit-queue 2013-11-14 07:36:01 -0800 Comment on attachment 216929 Patch Clearing flags on attachment: 216929 Committed r159285: <http://trac.webkit.org/changeset/159285> 950647 6 commit-queue 2013-11-14 07:36:03 -0800 All reviewed patches have been landed. Closing bug. 216916 2013-11-14 04:10:53 -0800 2013-11-14 06:56:35 -0800 Patch bug-105236-20131114131052.patch text/plain 2059 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWU0YTYxMWI4MzM0NzQzOWRlMzEzNTZhZmZmMzA5MTc3 NTZjZjMzZi4uOTJiNzU5N2MzYmI1MzU1ZjNjZTZmMWJmNjE3ODg5MDA2YjcwODA1ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTExLTE0ICDDiXZhIEJhbMOhenNmYWx2aSAgPGJhbGF6c2ZhbHZpLmV2YUBzdHVk LnUtc3plZ2VkLmh1PgorCisgICAgICAgIHJ1bi1wZXJmLXRlc3RzIHNob3VsZCB3YXJuIGxvdWRs eSBpZiB5b3UncmUgdXNpbmcgYSBEZWJ1ZyBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTIzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90 ZXN0cy9wZXJmdGVzdHNydW5uZXIucHk6CisgICAgICAgIChQZXJmVGVzdHNSdW5uZXIucnVuKToK KwogMjAxMy0xMS0wOCAgTWF0dGhldyBIYW5zb24gIDxtYXR0aGV3X2hhbnNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkZWQgbXlzZWxmIGFzIGEgY29udHJpYnV0b3IuCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0 ZXN0c3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMv cGVyZnRlc3RzcnVubmVyLnB5CmluZGV4IGFkZmFiZmZiZGUxNWRhYTU0NDc5Y2FiNzA4MDFkM2Nk NzE3YjRhMmMuLjI4ZDA1M2IzYWVhNmMyYTc1MzZlODBkMjFkYjJlMWUwMmI3YTRjN2MgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3Rz cnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMv cGVyZnRlc3RzcnVubmVyLnB5CkBAIC00Miw2ICs0Miw5IEBAIGZyb20gd2Via2l0cHkuY29tbW9u Lmhvc3QgaW1wb3J0IEhvc3QKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5maWxlX3VwbG9hZGVy IGltcG9ydCBGaWxlVXBsb2FkZXIKIGZyb20gd2Via2l0cHkucGVyZm9ybWFuY2VfdGVzdHMucGVy ZnRlc3QgaW1wb3J0IFBlcmZUZXN0RmFjdG9yeQogZnJvbSB3ZWJraXRweS5wZXJmb3JtYW5jZV90 ZXN0cy5wZXJmdGVzdCBpbXBvcnQgREVGQVVMVF9URVNUX1JVTk5FUl9DT1VOVAorZnJvbSB3ZWJr aXRweS5wb3J0IGltcG9ydCBjb25maWcKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbSBpbXBv cnQgZXhlY3V0aXZlCitmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0gaW1wb3J0IGZpbGVzeXN0 ZW0KIAogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCkBAIC0xNjYsNiArMTY5 LDExIEBAIGNsYXNzIFBlcmZUZXN0c1J1bm5lcihvYmplY3QpOgogICAgICAgICByZXR1cm4gdGVz dHMKIAogICAgIGRlZiBydW4oc2VsZik6CisgICAgICAgIGlmICJEZWJ1ZyIgPT0gY29uZmlnLkNv bmZpZyhleGVjdXRpdmUuRXhlY3V0aXZlKCksIGZpbGVzeXN0ZW0uRmlsZVN5c3RlbSgpKS5kZWZh dWx0X2NvbmZpZ3VyYXRpb24oKToKKyAgICAgICAgICAgIF9sb2cud2FybmluZygiIiIqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqCisqIFdBUk5JTkc6 IHJ1bi1wZXJmLXRlc3RzIGlzIHJ1bm5pbmcgaW4gREVCVUcgbW9kZSAqCisqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqIiIiKQorCiAgICAgICAgIGlm IG5vdCBzZWxmLl9wb3J0LmNoZWNrX2J1aWxkKG5lZWRzX2h0dHA9RmFsc2UpOgogICAgICAgICAg ICAgX2xvZy5lcnJvcigiQnVpbGQgbm90IHVwIHRvIGRhdGUgZm9yICVzIiAlIHNlbGYuX3BvcnQu X3BhdGhfdG9fZHJpdmVyKCkpCiAgICAgICAgICAgICByZXR1cm4gc2VsZi5FWElUX0NPREVfQkFE X0JVSUxECg== 216929 2013-11-14 06:56:41 -0800 2013-11-14 07:36:01 -0800 Patch bug-105236-20131114155640.patch text/plain 1589 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWU0YTYxMWI4MzM0NzQzOWRlMzEzNTZhZmZmMzA5MTc3 NTZjZjMzZi4uOTJiNzU5N2MzYmI1MzU1ZjNjZTZmMWJmNjE3ODg5MDA2YjcwODA1ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTExLTE0ICDDiXZhIEJhbMOhenNmYWx2aSAgPGJhbGF6c2ZhbHZpLmV2YUBzdHVk LnUtc3plZ2VkLmh1PgorCisgICAgICAgIHJ1bi1wZXJmLXRlc3RzIHNob3VsZCB3YXJuIGxvdWRs eSBpZiB5b3UncmUgdXNpbmcgYSBEZWJ1ZyBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTIzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90 ZXN0cy9wZXJmdGVzdHNydW5uZXIucHk6CisgICAgICAgIChQZXJmVGVzdHNSdW5uZXIucnVuKToK KwogMjAxMy0xMS0wOCAgTWF0dGhldyBIYW5zb24gIDxtYXR0aGV3X2hhbnNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkZWQgbXlzZWxmIGFzIGEgY29udHJpYnV0b3IuCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0 ZXN0c3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMv cGVyZnRlc3RzcnVubmVyLnB5CmluZGV4IGFkZmFiZmZiZGUxNWRhYTU0NDc5Y2FiNzA4MDFkM2Nk NzE3YjRhMmMuLmY0OGY1NDZkNzlmNzkwMDUzMzc1YTY1ZDhkODFiNzc5ZmRhMzFkZTAgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3Rz cnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMv cGVyZnRlc3RzcnVubmVyLnB5CkBAIC0xNjYsNiArMTY2LDExIEBAIGNsYXNzIFBlcmZUZXN0c1J1 bm5lcihvYmplY3QpOgogICAgICAgICByZXR1cm4gdGVzdHMKIAogICAgIGRlZiBydW4oc2VsZik6 CisgICAgICAgIGlmICJEZWJ1ZyIgPT0gc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCJjb25maWd1cmF0 aW9uIik6CisgICAgICAgICAgICBfbG9nLndhcm5pbmcoIiIiKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgorKiBXQVJOSU5HOiBydW4tcGVyZi10ZXN0 cyBpcyBydW5uaW5nIGluIERFQlVHIG1vZGUgKgorKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKiIiIikKKwogICAgICAgICBpZiBub3Qgc2VsZi5fcG9y dC5jaGVja19idWlsZChuZWVkc19odHRwPUZhbHNlKToKICAgICAgICAgICAgIF9sb2cuZXJyb3Io IkJ1aWxkIG5vdCB1cCB0byBkYXRlIGZvciAlcyIgJSBzZWxmLl9wb3J0Ll9wYXRoX3RvX2RyaXZl cigpKQogICAgICAgICAgICAgcmV0dXJuIHNlbGYuRVhJVF9DT0RFX0JBRF9CVUlMRAo=