105235 2012-12-17 17:53:52 -0800 Can't visit sites with untrusted certs with the NetworkProcess 2012-12-17 21:01:06 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ap rniwa sam oldest_to_newest 793213 0 beidson 2012-12-17 17:53:52 -0800 Can't visit sites with untrusted certs with the NetworkProcess. We need to expose API to allow telling the network layer to temporary accept an untrusted cert. In radar as <rdar://problem/12885641> 793216 1 179843 beidson 2012-12-17 18:00:01 -0800 Created attachment 179843 Patch v1 - Add SPI to support this. 793229 2 beidson 2012-12-17 18:23:57 -0800 http://trac.webkit.org/changeset/137967 793279 3 rniwa 2012-12-17 19:28:38 -0800 This patch broke Mac builds: http://build.webkit.org/builders/Apple%20Lion%20Release%20%28Build%29/builds/7897/steps/compile-webkit/logs/stdio /Volumes/Data/slave/lion-release/build/Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:34:9: fatal error: 'Foundation/NSURLRequestPrivate.h' file not found #import <Foundation/NSURLRequestPrivate.h> ^ 1 error generated. 793325 4 179843 ap 2012-12-17 21:01:06 -0800 Comment on attachment 179843 Patch v1 - Add SPI to support this. View in context: https://bugs.webkit.org/attachment.cgi?id=179843&action=review > Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:118 > + [NSURLRequest setAllowsSpecificHTTPSCertificate:(NSArray *)certificateInfo.certificateChain() forHost:(NSString *)host]; I would add a USE(CFNETWORK) block with an #error. 179843 2012-12-17 18:00:01 -0800 2012-12-17 21:01:06 -0800 Patch v1 - Add SPI to support this. opatch.txt text/plain 7168 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwYjM3ZGYzLi5mZjBkMDY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTItMTItMTcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIENhbid0IHZpc2l0IHNpdGVzIHdpdGggdW50cnVzdGVkIGNlcnRzIHdpdGggdGhlIE5ldHdv cmtQcm9jZXNzLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTI4ODU2NDE+IGFuZCBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIE1hYyB0aGUgbWlzc2luZyBmdW5j dGlvbmFsaXR5IGlzIGJlaW5nIGFibGUgdG8gdGVsbCB0aGUgbmV0d29yayBsYXllciBpbiB0aGUK KyAgICAgICAgTmV0d29ya1Byb2Nlc3MgdG8gdGVtcG9yYXJpbHkgYWNjZXB0IGEgY2VydGlmaWNh dGUgY2hhaW4gZm9yIHRoZSBnaXZlbiBob3N0LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBz b21lIFNQSSBzdXBwb3J0aW5nIHRoZSB3YXkgdGhpcyB3b3JrcyBvbiBNYWMuCisKKyAgICAgICAg QWRkIGEgbWVzc2FnZSBhbmQgTWFjIGltcGxlbWVudGF0aW9uIGZvciAiYWxsb3dTcGVjaWZpY0hU VFBTQ2VydGlmaWNhdGVGb3JIb3N0IjoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr UHJvY2Vzcy5oOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLm1lc3Nh Z2VzLmluOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL21hYy9OZXR3b3JrUHJvY2Vzc01hYy5t bToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OmFsbG93U3BlY2lmaWNIVFRQU0Nl cnRpZmljYXRlRm9ySG9zdCk6CisKKyAgICAgICAgQWRkIFNQSSBmb3IgdGhlIGVtYmVkZGluZyBh cHAiCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHA6CisgICAgICAgIChX S0NvbnRleHRBbGxvd1NwZWNpZmljSFRUUFNDZXJ0aWZpY2F0ZUZvckhvc3QpOgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRQcml2YXRlLmg6CisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OmFsbG93U3Bl Y2lmaWNIVFRQU0NlcnRpZmljYXRlRm9ySG9zdCk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkNv bnRleHQuaDoKKwogMjAxMi0xMi0xNyAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28u c2FudG9zQGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBVbml0IHRlc3RzIHByb2Nlc3MgaGFu Z2luZyBvbiBXSzIgUmVsZWFzZSBib3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Byb2Nlc3MuaAppbmRleCA0YWM0YzM0Li42OWQ5ZDAwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmgKQEAgLTkzLDYgKzkzLDgg QEAgcHJpdmF0ZToKICAgICB2b2lkIHVucmVnaXN0ZXJTY2hlbWVGb3JDdXN0b21Qcm90b2NvbChj b25zdCBTdHJpbmcmKTsKICNlbmRpZgogCisgICAgdm9pZCBhbGxvd1NwZWNpZmljSFRUUFNDZXJ0 aWZpY2F0ZUZvckhvc3QoY29uc3QgUGxhdGZvcm1DZXJ0aWZpY2F0ZUluZm8mLCBjb25zdCBTdHJp bmcmIGhvc3QpOworCiAgICAgLy8gUGxhdGZvcm0gSGVscGVycwogICAgIHZvaWQgcGxhdGZvcm1T ZXRDYWNoZU1vZGVsKENhY2hlTW9kZWwpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLm1lc3NhZ2VzLmluCmluZGV4IGJlOWMyNTQu LjU2NzY2ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdv cmtQcm9jZXNzLm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L05ldHdvcmtQcm9jZXNzLm1lc3NhZ2VzLmluCkBAIC00Myw2ICs0Myw4IEBAIG1lc3NhZ2VzIC0+ IE5ldHdvcmtQcm9jZXNzIHsKICAgICBSZWdpc3RlclNjaGVtZUZvckN1c3RvbVByb3RvY29sKFdU Rjo6U3RyaW5nIG5hbWUpCiAgICAgVW5yZWdpc3RlclNjaGVtZUZvckN1c3RvbVByb3RvY29sKFdU Rjo6U3RyaW5nIG5hbWUpCiAjZW5kaWYKKworICAgIEFsbG93U3BlY2lmaWNIVFRQU0NlcnRpZmlj YXRlRm9ySG9zdChXZWJLaXQ6OlBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvIGNlcnRpZmljYXRlLCBX VEY6OlN0cmluZyBob3N0KQogfQogCiAjZW5kaWYgLy8gRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL21hYy9OZXR3b3JrUHJv Y2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL21hYy9OZXR3b3JrUHJv Y2Vzc01hYy5tbQppbmRleCAxM2VkM2UxLi4zNWZkOGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9tYWMvTmV0d29ya1Byb2Nlc3NNYWMubW0KKysrIGIvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvbWFjL05ldHdvcmtQcm9jZXNzTWFjLm1tCkBAIC0yOSw3 ICsyOSw5IEBACiAjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKIAogI2ltcG9ydCAiTmV0d29y a1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaCIKKyNpbXBvcnQgIlBsYXRmb3JtQ2VydGlmaWNh dGVJbmZvLmgiCiAjaW1wb3J0ICJTYW5kYm94RXh0ZW5zaW9uLmgiCisjaW1wb3J0IDxGb3VuZGF0 aW9uL05TVVJMUmVxdWVzdFByaXZhdGUuaD4KICNpbXBvcnQgPFdlYkNvcmUvTG9jYWxpemVkU3Ry aW5ncy5oPgogI2ltcG9ydCA8V2ViS2l0U3lzdGVtSW50ZXJmYWNlLmg+CiAjaW1wb3J0IDxtYWNo L2hvc3RfaW5mby5oPgpAQCAtMTExLDYgKzExMywxMSBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpw bGF0Zm9ybVNldENhY2hlTW9kZWwoQ2FjaGVNb2RlbCBjYWNoZU1vZGVsKQogICAgIFtuc3VybENh Y2hlIHNldERpc2tDYXBhY2l0eTpzdGQ6Om1heDx1bnNpZ25lZCBsb25nPih1cmxDYWNoZURpc2tD YXBhY2l0eSwgW25zdXJsQ2FjaGUgZGlza0NhcGFjaXR5XSldOyAvLyBEb24ndCBzaHJpbmsgYSBi aWcgZGlzayBjYWNoZSwgc2luY2UgdGhhdCB3b3VsZCBjYXVzZSBjaHVybi4KIH0KIAordm9pZCBO ZXR3b3JrUHJvY2Vzczo6YWxsb3dTcGVjaWZpY0hUVFBTQ2VydGlmaWNhdGVGb3JIb3N0KGNvbnN0 IFBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvJiBjZXJ0aWZpY2F0ZUluZm8sIGNvbnN0IFN0cmluZyYg aG9zdCkKK3sKKyAgICBbTlNVUkxSZXF1ZXN0IHNldEFsbG93c1NwZWNpZmljSFRUUFNDZXJ0aWZp Y2F0ZTooTlNBcnJheSAqKWNlcnRpZmljYXRlSW5mby5jZXJ0aWZpY2F0ZUNoYWluKCkgZm9ySG9z dDooTlNTdHJpbmcgKilob3N0XTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKICNlbmRp ZiAvLyBFTkFCTEUoTkVUV09SS19QUk9DRVNTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0MvV0tDb250ZXh0LmNwcAppbmRleCAxYzRjM2I1Li40YjU1NDA4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmNwcApAQCAtMjY3LDYgKzI2NywxMSBA QCB2b2lkIFdLQ29udGV4dFNldEljb25EYXRhYmFzZVBhdGgoV0tDb250ZXh0UmVmIGNvbnRleHRS ZWYsIFdLU3RyaW5nUmVmIGljb25EYXRhYgogICAgIHRvSW1wbChjb250ZXh0UmVmKS0+c2V0SWNv bkRhdGFiYXNlUGF0aCh0b0ltcGwoaWNvbkRhdGFiYXNlUGF0aCktPnN0cmluZygpKTsKIH0KIAor dm9pZCBXS0NvbnRleHRBbGxvd1NwZWNpZmljSFRUUFNDZXJ0aWZpY2F0ZUZvckhvc3QoV0tDb250 ZXh0UmVmIGNvbnRleHRSZWYsIFdLQ2VydGlmaWNhdGVJbmZvUmVmIGNlcnRpZmljYXRlUmVmLCBX S1N0cmluZ1JlZiBob3N0UmVmKQoreworICAgIHRvSW1wbChjb250ZXh0UmVmKS0+YWxsb3dTcGVj aWZpY0hUVFBTQ2VydGlmaWNhdGVGb3JIb3N0KHRvSW1wbChjZXJ0aWZpY2F0ZVJlZiksIHRvSW1w bChob3N0UmVmKS0+c3RyaW5nKCkpOworfQorCiB2b2lkIFdLQ29udGV4dFNldERhdGFiYXNlRGly ZWN0b3J5KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1N0cmluZ1JlZiBkYXRhYmFzZURpcmVj dG9yeSkKIHsKICAgICB0b0ltcGwoY29udGV4dFJlZiktPnNldERhdGFiYXNlRGlyZWN0b3J5KHRv SW1wbChkYXRhYmFzZURpcmVjdG9yeSktPnN0cmluZygpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0UHJpdmF0ZS5oCmluZGV4IDc5YzJlZjUuLmM3Yzkw NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRQ cml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dFBy aXZhdGUuaApAQCAtNTYsNiArNTYsOCBAQCBXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRTZXREb21h aW5SZWxheGF0aW9uRm9yYmlkZGVuRm9yVVJMU2NoZW1lKFdLQ29udGV4dFJlZiBjbwogCiBXS19F WFBPUlQgdm9pZCBXS0NvbnRleHRTZXRJY29uRGF0YWJhc2VQYXRoKFdLQ29udGV4dFJlZiBjb250 ZXh0LCBXS1N0cmluZ1JlZiBpY29uRGF0YWJhc2VQYXRoKTsKIAorV0tfRVhQT1JUIHZvaWQgV0tD b250ZXh0QWxsb3dTcGVjaWZpY0hUVFBTQ2VydGlmaWNhdGVGb3JIb3N0KFdLQ29udGV4dFJlZiBj b250ZXh0LCBXS0NlcnRpZmljYXRlSW5mb1JlZiBjZXJ0aWZpY2F0ZSwgV0tTdHJpbmdSZWYgaG9z dCk7CisKIC8vIEZJWE1FOiBUaGVzZSBmdW5jdGlvbnMgYXJlIG9ubHkgZWZmZWN0aXZlIGlmIGNh bGxlZCBiZWZvcmUgdGhlIFdlYiBwcm9jZXNzIGlzIGxhdW5jaGVkLiBCdXQKIC8vIHdlIHNob3Vs ZCByZWFsbHkgY2hhbmdlIHRoZXNlIHNldHRpbmdzIHRvIGJlIG9uIFdlYlByZWZlcmVuY2VzIGFu ZCBjaGFuZ2VhYmxlIGF0IHJ1bnRpbWUuCiBXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRTZXREYXRh YmFzZURpcmVjdG9yeShXS0NvbnRleHRSZWYgY29udGV4dCwgV0tTdHJpbmdSZWYgZGF0YWJhc2VE aXJlY3RvcnkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRl eHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCmluZGV4IGJl ZDRiZmIuLmVlODg1YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJD b250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAK QEAgLTEwNDMsNiArMTA0MywxOCBAQCBTdHJpbmcgV2ViQ29udGV4dDo6Y29va2llU3RvcmFnZURp cmVjdG9yeSgpIGNvbnN0CiAgICAgcmV0dXJuIHBsYXRmb3JtRGVmYXVsdENvb2tpZVN0b3JhZ2VE aXJlY3RvcnkoKTsKIH0KIAordm9pZCBXZWJDb250ZXh0OjphbGxvd1NwZWNpZmljSFRUUFNDZXJ0 aWZpY2F0ZUZvckhvc3QoY29uc3QgV2ViQ2VydGlmaWNhdGVJbmZvKiBjZXJ0aWZpY2F0ZSwgY29u c3QgU3RyaW5nJiBob3N0KQoreworI2lmIEVOQUJMRShORVRXT1JLX1BST0NFU1MpCisgICAgaWYg KG1fdXNlc05ldHdvcmtQcm9jZXNzICYmIG1fbmV0d29ya1Byb2Nlc3MpIHsKKyAgICAgICAgbV9u ZXR3b3JrUHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6TmV0d29ya1Byb2Nlc3M6OkFsbG93U3BlY2lm aWNIVFRQU0NlcnRpZmljYXRlRm9ySG9zdChjZXJ0aWZpY2F0ZS0+cGxhdGZvcm1DZXJ0aWZpY2F0 ZUluZm8oKSwgaG9zdCksIDApOworICAgICAgICByZXR1cm47CisgICAgfQorI2VuZGlmCisgICAg Ly8gRklYTUU6IEl0J3MgdW5jbGVhciB3aGV0aGVyIHdlIHdhbnQgdGhpcyBTUEkgdG8gYmUgZXhw b3NlZCBhbmQgdXNlZCBmb3IgY2xpZW50cyB0aGF0IGRvbid0IHVzZSB0aGUgTmV0d29ya1Byb2Nl c3MuCisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cit9CisKIHZvaWQgV2ViQ29udGV4dDo6c2V0 SFRUUFBpcGVsaW5pbmdFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKICNpZiBQTEFURk9STShNQUMp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAppbmRleCAxNjU1MTM5Li4wNGExMWIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgKQEAgLTIyNyw2ICsyMjcsOCBA QCBwdWJsaWM6CiAgICAgdm9pZCBzZXREaXNrQ2FjaGVEaXJlY3RvcnkoY29uc3QgU3RyaW5nJiBk aXIpIHsgbV9vdmVycmlkZURpc2tDYWNoZURpcmVjdG9yeSA9IGRpcjsgfQogICAgIHZvaWQgc2V0 Q29va2llU3RvcmFnZURpcmVjdG9yeShjb25zdCBTdHJpbmcmIGRpcikgeyBtX292ZXJyaWRlQ29v a2llU3RvcmFnZURpcmVjdG9yeSA9IGRpcjsgfQogCisgICAgdm9pZCBhbGxvd1NwZWNpZmljSFRU UFNDZXJ0aWZpY2F0ZUZvckhvc3QoY29uc3QgV2ViQ2VydGlmaWNhdGVJbmZvKiwgY29uc3QgU3Ry aW5nJiBob3N0KTsKKwogICAgIFdlYlByb2Nlc3NQcm94eSogZW5zdXJlU2hhcmVkV2ViUHJvY2Vz cygpOwogICAgIFdlYlByb2Nlc3NQcm94eSogY3JlYXRlTmV3V2ViUHJvY2Vzc1Jlc3BlY3RpbmdQ cm9jZXNzQ291bnRMaW1pdCgpOyAvLyBXaWxsIHJldHVybiBhbiBleGlzdGluZyBvbmUgaWYgbGlt aXQgaXMgbWV0LgogICAgIHZvaWQgd2FybUluaXRpYWxQcm9jZXNzKCk7Cg==