105228 2012-12-17 16:29:30 -0800 [Chromium] Check Document now should work with continuous check off 2012-12-21 17:08:34 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 groby groby webkit.review.bot oldest_to_newest 793145 0 groby 2012-12-17 16:29:30 -0800 Users should be able to invoke "Check document now" even if "Check spelling while typing" is off. (crbug.com/161030) 793149 1 179829 groby 2012-12-17 16:33:58 -0800 Created attachment 179829 Patch 793157 2 179829 andersca 2012-12-17 16:41:41 -0800 Comment on attachment 179829 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179829&action=review > Source/WebKit/chromium/ChangeLog:3 > + [Chromium] Check Document now should work with continuous check of of->off 793168 3 179833 groby 2012-12-17 16:49:30 -0800 Created attachment 179833 Patch 793171 4 179833 groby 2012-12-17 16:50:36 -0800 Comment on attachment 179833 Patch Fixed spelling issue. 795160 5 179833 webkit.review.bot 2012-12-19 21:40:46 -0800 Comment on attachment 179833 Patch Clearing flags on attachment: 179833 Committed r138220: <http://trac.webkit.org/changeset/138220> 795161 6 webkit.review.bot 2012-12-19 21:40:49 -0800 All reviewed patches have been landed. Closing bug. 179829 2012-12-17 16:33:58 -0800 2012-12-17 16:49:29 -0800 Patch bug-105228-20121217163116.patch text/plain 1497 groby U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFkYmFhZWU0ZDNkNWRjODRiMzRlYjM2MjNhMGIyNzA5ZDk2ZWE1MTkuLmQ1MGM1OWMwNDZkYzIz NTdmMjA5MTQzZWI2ZGY5YzQ5ZjNlOWY2OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMTItMTcgIFJhY2hlbCBCbHVtICA8Z3JvYnlAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQ2hlY2sgRG9jdW1lbnQgbm93IHNob3VsZCB3b3Jr IHdpdGggY29udGludW91cyBjaGVjayBvZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBzcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkVkaXRvckNsaWVudEltcGw6OmNoZWNrU3BlbGxpbmdPZlN0cmluZyk6CisKIDIwMTIt MTItMTYgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFB1 c2ggcGl4ZWwgc25hcHBpbmcgbG9naWMgaW50byBUcmFuc2Zvcm1TdGF0ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcAppbmRleCAzMDQ2ZGIzMmU3 YjNhMTcyYTBhZWZiZmVlZWExN2MwNDc3YzhjODQ4Li43MGIyZmI3NjZiNzc5MjJlNTM0YzVhZTRh NzljMDE0NDExYWZiYWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9F ZGl0b3JDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0 b3JDbGllbnRJbXBsLmNwcApAQCAtNzI2LDcgKzcyNiw3IEBAIHZvaWQgRWRpdG9yQ2xpZW50SW1w bDo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKGNvbnN0IFVDaGFyKiB0ZXh0LCBpbnQgbGVuZ3RoLAog ICAgIGludCBzcGVsbExlbmd0aCA9IDA7CiAKICAgICAvLyBDaGVjayB0byBzZWUgaWYgdGhlIHBy b3ZpZGVkIHRleHQgaXMgc3BlbGxlZCBjb3JyZWN0bHkuCi0gICAgaWYgKGlzQ29udGludW91c1Nw ZWxsQ2hlY2tpbmdFbmFibGVkKCkgJiYgbV93ZWJWaWV3LT5zcGVsbENoZWNrQ2xpZW50KCkpCisg ICAgaWYgKG1fd2ViVmlldy0+c3BlbGxDaGVja0NsaWVudCgpKQogICAgICAgICBtX3dlYlZpZXct PnNwZWxsQ2hlY2tDbGllbnQoKS0+c3BlbGxDaGVjayhXZWJTdHJpbmcodGV4dCwgbGVuZ3RoKSwg c3BlbGxMb2NhdGlvbiwgc3BlbGxMZW5ndGgsIDApOwogICAgIGVsc2UgewogICAgICAgICBzcGVs bExvY2F0aW9uID0gMDsK 179833 2012-12-17 16:49:30 -0800 2012-12-19 21:40:46 -0800 Patch bug-105228-20121217164648.patch text/plain 1498 groby U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFkYmFhZWU0ZDNkNWRjODRiMzRlYjM2MjNhMGIyNzA5ZDk2ZWE1MTkuLjg0Y2MzNWQ2ODQ3MzYx YmNhOTMwODk2MDUwNDVjMjkzMTU5ZWJiNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMTItMTcgIFJhY2hlbCBCbHVtICA8Z3JvYnlAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQ2hlY2sgRG9jdW1lbnQgbm93IHNob3VsZCB3b3Jr IHdpdGggY29udGludW91cyBjaGVjayBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwNTIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogc3JjL0VkaXRvckNsaWVudEltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpFZGl0b3JDbGllbnRJbXBsOjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcpOgorCiAyMDEy LTEyLTE2ICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBQ dXNoIHBpeGVsIHNuYXBwaW5nIGxvZ2ljIGludG8gVHJhbnNmb3JtU3RhdGUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuY3BwIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHAKaW5kZXggMzA0NmRiMzJl N2IzYTE3MmEwYWVmYmZlZWVhMTdjMDQ3N2M4Yzg0OC4uNzBiMmZiNzY2Yjc3OTIyZTUzNGM1YWU0 YTc5YzAxNDQxMWFmYmFkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv RWRpdG9yQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRp dG9yQ2xpZW50SW1wbC5jcHAKQEAgLTcyNiw3ICs3MjYsNyBAQCB2b2lkIEVkaXRvckNsaWVudElt cGw6OmNoZWNrU3BlbGxpbmdPZlN0cmluZyhjb25zdCBVQ2hhciogdGV4dCwgaW50IGxlbmd0aCwK ICAgICBpbnQgc3BlbGxMZW5ndGggPSAwOwogCiAgICAgLy8gQ2hlY2sgdG8gc2VlIGlmIHRoZSBw cm92aWRlZCB0ZXh0IGlzIHNwZWxsZWQgY29ycmVjdGx5LgotICAgIGlmIChpc0NvbnRpbnVvdXNT cGVsbENoZWNraW5nRW5hYmxlZCgpICYmIG1fd2ViVmlldy0+c3BlbGxDaGVja0NsaWVudCgpKQor ICAgIGlmIChtX3dlYlZpZXctPnNwZWxsQ2hlY2tDbGllbnQoKSkKICAgICAgICAgbV93ZWJWaWV3 LT5zcGVsbENoZWNrQ2xpZW50KCktPnNwZWxsQ2hlY2soV2ViU3RyaW5nKHRleHQsIGxlbmd0aCks IHNwZWxsTG9jYXRpb24sIHNwZWxsTGVuZ3RoLCAwKTsKICAgICBlbHNlIHsKICAgICAgICAgc3Bl bGxMb2NhdGlvbiA9IDA7Cg==