105224 2012-12-17 15:52:54 -0800 Enable autoplay when <video>'s src is from media stream 2013-01-23 20:57:36 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wjia wjia abarth eric.carlson feature-media-reviews laszlo.gombos ojan.autocc tommyw webkit.review.bot oldest_to_newest 793105 0 wjia 2012-12-17 15:52:54 -0800 The autoplay is disabled on some platform, e.g., Chromium on Android. When <video>'s src is from media stream, autoplay should be allowed to avoid requesting multiple gestures, since user could have gesture for device access permission. 793115 1 179820 wjia 2012-12-17 15:58:42 -0800 Created attachment 179820 Patch 795507 2 wjia 2012-12-20 09:50:37 -0800 ping. 805503 3 179820 abarth 2013-01-11 12:13:10 -0800 Comment on attachment 179820 Patch Can we test this change? 805615 4 wjia 2013-01-11 14:20:16 -0800 In my local build of Chrome on Android, this patch works. Not sure how to add an auto test for this. 805626 5 eric.carlson 2013-01-11 14:34:45 -0800 (In reply to comment #4) > In my local build of Chrome on Android, this patch works. Not sure how to add an auto test for this. Couldn't you use internals.settings.setMediaPlaybackRequiresUserGesture()? See LayoutTests/media/no-autoplay-with-user-gesture-requirement.html for an example. 813282 6 184029 wjia 2013-01-22 11:48:40 -0800 Created attachment 184029 Patch 813284 7 wjia 2013-01-22 11:50:12 -0800 The test has been added by utilizing platform/chromium/media/video-capture-preview.html in second patch. Please take another look. 813401 8 184029 abarth 2013-01-22 14:14:36 -0800 Comment on attachment 184029 Patch Looks reasonable to me, but I'm not an expert on this code. 814667 9 184029 eric.carlson 2013-01-23 14:50:17 -0800 Comment on attachment 184029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184029&action=review > Source/WebCore/html/HTMLMediaElement.cpp:1027 > +#if ENABLE(MEDIA_STREAM) > + if (MediaStreamRegistry::registry().lookupMediaStreamDescriptor(url.string())) > + removeBehaviorRestriction(RequireUserGestureForRateChangeRestriction); > +#endif Does MediaStreamRegistry::registry().lookupMediaStreamDescriptor() returning true *always* mean that the user has been prompted? 814733 10 wjia 2013-01-23 15:22:15 -0800 (In reply to comment #9) > (From update of attachment 184029 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184029&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:1027 > > +#if ENABLE(MEDIA_STREAM) > > + if (MediaStreamRegistry::registry().lookupMediaStreamDescriptor(url.string())) > > + removeBehaviorRestriction(RequireUserGestureForRateChangeRestriction); > > +#endif > > Does MediaStreamRegistry::registry().lookupMediaStreamDescriptor() returning true *always* mean that the user has been prompted? Yes. That's described in http://www.w3.org/TR/mediacapture-streams/. More specifically, getUserMedia prompts the user for permission to use their Web cam or other video or audio input. 814986 11 184029 webkit.review.bot 2013-01-23 20:01:32 -0800 Comment on attachment 184029 Patch Rejecting attachment 184029 from commit-queue. wjia@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 815026 12 184029 webkit.review.bot 2013-01-23 20:57:32 -0800 Comment on attachment 184029 Patch Clearing flags on attachment: 184029 Committed r140645: <http://trac.webkit.org/changeset/140645> 815027 13 webkit.review.bot 2013-01-23 20:57:36 -0800 All reviewed patches have been landed. Closing bug. 179820 2012-12-17 15:58:42 -0800 2013-01-22 11:48:38 -0800 Patch bug-105224-20121217155600.patch text/plain 1682 wjia SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzk1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTE3ICBXZWkgSmlh ICA8d2ppYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRW5hYmxlIGF1dG9wbGF5IHdoZW4gPHZp ZGVvPidzIHNyYyBpcyBmcm9tIG1lZGlhIHN0cmVhbQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIGF1dG9wbGF5IHdoZW4gPHZpZGVvPidzIHNy YyBpcyBmcm9tIG1lZGlhIHN0cmVhbS4gVGhpcyB3b3VsZCBhdm9pZCByZXF1ZXN0aW5nIG11bHRp cGxlIGdlc3R1cmVzIHdoZW4gPHZpZGVvPiBpcyB1c2VkIGZvciBXZWJSVEMuCisKKyAgICAgICAg KiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6bG9hZFJlc291cmNlKToKKwogMjAxMi0xMi0xNyAgSmFlaHVuIExpbSAgPGxqYWVo dW4ubGltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIENoYW5nZSBTRVRfVkFSLCBTRVRfQk9SREVS VkFMVUVfQ09MT1IgbWFjcm8gdG8gcmVxdWlyZSBzZW1pY29sb24oOykgYXQgdGhlIGVuZCBvZiB0 aGUgbGluZQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShy ZXZpc2lvbiAxMzc5NTIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjEsNiArMTIxLDEwIEBACiAjaW5jbHVkZSAiTWVkaWFT b3VyY2VSZWdpc3RyeS5oIgogI2VuZGlmCiAKKyNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQorI2lu Y2x1ZGUgIk1lZGlhU3RyZWFtUmVnaXN0cnkuaCIKKyNlbmRpZgorCiB1c2luZyBuYW1lc3BhY2Ug c3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC05OTgsNiArMTAwMiwxMSBAQCB2b2lkIEhU TUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZShjb25zCiAKICAgICBMT0coTWVkaWEsICJIVE1M TWVkaWFFbGVtZW50Ojpsb2FkUmVzb3VyY2UgLSBtX2N1cnJlbnRTcmMgLT4gJXMiLCB1cmxGb3JM b2dnaW5nTWVkaWEobV9jdXJyZW50U3JjKS51dGY4KCkuZGF0YSgpKTsKIAorI2lmIEVOQUJMRShN RURJQV9TVFJFQU0pCisgICAgaWYgKE1lZGlhU3RyZWFtUmVnaXN0cnk6OnJlZ2lzdHJ5KCkubG9v a3VwTWVkaWFTdHJlYW1EZXNjcmlwdG9yKHVybC5zdHJpbmcoKSkpCisgICAgICAgIHJlbW92ZUJl aGF2aW9yUmVzdHJpY3Rpb24oUmVxdWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZVJlc3RyaWN0 aW9uKTsKKyNlbmRpZgorCiAgICAgaWYgKG1fc2VuZFByb2dyZXNzRXZlbnRzKSAKICAgICAgICAg c3RhcnRQcm9ncmVzc0V2ZW50VGltZXIoKTsKIAo= 184029 2013-01-22 11:48:40 -0800 2013-01-23 20:57:32 -0800 Patch bug-105224-20130122114535.patch text/plain 2985 wjia SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDQ0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTIyICBXZWkgSmlh ICA8d2ppYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRW5hYmxlIGF1dG9wbGF5IHdoZW4gPHZp ZGVvPidzIHNyYyBpcyBmcm9tIG1lZGlhIHN0cmVhbQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIGF1dG9wbGF5IHdoZW4gPHZpZGVvPidzIHNy YyBpcyBmcm9tIG1lZGlhIHN0cmVhbS4gVGhpcyB3b3VsZCBhdm9pZCByZXF1ZXN0aW5nIG11bHRp cGxlIGdlc3R1cmVzIHdoZW4gPHZpZGVvPiBpcyB1c2VkIGZvciBXZWJSVEMuCisgICAgICAgIFRo ZSB0ZXN0IGlzIGRvbmUgYnkgbW9kaWZ5aW5nIHBsYXRmb3JtL2Nocm9taXVtL21lZGlhL3ZpZGVv LWNhcHR1cmUtcHJldmlldy5odG1sLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZSk6 CisKIDIwMTMtMDEtMjIgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW1NvdXBdIFJhbmRvbSB0aHJlYWQgY3Jhc2hlcwpJbmRleDogU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNDA0NDUpCisrKyBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MjEsNiArMTIxLDEwIEBACiAjaW5jbHVkZSAiTWVkaWFTb3VyY2VSZWdpc3RyeS5oIgogI2VuZGlm CiAKKyNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQorI2luY2x1ZGUgIk1lZGlhU3RyZWFtUmVnaXN0 cnkuaCIKKyNlbmRpZgorCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CkBAIC0xMDE3LDYgKzEwMjEsMTEgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpsb2FkUmVz b3VyY2UoY29ucwogCiAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6bG9hZFJlc291 cmNlIC0gbV9jdXJyZW50U3JjIC0+ICVzIiwgdXJsRm9yTG9nZ2luZ01lZGlhKG1fY3VycmVudFNy YykudXRmOCgpLmRhdGEoKSk7CiAKKyNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQorICAgIGlmIChN ZWRpYVN0cmVhbVJlZ2lzdHJ5OjpyZWdpc3RyeSgpLmxvb2t1cE1lZGlhU3RyZWFtRGVzY3JpcHRv cih1cmwuc3RyaW5nKCkpKQorICAgICAgICByZW1vdmVCZWhhdmlvclJlc3RyaWN0aW9uKFJlcXVp cmVVc2VyR2VzdHVyZUZvclJhdGVDaGFuZ2VSZXN0cmljdGlvbik7CisjZW5kaWYKKwogICAgIGlm IChtX3NlbmRQcm9ncmVzc0V2ZW50cykgCiAgICAgICAgIHN0YXJ0UHJvZ3Jlc3NFdmVudFRpbWVy KCk7CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDQ0NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTIyICBXZWkgSmlhICA8 d2ppYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRW5hYmxlIGF1dG9wbGF5IHdoZW4gPHZpZGVv PidzIHNyYyBpcyBmcm9tIG1lZGlhIHN0cmVhbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWx3YXlzIHR1cm5zIG9uIG1lZGlhUGxheWJhY2tSZXF1aXJl c1VzZXJHZXN0dXJlIGF0IHRoZSBiZWdpbm5pbmcuCisgICAgICAgIEhUTUxNZWRpYUVsZW1lbnQg aXMgc3VwcG9zZWQgdG8gdHVybiBpdCBvZmYgd2hlbiA8dmlkZW8+J3Mgc3JjIGlzIGZyb20gbWVk aWEgc3RyZWFtLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL21lZGlhL3ZpZGVvLWNhcHR1 cmUtcHJldmlldy5odG1sOgorCiAyMDEzLTAxLTIyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQw NDM1LgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vbWVkaWEvdmlkZW8tY2Fw dHVyZS1wcmV2aWV3Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vbWVkaWEvdmlkZW8tY2FwdHVyZS1wcmV2aWV3Lmh0bWwJKHJldmlzaW9uIDE0MDQ0NSkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL21lZGlhL3ZpZGVvLWNhcHR1cmUtcHJl dmlldy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMCw2ICsxMCw5IEBACiB2YXIgcHJldmlld1VS TCA9ICIiOwogdmFyIGxvY2FsU3RyZWFtID0gbnVsbDsKIAoraWYgKHdpbmRvdy5pbnRlcm5hbHMp IAorICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0TWVkaWFQbGF5YmFja1JlcXVpcmVz VXNlckdlc3R1cmUodHJ1ZSk7CisKIGZ1bmN0aW9uIHN0YXJ0UHJldmlldygpCiB7CiAgICAgdmlk ZW8uc3JjID0gcHJldmlld1VSTDsK