105218 2012-12-17 14:56:50 -0800 [ANGLE] Use of uninitialized memory in ArrayBoundsClamper 2012-12-21 17:45:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98977 1 mvujovic mvujovic achicu dino eric.carlson feature-media-reviews kbr webkit.review.bot zmo oldest_to_newest 793059 0 mvujovic 2012-12-17 14:56:50 -0800 TIntermBinary::addIndexClamp is uninitialized when the compile flag SH_CLAMP_INDIRECT_ARRAY_BOUNDS is not set. Then, addIndexClamp is used in OutputGLSLBase. CSS Shaders needs to do a first validation pass without the SH_CLAMP_INDIRECT_ARRAY_BOUNDS flag and its effects. However, sometimes addIndexClamp is true, which inserts clamping code that causes the a shader to fail compilation at the WebGL level. Patch coming up. 793064 1 179808 mvujovic 2012-12-17 15:08:17 -0800 Created attachment 179808 Patch Style bot never likes ANGLE changes, so please ignore her. 793068 2 webkit.review.bot 2012-12-17 15:09:47 -0800 Attachment 179808 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/intermediate.h:392: Missing space inside { }. [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 793081 3 dino 2012-12-17 15:27:38 -0800 We should make sure this gets back to ANGLE. Unfortunately I cannot contribute to ANGLE under its current license, but any code changes in WebKit are available under a BSD license. So Max, maybe you could contribute this and the original array clamper? 793088 4 mvujovic 2012-12-17 15:36:11 -0800 Thanks for the review! (In reply to comment #3) > We should make sure this gets back to ANGLE. > > Unfortunately I cannot contribute to ANGLE under its current license, but any code changes in WebKit are available under a BSD license. So Max, maybe you could contribute this and the original array clamper? Yes, definitely. I can do that. If there's no hurry right now, I'll plan on doing it early January when I get back from holiday break. 793200 5 179808 buildbot 2012-12-17 17:30:42 -0800 Comment on attachment 179808 Patch Attachment 179808 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15371922 New failing tests: inspector/profiler/heap-snapshot.html 793726 6 179960 mvujovic 2012-12-18 09:29:13 -0800 Created attachment 179960 Patch EWS failure seems unrelated. Running it again to double check. 793729 7 webkit.review.bot 2012-12-18 09:32:48 -0800 Attachment 179960 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/intermediate.h:392: Missing space inside { }. [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 793850 8 179960 mvujovic 2012-12-18 11:13:43 -0800 Comment on attachment 179960 Patch Bots are green. Setting cq+. 793856 9 179960 webkit.review.bot 2012-12-18 11:16:36 -0800 Comment on attachment 179960 Patch Rejecting attachment 179960 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Source/ThirdParty/ANGLE/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15418181 793863 10 179983 mvujovic 2012-12-18 11:24:30 -0800 Created attachment 179983 Patch Add reviewer entry in ChangeLog. 793869 11 webkit.review.bot 2012-12-18 11:27:39 -0800 Attachment 179983 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/intermediate.h:392: Missing space inside { }. [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 793893 12 179983 webkit.review.bot 2012-12-18 11:48:27 -0800 Comment on attachment 179983 Patch Clearing flags on attachment: 179983 Committed r138048: <http://trac.webkit.org/changeset/138048> 793894 13 webkit.review.bot 2012-12-18 11:48:31 -0800 All reviewed patches have been landed. Closing bug. 179808 2012-12-17 15:08:17 -0800 2012-12-18 09:29:13 -0800 Patch 105218-1.patch text/plain 1652 mvujovic ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCA0Zjk2NGU4Li5iNWRhNmFhIDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTItMTcgIE1heCBW dWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAgICAgIFtBTkdMRV0gVXNlIG9mIHVu aW5pdGlhbGl6ZWQgbWVtb3J5IGluIEFycmF5Qm91bmRzQ2xhbXBlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjE4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVEludGVybUJpbmFyeTo6YWRkSW5kZXhD bGFtcCBpcyB1bmluaXRpYWxpemVkIHdoZW4gdGhlIGNvbXBpbGUgZmxhZyAKKyAgICAgICAgU0hf Q0xBTVBfSU5ESVJFQ1RfQVJSQVlfQk9VTkRTIGlzIG5vdCBzZXQuIFRoZW4sIGFkZEluZGV4Q2xh bXAgaXMgdXNlZCBpbiBPdXRwdXRHTFNMQmFzZS4gCisgICAgICAgIENTUyBTaGFkZXJzIG5lZWRz IHRvIGRvIGEgZmlyc3QgdmFsaWRhdGlvbiBwYXNzIHdpdGhvdXQgdGhlIFNIX0NMQU1QX0lORElS RUNUX0FSUkFZX0JPVU5EUyAKKyAgICAgICAgZmxhZyBhbmQgaXRzIGVmZmVjdHMuIEhvd2V2ZXIs IHNvbWV0aW1lcyBhZGRJbmRleENsYW1wIGlzIHRydWUsIHdoaWNoIGluc2VydHMgY2xhbXBpbmcg Y29kZQorICAgICAgICB0aGF0IGNhdXNlcyBhIHNoYWRlciB0byBmYWlsIGNvbXBpbGF0aW9uIGF0 IHRoZSBXZWJHTCBsZXZlbC4KKworICAgICAgICAqIHNyYy9jb21waWxlci9pbnRlcm1lZGlhdGUu aDoKKyAgICAgICAgKFRJbnRlcm1CaW5hcnk6OlRJbnRlcm1CaW5hcnkpOgorCiAyMDEyLTEwLTI5 ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQg V2ViS2l0IGFzIEMrKzExIG9uIE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2NvbXBpbGVyL2ludGVybWVkaWF0ZS5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2NvbXBpbGVyL2ludGVybWVkaWF0ZS5oCmluZGV4IDllOWFiYmMuLmU2M2Q0MjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9pbnRlcm1lZGlhdGUu aAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvaW50ZXJtZWRpYXRl LmgKQEAgLTM4OSw3ICszODksNyBAQCBwcm90ZWN0ZWQ6CiAvLwogY2xhc3MgVEludGVybUJpbmFy eSA6IHB1YmxpYyBUSW50ZXJtT3BlcmF0b3IgewogcHVibGljOgotICAgIFRJbnRlcm1CaW5hcnko VE9wZXJhdG9yIG8pIDogVEludGVybU9wZXJhdG9yKG8pIHt9CisgICAgVEludGVybUJpbmFyeShU T3BlcmF0b3IgbykgOiBUSW50ZXJtT3BlcmF0b3IobyksIGFkZEluZGV4Q2xhbXAoZmFsc2UpIHt9 CiAKICAgICB2aXJ0dWFsIFRJbnRlcm1CaW5hcnkqIGdldEFzQmluYXJ5Tm9kZSgpIHsgcmV0dXJu IHRoaXM7IH0KICAgICB2aXJ0dWFsIHZvaWQgdHJhdmVyc2UoVEludGVybVRyYXZlcnNlciopOwo= 179960 2012-12-18 09:29:13 -0800 2012-12-18 11:24:30 -0800 Patch 105218-1.patch text/plain 1652 mvujovic ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCA0Zjk2NGU4Li5iNWRhNmFhIDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTItMTcgIE1heCBW dWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAgICAgIFtBTkdMRV0gVXNlIG9mIHVu aW5pdGlhbGl6ZWQgbWVtb3J5IGluIEFycmF5Qm91bmRzQ2xhbXBlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjE4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVEludGVybUJpbmFyeTo6YWRkSW5kZXhD bGFtcCBpcyB1bmluaXRpYWxpemVkIHdoZW4gdGhlIGNvbXBpbGUgZmxhZyAKKyAgICAgICAgU0hf Q0xBTVBfSU5ESVJFQ1RfQVJSQVlfQk9VTkRTIGlzIG5vdCBzZXQuIFRoZW4sIGFkZEluZGV4Q2xh bXAgaXMgdXNlZCBpbiBPdXRwdXRHTFNMQmFzZS4gCisgICAgICAgIENTUyBTaGFkZXJzIG5lZWRz IHRvIGRvIGEgZmlyc3QgdmFsaWRhdGlvbiBwYXNzIHdpdGhvdXQgdGhlIFNIX0NMQU1QX0lORElS RUNUX0FSUkFZX0JPVU5EUyAKKyAgICAgICAgZmxhZyBhbmQgaXRzIGVmZmVjdHMuIEhvd2V2ZXIs IHNvbWV0aW1lcyBhZGRJbmRleENsYW1wIGlzIHRydWUsIHdoaWNoIGluc2VydHMgY2xhbXBpbmcg Y29kZQorICAgICAgICB0aGF0IGNhdXNlcyBhIHNoYWRlciB0byBmYWlsIGNvbXBpbGF0aW9uIGF0 IHRoZSBXZWJHTCBsZXZlbC4KKworICAgICAgICAqIHNyYy9jb21waWxlci9pbnRlcm1lZGlhdGUu aDoKKyAgICAgICAgKFRJbnRlcm1CaW5hcnk6OlRJbnRlcm1CaW5hcnkpOgorCiAyMDEyLTEwLTI5 ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQg V2ViS2l0IGFzIEMrKzExIG9uIE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2NvbXBpbGVyL2ludGVybWVkaWF0ZS5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2NvbXBpbGVyL2ludGVybWVkaWF0ZS5oCmluZGV4IDllOWFiYmMuLmU2M2Q0MjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9pbnRlcm1lZGlhdGUu aAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvaW50ZXJtZWRpYXRl LmgKQEAgLTM4OSw3ICszODksNyBAQCBwcm90ZWN0ZWQ6CiAvLwogY2xhc3MgVEludGVybUJpbmFy eSA6IHB1YmxpYyBUSW50ZXJtT3BlcmF0b3IgewogcHVibGljOgotICAgIFRJbnRlcm1CaW5hcnko VE9wZXJhdG9yIG8pIDogVEludGVybU9wZXJhdG9yKG8pIHt9CisgICAgVEludGVybUJpbmFyeShU T3BlcmF0b3IgbykgOiBUSW50ZXJtT3BlcmF0b3IobyksIGFkZEluZGV4Q2xhbXAoZmFsc2UpIHt9 CiAKICAgICB2aXJ0dWFsIFRJbnRlcm1CaW5hcnkqIGdldEFzQmluYXJ5Tm9kZSgpIHsgcmV0dXJu IHRoaXM7IH0KICAgICB2aXJ0dWFsIHZvaWQgdHJhdmVyc2UoVEludGVybVRyYXZlcnNlciopOwo= 179983 2012-12-18 11:24:30 -0800 2012-12-18 11:48:27 -0800 Patch 105218-2.patch text/plain 1650 mvujovic ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCA0Zjk2NGU4Li4yOTg3YzBkIDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTItMTcgIE1heCBW dWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAgICAgIFtBTkdMRV0gVXNlIG9mIHVu aW5pdGlhbGl6ZWQgbWVtb3J5IGluIEFycmF5Qm91bmRzQ2xhbXBlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjE4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgRGVhbiBKYWNrc29uLgorCisgICAgICAgIFRJbnRlcm1CaW5hcnk6OmFkZEluZGV4Q2xh bXAgaXMgdW5pbml0aWFsaXplZCB3aGVuIHRoZSBjb21waWxlIGZsYWcgCisgICAgICAgIFNIX0NM QU1QX0lORElSRUNUX0FSUkFZX0JPVU5EUyBpcyBub3Qgc2V0LiBUaGVuLCBhZGRJbmRleENsYW1w IGlzIHVzZWQgaW4gT3V0cHV0R0xTTEJhc2UuIAorICAgICAgICBDU1MgU2hhZGVycyBuZWVkcyB0 byBkbyBhIGZpcnN0IHZhbGlkYXRpb24gcGFzcyB3aXRob3V0IHRoZSBTSF9DTEFNUF9JTkRJUkVD VF9BUlJBWV9CT1VORFMgCisgICAgICAgIGZsYWcgYW5kIGl0cyBlZmZlY3RzLiBIb3dldmVyLCBz b21ldGltZXMgYWRkSW5kZXhDbGFtcCBpcyB0cnVlLCB3aGljaCBpbnNlcnRzIGNsYW1waW5nIGNv ZGUKKyAgICAgICAgdGhhdCBjYXVzZXMgYSBzaGFkZXIgdG8gZmFpbCBjb21waWxhdGlvbiBhdCB0 aGUgV2ViR0wgbGV2ZWwuCisKKyAgICAgICAgKiBzcmMvY29tcGlsZXIvaW50ZXJtZWRpYXRlLmg6 CisgICAgICAgIChUSW50ZXJtQmluYXJ5OjpUSW50ZXJtQmluYXJ5KToKKwogMjAxMi0xMC0yOSAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIFdl YktpdCBhcyBDKysxMSBvbiBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9jb21waWxlci9pbnRlcm1lZGlhdGUuaCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3Ny Yy9jb21waWxlci9pbnRlcm1lZGlhdGUuaAppbmRleCA5ZTlhYmJjLi5lNjNkNDI1IDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvaW50ZXJtZWRpYXRlLmgK KysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL2ludGVybWVkaWF0ZS5o CkBAIC0zODksNyArMzg5LDcgQEAgcHJvdGVjdGVkOgogLy8KIGNsYXNzIFRJbnRlcm1CaW5hcnkg OiBwdWJsaWMgVEludGVybU9wZXJhdG9yIHsKIHB1YmxpYzoKLSAgICBUSW50ZXJtQmluYXJ5KFRP cGVyYXRvciBvKSA6IFRJbnRlcm1PcGVyYXRvcihvKSB7fQorICAgIFRJbnRlcm1CaW5hcnkoVE9w ZXJhdG9yIG8pIDogVEludGVybU9wZXJhdG9yKG8pLCBhZGRJbmRleENsYW1wKGZhbHNlKSB7fQog CiAgICAgdmlydHVhbCBUSW50ZXJtQmluYXJ5KiBnZXRBc0JpbmFyeU5vZGUoKSB7IHJldHVybiB0 aGlzOyB9CiAgICAgdmlydHVhbCB2b2lkIHRyYXZlcnNlKFRJbnRlcm1UcmF2ZXJzZXIqKTsK