105217 2012-12-17 14:31:58 -0800 Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100) 2012-12-17 15:29:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth dpranke pdr webkit.review.bot oldest_to_newest 793038 0 eric 2012-12-17 14:31:58 -0800 Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100) 793041 1 179804 eric 2012-12-17 14:34:03 -0800 Created attachment 179804 Patch 793044 2 179804 dpranke 2012-12-17 14:36:46 -0800 Comment on attachment 179804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179804&action=review > Tools/Scripts/webkitpy/common/system/profiler.py:89 > + # FIXME: Currently all reports are kept as test.*, until we fix that, search more than 100 names before giving up. Nit: "search up to 1000 names" rather than "search more than 100 names" ? > Tools/Scripts/webkitpy/common/system/profiler.py:173 > + print # An extra line between tests looks nicer. Nit: I wouldn't bother w/ the comment here ... 793047 3 179805 eric 2012-12-17 14:38:15 -0800 Created attachment 179805 Patch for landing 793082 4 179805 webkit.review.bot 2012-12-17 15:29:13 -0800 Comment on attachment 179805 Patch for landing Clearing flags on attachment: 179805 Committed r137952: <http://trac.webkit.org/changeset/137952> 793083 5 webkit.review.bot 2012-12-17 15:29:16 -0800 All reviewed patches have been landed. Closing bug. 179804 2012-12-17 14:34:03 -0800 2012-12-17 14:38:13 -0800 Patch bug-105217-20121217143121.patch text/plain 3657 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU1MDc0MTc4ZTc4OWE0MGQ0MGM4ZmMxNGQ3ZWU1Yjkx ZmU2M2JlNi4uMWEzNDQ2NDMzOGRlNTI0ZTcyZmRkNTQ4YWYxYTEzODkxNTk3ODM3MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDEyLTEyLTE3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAorICAgICAg ICBDbGVhbnVwIC0tcHJvZmlsZXI9cGVyZiBjb2RlIGEgbGl0dGxlIGFuZCBhbGxvdyB1cCB0byAx MDAwIHJlcG9ydCBmaWxlcyAoaW5zdGVhZCBvZiAxMDApCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyMTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5IC0tcHJvZmlsZSB3b3VsZCBmYWls IHN0cmFuZ2VseSBpZiBmaW5kX3VudXNlZF9maWxlbmFtZSByZXR1cm5lZCBOb25lCisgICAgICAg ICh3aGljaCB3b3VsZCBoYXBwZW4gYXMgc29vbiBhcyB3ZSBoYWQgMTAwIHJlcG9ydCBmaWxlcyku CisgICAgICAgIE5vdyB3ZSdsbCBzZWFyY2ggdGhyb3VnaCAxMDAwIGZpbGVuYW1lcyBiZWZvcmUg Z2l2aW5nIHVwIChhbmQgYXNzZXJ0IGlmIHdlIGZhaWxlZCB0byBmaW5kIG9uZSkuCisgICAgICAg IEkgYWxzbyBtYWRlIHNvbWUgbWlub3IgY2xlYW51cHMgdG8gdGhlIG91dHB1dCBvZiBwZXJmLCBh bmQgdHJpZWQgdG8gbWFrZSB0aGUKKyAgICAgICAgY29tbWFuZHMgbW9yZSBzZWxmLWRvY3VtZW50 aW5nIGJ5IHVzaW5nIGxvbmctbmFtZXMgZm9yIGFyZ3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vcHJvZmlsZXIucHk6CisgICAgICAgIChTaW5nbGVGaWxlT3V0 cHV0UHJvZmlsZXIuX19pbml0X18pOgorICAgICAgICAoUGVyZi5hdHRhY2hfdG9fcGlkKToKKyAg ICAgICAgKFBlcmYucHJvZmlsZV9hZnRlcl9leGl0KToKKworMjAxMi0xMi0xNyAgRXJpYyBTZWlk ZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgcnB0IC0tcHJvZmlsZSAtLWNocm9taXVt LWFuZHJvaWQgdGhyb3dzIGV4Y2VwdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MDYxCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9wcm9maWxlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS9wcm9maWxlci5weQppbmRleCBlMzA2N2NjMDdhZWMzYjVhZjM1NWY2ODg1 NjU5ZmZmYTY1N2YzZGJiLi5hYzUwZmFjNTNlN2Q5OTIxOWVmMTRjM2QzN2FhMTE3ZDgwOWU0MzI0 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcHJvZmls ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3Byb2ZpbGVy LnB5CkBAIC04Niw3ICs4Niw5IEBAIGNsYXNzIFByb2ZpbGVyKG9iamVjdCk6CiBjbGFzcyBTaW5n bGVGaWxlT3V0cHV0UHJvZmlsZXIoUHJvZmlsZXIpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBo b3N0LCBleGVjdXRhYmxlX3BhdGgsIG91dHB1dF9kaXIsIG91dHB1dF9zdWZmaXgsIGlkZW50aWZp ZXI9Tm9uZSk6CiAgICAgICAgIHN1cGVyKFNpbmdsZUZpbGVPdXRwdXRQcm9maWxlciwgc2VsZiku X19pbml0X18oaG9zdCwgZXhlY3V0YWJsZV9wYXRoLCBvdXRwdXRfZGlyLCBpZGVudGlmaWVyKQot ICAgICAgICBzZWxmLl9vdXRwdXRfcGF0aCA9IHNlbGYuX2hvc3Qud29ya3NwYWNlLmZpbmRfdW51 c2VkX2ZpbGVuYW1lKHNlbGYuX291dHB1dF9kaXIsIHNlbGYuX2lkZW50aWZpZXIsIG91dHB1dF9z dWZmaXgpCisgICAgICAgICMgRklYTUU6IEN1cnJlbnRseSBhbGwgcmVwb3J0cyBhcmUga2VwdCBh cyB0ZXN0LiosIHVudGlsIHdlIGZpeCB0aGF0LCBzZWFyY2ggbW9yZSB0aGFuIDEwMCBuYW1lcyBi ZWZvcmUgZ2l2aW5nIHVwLgorICAgICAgICBzZWxmLl9vdXRwdXRfcGF0aCA9IHNlbGYuX2hvc3Qu d29ya3NwYWNlLmZpbmRfdW51c2VkX2ZpbGVuYW1lKHNlbGYuX291dHB1dF9kaXIsIHNlbGYuX2lk ZW50aWZpZXIsIG91dHB1dF9zdWZmaXgsIHNlYXJjaF9saW1pdD0xMDAwKQorICAgICAgICBhc3Nl cnQoc2VsZi5fb3V0cHV0X3BhdGgpCiAKIAogY2xhc3MgR29vZ2xlUFByb2YoU2luZ2xlRmlsZU91 dHB1dFByb2ZpbGVyKToKQEAgLTEzOSw3ICsxNDEsNyBAQCBjbGFzcyBQZXJmKFNpbmdsZUZpbGVP dXRwdXRQcm9maWxlcik6CiAgICAgZGVmIGF0dGFjaF90b19waWQoc2VsZiwgcGlkKToKICAgICAg ICAgYXNzZXJ0KG5vdCBzZWxmLl9wZXJmX3Byb2Nlc3MgYW5kIG5vdCBzZWxmLl9waWRfYmVpbmdf cHJvZmlsZWQpCiAgICAgICAgIHNlbGYuX3BpZF9iZWluZ19wcm9maWxlZCA9IHBpZAotICAgICAg ICBjbWQgPSBbc2VsZi5fcGVyZl9wYXRoKCksICJyZWNvcmQiLCAiLWciLCAiLXAiLCBwaWQsICIt byIsIHNlbGYuX291dHB1dF9wYXRoXQorICAgICAgICBjbWQgPSBbc2VsZi5fcGVyZl9wYXRoKCks ICJyZWNvcmQiLCAiLS1jYWxsLWdyYXBoIiwgIi0tcGlkIiwgcGlkLCAiLS1vdXRwdXQiLCBzZWxm Ll9vdXRwdXRfcGF0aF0KICAgICAgICAgc2VsZi5fcGVyZl9wcm9jZXNzID0gc2VsZi5faG9zdC5l eGVjdXRpdmUucG9wZW4oY21kKQogCiAgICAgZGVmIF9maXJzdF90ZW5fbGluZXNfb2ZfcHJvZmls ZShzZWxmLCBwZXJmX291dHB1dCk6CkBAIC0xNTksMTMgKzE2MSwxNiBAQCBjbGFzcyBQZXJmKFNp bmdsZUZpbGVPdXRwdXRQcm9maWxlcik6CiAgICAgICAgICAgICBwcmludCAiJ3BlcmYgcmVjb3Jk JyBmYWlsZWQgKGV4aXQgY29kZTogJWkpLCBjYW4ndCBwcm9jZXNzIHJlc3VsdHM6IiAlIHBlcmZf ZXhpdGNvZGUKICAgICAgICAgICAgIHJldHVybgogCi0gICAgICAgIHBlcmZfYXJncyA9IFtzZWxm Ll9wZXJmX3BhdGgoKSwgJ3JlcG9ydCcsICctZycsICdub25lJywgJy1pJywgc2VsZi5fb3V0cHV0 X3BhdGhdCisgICAgICAgIHBlcmZfYXJncyA9IFtzZWxmLl9wZXJmX3BhdGgoKSwgJ3JlcG9ydCcs ICctLWNhbGwtZ3JhcGgnLCAnbm9uZScsICctLWlucHV0Jywgc2VsZi5fb3V0cHV0X3BhdGhdCisg ICAgICAgIHByaW50ICJGaXJzdCAxMCBsaW5lcyBvZiAncGVyZiByZXBvcnQgLS1jYWxsLWdyYXBo PW5vbmUnOiIKKwogICAgICAgICBwcmludCAiICIuam9pbihwZXJmX2FyZ3MpCiAgICAgICAgIHBl cmZfb3V0cHV0ID0gc2VsZi5faG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQocGVyZl9hcmdzKQog ICAgICAgICBwcmludCBzZWxmLl9maXJzdF90ZW5fbGluZXNfb2ZfcHJvZmlsZShwZXJmX291dHB1 dCkKIAogICAgICAgICBwcmludCAiVG8gdmlldyB0aGUgZnVsbCBwcm9maWxlLCBydW46IgogICAg ICAgICBwcmludCAnICcuam9pbihbc2VsZi5fcGVyZl9wYXRoKCksICdyZXBvcnQnLCAnLWknLCBz ZWxmLl9vdXRwdXRfcGF0aF0pCisgICAgICAgIHByaW50ICAjIEFuIGV4dHJhIGxpbmUgYmV0d2Vl biB0ZXN0cyBsb29rcyBuaWNlci4KIAogCiBjbGFzcyBTYW1wbGUoU2luZ2xlRmlsZU91dHB1dFBy b2ZpbGVyKToK 179805 2012-12-17 14:38:15 -0800 2012-12-17 15:29:13 -0800 Patch for landing bug-105217-20121217143533.patch text/plain 3651 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU1MDc0MTc4ZTc4OWE0MGQ0MGM4ZmMxNGQ3ZWU1Yjkx ZmU2M2JlNi4uYWNkZWQ2MWNlY2QwNjZkNjJjNjViYjFiZDE4ODUyNTc2MDEzYWEyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDEyLTEyLTE3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAorICAgICAg ICBDbGVhbnVwIC0tcHJvZmlsZXI9cGVyZiBjb2RlIGEgbGl0dGxlIGFuZCBhbGxvdyB1cCB0byAx MDAwIHJlcG9ydCBmaWxlcyAoaW5zdGVhZCBvZiAxMDApCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyMTcKKworICAgICAgICBSZXZpZXdlZCBieSBE aXJrIFByYW5rZS4KKworICAgICAgICBQcmV2aW91c2x5IC0tcHJvZmlsZSB3b3VsZCBmYWlsIHN0 cmFuZ2VseSBpZiBmaW5kX3VudXNlZF9maWxlbmFtZSByZXR1cm5lZCBOb25lCisgICAgICAgICh3 aGljaCB3b3VsZCBoYXBwZW4gYXMgc29vbiBhcyB3ZSBoYWQgMTAwIHJlcG9ydCBmaWxlcykuCisg ICAgICAgIE5vdyB3ZSdsbCBzZWFyY2ggdGhyb3VnaCAxMDAwIGZpbGVuYW1lcyBiZWZvcmUgZ2l2 aW5nIHVwIChhbmQgYXNzZXJ0IGlmIHdlIGZhaWxlZCB0byBmaW5kIG9uZSkuCisgICAgICAgIEkg YWxzbyBtYWRlIHNvbWUgbWlub3IgY2xlYW51cHMgdG8gdGhlIG91dHB1dCBvZiBwZXJmLCBhbmQg dHJpZWQgdG8gbWFrZSB0aGUKKyAgICAgICAgY29tbWFuZHMgbW9yZSBzZWxmLWRvY3VtZW50aW5n IGJ5IHVzaW5nIGxvbmctbmFtZXMgZm9yIGFyZ3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vcHJvZmlsZXIucHk6CisgICAgICAgIChTaW5nbGVGaWxlT3V0cHV0 UHJvZmlsZXIuX19pbml0X18pOgorICAgICAgICAoUGVyZi5hdHRhY2hfdG9fcGlkKToKKyAgICAg ICAgKFBlcmYucHJvZmlsZV9hZnRlcl9leGl0KToKKworMjAxMi0xMi0xNyAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgcnB0IC0tcHJvZmlsZSAtLWNocm9taXVtLWFu ZHJvaWQgdGhyb3dzIGV4Y2VwdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA1MDYxCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL3N5c3RlbS9wcm9maWxlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL3N5c3RlbS9wcm9maWxlci5weQppbmRleCBlMzA2N2NjMDdhZWMzYjVhZjM1NWY2ODg1NjU5 ZmZmYTY1N2YzZGJiLi4wMjA4Y2Y4OThlYjJkYjY0N2VjMzgyYzkwMzVmNWY3OThiN2IzZDQ5IDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcHJvZmlsZXIu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3Byb2ZpbGVyLnB5 CkBAIC04Niw3ICs4Niw5IEBAIGNsYXNzIFByb2ZpbGVyKG9iamVjdCk6CiBjbGFzcyBTaW5nbGVG aWxlT3V0cHV0UHJvZmlsZXIoUHJvZmlsZXIpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBob3N0 LCBleGVjdXRhYmxlX3BhdGgsIG91dHB1dF9kaXIsIG91dHB1dF9zdWZmaXgsIGlkZW50aWZpZXI9 Tm9uZSk6CiAgICAgICAgIHN1cGVyKFNpbmdsZUZpbGVPdXRwdXRQcm9maWxlciwgc2VsZikuX19p bml0X18oaG9zdCwgZXhlY3V0YWJsZV9wYXRoLCBvdXRwdXRfZGlyLCBpZGVudGlmaWVyKQotICAg ICAgICBzZWxmLl9vdXRwdXRfcGF0aCA9IHNlbGYuX2hvc3Qud29ya3NwYWNlLmZpbmRfdW51c2Vk X2ZpbGVuYW1lKHNlbGYuX291dHB1dF9kaXIsIHNlbGYuX2lkZW50aWZpZXIsIG91dHB1dF9zdWZm aXgpCisgICAgICAgICMgRklYTUU6IEN1cnJlbnRseSBhbGwgcmVwb3J0cyBhcmUga2VwdCBhcyB0 ZXN0LiosIHVudGlsIHdlIGZpeCB0aGF0LCBzZWFyY2ggdXAgdG8gMTAwMCBuYW1lcyBiZWZvcmUg Z2l2aW5nIHVwLgorICAgICAgICBzZWxmLl9vdXRwdXRfcGF0aCA9IHNlbGYuX2hvc3Qud29ya3Nw YWNlLmZpbmRfdW51c2VkX2ZpbGVuYW1lKHNlbGYuX291dHB1dF9kaXIsIHNlbGYuX2lkZW50aWZp ZXIsIG91dHB1dF9zdWZmaXgsIHNlYXJjaF9saW1pdD0xMDAwKQorICAgICAgICBhc3NlcnQoc2Vs Zi5fb3V0cHV0X3BhdGgpCiAKIAogY2xhc3MgR29vZ2xlUFByb2YoU2luZ2xlRmlsZU91dHB1dFBy b2ZpbGVyKToKQEAgLTEzOSw3ICsxNDEsNyBAQCBjbGFzcyBQZXJmKFNpbmdsZUZpbGVPdXRwdXRQ cm9maWxlcik6CiAgICAgZGVmIGF0dGFjaF90b19waWQoc2VsZiwgcGlkKToKICAgICAgICAgYXNz ZXJ0KG5vdCBzZWxmLl9wZXJmX3Byb2Nlc3MgYW5kIG5vdCBzZWxmLl9waWRfYmVpbmdfcHJvZmls ZWQpCiAgICAgICAgIHNlbGYuX3BpZF9iZWluZ19wcm9maWxlZCA9IHBpZAotICAgICAgICBjbWQg PSBbc2VsZi5fcGVyZl9wYXRoKCksICJyZWNvcmQiLCAiLWciLCAiLXAiLCBwaWQsICItbyIsIHNl bGYuX291dHB1dF9wYXRoXQorICAgICAgICBjbWQgPSBbc2VsZi5fcGVyZl9wYXRoKCksICJyZWNv cmQiLCAiLS1jYWxsLWdyYXBoIiwgIi0tcGlkIiwgcGlkLCAiLS1vdXRwdXQiLCBzZWxmLl9vdXRw dXRfcGF0aF0KICAgICAgICAgc2VsZi5fcGVyZl9wcm9jZXNzID0gc2VsZi5faG9zdC5leGVjdXRp dmUucG9wZW4oY21kKQogCiAgICAgZGVmIF9maXJzdF90ZW5fbGluZXNfb2ZfcHJvZmlsZShzZWxm LCBwZXJmX291dHB1dCk6CkBAIC0xNTksMTMgKzE2MSwxNiBAQCBjbGFzcyBQZXJmKFNpbmdsZUZp bGVPdXRwdXRQcm9maWxlcik6CiAgICAgICAgICAgICBwcmludCAiJ3BlcmYgcmVjb3JkJyBmYWls ZWQgKGV4aXQgY29kZTogJWkpLCBjYW4ndCBwcm9jZXNzIHJlc3VsdHM6IiAlIHBlcmZfZXhpdGNv ZGUKICAgICAgICAgICAgIHJldHVybgogCi0gICAgICAgIHBlcmZfYXJncyA9IFtzZWxmLl9wZXJm X3BhdGgoKSwgJ3JlcG9ydCcsICctZycsICdub25lJywgJy1pJywgc2VsZi5fb3V0cHV0X3BhdGhd CisgICAgICAgIHBlcmZfYXJncyA9IFtzZWxmLl9wZXJmX3BhdGgoKSwgJ3JlcG9ydCcsICctLWNh bGwtZ3JhcGgnLCAnbm9uZScsICctLWlucHV0Jywgc2VsZi5fb3V0cHV0X3BhdGhdCisgICAgICAg IHByaW50ICJGaXJzdCAxMCBsaW5lcyBvZiAncGVyZiByZXBvcnQgLS1jYWxsLWdyYXBoPW5vbmUn OiIKKwogICAgICAgICBwcmludCAiICIuam9pbihwZXJmX2FyZ3MpCiAgICAgICAgIHBlcmZfb3V0 cHV0ID0gc2VsZi5faG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQocGVyZl9hcmdzKQogICAgICAg ICBwcmludCBzZWxmLl9maXJzdF90ZW5fbGluZXNfb2ZfcHJvZmlsZShwZXJmX291dHB1dCkKIAog ICAgICAgICBwcmludCAiVG8gdmlldyB0aGUgZnVsbCBwcm9maWxlLCBydW46IgogICAgICAgICBw cmludCAnICcuam9pbihbc2VsZi5fcGVyZl9wYXRoKCksICdyZXBvcnQnLCAnLWknLCBzZWxmLl9v dXRwdXRfcGF0aF0pCisgICAgICAgIHByaW50ICAjIEFuIGV4dHJhIGxpbmUgYmV0d2VlbiB0ZXN0 cyBsb29rcyBuaWNlci4KIAogCiBjbGFzcyBTYW1wbGUoU2luZ2xlRmlsZU91dHB1dFByb2ZpbGVy KToK