105215 2012-12-17 13:59:57 -0800 [BlackBerry] Deadlock caused by PluginViewPrivate::destroyBuffers() 2012-12-17 14:44:36 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 793015 0 yong.li.webkit 2012-12-17 13:59:57 -0800 We've seen Deadlock caused by PluginViewPrivate::destroyBuffers locking mutexex ans sending sync message at the same time. 793018 1 179798 yong.li.webkit 2012-12-17 14:06:01 -0800 Created attachment 179798 the patch (shrink the mutex locking scope) 793022 2 179798 rwlbuis 2012-12-17 14:09:45 -0800 Comment on attachment 179798 the patch (shrink the mutex locking scope) LGTM. 793037 3 179802 yong.li.webkit 2012-12-17 14:26:05 -0800 Created attachment 179802 updated to commit 793053 4 179802 webkit.review.bot 2012-12-17 14:44:33 -0800 Comment on attachment 179802 updated to commit Clearing flags on attachment: 179802 Committed r137949: <http://trac.webkit.org/changeset/137949> 793054 5 webkit.review.bot 2012-12-17 14:44:36 -0800 All reviewed patches have been landed. Closing bug. 179798 2012-12-17 14:06:01 -0800 2012-12-17 14:26:05 -0800 the patch (shrink the mutex locking scope) 105215.diff text/plain 2208 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMmJkMDQ2Li5hOTE2NGFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTItMTcgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNr QmVycnldIERlYWRsb2NrIGNhdXNlZCBieSBQbHVnaW5WaWV3UHJpdmF0ZTo6ZGVzdHJveUJ1ZmZl cnMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1 MjE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUFIj IDI2NjQ0MworICAgICAgICBJdCBzaG91bGQgcmVsZWFzZSBtdXRleGVzIGJlZm9yZSBzZW5kaW5n IHN5bmMgbWVzc2FnZS4KKworICAgICAgICAqIHBsdWdpbnMvYmxhY2tiZXJyeS9QbHVnaW5WaWV3 UHJpdmF0ZUJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlld1ByaXZh dGU6OmRlc3Ryb3lCdWZmZXJzKToKKwogMjAxMi0xMi0xNyAgQmVtIEpvbmVzLUJleSAgPGJqb25l c2JlQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNdIHNoYXBlLW91dHNpZGUg b24gZmxvYXRzIGZvciByZWN0YW5nbGUgc2hhcGVzIGhlaWdodC93aWR0aApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdQcml2YXRlQmxhY2tC ZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2JsYWNrYmVycnkvUGx1Z2luVmlld1By aXZhdGVCbGFja0JlcnJ5LmNwcAppbmRleCBjZjdmN2UyLi42MzQ2MjIyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbHVnaW5zL2JsYWNrYmVycnkvUGx1Z2luVmlld1ByaXZhdGVCbGFja0Jl cnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2JsYWNrYmVycnkvUGx1Z2luVmll d1ByaXZhdGVCbGFja0JlcnJ5LmNwcApAQCAtMzY0LDE4ICszNjQsMjEgQEAgYm9vbCBQbHVnaW5W aWV3UHJpdmF0ZTo6cmVzaXplQnVmZmVycyhOUFN1cmZhY2VGb3JtYXQgZm9ybWF0LCBpbnQgd2lk dGgsIGludCBoZWkKIAogYm9vbCBQbHVnaW5WaWV3UHJpdmF0ZTo6ZGVzdHJveUJ1ZmZlcnMoKQog ewotICAgIFB0aHJlYWRNdXRleExvY2tlciBiYWNrTG9jaygmbV9iYWNrQnVmZmVyTXV0ZXgpOwot ICAgIFB0aHJlYWRXcml0ZUxvY2tlciBmcm9udExvY2soJm1fZnJvbnRCdWZmZXJSd0xvY2spOwot CiAgICAgYm9vbCBkaWREZXN0cm95QnVmZmVycyA9IGZhbHNlOwotICAgIGZvciAoaW50IGkgPSAw OyBpIDwgUExVR0lOX0JVRkZFUlM7IGkrKykgewotICAgICAgICBpZiAobV9wbHVnaW5CdWZmZXJz W2ldKSB7Ci0gICAgICAgICAgICBkaWREZXN0cm95QnVmZmVycyA9IHRydWU7Ci0gICAgICAgICAg ICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OmRlc3Ryb3lCdWZmZXIobV9wbHVnaW5C dWZmZXJzW2ldKTsKLSAgICAgICAgICAgIG1fcGx1Z2luQnVmZmVyc1tpXSA9IDA7CisKKyAgICB7 CisgICAgICAgIFB0aHJlYWRNdXRleExvY2tlciBiYWNrTG9jaygmbV9iYWNrQnVmZmVyTXV0ZXgp OworICAgICAgICBQdGhyZWFkV3JpdGVMb2NrZXIgZnJvbnRMb2NrKCZtX2Zyb250QnVmZmVyUndM b2NrKTsKKworICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IFBMVUdJTl9CVUZGRVJTOyBpKysp IHsKKyAgICAgICAgICAgIGlmIChtX3BsdWdpbkJ1ZmZlcnNbaV0pIHsKKyAgICAgICAgICAgICAg ICBkaWREZXN0cm95QnVmZmVycyA9IHRydWU7CisgICAgICAgICAgICAgICAgQmxhY2tCZXJyeTo6 UGxhdGZvcm06OkdyYXBoaWNzOjpkZXN0cm95QnVmZmVyKG1fcGx1Z2luQnVmZmVyc1tpXSk7Cisg ICAgICAgICAgICAgICAgbV9wbHVnaW5CdWZmZXJzW2ldID0gMDsKKyAgICAgICAgICAgIH0KICAg ICAgICAgfQorICAgICAgICBtX3BsdWdpbkJ1ZmZlclNpemUgPSBJbnRTaXplKCk7CiAgICAgfQot ICAgIG1fcGx1Z2luQnVmZmVyU2l6ZSA9IEludFNpemUoKTsKIAogICAgIGlmIChkaWREZXN0cm95 QnVmZmVycykgewogICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6dXNlckludGVyZmFjZVRo cmVhZE1lc3NhZ2VDbGllbnQoKS0+ZGlzcGF0Y2hTeW5jTWVzc2FnZSgK 179802 2012-12-17 14:26:05 -0800 2012-12-17 14:44:33 -0800 updated to commit 105215.diff text/plain 2255 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMmJkMDQ2Li5mN2JmOWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTItMTcgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNr QmVycnldIERlYWRsb2NrIGNhdXNlZCBieSBQbHVnaW5WaWV3UHJpdmF0ZTo6ZGVzdHJveUJ1ZmZl cnMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1 MjE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUm9iIEJ1aXMuCisgICAgICAgIEFsc28gaW50ZXJu YWxseSByZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAgICBQUiMgMjY2NDQzCisg ICAgICAgIEl0IHNob3VsZCByZWxlYXNlIG11dGV4ZXMgYmVmb3JlIHNlbmRpbmcgc3luYyBtZXNz YWdlLgorCisgICAgICAgICogcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdQcml2YXRlQmxh Y2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3UHJpdmF0ZTo6ZGVzdHJv eUJ1ZmZlcnMpOgorCiAyMDEyLTEyLTE3ICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUu Y29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10gc2hhcGUtb3V0c2lkZSBvbiBmbG9hdHMg Zm9yIHJlY3RhbmdsZSBzaGFwZXMgaGVpZ2h0L3dpZHRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbHVnaW5zL2JsYWNrYmVycnkvUGx1Z2luVmlld1ByaXZhdGVCbGFja0JlcnJ5LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvYmxhY2tiZXJyeS9QbHVnaW5WaWV3UHJpdmF0ZUJsYWNr QmVycnkuY3BwCmluZGV4IGNmN2Y3ZTIuLjYzNDYyMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsdWdpbnMvYmxhY2tiZXJyeS9QbHVnaW5WaWV3UHJpdmF0ZUJsYWNrQmVycnkuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvYmxhY2tiZXJyeS9QbHVnaW5WaWV3UHJpdmF0ZUJs YWNrQmVycnkuY3BwCkBAIC0zNjQsMTggKzM2NCwyMSBAQCBib29sIFBsdWdpblZpZXdQcml2YXRl OjpyZXNpemVCdWZmZXJzKE5QU3VyZmFjZUZvcm1hdCBmb3JtYXQsIGludCB3aWR0aCwgaW50IGhl aQogCiBib29sIFBsdWdpblZpZXdQcml2YXRlOjpkZXN0cm95QnVmZmVycygpCiB7Ci0gICAgUHRo cmVhZE11dGV4TG9ja2VyIGJhY2tMb2NrKCZtX2JhY2tCdWZmZXJNdXRleCk7Ci0gICAgUHRocmVh ZFdyaXRlTG9ja2VyIGZyb250TG9jaygmbV9mcm9udEJ1ZmZlclJ3TG9jayk7Ci0KICAgICBib29s IGRpZERlc3Ryb3lCdWZmZXJzID0gZmFsc2U7Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBQTFVH SU5fQlVGRkVSUzsgaSsrKSB7Ci0gICAgICAgIGlmIChtX3BsdWdpbkJ1ZmZlcnNbaV0pIHsKLSAg ICAgICAgICAgIGRpZERlc3Ryb3lCdWZmZXJzID0gdHJ1ZTsKLSAgICAgICAgICAgIEJsYWNrQmVy cnk6OlBsYXRmb3JtOjpHcmFwaGljczo6ZGVzdHJveUJ1ZmZlcihtX3BsdWdpbkJ1ZmZlcnNbaV0p OwotICAgICAgICAgICAgbV9wbHVnaW5CdWZmZXJzW2ldID0gMDsKKworICAgIHsKKyAgICAgICAg UHRocmVhZE11dGV4TG9ja2VyIGJhY2tMb2NrKCZtX2JhY2tCdWZmZXJNdXRleCk7CisgICAgICAg IFB0aHJlYWRXcml0ZUxvY2tlciBmcm9udExvY2soJm1fZnJvbnRCdWZmZXJSd0xvY2spOworCisg ICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgUExVR0lOX0JVRkZFUlM7IGkrKykgeworICAgICAg ICAgICAgaWYgKG1fcGx1Z2luQnVmZmVyc1tpXSkgeworICAgICAgICAgICAgICAgIGRpZERlc3Ry b3lCdWZmZXJzID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 R3JhcGhpY3M6OmRlc3Ryb3lCdWZmZXIobV9wbHVnaW5CdWZmZXJzW2ldKTsKKyAgICAgICAgICAg ICAgICBtX3BsdWdpbkJ1ZmZlcnNbaV0gPSAwOworICAgICAgICAgICAgfQogICAgICAgICB9Cisg ICAgICAgIG1fcGx1Z2luQnVmZmVyU2l6ZSA9IEludFNpemUoKTsKICAgICB9Ci0gICAgbV9wbHVn aW5CdWZmZXJTaXplID0gSW50U2l6ZSgpOwogCiAgICAgaWYgKGRpZERlc3Ryb3lCdWZmZXJzKSB7 CiAgICAgICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjp1c2VySW50ZXJmYWNlVGhyZWFkTWVzc2Fn ZUNsaWVudCgpLT5kaXNwYXRjaFN5bmNNZXNzYWdlKAo=