105205 2012-12-17 13:04:55 -0800 [Chromium] Remove temporary backwards compatible interface code (from r137724). 2012-12-18 17:54:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddorwin ddorwin abarth dglazkov eric.carlson feature-media-reviews fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 792945 0 ddorwin 2012-12-17 13:04:55 -0800 [Chromium] Remove temporary backwards compatible interface code (from r137724). 792946 1 179786 ddorwin 2012-12-17 13:06:51 -0800 Created attachment 179786 Patch 792948 2 webkit.review.bot 2012-12-17 13:09:56 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 792949 3 179786 webkit.review.bot 2012-12-17 13:11:52 -0800 Comment on attachment 179786 Patch Attachment 179786 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15363882 794223 4 179786 webkit.review.bot 2012-12-18 17:54:02 -0800 Comment on attachment 179786 Patch Clearing flags on attachment: 179786 Committed r138092: <http://trac.webkit.org/changeset/138092> 794224 5 webkit.review.bot 2012-12-18 17:54:06 -0800 All reviewed patches have been landed. Closing bug. 179786 2012-12-17 13:06:51 -0800 2012-12-18 17:54:02 -0800 Patch bug-105205-20121217130409.patch text/plain 3008 ddorwin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFkYmFhZWU0ZDNkNWRjODRiMzRlYjM2MjNhMGIyNzA5ZDk2ZWE1MTkuLjU4OWU2YjZkNDc0N2I3 OGE0NmVmNTM1NWQ0Y2U4Yzc0NjM5Nzk0MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMTItMTcgIERhdmlkIERvcndpbiAgPGRkb3J3aW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gUmVtb3ZlIHRlbXBvcmFyeSBiYWNrd2FyZHMg Y29tcGF0aWJsZSBpbnRlcmZhY2UgY29kZSAoZnJvbSByMTM3NzI0KS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTIwNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVy Q2xpZW50Lmg6CisgICAgICAgICogc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHA6CisK IDIwMTItMTItMTYgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFB1c2ggcGl4ZWwgc25hcHBpbmcgbG9naWMgaW50byBUcmFuc2Zvcm1TdGF0ZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJDbGllbnQu aCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmgK aW5kZXggNGFiYjBkNDAxMDRiMGUxMmEyMWU5ZjdlYTFhZTdhOGFkYzE2YjU1Yi4uZGVjYTk1MzZk OTlhNDVjYjIxNWU4ZWE1ZTIwNGE2MTg5NzU1YzRiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJDbGllbnQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckNsaWVudC5oCkBAIC03Niw4ICs3Niw2 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQga2V5QWRkZWQoY29uc3QgV2ViU3RyaW5nJiBr ZXlTeXN0ZW0sIGNvbnN0IFdlYlN0cmluZyYgc2Vzc2lvbklkKSA9IDA7CiAgICAgdmlydHVhbCB2 b2lkIGtleUVycm9yKGNvbnN0IFdlYlN0cmluZyYga2V5U3lzdGVtLCBjb25zdCBXZWJTdHJpbmcm IHNlc3Npb25JZCwgTWVkaWFLZXlFcnJvckNvZGUsIHVuc2lnbmVkIHNob3J0IHN5c3RlbUNvZGUp ID0gMDsKICAgICB2aXJ0dWFsIHZvaWQga2V5TWVzc2FnZShjb25zdCBXZWJTdHJpbmcmIGtleVN5 c3RlbSwgY29uc3QgV2ViU3RyaW5nJiBzZXNzaW9uSWQsIGNvbnN0IHVuc2lnbmVkIGNoYXIqIG1l c3NhZ2UsIHVuc2lnbmVkIG1lc3NhZ2VMZW5ndGgsIGNvbnN0IFdlYlVSTCYgZGVmYXVsdFVSTCkg PSAwOwotICAgIC8vIEZJWE1FKGRkb3J3aW4pOiBSZW1vdmUgYWZ0ZXIgcm9sbGluZyBXZWJLaXQg aW4gQ2hyb21pdW0gYW5kIENocm9taXVtIGlzIHVwZGF0ZWQgdG8gdXNlIHRoZSBuZXcgc2lnbmF0 dXJlLgotICAgIHZpcnR1YWwgdm9pZCBrZXlNZXNzYWdlKGNvbnN0IFdlYlN0cmluZyYga2V5U3lz dGVtLCBjb25zdCBXZWJTdHJpbmcmIHNlc3Npb25JZCwgY29uc3QgdW5zaWduZWQgY2hhciogbWVz c2FnZSwgdW5zaWduZWQgbWVzc2FnZUxlbmd0aCk7CiAgICAgdmlydHVhbCB2b2lkIGtleU5lZWRl ZChjb25zdCBXZWJTdHJpbmcmIGtleVN5c3RlbSwgY29uc3QgV2ViU3RyaW5nJiBzZXNzaW9uSWQs IGNvbnN0IHVuc2lnbmVkIGNoYXIqIGluaXREYXRhLCB1bnNpZ25lZCBpbml0RGF0YUxlbmd0aCkg PSAwOwogICAgIC8vIFRoZSByZXR1cm5lZCBwb2ludGVyIGlzIHZhbGlkIHVudGlsIGNsb3NlSGVs cGVyUGx1Z2luKCkgaXMgY2FsbGVkLgogICAgIC8vIFJldHVybnMgMCBpZiB0aGUgcGx1Z2luIGNv dWxkIG5vdCBiZSBpbnN0YW50aWF0ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcAppbmRleCBiMGUzM2RjN2YyOWRm MGE5M2VmYjZhYjkwM2RkZDY5MWM3YTE1YjYxLi41ZjliZWIwYzY4MTk4YTUxOWUxNWQxNjNmNDI1 ZmNkMTQwOGJhNWRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJN ZWRpYVBsYXllckNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAKQEAgLTI2NSwxMiArMjY1LDYgQEAgdm9pZCBX ZWJNZWRpYVBsYXllckNsaWVudEltcGw6OmtleU1lc3NhZ2UoY29uc3QgV2ViU3RyaW5nJiBrZXlT eXN0ZW0sIGNvbnN0IFdlYlMKICNlbmRpZgogfQogCi0vLyBGSVhNRShkZG9yd2luKTogUmVtb3Zl IGFmdGVyIHJvbGxpbmcgV2ViS2l0IGluIENocm9taXVtIGFuZCBDaHJvbWl1bSBpcyB1cGRhdGVk IHRvIHVzZSB0aGUgbmV3IHNpZ25hdHVyZS4KLXZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnQ6Omtl eU1lc3NhZ2UoY29uc3QgV2ViU3RyaW5nJiBrZXlTeXN0ZW0sIGNvbnN0IFdlYlN0cmluZyYgc2Vz c2lvbklkLCBjb25zdCB1bnNpZ25lZCBjaGFyKiBtZXNzYWdlLCB1bnNpZ25lZCBtZXNzYWdlTGVu Z3RoKQotewotICAgIGtleU1lc3NhZ2Uoa2V5U3lzdGVtLCBzZXNzaW9uSWQsIG1lc3NhZ2UsIG1l c3NhZ2VMZW5ndGgsIFdlYlVSTCgpKTsKLX0KLQogdm9pZCBXZWJNZWRpYVBsYXllckNsaWVudElt cGw6OmtleU5lZWRlZChjb25zdCBXZWJTdHJpbmcmIGtleVN5c3RlbSwgY29uc3QgV2ViU3RyaW5n JiBzZXNzaW9uSWQsIGNvbnN0IHVuc2lnbmVkIGNoYXIqIGluaXREYXRhLCB1bnNpZ25lZCBpbml0 RGF0YUxlbmd0aCkKIHsKICNpZiBFTkFCTEUoRU5DUllQVEVEX01FRElBKQo=