105203 2012-12-17 12:17:01 -0800 [BlackBerry] Prevent selection handles from being rendered after selection was canceled 2012-12-17 20:20:34 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yodai webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 792918 0 yodai 2012-12-17 12:17:01 -0800 Here is the explanation why handles occur without selection overlay. 1. Still touch at current selection (Selection A) initiated by touch-hold 2. Selection expanding (Selection B) is ongoing 3. Finger moves. In UI thread: 1) SelectionHander::cancelSelection() gets called. a. Selection A is canceled immediately (clear selecting state and hide handles) b. Post a request to webkit thread to cancel Selection A. 4. In webkit thread: 1) Selection B becomes active selection a. Show selection overlay for Selection B b. Dispatch Selection B to UI thread to show handles 2) Handle the request of canceling Selection A. The selection A was gone. Instead the active Selection B is canceled. The visual change is Selection overlay for Selection B becomes invisible.. 5. In UI thread: Selection B is rendered. The start handle and the end handle occur without selection overlay. The fix is to notify client with a empty selection whenever the selection is canceled in webkit thread. 793260 1 179857 yodai 2012-12-17 18:55:55 -0800 Created attachment 179857 Patch 793266 2 179857 rwlbuis 2012-12-17 19:09:58 -0800 Comment on attachment 179857 Patch LGTM. 793300 3 179857 webkit.review.bot 2012-12-17 20:20:30 -0800 Comment on attachment 179857 Patch Clearing flags on attachment: 179857 Committed r137977: <http://trac.webkit.org/changeset/137977> 793301 4 webkit.review.bot 2012-12-17 20:20:34 -0800 All reviewed patches have been landed. Closing bug. 179857 2012-12-17 18:55:55 -0800 2012-12-17 20:20:30 -0800 Patch bug-105203-20121217215312.patch text/plain 2968 yodai U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Njg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwMWI5YmI2ZGUzZWZkYmVjNGQ2NmMyOGY2YzVlYjE2YjNkOTZiODY5Li5jMzlmNmYyZmM0 MTNiNmVkZWFjYzYyZTYwYjNiODgzNjVkMDVhMWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzNSBAQAorMjAxMi0xMi0xNyAgWW9uZ3hpbiBEYWkgIDx5b2RhaUBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBQcmV2ZW50IHNlbGVjdGlvbiBoYW5kbGVz IGZyb20gYmVpbmcgcmVuZGVyZWQgYWZ0ZXIgc2VsZWN0aW9uIHdhcyBjYW5jZWxlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjAzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUFIyNTU0MzgKKworICAg ICAgICBIZXJlIGlzIHRoZSBleHBsYW5hdGlvbiB3aHkgaGFuZGxlcyBvY2N1ciB3aXRob3V0IHNl bGVjdGlvbiBvdmVybGF5LgorICAgICAgICAxLiBTdGlsbCB0b3VjaCBhdCBjdXJyZW50IHNlbGVj dGlvbiAoU2VsZWN0aW9uIEEpIGluaXRpYXRlZCBieSB0b3VjaC1ob2xkCisgICAgICAgIDIuIFNl bGVjdGlvbiBleHBhbmRpbmcgKFNlbGVjdGlvbiBCKSBpcyBvbmdvaW5nCisgICAgICAgIDMuIEZp bmdlciBtb3Zlcy4gSW4gVUkgdGhyZWFkOgorICAgICAgICAgICAgMSkgU2VsZWN0aW9uSGFuZGVy OjpjYW5jZWxTZWxlY3Rpb24oKSBnZXRzIGNhbGxlZC4KKyAgICAgICAgICAgICAgICBhLiBTZWxl Y3Rpb24gQSBpcyBjYW5jZWxlZCBpbW1lZGlhdGVseSAoY2xlYXIgc2VsZWN0aW5nIHN0YXRlIGFu ZCBoaWRlIGhhbmRsZXMpCisgICAgICAgICAgICAgICAgYi4gUG9zdCBhIHJlcXVlc3QgdG8gd2Vi a2l0IHRocmVhZCB0byBjYW5jZWwgU2VsZWN0aW9uIEEuCisgICAgICAgIDQuIEluIHdlYmtpdCB0 aHJlYWQ6CisgICAgICAgICAgICAxKSBTZWxlY3Rpb24gQiBiZWNvbWVzIGFjdGl2ZSBzZWxlY3Rp b24KKyAgICAgICAgICAgICAgICBhLiBTaG93IHNlbGVjdGlvbiBvdmVybGF5IGZvciBTZWxlY3Rp b24gQgorICAgICAgICAgICAgICAgIGIuIERpc3BhdGNoIFNlbGVjdGlvbiBCIHRvIFVJIHRocmVh ZCB0byBzaG93IGhhbmRsZXMKKyAgICAgICAgICAgIDIpIEhhbmRsZSB0aGUgcmVxdWVzdCBvZiBj YW5jZWxpbmcgU2VsZWN0aW9uIEEuIFRoZSBzZWxlY3Rpb24gQSB3YXMgZ29uZS4gSW5zdGVhZCB0 aGUgYWN0aXZlIFNlbGVjdGlvbiBCIGlzIGNhbmNlbGVkLgorICAgICAgICAgICAgVGhlIHZpc3Vh bCBjaGFuZ2UgaXMgU2VsZWN0aW9uIG92ZXJsYXkgZm9yIFNlbGVjdGlvbiBCIGJlY29tZXMgaW52 aXNpYmxlLi4KKyAgICAgICAgNS4gSW4gVUkgdGhyZWFkOgorICAgICAgICAgICAgU2VsZWN0aW9u IEIgaXMgcmVuZGVyZWQuIFRoZSBzdGFydCBoYW5kbGUgYW5kIHRoZSBlbmQgaGFuZGxlIG9jY3Vy IHdpdGhvdXQgc2VsZWN0aW9uIG92ZXJsYXkuCisKKyAgICAgICAgVGhlIGZpeCBpcyB0byBub3Rp ZnkgY2xpZW50IHdpdGggYSBlbXB0eSBzZWxlY3Rpb24gd2hlbmV2ZXIgdGhlIHNlbGVjdGlvbiBp cyBjYW5jZWxlZCBpbiB3ZWJraXQgdGhyZWFkLgorCisgICAgICAgIFJldmlld2VkIEludGVybmFs bHkgYnkgTWlrZSBGZW50b24uCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhh bmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVy OjpjYW5jZWxTZWxlY3Rpb24pOgorCiAyMDEyLTEyLTA1ICBZb25neGluIERhaSAgPHlvZGFpQHJp bS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEF2b2lkIHNob3dpbmcgRkNDIG9uIGVtcHR5 IHRleHQgZmllbGQgaW4gYSBkaWZmZXJlbnQgd2F5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4 IGJiMDBlZmMxYzdmYzZkZDVlNmQwMzNiM2I4MDRjYWE2YTM2YjBkY2EuLmU5NjgzNjA5OTAxODVj NzU2MGI3OWJmNmI2MTkyMDk5ZjYwNjYzMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC04 NSw2ICs4NSwxMCBAQCB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OmNhbmNlbFNlbGVjdGlvbigpCiAK ICAgICBpZiAobV93ZWJQYWdlLT5tX3NlbGVjdGlvbk92ZXJsYXkpCiAgICAgICAgIG1fd2ViUGFn ZS0+bV9zZWxlY3Rpb25PdmVybGF5LT5oaWRlKCk7CisgICAgLy8gTm90aWZ5IGNsaWVudCB3aXRo IGVtcHR5IHNlbGVjdGlvbiB0byBlbnN1cmUgdGhlIGhhbmRsZXMgYXJlIHJlbW92ZWQgaWYKKyAg ICAvLyByZW5kZXJpbmcgaGFwcGVuZWQgcHJpb3IgdG8gcHJvY2Vzc2luZyBvbiB3ZWJraXQgdGhy ZWFkCisgICAgbV93ZWJQYWdlLT5tX2NsaWVudC0+bm90aWZ5U2VsZWN0aW9uRGV0YWlsc0NoYW5n ZWQoV2ViQ29yZTo6SW50UmVjdChET01TdXBwb3J0OjpJbnZhbGlkUG9pbnQsIFdlYkNvcmU6Oklu dFNpemUoKSksCisgICAgICAgIFdlYkNvcmU6OkludFJlY3QoRE9NU3VwcG9ydDo6SW52YWxpZFBv aW50LCBXZWJDb3JlOjpJbnRTaXplKCkpLCBJbnRSZWN0UmVnaW9uKCkpOwogCiAgICAgU2VsZWN0 aW9uTG9nKExvZ0xldmVsSW5mbywgIlNlbGVjdGlvbkhhbmRsZXI6OmNhbmNlbFNlbGVjdGlvbiIp OwogCg==