105201 2012-12-17 12:07:53 -0800 [BlackBerry] Use application size rather than screen size where appropriate. 2012-12-17 12:38:47 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 792907 0 anlo 2012-12-17 12:07:53 -0800 In some places we should use application size rather than screen size. 792913 1 179778 anlo 2012-12-17 12:13:01 -0800 Created attachment 179778 Patch 792914 2 179778 rwlbuis 2012-12-17 12:14:14 -0800 Comment on attachment 179778 Patch LGTM. 792931 3 179778 webkit.review.bot 2012-12-17 12:38:43 -0800 Comment on attachment 179778 Patch Clearing flags on attachment: 179778 Committed r137932: <http://trac.webkit.org/changeset/137932> 792932 4 webkit.review.bot 2012-12-17 12:38:47 -0800 All reviewed patches have been landed. Closing bug. 179778 2012-12-17 12:13:01 -0800 2012-12-17 12:38:43 -0800 Patch bug-105201-20121217151018.patch text/plain 3407 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlOTM4YmVlMTRjYTk2YzUxZjNhMjZlN2I1MDNlMGM2YTVjYjhjZjFhLi5iYjhkYTViN2M1 ODk3Nzg0MzRiODcyMjMwMzNmZjY1OTNkYWZlNzEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMi0xNyAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgYXBwbGljYXRpb24gc2l6ZSByYXRoZXIg dGhhbiBzY3JlZW4gc2l6ZSB3aGVyZSBhcHByb3ByaWF0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTIwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEplZmYgUm9n ZXJzLgorCisgICAgICAgIFN3aXRjaCBmcm9tIHNjcmVlblNpemUgdG8gYXBwbGljYXRpb25TaXpl IHdoZXJlIGFwcHJvcHJpYXRlLgorICAgICAgICBJbnRlcm5hbCBQUjI2NjQwMAorCisgICAgICAg ICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdl UHJpdmF0ZTo6dHJhbnNmb3JtZWRWaWV3cG9ydFNpemUpOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6c2V0RGVmYXVsdExheW91dFNpemUpOgorICAgICAgICAq IFdlYktpdFN1cHBvcnQvU3VyZmFjZVBvb2wuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2Vi S2l0OjpTdXJmYWNlUG9vbDo6aW5pdGlhbGl6ZSk6CisKIDIwMTItMTItMTMgIFBhcnRoIFBhdGVs ICA8cGFycGF0ZWxAcmltLmNvbT4sIE1heCBGZWlsIDxtZmVpbEByaW0uY29tPgogCiAgICAgICAg IEFsbG93IHBsdWdpbnMgdG8gYmUgZGlzYWJsZWQgYnkgc2hhcmVkIGxpYnJhcnkgZmlsZW5hbWUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IGRkNDQxNzkwMTNm YzY0MzZkZGU0ZTk2NWFmZjRjNmU0ZmQyZDU4OGEuLjNmNTAzZWM5ZWYxNmJmZGE2MjRhODVjYTMy M2QxN2E4NzA5NDM4NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNw cApAQCAtMTgzNyw3ICsxODM3LDcgQEAgUGxhdGZvcm06OkludFNpemUgV2ViUGFnZTo6dmlld3Bv cnRTaXplKCkgY29uc3QKIAogSW50U2l6ZSBXZWJQYWdlUHJpdmF0ZTo6dHJhbnNmb3JtZWRWaWV3 cG9ydFNpemUoKSBjb25zdAogewotICAgIHJldHVybiBQbGF0Zm9ybTo6R3JhcGhpY3M6OlNjcmVl bjo6cHJpbWFyeVNjcmVlbigpLT5zaXplKCk7CisgICAgcmV0dXJuIEJsYWNrQmVycnk6OlBsYXRm b3JtOjpTZXR0aW5nczo6aW5zdGFuY2UoKS0+YXBwbGljYXRpb25TaXplKCk7CiB9CiAKIEludFJl Y3QgV2ViUGFnZVByaXZhdGU6OnRyYW5zZm9ybWVkVmlzaWJsZUNvbnRlbnRzUmVjdCgpIGNvbnN0 CkBAIC0zODk4LDcgKzM4OTgsNyBAQCB2b2lkIFdlYlBhZ2U6OnNldFZpZXdwb3J0U2l6ZShjb25z dCBQbGF0Zm9ybTo6SW50U2l6ZSYgdmlld3BvcnRTaXplLCBib29sIGVuc3VyZQogCiB2b2lkIFdl YlBhZ2VQcml2YXRlOjpzZXREZWZhdWx0TGF5b3V0U2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQog ewotICAgIEludFNpemUgc2NyZWVuU2l6ZSA9IFBsYXRmb3JtOjpHcmFwaGljczo6U2NyZWVuOjpw cmltYXJ5U2NyZWVuKCktPnNpemUoKTsKKyAgICBJbnRTaXplIHNjcmVlblNpemUgPSBQbGF0Zm9y bTo6U2V0dGluZ3M6Omluc3RhbmNlKCktPmFwcGxpY2F0aW9uU2l6ZSgpOwogICAgIEFTU0VSVChz aXplLndpZHRoKCkgPD0gc2NyZWVuU2l6ZS53aWR0aCgpICYmIHNpemUuaGVpZ2h0KCkgPD0gc2Ny ZWVuU2l6ZS5oZWlnaHQoKSk7CiAgICAgbV9kZWZhdWx0TGF5b3V0U2l6ZSA9IHNpemUuZXhwYW5k ZWRUbyhtaW5pbXVtTGF5b3V0U2l6ZSkuc2hydW5rVG8oc2NyZWVuU2l6ZSk7CiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TdXJmYWNlUG9vbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TdXJmYWNlUG9vbC5j cHAKaW5kZXggYTcwMGNjOTIxODI1NTc4YmZlZTliNjM3YjhiYmFiM2VmNGM2ZDA4NC4uZGFkYmI5 MDMzZTYwMjIxY2UxYjJlNDcyZDQ3OTEyOTE2NjhmMTM4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU3VyZmFjZVBvb2wuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1N1cmZhY2VQb29sLmNwcApAQCAtODEs NyArODEsNyBAQCB2b2lkIFN1cmZhY2VQb29sOjppbml0aWFsaXplKGNvbnN0IFBsYXRmb3JtOjpJ bnRTaXplJiB0aWxlU2l6ZSkKICAgICBjb25zdCB1bnNpZ25lZCBtYXhOdW1iZXJPZlRpbGVzID0g UGxhdGZvcm06OlNldHRpbmdzOjppbnN0YW5jZSgpLT5tYXhpbXVtTnVtYmVyT2ZCYWNraW5nU3Rv cmVUaWxlc0Fjcm9zc1Byb2Nlc3NlcygpOwogCiAgICAgaWYgKG1fbnVtYmVyT2ZGcm9udEJ1ZmZl cnMpIHsgLy8gT25seSBhbGxvY2F0ZSBpZiB3ZSBhY3R1YWxseSB1c2UgYSBiYWNraW5nc3RvcmUu Ci0gICAgICAgIFBsYXRmb3JtOjpJbnRTaXplIHNjcmVlblNpemUgPSBQbGF0Zm9ybTo6R3JhcGhp Y3M6OlNjcmVlbjo6cHJpbWFyeVNjcmVlbigpLT5zaXplKCk7CisgICAgICAgIFBsYXRmb3JtOjpJ bnRTaXplIHNjcmVlblNpemUgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U2V0dGluZ3M6Omluc3Rh bmNlKCktPmFwcGxpY2F0aW9uU2l6ZSgpOwogICAgICAgICB1bnNpZ25lZCBieXRlTGltaXQgPSBt YXhOdW1iZXJPZlRpbGVzICogdGlsZVNpemUud2lkdGgoKSAqIHRpbGVTaXplLmhlaWdodCgpICog NDsKICAgICAgICAgYnl0ZUxpbWl0ICs9IHNjcmVlblNpemUud2lkdGgoKSAqIHNjcmVlblNpemUu aGVpZ2h0KCkgKiA0OyAvLyB2aXNpYmxlIHRpbGUgYnVmZmVyIC0gRklYTUUsIGZyYWdpbGUgZm9y IGZ1cnRoZXIgbWFpbnRlbmFuY2UgYXMgaXRzIHNpemUgZG9lc24ndCBzeW5jIHVwIHdpdGggdGhl IHJlc3QKICAgICAgICAgYm9vbCBzdWNjZXNzID0gUGxhdGZvcm06OkdyYXBoaWNzOjpjcmVhdGVQ aXhtYXBHcm91cChTSEFSRURfUElYTUFQX0dST1VQLCBieXRlTGltaXQpOwo=