10520 2006-08-22 21:02:43 -0700 Windows compile fixes (remove TextBox code, better notImplemented() function) 2006-08-24 20:31:14 -0700 1 1 1 Unclassified WebKit New Bugs 420+ PC OS X 10.4 RESOLVED DUPLICATE 10553 P2 Normal --- 1 kkowalczyk webkit-unassigned oldest_to_newest 53104 0 kkowalczyk 2006-08-22 21:02:43 -0700 The attached patch does 2 things: * removes declarations for TextBox class which was recently removed * changes notImplemented() to output debug info to debug output (i.e. it'll show in Visual Studio's output window) and not break into the debugger. This happens very often e.g. on google.com and makes debugging impossible. It matches e.g. qt behaviour. 53105 1 10173 kkowalczyk 2006-08-22 21:03:24 -0700 Created attachment 10173 Remove TextBox code in Windows, better notImplemented() 53481 2 kkowalczyk 2006-08-24 20:31:14 -0700 bug 10553 has updated version of this change. trying to consolidate changes into one bug *** This bug has been marked as a duplicate of 10553 *** 10173 2006-08-22 21:03:24 -0700 2006-08-24 20:30:33 -0700 Remove TextBox code in Windows, better notImplemented() better_not_implemented.txt text/plain 3944 kkowalczyk SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vd2luL0ZvbnRXaW4uY3BwDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g V2ViQ29yZS9wbGF0Zm9ybS93aW4vRm9udFdpbi5jcHAJKHJldmlzaW9uIDE1OTc5KQ0KKysrIFdl YkNvcmUvcGxhdGZvcm0vd2luL0ZvbnRXaW4uY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMzQsNyAr MzQsMTEgQEANCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RhdGljIHZvaWQgbm90SW1wbGVt ZW50ZWQoKSB7IHB1dHMoIk5vdCB5ZXQgaW1wbGVtZW50ZWQiKTsgX0NydERiZ0JyZWFrKCk7IH0K KyNkZWZpbmUgbm90SW1wbGVtZW50ZWQoKSBkbyB7IFwKKyAgICBjaGFyIGJ1ZlsyNTZdID0gezB9 OyBcCisgICAgX3NucHJpbnRmKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJGSVhNRTogVU5JTVBMRU1FTlRF RDogJXM6JWRcbiIsIF9fRklMRV9fLCBfX0xJTkVfXyk7IFwKKyAgICBPdXRwdXREZWJ1Z1N0cmlu Z0EoYnVmKTsgXAorfSB3aGlsZSAoMCkKIAogdm9pZCBGb250OjpkcmF3R2x5cGhzKEdyYXBoaWNz Q29udGV4dCogZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBGb250RGF0YSogZm9udCwgY29uc3QgR2x5 cGhCdWZmZXImIGdseXBoQnVmZmVyLCAKICAgICAgICAgICAgICAgICAgICAgICBpbnQgZnJvbSwg aW50IG51bUdseXBocywgY29uc3QgRmxvYXRQb2ludCYgcG9pbnQpIGNvbnN0CkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL3dpbi9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g V2ViQ29yZS9wbGF0Zm9ybS93aW4vVGVtcG9yYXJ5TGlua1N0dWJzLmNwcAkocmV2aXNpb24gMTU5 NzkpDQorKysgV2ViQ29yZS9wbGF0Zm9ybS93aW4vVGVtcG9yYXJ5TGlua1N0dWJzLmNwcAkod29y a2luZyBjb3B5KQ0KQEAgLTMzLDcgKzMzLDYgQEANCiAjaW5jbHVkZSAiVGV4dEZpZWxkLmgiCiAj aW5jbHVkZSAiRm9udC5oIgogI2luY2x1ZGUgIkZpbGVCdXR0b24uaCIKLSNpbmNsdWRlICJUZXh0 Qm94LmgiCiAjaW5jbHVkZSAiUG9wVXBCdXR0b24uaCIKICNpbmNsdWRlICJJbnRQb2ludC5oIgog I2luY2x1ZGUgIldpZGdldC5oIgpAQCAtNjUsMzcgKzY0LDE1IEBADQogCiB1c2luZyBuYW1lc3Bh Y2UgV2ViQ29yZTsKIAotc3RhdGljIHZvaWQgbm90SW1wbGVtZW50ZWQoKSB7IHB1dHMoIk5vdCB5 ZXQgaW1wbGVtZW50ZWQiKTsgX0NydERiZ0JyZWFrKCk7IH0KKyNkZWZpbmUgbm90SW1wbGVtZW50 ZWQoKSBkbyB7IFwKKyAgICBjaGFyIGJ1ZlsyNTZdID0gezB9OyBcCisgICAgX3NucHJpbnRmKGJ1 Ziwgc2l6ZW9mKGJ1ZiksICJGSVhNRTogVU5JTVBMRU1FTlRFRDogJXM6JWRcbiIsIF9fRklMRV9f LCBfX0xJTkVfXyk7IFwKKyAgICBPdXRwdXREZWJ1Z1N0cmluZ0EoYnVmKTsgXAorfSB3aGlsZSAo MCkKIAogdm9pZCBGcmFtZVZpZXc6OnVwZGF0ZUJvcmRlcigpIHsgbm90SW1wbGVtZW50ZWQoKTsg fQogYm9vbCBGcmFtZVZpZXc6OmlzRnJhbWVWaWV3KCkgY29uc3QgeyBub3RJbXBsZW1lbnRlZCgp OyByZXR1cm4gMDsgfQogCi1UZXh0Qm94OjpUZXh0Qm94KFdpZGdldCopIHsgbm90SW1wbGVtZW50 ZWQoKTsgfQotVGV4dEJveDo6flRleHRCb3goKSB7IG5vdEltcGxlbWVudGVkKCk7IH0KLVN0cmlu ZyBUZXh0Qm94Ojp0ZXh0V2l0aEhhcmRMaW5lQnJlYWtzKCkgY29uc3QgeyBub3RJbXBsZW1lbnRl ZCgpOyByZXR1cm4gU3RyaW5nKCk7IH0KLUludFNpemUgVGV4dEJveDo6c2l6ZVdpdGhDb2x1bW5z QW5kUm93cyhpbnQsaW50KSBjb25zdCB7IG5vdEltcGxlbWVudGVkKCk7IHJldHVybiBJbnRTaXpl KCk7IH0KLXZvaWQgVGV4dEJveDo6c2V0VGV4dChTdHJpbmcgY29uc3QmKSB7IG5vdEltcGxlbWVu dGVkKCk7IH0KLXZvaWQgVGV4dEJveDo6c2V0Q29sb3JzKENvbG9yIGNvbnN0JixDb2xvciBjb25z dCYpIHsgbm90SW1wbGVtZW50ZWQoKTsgfQotdm9pZCBUZXh0Qm94OjpzZXRGb250KFdlYkNvcmU6 OkZvbnQgY29uc3QmKSB7IG5vdEltcGxlbWVudGVkKCk7IH0KLXZvaWQgVGV4dEJveDo6c2V0V3Jp dGluZ0RpcmVjdGlvbihlbnVtIFdlYkNvcmU6OlRleHREaXJlY3Rpb24pIHsgbm90SW1wbGVtZW50 ZWQoKTsgfQotYm9vbCBUZXh0Qm94OjpjaGVja3NEZXNjZW5kYW50c0ZvckZvY3VzKCkgY29uc3Qg eyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gZmFsc2U7IH0KLWludCBUZXh0Qm94OjpzZWxlY3Rp b25TdGFydCgpIHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIDA7IH0KLWJvb2wgVGV4dEJveDo6 aGFzU2VsZWN0ZWRUZXh0KCkgY29uc3QgeyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gMDsgfQot aW50IFRleHRCb3g6OnNlbGVjdGlvbkVuZCgpIHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIDA7 IH0KLXZvaWQgVGV4dEJveDo6c2V0U2Nyb2xsQmFyTW9kZXMoU2Nyb2xsQmFyTW9kZSxTY3JvbGxC YXJNb2RlKSB7IG5vdEltcGxlbWVudGVkKCk7IH0KLXZvaWQgVGV4dEJveDo6c2V0UmVhZE9ubHko Ym9vbCkgeyBub3RJbXBsZW1lbnRlZCgpOyB9Ci12b2lkIFRleHRCb3g6OnNlbGVjdEFsbCgpIHsg bm90SW1wbGVtZW50ZWQoKTsgfQotdm9pZCBUZXh0Qm94OjpzZXREaXNhYmxlZChib29sKSB7IG5v dEltcGxlbWVudGVkKCk7IH0KLXZvaWQgVGV4dEJveDo6c2V0TGluZUhlaWdodChpbnQpIHsgbm90 SW1wbGVtZW50ZWQoKTsgfQotdm9pZCBUZXh0Qm94OjpzZXRTZWxlY3Rpb25TdGFydChpbnQpIHsg bm90SW1wbGVtZW50ZWQoKTsgfQotdm9pZCBUZXh0Qm94OjpzZXRDdXJzb3JQb3NpdGlvbihpbnQs aW50KSB7IG5vdEltcGxlbWVudGVkKCk7IH0KLVN0cmluZyBUZXh0Qm94Ojp0ZXh0KCkgY29uc3Qg eyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gU3RyaW5nKCk7IH0KLXZvaWQgVGV4dEJveDo6c2V0 V29yZFdyYXAoVGV4dEJveDo6V3JhcFN0eWxlKSB7IG5vdEltcGxlbWVudGVkKCk7IH0KLXZvaWQg VGV4dEJveDo6c2V0QWxpZ25tZW50KEhvcml6b250YWxBbGlnbm1lbnQpIHsgbm90SW1wbGVtZW50 ZWQoKTsgfQotdm9pZCBUZXh0Qm94OjpzZXRTZWxlY3Rpb25FbmQoaW50KSB7IG5vdEltcGxlbWVu dGVkKCk7IH0KLXZvaWQgVGV4dEJveDo6Z2V0Q3Vyc29yUG9zaXRpb24oaW50KixpbnQqKSBjb25z dCB7IG5vdEltcGxlbWVudGVkKCk7IH0KLXZvaWQgVGV4dEJveDo6c2V0U2VsZWN0aW9uUmFuZ2Uo aW50LGludCkgeyBub3RJbXBsZW1lbnRlZCgpOyB9Ci0KIFdpZGdldDo6Rm9jdXNQb2xpY3kgUG9w VXBCdXR0b246OmZvY3VzUG9saWN5KCkgY29uc3QgeyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4g Tm9Gb2N1czsgfQogdm9pZCBQb3BVcEJ1dHRvbjo6cG9wdWxhdGUoKSB7IG5vdEltcGxlbWVudGVk KCk7IH0KIApAQCAtMTQ4LDcgKzEyNSw2IEBADQogdm9pZCBGaWxlQnV0dG9uOjpzZXRGcmFtZUdl b21ldHJ5KFdlYkNvcmU6OkludFJlY3QgY29uc3QmKSB7IG5vdEltcGxlbWVudGVkKCk7IH0KIHZv aWQgRmlsZUJ1dHRvbjo6c2V0RGlzYWJsZWQoYm9vbCkgeyBub3RJbXBsZW1lbnRlZCgpOyB9CiAK LVdpZGdldDo6Rm9jdXNQb2xpY3kgVGV4dEJveDo6Zm9jdXNQb2xpY3koKSBjb25zdCB7IG5vdElt cGxlbWVudGVkKCk7IHJldHVybiBOb0ZvY3VzOyB9CiBXaWRnZXQ6OkZvY3VzUG9saWN5IFNsaWRl cjo6Zm9jdXNQb2xpY3koKSBjb25zdCB7IG5vdEltcGxlbWVudGVkKCk7IHJldHVybiBOb0ZvY3Vz OyB9CiBXaWRnZXQ6OkZvY3VzUG9saWN5IExpc3RCb3g6OmZvY3VzUG9saWN5KCkgY29uc3QgeyBu b3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gTm9Gb2N1czsgfQogV2lkZ2V0OjpGb2N1c1BvbGljeSBU ZXh0RmllbGQ6OmZvY3VzUG9saWN5KCkgY29uc3QgeyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4g Tm9Gb2N1czsgfQo=