105198 2012-12-17 11:28:48 -0800 [BlackBerry] Improve DOMSupport visibleSelectionForClosestActualWordStart for content editable. 2012-12-17 12:31:12 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 792876 0 mifenton 2012-12-17 11:28:48 -0800 SSIA 792881 1 179772 mifenton 2012-12-17 11:31:02 -0800 Created attachment 179772 Patch 792887 2 179772 rwlbuis 2012-12-17 11:35:18 -0800 Comment on attachment 179772 Patch LGTM. 792928 3 179772 webkit.review.bot 2012-12-17 12:31:09 -0800 Comment on attachment 179772 Patch Clearing flags on attachment: 179772 Committed r137931: <http://trac.webkit.org/changeset/137931> 792929 4 webkit.review.bot 2012-12-17 12:31:12 -0800 All reviewed patches have been landed. Closing bug. 179772 2012-12-17 11:31:02 -0800 2012-12-17 12:31:08 -0800 Patch 0001-2012-12-17-Mike-Fenton-mifenton-rim.com.patch text/plain 5155 mifenton RnJvbSBiNmI3ODAyMGEyMmRjYzZkYmVlZTI5ZDA5MDNhNTAwMzI1ZjU4ODliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog TW9uLCAxNyBEZWMgMjAxMiAxMjo1MDo0MSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMTIt MTcgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMjU4MDM4LgoK ICAgICAgICBJbXByb3ZlIGNsb3Nlc3Qgd29yZCBtYXRjaGluZyBieSBnaXZpbmcgcHJlZmVyZW5j ZSB0byB0aGUgbGVmdCB3aGVuCiAgICAgICAgZGlzdGFuY2VzIGFyZSBlcXVhbC4KCiAgICAgICAg QWxzbyBlbmZvcmNlIGNvbnRhaW5lciBtYXRjaGluZyB0byBhdm9pZCBzZWxlY3RpbmcgdGhlIHBh cmFncmFwaAogICAgICAgIG1hcmtlciBpZiBhIENFIGRpdiBpcyBmb2xsb3dlZCBpbW1lZGlhdGVs eSBieSBhIENFIHBhcmFncmFwaC4KCiAgICAgICAgTWlub3IgcmVmYWN0b3IgLSBkb24ndCBjYWxj dWxhdGUgdGhlIGRpc3RhbmNlIGlmIHRoZSBzZWxlY3Rpb24KICAgICAgICBpc24ndCBvbiBhIHdv cmQuCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIFdlYktp dFN1cHBvcnQvRE9NU3VwcG9ydC5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6RE9N U3VwcG9ydDo6dmlzaWJsZVNlbGVjdGlvbkZvckNsb3Nlc3RBY3R1YWxXb3JkU3RhcnQpOgotLS0K IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAy MyArKysrKysrKysrKysrKysrKysrCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9ET01TdXBwb3J0LmNwcCB8ICAgMjQgKysrKysrKysrKysrLS0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZwppbmRleCBiN2NkZTcyLi4zYzc5OTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0xMi0xNyAgTWlrZSBGZW50b24gIDxtaWZl bnRvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBJbXByb3ZlIERPTVN1cHBvcnQg dmlzaWJsZVNlbGVjdGlvbkZvckNsb3Nlc3RBY3R1YWxXb3JkU3RhcnQgZm9yIGNvbnRlbnQgZWRp dGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDUxOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ UiAyNTgwMzguCisKKyAgICAgICAgSW1wcm92ZSBjbG9zZXN0IHdvcmQgbWF0Y2hpbmcgYnkgZ2l2 aW5nIHByZWZlcmVuY2UgdG8gdGhlIGxlZnQgd2hlbgorICAgICAgICBkaXN0YW5jZXMgYXJlIGVx dWFsLgorCisgICAgICAgIEFsc28gZW5mb3JjZSBjb250YWluZXIgbWF0Y2hpbmcgdG8gYXZvaWQg c2VsZWN0aW5nIHRoZSBwYXJhZ3JhcGgKKyAgICAgICAgbWFya2VyIGlmIGEgQ0UgZGl2IGlzIGZv bGxvd2VkIGltbWVkaWF0ZWx5IGJ5IGEgQ0UgcGFyYWdyYXBoLgorCisgICAgICAgIE1pbm9yIHJl ZmFjdG9yIC0gZG9uJ3QgY2FsY3VsYXRlIHRoZSBkaXN0YW5jZSBpZiB0aGUgc2VsZWN0aW9uCisg ICAgICAgIGlzbid0IG9uIGEgd29yZC4KKworICAgICAgICBSZXZpZXdlZCBJbnRlcm5hbGx5IGJ5 IEdlbiBNYWsgYW5kIE5pbWEgR2hhbmF2YXRpYW4uCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0 L0RPTVN1cHBvcnQuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0 Ojp2aXNpYmxlU2VsZWN0aW9uRm9yQ2xvc2VzdEFjdHVhbFdvcmRTdGFydCk6CisKIDIwMTItMTIt MTcgIEFudGhvbnkgU2NpYW4gIDxhc2NpYW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tiZXJy eV0gU3RhdGljIGNvZGUgYW5hbHlzaXMgd2FybmluZyBmaXhlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcAppbmRleCAwZDBh YjNkLi40N2ZmMWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9ET01TdXBwb3J0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcApAQCAtNDY3LDI0ICs0NjcsMzAgQEAgVmlzaWJsZVNl bGVjdGlvbiB2aXNpYmxlU2VsZWN0aW9uRm9yQ2xvc2VzdEFjdHVhbFdvcmRTdGFydChjb25zdCBW aXNpYmxlU2VsZWN0aW8KICAgICAvLyBpdCBzZWxlY3RzIHRoZSBwYXJhZ3JhcGggbWFya2VyLiBB cyB3ZWxsLCBpZiB0aGUgcG9zaXRpb24gaXMgYXQgdGhlIGVuZCBvZiBhIHdvcmQsIGl0IHdpbGwg c2VsZWN0CiAgICAgLy8gb25seSB0aGUgc3BhY2UgYmV0d2VlbiB3b3Jkcy4gV2Ugd2FudCB0byBz ZWxlY3QgYW4gYWN0dWFsIHdvcmQgc28gd2UgbW92ZSB0aGUgc2VsZWN0aW9uIHRvCiAgICAgLy8g dGhlIHN0YXJ0IG9mIHRoZSBsZWZ0bW9zdCB3b3JkIGlmIHRoZSBjaGFyYWN0ZXIgYWZ0ZXIgdGhl IHNlbGVjdGlvbiBwb2ludCBpcyB3aGl0ZXNwYWNlLgorCiAgICAgaWYgKHNlbGVjdGlvbi5zZWxl Y3Rpb25UeXBlKCkgIT0gVmlzaWJsZVNlbGVjdGlvbjo6UmFuZ2VTZWxlY3Rpb24pIHsKLSAgICAg ICAgVmlzaWJsZVNlbGVjdGlvbiBsZWZ0U2VsZWN0aW9uKHByZXZpb3VzV29yZFBvc2l0aW9uKHNl bGVjdGlvbi5zdGFydCgpKSk7Ci0gICAgICAgIGJvb2wgbGVmdFNlbGVjdGlvbklzT25Xb3JkID0g IWlzV2hpdGVzcGFjZShsZWZ0U2VsZWN0aW9uLnZpc2libGVTdGFydCgpLmNoYXJhY3RlckFmdGVy KCkpOworICAgICAgICBpbnQgbGVmdERpc3RhbmNlID0gMDsKKyAgICAgICAgaW50IHJpZ2h0RGlz dGFuY2UgPSAwOwogCi0gICAgICAgIFZpc2libGVTZWxlY3Rpb24gcmFuZ2VTZWxlY3Rpb24oZW5k T2ZXb3JkKGxlZnRTZWxlY3Rpb24uc3RhcnQoKSksIHNlbGVjdGlvbi52aXNpYmxlU3RhcnQoKSk7 Ci0gICAgICAgIGludCBsZWZ0RGlzdGFuY2UgPSBUZXh0SXRlcmF0b3I6OnJhbmdlTGVuZ3RoKHJh bmdlU2VsZWN0aW9uLnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCkpOworICAgICAgICBWaXNpYmxl U2VsZWN0aW9uIGxlZnRTZWxlY3Rpb24ocHJldmlvdXNXb3JkUG9zaXRpb24oc2VsZWN0aW9uLnN0 YXJ0KCkpKTsKKyAgICAgICAgYm9vbCBsZWZ0U2VsZWN0aW9uSXNPbldvcmQgPSAhaXNXaGl0ZXNw YWNlKGxlZnRTZWxlY3Rpb24udmlzaWJsZVN0YXJ0KCkuY2hhcmFjdGVyQWZ0ZXIoKSkgJiYgbGVm dFNlbGVjdGlvbi5zdGFydCgpLmNvbnRhaW5lck5vZGUoKSA9PSBzZWxlY3Rpb24uc3RhcnQoKS5j b250YWluZXJOb2RlKCk7CisgICAgICAgIGlmIChsZWZ0U2VsZWN0aW9uSXNPbldvcmQpIHsKKyAg ICAgICAgICAgIFZpc2libGVTZWxlY3Rpb24gcmFuZ2VTZWxlY3Rpb24oZW5kT2ZXb3JkKGxlZnRT ZWxlY3Rpb24uc3RhcnQoKSksIHNlbGVjdGlvbi52aXNpYmxlU3RhcnQoKSk7CisgICAgICAgICAg ICBsZWZ0RGlzdGFuY2UgPSBUZXh0SXRlcmF0b3I6OnJhbmdlTGVuZ3RoKHJhbmdlU2VsZWN0aW9u LnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCkpOworICAgICAgICB9CiAKICAgICAgICAgVmlzaWJs ZVNlbGVjdGlvbiByaWdodFNlbGVjdGlvbiA9IHByZXZpb3VzV29yZFBvc2l0aW9uKG5leHRXb3Jk UG9zaXRpb24oc2VsZWN0aW9uLnN0YXJ0KCkpKTsKLSAgICAgICAgYm9vbCByaWdodFNlbGVjdGlv bklzT25Xb3JkID0gIWlzV2hpdGVzcGFjZShyaWdodFNlbGVjdGlvbi52aXNpYmxlU3RhcnQoKS5j aGFyYWN0ZXJBZnRlcigpKTsKLQotICAgICAgICByYW5nZVNlbGVjdGlvbiA9IFZpc2libGVTZWxl Y3Rpb24ocmlnaHRTZWxlY3Rpb24udmlzaWJsZVN0YXJ0KCksIHNlbGVjdGlvbi52aXNpYmxlU3Rh cnQoKSk7Ci0gICAgICAgIGludCByaWdodERpc3RhbmNlID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUxl bmd0aChyYW5nZVNlbGVjdGlvbi50b05vcm1hbGl6ZWRSYW5nZSgpLmdldCgpKTsKKyAgICAgICAg Ym9vbCByaWdodFNlbGVjdGlvbklzT25Xb3JkID0gIWlzV2hpdGVzcGFjZShyaWdodFNlbGVjdGlv bi52aXNpYmxlU3RhcnQoKS5jaGFyYWN0ZXJBZnRlcigpKSAmJiByaWdodFNlbGVjdGlvbi5zdGFy dCgpLmNvbnRhaW5lck5vZGUoKSA9PSBzZWxlY3Rpb24uc3RhcnQoKS5jb250YWluZXJOb2RlKCk7 CisgICAgICAgIGlmIChyaWdodFNlbGVjdGlvbklzT25Xb3JkKSB7CisgICAgICAgICAgICBWaXNp YmxlU2VsZWN0aW9uIHJhbmdlU2VsZWN0aW9uID0gVmlzaWJsZVNlbGVjdGlvbihyaWdodFNlbGVj dGlvbi52aXNpYmxlU3RhcnQoKSwgc2VsZWN0aW9uLnZpc2libGVTdGFydCgpKTsKKyAgICAgICAg ICAgIHJpZ2h0RGlzdGFuY2UgPSBUZXh0SXRlcmF0b3I6OnJhbmdlTGVuZ3RoKHJhbmdlU2VsZWN0 aW9uLnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCkpOworICAgICAgICB9CiAKICAgICAgICAgLy8g TWFrZSBzdXJlIHdlIGZvdW5kIGFuIGFjdHVhbCB3b3JkLiBJZiBub3QsIHJldHVybiB0aGUgb3Jp Z2luYWwgc2VsZWN0aW9uLgogICAgICAgICBpZiAoIWxlZnRTZWxlY3Rpb25Jc09uV29yZCAmJiAh cmlnaHRTZWxlY3Rpb25Jc09uV29yZCkKICAgICAgICAgICAgIHJldHVybiBzZWxlY3Rpb247CiAK LSAgICAgICAgaWYgKCFyaWdodFNlbGVjdGlvbklzT25Xb3JkIHx8IChsZWZ0U2VsZWN0aW9uSXNP bldvcmQgJiYgbGVmdERpc3RhbmNlIDwgcmlnaHREaXN0YW5jZSkpIHsKKyAgICAgICAgaWYgKCFy aWdodFNlbGVjdGlvbklzT25Xb3JkIHx8IChsZWZ0U2VsZWN0aW9uSXNPbldvcmQgJiYgbGVmdERp c3RhbmNlIDw9IHJpZ2h0RGlzdGFuY2UpKSB7CiAgICAgICAgICAgICAvLyBMZWZ0IGlzIGNsb3Nl ciBvciByaWdodCBpcyBpbnZhbGlkLgogICAgICAgICAgICAgcmV0dXJuIGxlZnRTZWxlY3Rpb247 CiAgICAgICAgIH0KLS0gCjEuNy45LjUKCg==