105187 2012-12-17 09:09:47 -0800 [WK2] ManualTests/window-geometry.html contents is shaking while scrolling 2014-02-05 11:15:40 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 105978 108820 1 mikhail.pozdnyakov mikhail.pozdnyakov abecsi benjamin cdumez eflews.bot gyuyoung.kim gyuyoung.kim jturcotte kenneth lucas.de.marchi mikhail.pozdnyakov noam simon.fraser tmpsantos webkit.review.bot zeno oldest_to_newest 792770 0 mikhail.pozdnyakov 2012-12-17 09:09:47 -0800 1) Launch ManualTests/window-geometry.html test with EFL WK2 mini browser 2) Scroll main window -> both main window contents and little windows are shaking 792772 1 kenneth 2012-12-17 09:11:55 -0800 It seems to not be scrolling correctly at all to me. Ie. the scrollBy scrolls but asks to scroll again before it gets its uptodate position. That could cause the shaking... moving to new position, reading the old position and moving back. 792777 2 kenneth 2012-12-17 09:20:02 -0800 Adding some Qt guys. Do you have similar issues on Qt side? 792804 3 abecsi 2012-12-17 09:51:45 -0800 (In reply to comment #2) > Adding some Qt guys. Do you have similar issues on Qt side? AFAIK opening additional windows / dialogs from JS would need client-side QML on Qt, which is not implemented right now in MiniBrowser. But the main window seems to scroll correctly in MiniBrowser, without any "shaking". 792809 4 abecsi 2012-12-17 09:58:17 -0800 (In reply to comment #1) > It seems to not be scrolling correctly at all to me. > > Ie. the scrollBy scrolls but asks to scroll again before it gets its uptodate position. That could cause the shaking... moving to new position, reading the old position and moving back. I'm not familiar with EFL, but this almost sounds like event delivery issues (eg. both the UI and WebCore try to apply the scroll delta and this conflicts). Does EFL use delegated scrolling or does WebCore handle scroll events? Or an incorrectly updated visible rect could also be a source of the issue. 792831 5 kenneth 2012-12-17 10:33:48 -0800 We are using delegated scrolling. Very much same arch as Qt. 793576 6 mikhail.pozdnyakov 2012-12-18 05:40:49 -0800 var before = document.body.scrollTop; window.scrollBy(0, 10 * sign); if (before == document.body.scrollTop) { sign = sign * -1; } the problem is that document.body.scrollTop is not updated immediately after window.scrollBy(0, 10 * sign); so it changes sign every time. 794708 7 180174 mikhail.pozdnyakov 2012-12-19 08:46:04 -0800 Created attachment 180174 preliminary patch. 795025 8 180174 kenneth 2012-12-19 16:30:54 -0800 Comment on attachment 180174 preliminary patch. View in context: https://bugs.webkit.org/attachment.cgi?id=180174&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1428 > void WebPage::pageDidRequestScroll(const IntPoint& point) > { > send(Messages::WebPageProxy::PageDidRequestScroll(point)); I think we need to turn this into a non-request. A request can be ignored, and that is not what we are doing here. It can only be called from javascript (which is supposed to be suspended when we are interaction with the page) or by the session history, which already checks whether someone interacted (but that doesn't combine 100% with PageViewportHandler::hadUserInteraction - but there is a bug about that) > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1438 > + // it might not be possible to scroll the last pixel and that affects fixed position elements. > + FloatRect bounds; > + bounds.setWidth(std::max(float(0), view->contentsSize().width() - floorf(m_viewportSize.width() / m_scale))); > + bounds.setHeight(std::max(float(0), view->contentsSize().height() - floorf(m_viewportSize.height() / m_scale))); Why can't you use the current one instead of introducing m_scale? We really need to move to use pageScaleFactor 805842 9 180174 benjamin 2013-01-12 00:03:47 -0800 Comment on attachment 180174 preliminary patch. View in context: https://bugs.webkit.org/attachment.cgi?id=180174&action=review This is an interesting idea, but it needs good test coverage. This raises interesting questions like how to drive this properly when you have JavaScript and User initiated scrolling going on simultaneously. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:249 > +#if USE(TILED_BACKING_STORE) > + , m_scale(1) > +#endif WebPage already has a concept of scaleFactor. Why introduce a new scale here? The name is also too generic given the existing support for scaling. > Source/WebKit2/WebProcess/WebPage/WebPage.h:888 > #if USE(TILED_BACKING_STORE) > WebCore::IntSize m_viewportSize; > + float m_scale; > #endif This has nothing to do with TILED_BACKING_STORE. 805843 10 benjamin 2013-01-12 00:04:41 -0800 The EFL tag is misleading here, removing it. 806149 11 mikhail.pozdnyakov 2013-01-14 01:18:22 -0800 (In reply to comment #9) > (From update of attachment 180174 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180174&action=review > > This is an interesting idea, but it needs good test coverage. > > This raises interesting questions like how to drive this properly when you have JavaScript and User initiated scrolling going on simultaneously. > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:249 > > +#if USE(TILED_BACKING_STORE) > > + , m_scale(1) > > +#endif > > WebPage already has a concept of scaleFactor. Why introduce a new scale here? > The name is also too generic given the existing support for scaling. > Fully agree, but the problem is that we currently do not consider scale factors from WebCore. That is why this bug depends on bug#105978. > > Source/WebKit2/WebProcess/WebPage/WebPage.h:888 > > #if USE(TILED_BACKING_STORE) > > WebCore::IntSize m_viewportSize; > > + float m_scale; > > #endif > > This has nothing to do with TILED_BACKING_STORE. Indeed :) it is rather delegated scrolling code, however all the related code is inside TILED_BACKING_STORE guards for some reason. Thank you for review! 822823 12 186057 mikhail.pozdnyakov 2013-02-01 08:45:39 -0800 Created attachment 186057 patch Updated since the dependent bug is closed an pageScaleFactor can be used. 822830 13 noam 2013-02-01 08:58:04 -0800 This looks fine to me. 822865 14 186057 kenneth 2013-02-01 09:28:57 -0800 Comment on attachment 186057 patch View in context: https://bugs.webkit.org/attachment.cgi?id=186057&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1454 > + // We need to update 'FixedVisibleContentRect' right away, so that > + // JS window properties have updated values even before actual delegated scrolling happens. > + FrameView* view = m_page->mainFrame()->view(); Need to update the visible content rect immediately so that DOM Window properties have correct values before the actual delegates scroll happens. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1465 > + // Unfortunately it doesn't seem to be enough, so just always allow one pixel more. > + position.setX(clampTo(point.x(), bounds.x(), bounds.width()) + 1); > + position.setY(clampTo(point.y(), bounds.y(), bounds.height()) + 1); We should try to fix this instead of adding workarounds, or at least understand what is going on. 824312 15 mikhail.pozdnyakov 2013-02-04 06:33:46 -0800 (In reply to comment #14) > (From update of attachment 186057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186057&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1454 > > + // We need to update 'FixedVisibleContentRect' right away, so that > > + // JS window properties have updated values even before actual delegated scrolling happens. > > + FrameView* view = m_page->mainFrame()->view(); > > Need to update the visible content rect immediately so that DOM Window properties have > correct values before the actual delegates scroll happens. > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1465 > > + // Unfortunately it doesn't seem to be enough, so just always allow one pixel more. > > + position.setX(clampTo(point.x(), bounds.x(), bounds.width()) + 1); > > + position.setY(clampTo(point.y(), bounds.y(), bounds.height()) + 1); > > We should try to fix this instead of adding workarounds, or at least understand what is going on. Ok, it should be fixed in viewport controller first, so put this bug as a dependency for the dedicated one. 824338 16 186371 mikhail.pozdnyakov 2013-02-04 07:24:30 -0800 Created attachment 186371 patch v3 Updated after bug#108820 is fixed and due to Kenneth comments. 879770 17 186371 eflews.bot 2013-04-23 03:26:38 -0700 Comment on attachment 186371 patch v3 Attachment 186371 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/157741 976970 18 186371 kling 2014-02-05 11:15:40 -0800 Comment on attachment 186371 patch v3 Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 180174 2012-12-19 08:46:04 -0800 2013-02-01 08:45:39 -0800 preliminary patch. bug105187 text/plain 4815 mikhail.pozdnyakov Y29tbWl0IGE1ZWM0NTJkMTA3NTRiNWU0MzMxYmZiN2QyMzVkODk4OTczZTFiMjAKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIERlYyAxOSAxODo0MDozNSAyMDEyICswMjAwCgogICAgYnVnMTA1MTg3CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IDUzOWRlZmQuLmE3NWVmODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMi0x Mi0xOSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdIE1hbnVhbFRlc3RzL3dpbmRvdy1nZW9tZXRyeS5odG1sIGNv bnRlbnRzIGlzIHNoYWtpbmcgd2hpbGUgc2Nyb2xsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUxODcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCBkb2N1bWVudC5i b2R5LnNjcm9sbFRvcCB3YXMgbm90IHVwZGF0ZWQgaW1tZWRpYXRlbHkgYWZ0ZXIKKyAgICAgICAg d2luZG93LnNjcm9sbEJ5KCkgY2FsbC4gVGhlIHJlYXNvbiBmb3IgdGhhdCBpcyBkZWxlZ2F0ZWQg c2Nyb2xsaW5nOiB0aGUgdmlldworICAgICAgICAnRml4ZWRWaXNpYmxlQ29udGVudFJlY3QnIGhh ZCBvbGQgdmFsdWUgYmVmb3JlIG5vdGlmaWNhdGlvbiBmcm9tIFVJIHByb2Nlc3MKKyAgICAgICAg d2FzIHJlY2VpdmVkLgorCisgICAgICAgIFNvbHV0aW9uIGlzIHRvIGNhbGN1bGF0ZSBhbmQgc2V0 ICdGaXhlZFZpc2libGVDb250ZW50UmVjdCcgcmlnaHQgYXdheSBpbnNpZGUKKyAgICAgICAgd2Vi IHByb2Nlc3MuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFw aGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb29y ZGluYXRlZExheWVyVHJlZUhvc3Q6OnNldFZpc2libGVDb250ZW50c1JlY3QpOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZTo6V2ViUGFnZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnBhZ2VEaWRSZXF1ZXN0U2Ny b2xsKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlOjpzZXRTY2FsZSk6CisgICAgICAgIChXZWJQYWdlKToKKwogMjAxMi0x Mi0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1v dmUgdW5uZWNlc3NhcnkgZnVuY3Rpb25zIGZyb20gQ29va2llc1N0cmF0ZWd5CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcApp bmRleCA0ODQ0NDUwLi4xYmQyZTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKQEAgLTcyOSw2ICs3MjksNyBAQCB2 b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6c2V0VmlzaWJsZUNvbnRlbnRzUmVjdChjb25z dCBGbG9hdFJlY3QmIHJlY3QsIGZsbwogICAgICAgICAvLyBSb3VuZCB0aGUgcmVjdCBpbnN0ZWFk IG9mIGVuY2xvc2luZyBpdCB0byBtYWtlIHN1cmUgdGhhdCBpdHMgc2l6ZSBzdGF5cwogICAgICAg ICAvLyB0aGUgc2FtZSB3aGlsZSBwYW5uaW5nLiBUaGlzIGNhbiBoYXZlIG5hc3R5IGVmZmVjdHMg b24gbGF5b3V0LgogICAgICAgICBtX3dlYlBhZ2UtPnNldEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0 KHJvdW5kZWRJbnRSZWN0KHJlY3QpKTsKKyAgICAgICAgbV93ZWJQYWdlLT5zZXRTY2FsZShzY2Fs ZSk7CiAgICAgfQogCiAgICAgaWYgKGNvbnRlbnRzUmVjdERpZENoYW5nZSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCAwMzA2NDU3Li5jMzFl Mzk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw CkBAIC0yNDQsNiArMjQ0LDkgQEAgV2ViUGFnZTo6V2ViUGFnZSh1aW50NjRfdCBwYWdlSUQsIGNv bnN0IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMpCiAgICAgLCBtX2FjY2Vz c2liaWxpdHlPYmplY3QoMCkKICNlbmRpZgogICAgICwgbV9zZXRDYW5TdGFydE1lZGlhVGltZXIo V2ViUHJvY2Vzczo6c2hhcmVkKCkucnVuTG9vcCgpLCB0aGlzLCAmV2ViUGFnZTo6c2V0Q2FuU3Rh cnRNZWRpYVRpbWVyRmlyZWQpCisjaWYgVVNFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCisgICAgLCBt X3NjYWxlKDEpCisjZW5kaWYKICAgICAsIG1fZmluZENvbnRyb2xsZXIodGhpcykKICNpZiBFTkFC TEUoVE9VQ0hfRVZFTlRTKQogI2lmIFBMQVRGT1JNKFFUKQpAQCAtMTQyMyw2ICsxNDI2LDIzIEBA IHZvaWQgV2ViUGFnZTo6cGFnZURpZFNjcm9sbCgpCiB2b2lkIFdlYlBhZ2U6OnBhZ2VEaWRSZXF1 ZXN0U2Nyb2xsKGNvbnN0IEludFBvaW50JiBwb2ludCkKIHsKICAgICBzZW5kKE1lc3NhZ2VzOjpX ZWJQYWdlUHJveHk6OlBhZ2VEaWRSZXF1ZXN0U2Nyb2xsKHBvaW50KSk7CisKKyAgICAvLyBXZSBu ZWVkIHRvIHVwZGF0ZSAnRml4ZWRWaXNpYmxlQ29udGVudFJlY3QnIHJpZ2h0IGF3YXksIHNvIHRo YXQKKyAgICAvLyBKUyB3aW5kb3cgcHJvcGVydGllcyBoYXZlIHVwZGF0ZWQgdmFsdWVzIGV2ZW4g YmVmb3JlIGFjdHVhbCBkZWxlZ2F0ZWQgc2Nyb2xsaW5nIGhhcHBlbnMuCisgICAgRnJhbWVWaWV3 KiB2aWV3ID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+dmlldygpOworCisgICAgLy8gV2UgbmVlZCB0 byBmbG9vciB0aGUgdmlld3BvcnQgaGVyZSBhcyB0byBhbGxvdyBhbGlnbmluZyB0aGUgY29udGVu dCBpbiBkZXZpY2UgdW5pdHMuIElmIG5vdCwKKyAgICAvLyBpdCBtaWdodCBub3QgYmUgcG9zc2li bGUgdG8gc2Nyb2xsIHRoZSBsYXN0IHBpeGVsIGFuZCB0aGF0IGFmZmVjdHMgZml4ZWQgcG9zaXRp b24gZWxlbWVudHMuCisgICAgRmxvYXRSZWN0IGJvdW5kczsKKyAgICBib3VuZHMuc2V0V2lkdGgo c3RkOjptYXgoZmxvYXQoMCksIHZpZXctPmNvbnRlbnRzU2l6ZSgpLndpZHRoKCkgLSBmbG9vcmYo bV92aWV3cG9ydFNpemUud2lkdGgoKSAvIG1fc2NhbGUpKSk7CisgICAgYm91bmRzLnNldEhlaWdo dChzdGQ6Om1heChmbG9hdCgwKSwgdmlldy0+Y29udGVudHNTaXplKCkuaGVpZ2h0KCkgLSBmbG9v cmYobV92aWV3cG9ydFNpemUuaGVpZ2h0KCkgLyBtX3NjYWxlKSkpOworCisgICAgRmxvYXRQb2lu dCBwb3NpdGlvbjsKKyAgICAvLyBVbmZvcnR1bmF0ZWx5IGl0IGRvZXNuJ3Qgc2VlbSB0byBiZSBl bm91Z2gsIHNvIGp1c3QgYWx3YXlzIGFsbG93IG9uZSBwaXhlbCBtb3JlLgorICAgIHBvc2l0aW9u LnNldFgoY2xhbXBUbyhwb2ludC54KCksIGJvdW5kcy54KCksIGJvdW5kcy53aWR0aCgpKSArIDEp OworICAgIHBvc2l0aW9uLnNldFkoY2xhbXBUbyhwb2ludC55KCksIGJvdW5kcy55KCksIGJvdW5k cy5oZWlnaHQoKSkgKyAxKTsKKworICAgIHNldEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0KEludFJl Y3Qocm91bmRlZEludFBvaW50KHBvc2l0aW9uKSwgdmlldy0+Zml4ZWRWaXNpYmxlQ29udGVudFJl Y3QoKS5zaXplKCkpKTsKIH0KICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuaAppbmRleCA0NGIyODkxLi4wYWZmNjkwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKQEAgLTM4NCw2ICszODQsNyBAQCBwdWJs aWM6CiAgICAgdm9pZCBzZW5kVmlld3BvcnRBdHRyaWJ1dGVzQ2hhbmdlZCgpOwogICAgIHZvaWQg c2V0Vmlld3BvcnRTaXplKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKTsKICAgICBXZWJDb3JlOjpJ bnRTaXplIHZpZXdwb3J0U2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmlld3BvcnRTaXplOyB9Cisg ICAgdm9pZCBzZXRTY2FsZShmbG9hdCBzY2FsZSkgeyBtX3NjYWxlID0gc2NhbGU7IH0KICNlbmRp ZgogCiAjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCkBAIC04ODMsNiArODg0LDcgQEAgcHJpdmF0 ZToKIAogI2lmIFVTRShUSUxFRF9CQUNLSU5HX1NUT1JFKQogICAgIFdlYkNvcmU6OkludFNpemUg bV92aWV3cG9ydFNpemU7CisgICAgZmxvYXQgbV9zY2FsZTsKICNlbmRpZgogCiAgICAgRmluZENv bnRyb2xsZXIgbV9maW5kQ29udHJvbGxlcjsK 186057 2013-02-01 08:45:39 -0800 2013-02-04 07:24:30 -0800 patch bug105187_v2 text/plain 2788 mikhail.pozdnyakov Y29tbWl0IDM2MjkzOTU0NWEwNGUzY2JjZTEzZDM4Y2EwOWE5MTRmNDhlMWFkMzMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg RnJpIEZlYiAxIDE4OjQwOjQ1IDIwMTMgKzAyMDAKCiAgICBidWcxMDUxODcKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggNzNkZTQzMy4uOTg2YzMyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTAy LTAxICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgog CisgICAgICAgIFtXSzJdIE1hbnVhbFRlc3RzL3dpbmRvdy1nZW9tZXRyeS5odG1sIGNvbnRlbnRz IGlzIHNoYWtpbmcgd2hpbGUgc2Nyb2xsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUxODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCBkb2N1bWVudC5ib2R5LnNj cm9sbFRvcCB3YXMgbm90IHVwZGF0ZWQgaW1tZWRpYXRlbHkgYWZ0ZXIKKyAgICAgICAgd2luZG93 LnNjcm9sbEJ5KCkgY2FsbC4gVGhlIHJlYXNvbiBmb3IgdGhhdCBpcyBkZWxlZ2F0ZWQgc2Nyb2xs aW5nOiB0aGUgdmlldworICAgICAgICAnRml4ZWRWaXNpYmxlQ29udGVudFJlY3QnIGhhZCBvbGQg dmFsdWUgYmVmb3JlIG5vdGlmaWNhdGlvbiBmcm9tIFVJIHByb2Nlc3MKKyAgICAgICAgd2FzIHJl Y2VpdmVkLgorCisgICAgICAgIFNvbHV0aW9uIGlzIHRvIGNhbGN1bGF0ZSBhbmQgc2V0ICdGaXhl ZFZpc2libGVDb250ZW50UmVjdCcgcmlnaHQgYXdheSBpbnNpZGUKKyAgICAgICAgd2ViIHByb2Nl c3MuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2U6OnBhZ2VEaWRSZXF1ZXN0U2Nyb2xsKToKKworMjAxMy0wMi0wMSAg TWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKwogICAg ICAgICBbRUZMXVtXSzJdIEV3a0NvbnRleHQgc2hvdWxkIGJlIGJhc2VkIG9uIEMgV0syIEFQSQog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NjY2CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCAx ODdjZGU5Li44YWU5ZGRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwCkBAIC0xNDQ5LDYgKzE0NDksMjIgQEAgdm9pZCBXZWJQYWdlOjpwYWdlRGlk U2Nyb2xsKCkKICNpZiBVU0UoVElMRURfQkFDS0lOR19TVE9SRSkKIHZvaWQgV2ViUGFnZTo6cGFn ZURpZFJlcXVlc3RTY3JvbGwoY29uc3QgSW50UG9pbnQmIHBvaW50KQogeworICAgIC8vIFdlIG5l ZWQgdG8gdXBkYXRlICdGaXhlZFZpc2libGVDb250ZW50UmVjdCcgcmlnaHQgYXdheSwgc28gdGhh dAorICAgIC8vIEpTIHdpbmRvdyBwcm9wZXJ0aWVzIGhhdmUgdXBkYXRlZCB2YWx1ZXMgZXZlbiBi ZWZvcmUgYWN0dWFsIGRlbGVnYXRlZCBzY3JvbGxpbmcgaGFwcGVucy4KKyAgICBGcmFtZVZpZXcq IHZpZXcgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLT52aWV3KCk7CisKKyAgICAvLyBXZSBuZWVkIHRv IGZsb29yIHRoZSB2aWV3cG9ydCBoZXJlIGFzIHRvIGFsbG93IGFsaWduaW5nIHRoZSBjb250ZW50 IGluIGRldmljZSB1bml0cy4gSWYgbm90LAorICAgIC8vIGl0IG1pZ2h0IG5vdCBiZSBwb3NzaWJs ZSB0byBzY3JvbGwgdGhlIGxhc3QgcGl4ZWwgYW5kIHRoYXQgYWZmZWN0cyBmaXhlZCBwb3NpdGlv biBlbGVtZW50cy4KKyAgICBGbG9hdFJlY3QgYm91bmRzOworICAgIGJvdW5kcy5zZXRXaWR0aChz dGQ6Om1heChmbG9hdCgwKSwgdmlldy0+Y29udGVudHNTaXplKCkud2lkdGgoKSAtIGZsb29yZiht X3ZpZXdwb3J0U2l6ZS53aWR0aCgpIC8gcGFnZVNjYWxlRmFjdG9yKCkpKSk7CisgICAgYm91bmRz LnNldEhlaWdodChzdGQ6Om1heChmbG9hdCgwKSwgdmlldy0+Y29udGVudHNTaXplKCkuaGVpZ2h0 KCkgLSBmbG9vcmYobV92aWV3cG9ydFNpemUuaGVpZ2h0KCkgLyBwYWdlU2NhbGVGYWN0b3IoKSkp KTsKKyAgICBGbG9hdFBvaW50IHBvc2l0aW9uOworCisgICAgLy8gVW5mb3J0dW5hdGVseSBpdCBk b2Vzbid0IHNlZW0gdG8gYmUgZW5vdWdoLCBzbyBqdXN0IGFsd2F5cyBhbGxvdyBvbmUgcGl4ZWwg bW9yZS4KKyAgICBwb3NpdGlvbi5zZXRYKGNsYW1wVG8ocG9pbnQueCgpLCBib3VuZHMueCgpLCBi b3VuZHMud2lkdGgoKSkgKyAxKTsKKyAgICBwb3NpdGlvbi5zZXRZKGNsYW1wVG8ocG9pbnQueSgp LCBib3VuZHMueSgpLCBib3VuZHMuaGVpZ2h0KCkpICsgMSk7CisgICAgc2V0Rml4ZWRWaXNpYmxl Q29udGVudFJlY3QoSW50UmVjdChyb3VuZGVkSW50UG9pbnQocG9zaXRpb24pLCB2aWV3LT5maXhl ZFZpc2libGVDb250ZW50UmVjdCgpLnNpemUoKSkpOworCiAgICAgc2VuZChNZXNzYWdlczo6V2Vi UGFnZVByb3h5OjpQYWdlRGlkUmVxdWVzdFNjcm9sbChwb2ludCkpOwogfQogI2VuZGlmCg== 186371 2013-02-04 07:24:30 -0800 2014-02-05 11:15:40 -0800 patch v3 bug105187_v3 text/plain 2680 mikhail.pozdnyakov Y29tbWl0IDI2ZjUyMjc2ZTMyNjg4Nzc4ODMzMzZmMTBmOTNiYmFmN2E5MGM2OGUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIEZlYiA0IDE3OjA3OjE5IDIwMTMgKzAyMDAKCiAgICBidWcxMDUxODcKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggODZmYTExYS4uM2ExZWU4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTAy LTA0ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgog CisgICAgICAgIFtXSzJdIE1hbnVhbFRlc3RzL3dpbmRvdy1nZW9tZXRyeS5odG1sIGNvbnRlbnRz IGlzIHNoYWtpbmcgd2hpbGUgc2Nyb2xsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUxODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCBkb2N1bWVudC5ib2R5LnNj cm9sbFRvcCB3YXMgbm90IHVwZGF0ZWQgaW1tZWRpYXRlbHkgYWZ0ZXIKKyAgICAgICAgd2luZG93 LnNjcm9sbEJ5KCkgY2FsbC4gVGhlIHJlYXNvbiBmb3IgdGhhdCBpcyBkZWxlZ2F0ZWQgc2Nyb2xs aW5nOiB0aGUgdmlldworICAgICAgICAnRml4ZWRWaXNpYmxlQ29udGVudFJlY3QnIGhhZCBvbGQg dmFsdWUgYmVmb3JlIG5vdGlmaWNhdGlvbiBmcm9tIFVJIHByb2Nlc3MKKyAgICAgICAgd2FzIHJl Y2VpdmVkLgorCisgICAgICAgIFNvbHV0aW9uIGlzIHRvIGNhbGN1bGF0ZSBhbmQgc2V0ICdGaXhl ZFZpc2libGVDb250ZW50UmVjdCcgcmlnaHQgYXdheSBpbnNpZGUKKyAgICAgICAgd2ViIHByb2Nl c3MuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2U6OnBhZ2VEaWRSZXF1ZXN0U2Nyb2xsKToKKworMjAxMy0wMi0wNCAg TWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKwogICAg ICAgICBbV0syXVtFRkxdIFdlaXJkIHN0cmlwZSBhdCB0aGUgZW5kIG9mIHRoZSBwYWdlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg4MjAKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDE4N2Nk ZTkuLmY0Yjg3NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKQEAgLTE0NDksNiArMTQ0OSwyMSBAQCB2b2lkIFdlYlBhZ2U6OnBhZ2VEaWRTY3Jv bGwoKQogI2lmIFVTRShUSUxFRF9CQUNLSU5HX1NUT1JFKQogdm9pZCBXZWJQYWdlOjpwYWdlRGlk UmVxdWVzdFNjcm9sbChjb25zdCBJbnRQb2ludCYgcG9pbnQpCiB7CisgICAgLy8gTmVlZCB0byB1 cGRhdGUgdGhlIHZpc2libGUgY29udGVudCByZWN0IGltbWVkaWF0ZWx5IHNvIHRoYXQgRE9NIFdp bmRvdyBwcm9wZXJ0aWVzIGhhdmUKKyAgICAvLyBjb3JyZWN0IHZhbHVlcyBiZWZvcmUgdGhlIGFj dHVhbCBkZWxlZ2F0ZXMgc2Nyb2xsIGhhcHBlbnMuCisgICAgRnJhbWVWaWV3KiB2aWV3ID0gbV9w YWdlLT5tYWluRnJhbWUoKS0+dmlldygpOworCisgICAgLy8gV2UgbmVlZCB0byBmbG9vciB0aGUg dmlld3BvcnQgaGVyZSBhcyB0byBhbGxvdyBhbGlnbmluZyB0aGUgY29udGVudCBpbiBkZXZpY2Ug dW5pdHMuIElmIG5vdCwKKyAgICAvLyBpdCBtaWdodCBub3QgYmUgcG9zc2libGUgdG8gc2Nyb2xs IHRoZSBsYXN0IHBpeGVsIGFuZCB0aGF0IGFmZmVjdHMgZml4ZWQgcG9zaXRpb24gZWxlbWVudHMu CisgICAgRmxvYXRSZWN0IGJvdW5kczsKKyAgICBib3VuZHMuc2V0V2lkdGgoc3RkOjptYXgoZmxv YXQoMCksIHZpZXctPmNvbnRlbnRzU2l6ZSgpLndpZHRoKCkgLSBmbG9vcmYobV92aWV3cG9ydFNp emUud2lkdGgoKSAvIHBhZ2VTY2FsZUZhY3RvcigpKSkpOworICAgIGJvdW5kcy5zZXRIZWlnaHQo c3RkOjptYXgoZmxvYXQoMCksIHZpZXctPmNvbnRlbnRzU2l6ZSgpLmhlaWdodCgpIC0gZmxvb3Jm KG1fdmlld3BvcnRTaXplLmhlaWdodCgpIC8gcGFnZVNjYWxlRmFjdG9yKCkpKSk7CisgICAgRmxv YXRQb2ludCBwb3NpdGlvbjsKKworICAgIHBvc2l0aW9uLnNldFgoY2xhbXBUbyhwb2ludC54KCks IGJvdW5kcy54KCksIGJvdW5kcy53aWR0aCgpKSk7CisgICAgcG9zaXRpb24uc2V0WShjbGFtcFRv KHBvaW50LnkoKSwgYm91bmRzLnkoKSwgYm91bmRzLmhlaWdodCgpKSk7CisgICAgc2V0Rml4ZWRW aXNpYmxlQ29udGVudFJlY3QoSW50UmVjdChyb3VuZGVkSW50UG9pbnQocG9zaXRpb24pLCB2aWV3 LT5maXhlZFZpc2libGVDb250ZW50UmVjdCgpLnNpemUoKSkpOworCiAgICAgc2VuZChNZXNzYWdl czo6V2ViUGFnZVByb3h5OjpQYWdlRGlkUmVxdWVzdFNjcm9sbChwb2ludCkpOwogfQogI2VuZGlm Cg==