105178 2012-12-17 07:27:51 -0800 GraphicsLayer's repaint count should update even when debugging option to show it is off 2012-12-17 09:20:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts dino simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 792709 0 graouts 2012-12-17 07:27:51 -0800 While you can turn on repaint counts for debugging redraws on composited layers, the count is not incremented when there is a repaint but the debug option to display the count is turned off. In order to facilitate https://bugs.webkit.org/show_bug.cgi?id=105024, we should always increment the repaint counter, even when the option is off. 792710 1 webkit-bug-importer 2012-12-17 07:28:44 -0800 <rdar://problem/12892473> 792735 2 179747 graouts 2012-12-17 08:22:21 -0800 Created attachment 179747 Patch 792779 3 179747 webkit.review.bot 2012-12-17 09:20:25 -0800 Comment on attachment 179747 Patch Clearing flags on attachment: 179747 Committed r137915: <http://trac.webkit.org/changeset/137915> 792780 4 webkit.review.bot 2012-12-17 09:20:29 -0800 All reviewed patches have been landed. Closing bug. 179747 2012-12-17 08:22:21 -0800 2012-12-17 09:20:25 -0800 Patch bug-105178-20121217171938.patch text/plain 2483 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU5ZjdmZmZlNDEyYzQ1 MTU3ZjRjZTJiZTVhYmMwODAzNmE0OTRhMy4uNDBhZDZjMzAyY2QyYzI3NWQzMjVkNzA2Mzk5N2E0 NDkyMmEzNzMzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTE3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgR3JhcGhpY3NMYXllcidz IHJlcGFpbnQgY291bnQgc2hvdWxkIHVwZGF0ZSBldmVuIHdoZW4gZGVidWdnaW5nIG9wdGlvbiB0 byBzaG93IGl0IGlzIG9mZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA1MTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVXBkYXRlIHRoZSByZXBhaW4gY291bnQgZXZlbiBpZiB0aGUgZGVidWcgb3B0aW9u IHRvIHNob3cgdGhlbSBpcyB0dXJuZWQgb2ZmLgorICAgICAgICBUaGlzIGFsbG93cyB0aGUgY291 bnQgdG8gYmUgYWNjdXJhdGUgaW4gYmV0d2VlbiB0b2dnbGVzIG9mIHRoZSBkZWJ1ZyBvcHRpb24K KyAgICAgICAgYW5kIHRvIGFsbG93IHRoZSBJbnNwZWN0b3JMYXllclRyZWVBZ2VudCB0byBnZXQg YWNjdXJhdGUgcmVzdWx0cyBhbnkgdGltZQorICAgICAgICB0aGUgbGF5ZXIgdHJlZSBpcyByZXF1 ZXN0ZWQgKHNlZSB3ZWJraXQub3JnL2IvMTA1MDI0KS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL21hYy9XZWJMYXllci5tbToKKyAgICAgICAgKGRyYXdMYXllckNvbnRlbnRzKToKKwog MjAxMi0xMi0xNiAgTWlobmVhIE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KIAogICAgICAg ICBbQ1NTUmVnaW9uc10gUHNldWRvLWVsZW1lbnRzIHNob3VsZCBub3QgYmUgZGlyZWN0bHkgY29s bGVjdGVkIGludG8gYSBuYW1lZCBmbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9tYWMvV2ViTGF5ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9tYWMvV2ViTGF5ZXIubW0KaW5kZXggZTQ2NjNhYmFmZmUxMjFjYWQwNzhlMDk2YjM3 Mzc4NTFiYzI3ZDQ0My4uNTY1YTExODBlOGFhMmNmYzllOTllMzYyMDkyZmM5YTRkOWQwNzEwMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dlYkxheWVy Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9XZWJMYXllci5t bQpAQCAtMTI4LDExICsxMjgsMTYgQEAgdm9pZCBkcmF3TGF5ZXJDb250ZW50cyhDR0NvbnRleHRS ZWYgY29udGV4dCwgQ0FMYXllciAqbGF5ZXIsIFdlYkNvcmU6OlBsYXRmb3JtQ0EKICAgICAvLyBS ZS1mZXRjaCB0aGUgbGF5ZXIgb3duZXIsIHNpbmNlIDxyZGFyOi8vcHJvYmxlbS85MTI1MTUxPiBp bmRpY2F0ZXMgdGhhdCBpdCBtaWdodCBoYXZlIGJlZW4gZGVzdHJveWVkIGR1cmluZyBwYWludGlu Zy4KICAgICBsYXllckNvbnRlbnRzID0gcGxhdGZvcm1MYXllci0+b3duZXIoKTsKICAgICBBU1NF UlQobGF5ZXJDb250ZW50cyk7CisKKyAgICAvLyBBbHdheXMgdXBkYXRlIHRoZSByZXBhaW4gY291 bnQgc28gdGhhdCBpdCdzIGFjY3VyYXRlIGV2ZW4gaWYgdGhlIGNvdW50IGl0c2VsZiBpcyBub3Qg c2hvd24uIFRoaXMgd2lsbCBiZSB1c2VmdWwKKyAgICAvLyBmb3IgdGhlIFdlYiBJbnNwZWN0b3Ig ZmVlZGluZyB0aGlzIGluZm9ybWF0aW9uIHRocm91Z2ggdGhlIExheWVyVHJlZUFnZW50LiAKKyAg ICBpbnQgcmVwYWludENvdW50ID0gbGF5ZXJDb250ZW50cy0+cGxhdGZvcm1DQUxheWVySW5jcmVt ZW50UmVwYWludENvdW50KCk7CisKICAgICBpZiAoIXBsYXRmb3JtTGF5ZXItPnVzZXNUaWxlQ2Fj aGVMYXllcigpICYmIGxheWVyQ29udGVudHMgJiYgbGF5ZXJDb250ZW50cy0+cGxhdGZvcm1DQUxh eWVyU2hvd1JlcGFpbnRDb3VudGVyKHBsYXRmb3JtTGF5ZXIpKSB7CiAgICAgICAgIGJvb2wgaXNU aWxlZExheWVyID0gW2xheWVyIGlzS2luZE9mQ2xhc3M6W0NBVGlsZWRMYXllciBjbGFzc11dOwog CiAgICAgICAgIGNoYXIgdGV4dFsxNl07IC8vIHRoYXQncyBhIGxvdCBvZiByZXBhaW50cwotICAg ICAgICBzbnByaW50Zih0ZXh0LCBzaXplb2YodGV4dCksICIlZCIsIGxheWVyQ29udGVudHMtPnBs YXRmb3JtQ0FMYXllckluY3JlbWVudFJlcGFpbnRDb3VudCgpKTsKKyAgICAgICAgc25wcmludGYo dGV4dCwgc2l6ZW9mKHRleHQpLCAiJWQiLCByZXBhaW50Q291bnQpOwogCiAgICAgICAgIENHUmVj dCBpbmRpY2F0b3JCb3ggPSBsYXllckJvdW5kczsKICAgICAgICAgaW5kaWNhdG9yQm94LnNpemUu d2lkdGggPSAxMiArIDEwICogc3RybGVuKHRleHQpOwo=