105175 2012-12-17 07:01:09 -0800 [WinCairo] Compile fix. 2012-12-18 09:31:04 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned eric ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 792697 0 peavo 2012-12-17 07:01:09 -0800 Some checks for USE(ACCELERATED_COMPOSITING) are missing. 792700 1 179735 peavo 2012-12-17 07:10:40 -0800 Created attachment 179735 Patch 792764 2 179735 simon.fraser 2012-12-17 08:58:57 -0800 Comment on attachment 179735 Patch I'd prefer to keep #ifdefs out of cross-platform code. In this case I think it's better to to keep canSafelyEstablishAStackingContext() and code that calls it, and #ifdef the impl of needsCompositedScrolling() to always return false. 793567 3 179925 peavo 2012-12-18 05:11:55 -0800 Created attachment 179925 Patch 793705 4 179925 simon.fraser 2012-12-18 08:57:45 -0800 Comment on attachment 179925 Patch Much better, thanks! 793727 5 179925 webkit.review.bot 2012-12-18 09:31:00 -0800 Comment on attachment 179925 Patch Clearing flags on attachment: 179925 Committed r138030: <http://trac.webkit.org/changeset/138030> 793728 6 webkit.review.bot 2012-12-18 09:31:04 -0800 All reviewed patches have been landed. Closing bug. 179735 2012-12-17 07:10:40 -0800 2012-12-18 05:11:44 -0800 Patch bug-105175-20121217160757.patch text/plain 1902 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzkwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTE3ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDUxNzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6IEFkZCBjaGVja3MgZm9yIFVTRShBQ0NFTEVS QVRFRF9DT01QT1NJVElORykuCisKIDIwMTItMTItMTcgIEV1Z2VuZSBLbHl1Y2huaWtvdiAgPGV1 c3Rhc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBwb3BvdmVy IGNvbnRlbnQgYWNjZXNzaWJsZSBmb3IgY2xpY2tzLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZpc2lvbiAxMzc4ODIpCisrKyBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OTIsNiArODky LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6dXBkYXRlUGFnaW5hdGlvbigpCiAgICAgfQogfQogCisj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogYm9vbCBSZW5kZXJMYXllcjo6Y2FuU2Fm ZWx5RXN0YWJsaXNoQVN0YWNraW5nQ29udGV4dCgpIGNvbnN0CiB7CiAgICAgaWYgKGlzU3RhY2tp bmdDb250ZXh0KCkgfHwgIXN0YWNraW5nQ29udGV4dCgpKQpAQCAtODk5LDYgKzkwMCw3IEBAIGJv b2wgUmVuZGVyTGF5ZXI6OmNhblNhZmVseUVzdGFibGlzaEFTdGEKIAogICAgIHJldHVybiBtX2Rl c2NlbmRhbnRzQXJlQ29udGlndW91c0luU3RhY2tpbmdPcmRlcjsKIH0KKyNlbmRpZgogCiB2b2lk IFJlbmRlckxheWVyOjpzZXRIYXNWaXNpYmxlQ29udGVudCgpCiB7IApAQCAtNTI3OCwxNSArNTI4 MCwxOSBAQCBib29sIFJlbmRlckxheWVyOjpzaG91bGRCZU5vcm1hbEZsb3dPbmx5CiAjaWYgRU5B QkxFKENTU19DT01QT1NJVElORykKICAgICAgICAgICAgICYmICFyZW5kZXJlcigpLT5oYXNCbGVu ZE1vZGUoKQogI2VuZGlmCi0gICAgICAgICAgICAmJiAhaXNUcmFuc3BhcmVudCgpCi0gICAgICAg ICAgICAmJiAhbmVlZHNDb21wb3NpdGVkU2Nyb2xsaW5nKCk7CisjaWYgVVNFKEFDQ0VMRVJBVEVE X0NPTVBPU0lUSU5HKQorICAgICAgICAgICAgJiYgIW5lZWRzQ29tcG9zaXRlZFNjcm9sbGluZygp CisjZW5kaWYKKyAgICAgICAgICAgICYmICFpc1RyYW5zcGFyZW50KCk7CiB9CiAKIGJvb2wgUmVu ZGVyTGF5ZXI6OnNob3VsZEJlU2VsZlBhaW50aW5nTGF5ZXIoKSBjb25zdAogewogICAgIHJldHVy biAhaXNOb3JtYWxGbG93T25seSgpCiAgICAgICAgIHx8IGhhc092ZXJsYXlTY3JvbGxiYXJzKCkK KyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgICAgIHx8IG5lZWRzQ29tcG9z aXRlZFNjcm9sbGluZygpCisjZW5kaWYKICAgICAgICAgfHwgcmVuZGVyZXIoKS0+aGFzUmVmbGVj dGlvbigpCiAgICAgICAgIHx8IHJlbmRlcmVyKCktPmhhc01hc2soKQogICAgICAgICB8fCByZW5k ZXJlcigpLT5pc1RhYmxlUm93KCkK 179925 2012-12-18 05:11:55 -0800 2012-12-18 09:31:00 -0800 Patch bug-105175-20121218140911.patch text/plain 1830 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODAxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTE4ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDUxNzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5oOiBDb21waWxlIGZpeGVzIGZvciBVU0UoQUNDRUxF UkFURURfQ09NUE9TSVRJTkcpIG1pc21hdGNoLgorCiAyMDEyLTEyLTE4ICBFdWdlbmUgS2x5dWNo bmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtO ZXR3b3JrXSBPcmRlcmluZyBvZiBjb29raWVzIGRpc3BsYXllZCBpcyBub25kZXRlcm1pbmlzdGlj LgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgJKHJldmlzaW9uIDEz ODAwOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCSh3b3JraW5n IGNvcHkpCkBAIC02NzMsNiArNjczLDcgQEAgcHVibGljOgogICAgIGJvb2wgaXNDb21wb3NpdGVk KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICBib29sIGhhc0NvbXBvc2l0ZWRNYXNrKCkg Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICBib29sIHVzZXNDb21wb3NpdGVkU2Nyb2xsaW5n KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKyAgICBib29sIG5lZWRzQ29tcG9zaXRlZFNjcm9s bGluZygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAjZW5kaWYKIAogICAgIGJvb2wgcGFpbnRz V2l0aFRyYW5zcGFyZW5jeShQYWludEJlaGF2aW9yIHBhaW50QmVoYXZpb3IpIGNvbnN0CkBAIC05 NTYsMTAgKzk1NywxMCBAQCBwcml2YXRlOgogICAgIHZvaWQgc2V0SW5kaXJlY3RDb21wb3NpdGlu Z1JlYXNvbihJbmRpcmVjdENvbXBvc2l0aW5nUmVhc29uIHJlYXNvbikgeyBtX2luZGlyZWN0Q29t cG9zaXRpbmdSZWFzb24gPSByZWFzb247IH0KICAgICBJbmRpcmVjdENvbXBvc2l0aW5nUmVhc29u IGluZGlyZWN0Q29tcG9zaXRpbmdSZWFzb24oKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxJ bmRpcmVjdENvbXBvc2l0aW5nUmVhc29uPihtX2luZGlyZWN0Q29tcG9zaXRpbmdSZWFzb24pOyB9 CiAgICAgYm9vbCBtdXN0Q29tcG9zaXRlRm9ySW5kaXJlY3RSZWFzb25zKCkgY29uc3QgeyByZXR1 cm4gbV9pbmRpcmVjdENvbXBvc2l0aW5nUmVhc29uOyB9CisjZW5kaWYKIAogICAgIC8vIFJldHVy bnMgdHJ1ZSBpZiB6IG9yZGVyaW5nIHdvdWxkIG5vdCBjaGFuZ2UgaWYgdGhpcyBsYXllciB3ZXJl IHRvIGVzdGFibGlzaCBhIHN0YWNraW5nIGNvbnRleHQuCiAgICAgYm9vbCBjYW5TYWZlbHlFc3Rh Ymxpc2hBU3RhY2tpbmdDb250ZXh0KCkgY29uc3Q7Ci0jZW5kaWYKIAogICAgIGZyaWVuZCBjbGFz cyBSZW5kZXJMYXllckJhY2tpbmc7CiAgICAgZnJpZW5kIGNsYXNzIFJlbmRlckxheWVyQ29tcG9z aXRvcjsK