105159 2012-12-17 03:33:45 -0800 [EFL] Add ecore_imf_evas to FindEcore.cmake 2012-12-17 18:41:04 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 halton.huo webkit-unassigned benjamin gyuyoung.kim lucas.de.marchi ojan.autocc rakuco webkit.review.bot oldest_to_newest 792607 0 halton.huo 2012-12-17 03:33:45 -0800 ecore_imf_evas is a separate library, we should add ecore_imf_evas as well. $ls WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf*.so WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf_evas.so WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf.so 792613 1 179711 halton.huo 2012-12-17 03:53:55 -0800 Created attachment 179711 Patch 792732 2 179711 laszlo.gombos 2012-12-17 08:19:26 -0800 Comment on attachment 179711 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179711&action=review Make sense to me, except the WTF changes. > Source/WTF/wtf/PlatformEfl.cmake:25 > + ${ECORE_IMF_EVAS_LIBRARIES} Is this really necessary ? It seems to me that WTF is not using ECORE_IMF_EVAS_LIBRARIES. 793175 3 179835 halton.huo 2012-12-17 16:54:07 -0800 Created attachment 179835 Patch 793201 4 179835 laszlo.gombos 2012-12-17 17:31:17 -0800 Comment on attachment 179835 Patch r=me. 793248 5 179835 webkit.review.bot 2012-12-17 18:40:59 -0800 Comment on attachment 179835 Patch Clearing flags on attachment: 179835 Committed r137969: <http://trac.webkit.org/changeset/137969> 793249 6 webkit.review.bot 2012-12-17 18:41:04 -0800 All reviewed patches have been landed. Closing bug. 179711 2012-12-17 03:53:55 -0800 2012-12-17 16:53:53 -0800 Patch bug-105159-20121217195403.patch text/plain 3653 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFjN2ZlOTc1ZmRmNzJkMGM1Y2FmOWRl Mjg4MWNiNjFlNWRjZTcxYmQuLmRlYzhiYzFhZTZiNmYxNWUyMzQxYjA3NDUwYTg4MDUxOTQ4NTIx ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMTItMTcgIEhhbHRvbiBIdW8gIDxoYWx0b24u aHVvQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBBZGQgZWNvcmVfaW1mX2V2YXMgdG8gRmlu ZEVjb3JlLmNtYWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDUxNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybUVmbC5jbWFrZTogQWRkIEVDT1JFX0lNRl9FVkFTX0xJQlJBUklF UyB0byBXVEZfTElCUkFSSUVTCisKIDIwMTItMTItMTQgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5 c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIGRhdGEgZ3JpZCBm b3IgZXhwbG9yaW5nIG5hdGl2ZSBoZWFwIGdyYXBoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2E0Y2RiYzQ3YWVi ZjI2MmYxNzk5ZTUyMDg4NzVmNzU2NDM1ODg5ZC4uYWE2MzFjMGEyYTdmZDFlYTk5N2FlMmVjMDIx MmFlOTE2YTNlNDk4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTE3ICBI YWx0b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIGVj b3JlX2ltZl9ldmFzIHRvIEZpbmRFY29yZS5jbWFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZTogQWRkIEVDT1JFX0lN Rl9FVkFTX0xJQlJBUklFUyB0byBXZWJQcm9jZXNzX0xJQlJBUklFUworCiAyMDEyLTEyLTE3ICBP c3dhbGQgQnVkZGVuaGFnZW4gIDxvc3dhbGQuYnVkZGVuaGFnZW5AZGlnaWEuY29tPgogCiAgICAg ICAgIFtRdF0gcmVseSBvbiBhdXRvbWF0aWMgb3V0cHV0IGRpcmVjdG9yeSBzZXR1cApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1FZmwuY21ha2UgYi9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybUVmbC5jbWFrZQppbmRleCBkYzA5MTlmOWJjNjMyODdlMDIyMTg5Nzc3NjQ0YzYwOWNj Mzk1NDY3Li44YWJjYThiOWEyOWY3N2JjYjdiMjRiMDNmNzY1MTZjYWRjOGU5ZDc0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVmbC5jbWFrZQorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMjIsNiArMjIsNyBAQCBsaXN0KEFQUEVORCBXVEZfTElC UkFSSUVTCiAgICAgJHtFQ09SRV9MSUJSQVJJRVN9CiAgICAgJHtFQ09SRV9FVkFTX0xJQlJBUklF U30KICAgICAke0VDT1JFX0lNRl9MSUJSQVJJRVN9CisgICAgJHtFQ09SRV9JTUZfRVZBU19MSUJS QVJJRVN9CiAgICAgJHtFSU5BX0xJQlJBUklFU30KICAgICAke0VWQVNfTElCUkFSSUVTfQogICAg ICR7Q01BS0VfRExfTElCU30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZs LmNtYWtlIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UKaW5kZXggNzNlY2JhMDcy MzdjZGExNTBlZjhkOGQ1NTUwZjMwYWUzNDU4ODNlMi4uNTQ2ZTAwNDJmZTFiNjQxOWI3NTMxY2E2 MDkwOTVkZTQ1MzczMjBmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwu Y21ha2UKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UKQEAgLTIyOCw2ICsy MjgsNyBAQCBsaXN0KEFQUEVORCBXZWJQcm9jZXNzX1NPVVJDRVMKIGxpc3QoQVBQRU5EIFdlYlBy b2Nlc3NfTElCUkFSSUVTCiAgICAgJHtDQUlST19MSUJSQVJJRVN9CiAgICAgJHtFQ09SRV9JTUZf TElCUkFSSUVTfQorICAgICR7RUNPUkVfSU1GX0VWQVNfTElCUkFSSUVTfQogICAgICR7RURKRV9M SUJSQVJJRVN9CiAgICAgJHtFRkxERVBTX0xJQlJBUklFU30KICAgICAke0VWQVNfTElCUkFSSUVT fQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL0ZpbmRFY29yZS5jbWFrZSBiL1NvdXJjZS9jbWFr ZS9GaW5kRWNvcmUuY21ha2UKaW5kZXggNWIzNTYwYTMxN2NhYTlkMjlhODE1MDI1YmIxMDJjYWY1 ZmExNDVhZC4uODBmNTc4NzAxZmNkZTJmYjEyYThlOTE0YjI2MWEyYzU3MzI1ZDgxMyAxMDA2NDQK LS0tIGEvU291cmNlL2NtYWtlL0ZpbmRFY29yZS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvRmlu ZEVjb3JlLmNtYWtlCkBAIC02OCwxMCArNjgsMTUgQEAgRklORF9FRkxfTElCUkFSWShFQ09SRV9Y CiAgICAgTElCUkFSWSBlY29yZV94CiApCiBGSU5EX0VGTF9MSUJSQVJZKEVDT1JFX0lNRgotICAg IEhFQURFUlMgRWNvcmVfSU1GLmggRWNvcmVfSU1GX0V2YXMuaAorICAgIEhFQURFUlMgRWNvcmVf SU1GLmgKICAgICBIRUFERVJfUFJFRklYRVMgZWNvcmUtMQogICAgIExJQlJBUlkgZWNvcmVfaW1m CiApCitGSU5EX0VGTF9MSUJSQVJZKEVDT1JFX0lNRl9FVkFTCisgICAgSEVBREVSUyBFY29yZV9J TUZfRXZhcy5oCisgICAgSEVBREVSX1BSRUZJWEVTIGVjb3JlLTEKKyAgICBMSUJSQVJZIGVjb3Jl X2ltZl9ldmFzCispCiAKIGZvcmVhY2ggKF9jb21wb25lbnQgJHtFY29yZV9GSU5EX0NPTVBPTkVO VFN9KQogICAgIHNldChfZWNvcmVfY29tcG9uZW50ICJFQ09SRV8ke19jb21wb25lbnR9IikKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwYzRhNDQ3YzgwZmFmZmYzMWRh NTUxODFlOTEzMzc1NGIwNWM0Mjg3Li4yZjExNjQ1NThiYWY0N2YwZGNiNjVhMDQ2NWNkMjIxZGJh YThhODc0IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTItMTItMTcgIEhhbHRvbiBIdW8gIDxoYWx0b24uaHVvQGludGVsLmNvbT4KKwor ICAgICAgICBbRUZMXSBBZGQgZWNvcmVfaW1mX2V2YXMgdG8gRmluZEVjb3JlLmNtYWtlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUxNTkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBlY29yZV9pbWZfZXZh cyBpcyBhIHNlcGFyYXRlIGxpYnJhcnksIHdlIHNob3VsZCBhZGQgZm9yIEVGTCBwb3J0IGFzIHdl bGwuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEVjb3JlLmNtYWtlOiBBZGQgZmluZGlu ZyBGSU5EX0VGTF9MSUJSQVJZIGZvciBlY29yZV9pbWZfZXZhcworCiAyMDEyLTEyLTE2ICBDaGFu Z1Nlb2sgT2ggIDxzaGl2YW1pZG93QGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXVtBQ10gQnVp bGQgZmFpbHVyZSB3aXRoIGFuIG9wdGlvbiAtLXdpdGgtYWNjZWxlcmF0aW9uLWJhY2tlbmQ9Y2x1 dHRlcgo= 179835 2012-12-17 16:54:07 -0800 2012-12-17 18:40:59 -0800 Patch bug-105159-20121218085415.patch text/plain 2573 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmU3ZThiOTBkMGM4YjU5 ZjNiMTJiYTUwNTMwNjIwYjA0MDRjZDE2OS4uZjQ4ODk1ODNhMDZkNGVmZGRhOTQ2Y2JlYTU2NmVi MzFiMGUyMGRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTE4ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIGVjb3Jl X2ltZl9ldmFzIHRvIEZpbmRFY29yZS5jbWFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZTogQWRkIEVDT1JFX0lNRl9F VkFTX0xJQlJBUklFUyB0byBXZWJQcm9jZXNzX0xJQlJBUklFUworCiAyMDEyLTEyLTE3ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFtDb29yZGlu YXRlZEdyYXBoaWNzXSBBc3NlcnRpb24gaGl0IGluIFdlYktpdDo6TGF5ZXJUcmVlUmVuZGVyZXI6 OnNldExheWVyU3RhdGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwu Y21ha2UgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCA3M2VjYmEwNzIz N2NkYTE1MGVmOGQ4ZDU1NTBmMzBhZTM0NTg4M2UyLi41NDZlMDA0MmZlMWI2NDE5Yjc1MzFjYTYw OTA5NWRlNDUzNzMyMGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5j bWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMjI4LDYgKzIy OCw3IEBAIGxpc3QoQVBQRU5EIFdlYlByb2Nlc3NfU09VUkNFUwogbGlzdChBUFBFTkQgV2ViUHJv Y2Vzc19MSUJSQVJJRVMKICAgICAke0NBSVJPX0xJQlJBUklFU30KICAgICAke0VDT1JFX0lNRl9M SUJSQVJJRVN9CisgICAgJHtFQ09SRV9JTUZfRVZBU19MSUJSQVJJRVN9CiAgICAgJHtFREpFX0xJ QlJBUklFU30KICAgICAke0VGTERFUFNfTElCUkFSSUVTfQogICAgICR7RVZBU19MSUJSQVJJRVN9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmluZEVjb3JlLmNtYWtlIGIvU291cmNlL2NtYWtl L0ZpbmRFY29yZS5jbWFrZQppbmRleCA1YjM1NjBhMzE3Y2FhOWQyOWE4MTUwMjViYjEwMmNhZjVm YTE0NWFkLi44MGY1Nzg3MDFmY2RlMmZiMTJhOGU5MTRiMjYxYTJjNTczMjVkODEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvRmluZEVjb3JlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5k RWNvcmUuY21ha2UKQEAgLTY4LDEwICs2OCwxNSBAQCBGSU5EX0VGTF9MSUJSQVJZKEVDT1JFX1gK ICAgICBMSUJSQVJZIGVjb3JlX3gKICkKIEZJTkRfRUZMX0xJQlJBUlkoRUNPUkVfSU1GCi0gICAg SEVBREVSUyBFY29yZV9JTUYuaCBFY29yZV9JTUZfRXZhcy5oCisgICAgSEVBREVSUyBFY29yZV9J TUYuaAogICAgIEhFQURFUl9QUkVGSVhFUyBlY29yZS0xCiAgICAgTElCUkFSWSBlY29yZV9pbWYK ICkKK0ZJTkRfRUZMX0xJQlJBUlkoRUNPUkVfSU1GX0VWQVMKKyAgICBIRUFERVJTIEVjb3JlX0lN Rl9FdmFzLmgKKyAgICBIRUFERVJfUFJFRklYRVMgZWNvcmUtMQorICAgIExJQlJBUlkgZWNvcmVf aW1mX2V2YXMKKykKIAogZm9yZWFjaCAoX2NvbXBvbmVudCAke0Vjb3JlX0ZJTkRfQ09NUE9ORU5U U30pCiAgICAgc2V0KF9lY29yZV9jb21wb25lbnQgIkVDT1JFXyR7X2NvbXBvbmVudH0iKQpkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGJkZjFmZDM4ZjgyNTJjMDI1Y2I3 YmJlZWI0Y2Y4N2MwNjdiNmJmOGIuLmM4ZmMwYjM1ZGIyZWViNWEyNDUyYzM4ZWFkNGU1ZjMwYTIx N2M4ODMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxMi0xMi0xOCAgSGFsdG9uIEh1byAgPGhhbHRvbi5odW9AaW50ZWwuY29tPgorCisg ICAgICAgIFtFRkxdIEFkZCBlY29yZV9pbWZfZXZhcyB0byBGaW5kRWNvcmUuY21ha2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTE1OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGVjb3JlX2ltZl9ldmFz IGlzIGEgc2VwYXJhdGUgbGlicmFyeSwgd2Ugc2hvdWxkIGFkZCBmb3IgRUZMIHBvcnQgYXMgd2Vs bC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kRWNvcmUuY21ha2U6IEFkZCBmaW5kaW5n IEZJTkRfRUZMX0xJQlJBUlkgZm9yIGVjb3JlX2ltZl9ldmFzCisKIDIwMTItMTItMTcgIEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEFk ZCBtYW51YWwgdGVzdCB0byB2ZXJpZnkgdGhhdCBnZW9tZXRyeSBtZXRob2RzIChtb3ZlVG8sIGV0 Yykgd29yawo=