105150 2012-12-16 22:39:15 -0800 [V8] Improve performance of a conversion from WebKit strings to V8 strings 2012-12-16 23:45:26 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth eric japhet webkit.review.bot oldest_to_newest 792473 0 haraken 2012-12-16 22:39:15 -0800 I implemented v8::Weak(isolate) and v8::Local::New(isolate, ...), which is much faster than v8::Weak() and v8::Local::New(). By using the faster APIs, we can improve performance of a conversion from WebKit strings to V8 strings. 792478 1 179690 haraken 2012-12-16 23:01:58 -0800 Created attachment 179690 Patch 792483 2 179690 eric 2012-12-16 23:09:41 -0800 Comment on attachment 179690 Patch YES! I remember discussing these with Dr. Barth long ago. These are recent API additions to V8, correct? I suspect there are many other cases which would benefit from passing the isolate along so v8 doesn't have to branch? 792506 3 179690 webkit.review.bot 2012-12-16 23:45:22 -0800 Comment on attachment 179690 Patch Clearing flags on attachment: 179690 Committed r137881: <http://trac.webkit.org/changeset/137881> 792507 4 webkit.review.bot 2012-12-16 23:45:26 -0800 All reviewed patches have been landed. Closing bug. 179690 2012-12-16 23:01:58 -0800 2012-12-16 23:45:22 -0800 Patch bug-105150-20121217155916.patch text/plain 2318 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ExMDMwNjk1YWRmMDkw ZTc0Y2Q4YmZjODk5MjViOTFhMjUzOTA5OS4uNjJkYThlNWRmMmE5NWM3MDY5YzliOTY5NTBkMDJi NTM1OTQ2YmY5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEyLTEyLTE2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEltcHJvdmUg cGVyZm9ybWFuY2Ugb2YgYSBjb252ZXJzaW9uIGZyb20gV2ViS2l0IHN0cmluZ3MgdG8gVjggc3Ry aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1 MTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVjgg cHJvdmlkZXMgdjg6OldlYWsoaXNvbGF0ZSkgYW5kIHY4OjpMb2NhbDo6TmV3KGlzb2xhdGUsIC4u LiksCisgICAgICAgIHdoaWNoIGFyZSBtdWNoIGZhc3RlciB0aGFuIHY4OjpXZWFrKCkgYW5kIHY4 OjpMb2NhbDo6TmV3KCkuCisgICAgICAgIEJ5IHVzaW5nIHRoZSBmYXN0ZXIgQVBJcywgd2UgY2Fu IGltcHJvdmUgcGVyZm9ybWFuY2Ugb2YgYSBjb252ZXJzaW9uCisgICAgICAgIGZyb20gYSBXZWJL aXQgc3RyaW5nIHRvIGEgVjggc3RyaW5nLiBUaGlzIGltcHJvdmVzIHBlcmZvcm1hbmNlIG9mCisg ICAgICAgIGRpdi5pZCwgZGl2LmNsYXNzTmFtZSwgLi4uYW5kIGEgbG90IG9mIERPTSBhdHRyaWJ1 dGVzIHRoYXQgcmV0dXJuCisgICAgICAgIHN0cmluZ3MuCisKKyAgICAgICAgW0Ryb21hZW8vZG9t LWF0dHJdCisgICAgICAgIDEyMCBydW5zL3NlYywgMTIwIHJ1bnMvc2VjLCAxMTggcnVucy9zZWMg PT4gMTI1IHJ1bnMvc2VjLCAxMjMgcnVuL3NlYywgMTI1IHJ1bnMvc2VjICgrNC4xJSkKKworICAg ICAgICBbRHJvbWFlby9kb20tdHJhdmVyc2VdCisgICAgICAgIDk0IHJ1bnMvc2VjLCA5NCBydW5z L3NlYywgOTYgcnVucy9zZWMgPT4gMTA3IHJ1bnMvc2VjLCAxMDUgcnVucy9zZWMsIDEwNyBydW5z L3NlYyAoKzEyLjMlKQorCisgICAgICAgIFtCaW5kaW5ncy9pZC1nZXR0ZXJdCisgICAgICAgIDM1 NiBydW5zL3NlYywgMzU2IHJ1bnMvc2VjLCAzNDEgcnVucy9zZWMgPT4gNDIzIHJ1bnMvc2VjLCA0 MjQgcnVucy9zZWMsIDQyNCBydW5zL3NlYyAoKzIwLjclKQorCisgICAgICAgIE5vIHRlc3RzLiBO byBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFZhbHVlQ2Fj aGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlN0cmluZ0NhY2hlOjp2OEV4dGVybmFsU3RyaW5nKToK KwogMjAxMi0xMi0xNiAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUHVzaCBwaXhlbCBzbmFwcGluZyBsb2dpYyBpbnRvIFRyYW5zZm9ybVN0YXRlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUuaCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VmFsdWVDYWNoZS5oCmluZGV4IDMwNTc3YzM5YzVmNzY4 MmY1NTIzMzI4YmI4Mzk5ZDEyNWExMmQwNGUuLjEwZmU3MjRiOTZiY2ExMDljYWY4NzJhYzc5MmQy OTgxMzlmZTRjOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VmFs dWVDYWNoZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VmFsdWVDYWNoZS5o CkBAIC00MSw4ICs0MSw4IEBAIHB1YmxpYzoKIAogICAgIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiB2 OEV4dGVybmFsU3RyaW5nKFN0cmluZ0ltcGwqIHN0cmluZ0ltcGwsIHY4OjpJc29sYXRlKiBpc29s YXRlKQogICAgIHsKLSAgICAgICAgaWYgKG1fbGFzdFN0cmluZ0ltcGwuZ2V0KCkgPT0gc3RyaW5n SW1wbCAmJiBtX2xhc3RWOFN0cmluZy5Jc1dlYWsoKSkKLSAgICAgICAgICAgIHJldHVybiB2ODo6 TG9jYWw8djg6OlN0cmluZz46Ok5ldyhtX2xhc3RWOFN0cmluZyk7CisgICAgICAgIGlmIChtX2xh c3RTdHJpbmdJbXBsLmdldCgpID09IHN0cmluZ0ltcGwgJiYgbV9sYXN0VjhTdHJpbmcuSXNXZWFr KGlzb2xhdGUpKQorICAgICAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6U3RyaW5nPjo6TmV3 KGlzb2xhdGUsIG1fbGFzdFY4U3RyaW5nKTsKIAogICAgICAgICByZXR1cm4gdjhFeHRlcm5hbFN0 cmluZ1Nsb3coc3RyaW5nSW1wbCwgaXNvbGF0ZSk7CiAgICAgfQo=