105140 2012-12-16 16:34:17 -0800 [Chromium] Dragging a .jpg to Finder saves it as .jpeg 2012-12-17 14:42:54 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other All RESOLVED FIXED P2 Minor --- 1 avi webkit-unassigned dcheng noel.gordon rniwa tony webkit.review.bot oldest_to_newest 792390 0 avi 2012-12-16 16:34:17 -0800 https://code.google.com/p/chromium/issues/detail?id=35811 This is a bug in the Chromium code in WebKit. 792391 1 avi 2012-12-16 16:34:33 -0800 What steps will reproduce the problem? 1. Load an image with the .jpg extension. 2. Drag it to the desktop or a finder window. What is the expected result? Image should be saved with the same extension (.jpg). What happens instead? Image is saved with a .jpeg extension. 792406 2 179672 avi 2012-12-16 17:49:53 -0800 Created attachment 179672 fix 792919 3 179672 tony 2012-12-17 12:17:12 -0800 Comment on attachment 179672 fix View in context: https://bugs.webkit.org/attachment.cgi?id=179672&action=review > Source/WebCore/platform/chromium/ClipboardChromium.cpp:387 > + // Keep the existing extension if it is valid for the MIME type of the > + // image, and replace it if it is not. Nit: I think WebKit style would not include this comment since it's describing the code below. 792920 4 179672 tony 2012-12-17 12:19:14 -0800 Comment on attachment 179672 fix View in context: https://bugs.webkit.org/attachment.cgi?id=179672&action=review > Source/WebCore/ChangeLog:12 > + > + * platform/chromium/ClipboardChromium.cpp: There should be a sentence here explaining why there's no LayoutTest. You can say it's not possible since it involves dragging to the desktop. If you wanted to be more thorough, you could add a test to ManualTests. 792936 5 179783 avi 2012-12-17 12:50:15 -0800 Created attachment 179783 fix nits 792975 6 179783 webkit.review.bot 2012-12-17 13:29:20 -0800 Comment on attachment 179783 fix nits Clearing flags on attachment: 179783 Committed r137934: <http://trac.webkit.org/changeset/137934> 792977 7 webkit.review.bot 2012-12-17 13:29:23 -0800 All reviewed patches have been landed. Closing bug. 793050 8 noel.gordon 2012-12-17 14:42:54 -0800 (In reply to comment #4) > There should be a sentence here explaining why there's no LayoutTest. You can say it's not possible since it involves dragging to the desktop. If you wanted to be more thorough, you could add a test to ManualTests. Would a JPEG variant of fast/events/drag-image-filename.html work? 179672 2012-12-16 17:49:53 -0800 2012-12-17 12:50:15 -0800 fix drag.patch text/plain 2656 avi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzg2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTE2ICBBdmkgRHJp c3NtYW4gIDxhdmlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERyYWdnaW5nIGEgLmpwZyB0byBG aW5kZXIgc2F2ZXMgaXQgYXMgLmpwZWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNTE0MAorICAgICAgICBodHRwczovL2NvZGUuZ29vZ2xlLmNvbS9w L2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MzU4MTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgZmlsZW5hbWUncyBleHRlbnNpb24gaXMg YWxyZWFkeSB2YWxpZCBmb3IgdGhlIE1JTUUgdHlwZSwgd2UgZG9uJ3QKKyAgICAgICAgbmVlZCB0 byByZXdyaXRlIGl0IHRvIHRoZSBwcmVmZXJyZWQgZXh0ZW5zaW9uLgorCisgICAgICAgICogcGxh dGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 d3JpdGVJbWFnZVRvRGF0YU9iamVjdCk6CisKIDIwMTItMTItMTYgIExldmkgV2VpbnRyYXViICA8 bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFB1c2ggcGl4ZWwgc25hcHBpbmcgbG9naWMg aW50byBUcmFuc2Zvcm1TdGF0ZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVtLmNwcAkocmV2aXNpb24gMTM3ODYxKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNjksNiArMzY5LDcgQEAgc3RhdGljIHZvaWQgd3JpdGVJbWFn ZVRvRGF0YU9iamVjdChDaHJvbQogCiAgICAgLy8gRGV0ZXJtaW5lIHRoZSBmaWxlbmFtZSBmb3Ig dGhlIGZpbGUgY29udGVudHMgb2YgdGhlIGltYWdlLgogICAgIFN0cmluZyBmaWxlbmFtZSA9IGNh Y2hlZEltYWdlLT5yZXNwb25zZSgpLnN1Z2dlc3RlZEZpbGVuYW1lKCk7CisgICAgU3RyaW5nIGV4 dGVuc2lvbjsKICAgICBpZiAoZmlsZW5hbWUuaXNFbXB0eSgpKQogICAgICAgICBmaWxlbmFtZSA9 IHVybC5sYXN0UGF0aENvbXBvbmVudCgpOwogICAgIGlmIChmaWxlbmFtZS5pc0VtcHR5KCkpCkBA IC0zNzYsMTQgKzM3NywyMSBAQCBzdGF0aWMgdm9pZCB3cml0ZUltYWdlVG9EYXRhT2JqZWN0KENo cm9tCiAgICAgZWxzZSB7CiAgICAgICAgIC8vIFN0cmlwIGFueSBleGlzdGluZyBleHRlbnNpb24u IEFzc3VtZSB0aGF0IGFsdCB0ZXh0IGlzIHVzdWFsbHkgbm90IGEgZmlsZW5hbWUuCiAgICAgICAg IGludCBleHRlbnNpb25JbmRleCA9IGZpbGVuYW1lLnJldmVyc2VGaW5kKCcuJyk7Ci0gICAgICAg IGlmIChleHRlbnNpb25JbmRleCAhPSAtMSkKKyAgICAgICAgaWYgKGV4dGVuc2lvbkluZGV4ICE9 IC0xKSB7CisgICAgICAgICAgICBleHRlbnNpb24gPSBmaWxlbmFtZS5zdWJzdHJpbmcoZXh0ZW5z aW9uSW5kZXggKyAxKTsKICAgICAgICAgICAgIGZpbGVuYW1lLnRydW5jYXRlKGV4dGVuc2lvbklu ZGV4KTsKKyAgICAgICAgfQogICAgIH0KIAotICAgIFN0cmluZyBleHRlbnNpb24gPSBNSU1FVHlw ZVJlZ2lzdHJ5OjpnZXRQcmVmZXJyZWRFeHRlbnNpb25Gb3JNSU1FVHlwZSgKLSAgICAgICAgY2Fj aGVkSW1hZ2UtPnJlc3BvbnNlKCkubWltZVR5cGUoKSk7Ci0gICAgZXh0ZW5zaW9uID0gZXh0ZW5z aW9uLmlzRW1wdHkoKSA/IGVtcHR5U3RyaW5nKCkgOiAiLiIgKyBleHRlbnNpb247CisgICAgLy8g S2VlcCB0aGUgZXhpc3RpbmcgZXh0ZW5zaW9uIGlmIGl0IGlzIHZhbGlkIGZvciB0aGUgTUlNRSB0 eXBlIG9mIHRoZQorICAgIC8vIGltYWdlLCBhbmQgcmVwbGFjZSBpdCBpZiBpdCBpcyBub3QuCisg ICAgU3RyaW5nIGV4dGVuc2lvbk1pbWVUeXBlID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5 cGVGb3JFeHRlbnNpb24oZXh0ZW5zaW9uKTsKKyAgICBpZiAoZXh0ZW5zaW9uTWltZVR5cGUgIT0g Y2FjaGVkSW1hZ2UtPnJlc3BvbnNlKCkubWltZVR5cGUoKSkgeworICAgICAgICBleHRlbnNpb24g PSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRQcmVmZXJyZWRFeHRlbnNpb25Gb3JNSU1FVHlwZSgKKyAg ICAgICAgICAgIGNhY2hlZEltYWdlLT5yZXNwb25zZSgpLm1pbWVUeXBlKCkpOworICAgIH0KIAor ICAgIGV4dGVuc2lvbiA9IGV4dGVuc2lvbi5pc0VtcHR5KCkgPyBlbXB0eVN0cmluZygpIDogIi4i ICsgZXh0ZW5zaW9uOwogICAgIENsaXBib2FyZENocm9taXVtOjp2YWxpZGF0ZUZpbGVuYW1lKGZp bGVuYW1lLCBleHRlbnNpb24pOwogCiAgICAgZGF0YU9iamVjdC0+YWRkU2hhcmVkQnVmZmVyKGZp bGVuYW1lICsgZXh0ZW5zaW9uLCBpbWFnZUJ1ZmZlcik7Cg== 179783 2012-12-17 12:50:15 -0800 2012-12-17 13:29:19 -0800 fix nits drag.patch text/plain 2632 avi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzkwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTE2ICBBdmkgRHJp c3NtYW4gIDxhdmlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERyYWdnaW5nIGEgLmpwZyB0byBG aW5kZXIgc2F2ZXMgaXQgYXMgLmpwZWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNTE0MAorICAgICAgICBodHRwczovL2NvZGUuZ29vZ2xlLmNvbS9w L2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MzU4MTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgZmlsZW5hbWUncyBleHRlbnNpb24gaXMg YWxyZWFkeSB2YWxpZCBmb3IgdGhlIE1JTUUgdHlwZSwgd2UgZG9uJ3QKKyAgICAgICAgbmVlZCB0 byByZXdyaXRlIGl0IHRvIHRoZSBwcmVmZXJyZWQgZXh0ZW5zaW9uLgorCisgICAgICAgIE5vIGxh eW91dCB0ZXN0cyBiZWNhdXNlIGl0IGludm9sdmVzIGRyYWdnaW5nIGl0ZW1zIHRvIHRoZSBkZXNr dG9wLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6d3JpdGVJbWFnZVRvRGF0YU9iamVjdCk6CisKIDIwMTItMTIt MTcgIEV1Z2VuZSBLbHl1Y2huaWtvdiAgPGV1c3Rhc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogTWFrZSBwb3BvdmVyIGNvbnRlbnQgYWNjZXNzaWJsZSBmb3IgY2xpY2tz LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21p dW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Ns aXBib2FyZENocm9taXVtLmNwcAkocmV2aXNpb24gMTM3ODYxKQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNjksNiArMzY5LDcgQEAgc3RhdGljIHZvaWQgd3JpdGVJbWFnZVRvRGF0YU9iamVjdChDaHJv bQogCiAgICAgLy8gRGV0ZXJtaW5lIHRoZSBmaWxlbmFtZSBmb3IgdGhlIGZpbGUgY29udGVudHMg b2YgdGhlIGltYWdlLgogICAgIFN0cmluZyBmaWxlbmFtZSA9IGNhY2hlZEltYWdlLT5yZXNwb25z ZSgpLnN1Z2dlc3RlZEZpbGVuYW1lKCk7CisgICAgU3RyaW5nIGV4dGVuc2lvbjsKICAgICBpZiAo ZmlsZW5hbWUuaXNFbXB0eSgpKQogICAgICAgICBmaWxlbmFtZSA9IHVybC5sYXN0UGF0aENvbXBv bmVudCgpOwogICAgIGlmIChmaWxlbmFtZS5pc0VtcHR5KCkpCkBAIC0zNzYsMTQgKzM3NywxOSBA QCBzdGF0aWMgdm9pZCB3cml0ZUltYWdlVG9EYXRhT2JqZWN0KENocm9tCiAgICAgZWxzZSB7CiAg ICAgICAgIC8vIFN0cmlwIGFueSBleGlzdGluZyBleHRlbnNpb24uIEFzc3VtZSB0aGF0IGFsdCB0 ZXh0IGlzIHVzdWFsbHkgbm90IGEgZmlsZW5hbWUuCiAgICAgICAgIGludCBleHRlbnNpb25JbmRl eCA9IGZpbGVuYW1lLnJldmVyc2VGaW5kKCcuJyk7Ci0gICAgICAgIGlmIChleHRlbnNpb25JbmRl eCAhPSAtMSkKKyAgICAgICAgaWYgKGV4dGVuc2lvbkluZGV4ICE9IC0xKSB7CisgICAgICAgICAg ICBleHRlbnNpb24gPSBmaWxlbmFtZS5zdWJzdHJpbmcoZXh0ZW5zaW9uSW5kZXggKyAxKTsKICAg ICAgICAgICAgIGZpbGVuYW1lLnRydW5jYXRlKGV4dGVuc2lvbkluZGV4KTsKKyAgICAgICAgfQog ICAgIH0KIAotICAgIFN0cmluZyBleHRlbnNpb24gPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRQcmVm ZXJyZWRFeHRlbnNpb25Gb3JNSU1FVHlwZSgKLSAgICAgICAgY2FjaGVkSW1hZ2UtPnJlc3BvbnNl KCkubWltZVR5cGUoKSk7Ci0gICAgZXh0ZW5zaW9uID0gZXh0ZW5zaW9uLmlzRW1wdHkoKSA/IGVt cHR5U3RyaW5nKCkgOiAiLiIgKyBleHRlbnNpb247CisgICAgU3RyaW5nIGV4dGVuc2lvbk1pbWVU eXBlID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24oZXh0ZW5zaW9u KTsKKyAgICBpZiAoZXh0ZW5zaW9uTWltZVR5cGUgIT0gY2FjaGVkSW1hZ2UtPnJlc3BvbnNlKCku bWltZVR5cGUoKSkgeworICAgICAgICBleHRlbnNpb24gPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRQ cmVmZXJyZWRFeHRlbnNpb25Gb3JNSU1FVHlwZSgKKyAgICAgICAgICAgIGNhY2hlZEltYWdlLT5y ZXNwb25zZSgpLm1pbWVUeXBlKCkpOworICAgIH0KIAorICAgIGV4dGVuc2lvbiA9IGV4dGVuc2lv bi5pc0VtcHR5KCkgPyBlbXB0eVN0cmluZygpIDogIi4iICsgZXh0ZW5zaW9uOwogICAgIENsaXBi b2FyZENocm9taXVtOjp2YWxpZGF0ZUZpbGVuYW1lKGZpbGVuYW1lLCBleHRlbnNpb24pOwogCiAg ICAgZGF0YU9iamVjdC0+YWRkU2hhcmVkQnVmZmVyKGZpbGVuYW1lICsgZXh0ZW5zaW9uLCBpbWFn ZUJ1ZmZlcik7Cg==