105129 2012-12-16 10:02:22 -0800 [Blackberry] Static code analysis warning fixes 2012-12-17 07:46:50 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 afscian webkit-unassigned afscian mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 792338 0 afscian 2012-12-16 10:02:22 -0800 Klocwork issues: 176,177,532,631,632,956,957,958,960,1365,2267,2268,2269,4016,4017,4018,4019 792339 1 afscian 2012-12-16 10:04:13 -0800 Add Rob, patch to follow (limited to blackberry-specific code). 792341 2 179650 afscian 2012-12-16 10:22:54 -0800 Created attachment 179650 patch to address Klocwork issues 792346 3 179650 rwlbuis 2012-12-16 11:03:32 -0800 Comment on attachment 179650 patch to address Klocwork issues Looks good in general but plugin change needs explaining. 792359 4 rwlbuis 2012-12-16 12:35:20 -0800 (In reply to comment #3) > (From update of attachment 179650 [details]) > Looks good in general but plugin change needs explaining. Arg, my inline comment disappeared, sorry :( My question is, is it not a problem that the temp var gets deleted at end of scope? You are handing it over as a pointer. 792707 5 afscian 2012-12-17 07:27:05 -0800 I considered that possibility but it would be an exceptionally strange interface that the single pointer would have a longer lifetime than the event containing it (in my change the scope of the drawRect is exactly the same as the scope of the event). From my reading of the code, the drawRect is a pointer because it can be an array of rects, not that its lifetime is different than the event. Note that this code will merrily consume 128 bytes of stack space each time through the loop reusing the event struct each time. The new code is simpler and consumes far less stack space for what is essentially the same semantics. To further reinforce the scope of the pointer issue, the alloca allocation would go away after the loop is done since the method returns immediately, it can't have a longer lifetime than the event call. 792712 6 179650 rwlbuis 2012-12-17 07:40:20 -0800 Comment on attachment 179650 patch to address Klocwork issues After discussing with Yong and Anthony's explanation, looks good. 792718 7 179650 webkit.review.bot 2012-12-17 07:46:47 -0800 Comment on attachment 179650 patch to address Klocwork issues Clearing flags on attachment: 179650 Committed r137908: <http://trac.webkit.org/changeset/137908> 792719 8 webkit.review.bot 2012-12-17 07:46:50 -0800 All reviewed patches have been landed. Closing bug. 179650 2012-12-16 10:22:54 -0800 2012-12-17 07:46:46 -0800 patch to address Klocwork issues 0001-Blackberry-Static-code-analysis-warning-fixes.patch text/plain 14420 afscian RnJvbSA5NDE1Mzg0NGI3ZTA3NTIyODAwZmE0M2FlNzhhYzhlODY3Yzk0ZGE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFNjaWFuIDxhc2NpYW5AcmltLmNvbT4KRGF0ZTog U3VuLCAxNiBEZWMgMjAxMiAxMzoxODowNiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja2Jl cnJ5XSBTdGF0aWMgY29kZSBhbmFseXNpcyB3YXJuaW5nIGZpeGVzCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MTI5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KClNvdXJjZS9XZWJDb3JlOgoKLSBhbGxvY2EgY2FuIHJldHVybiBOVUxMLCByZWNvZGVkIHRv IGp1c3QgdXNlIGEgdGVtcCB2YXIKCiogcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdCbGFj a0JlcnJ5LmNwcDoKKFdlYkNvcmU6OlBsdWdpblZpZXc6OnVwZGF0ZUJ1ZmZlcik6CgpTb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnk6CgotIGRpc2FibGUgY29weS9vcD0gaW4gQmFja2luZ1N0b3JlCi0g Y2FjaGUgYW5kIGNoZWNrIGludGVybWVkaWF0ZSB2YWx1ZXMgaW4gcGFyZW50TGF5ZXIKLSBkaXNh YmxlIGNvcHkvb3A9IGluIEluUmVnaW9uU2Nyb2xsZXIKLSBkaXNhYmxlIGNvcHkvb3A9IGluIFdl YlBhZ2VHcm91cExvYWREZWZlcnJlcgotIGRpc2FibGUgY29weS9vcD0gaW4gV2ViU2V0dGluZ3MK LSBkaXNhYmxlIGNvcHkvb3A9IGluIFdlYlZpZXdwb3J0QXJndW1lbnRzCi0gZGlzYWJsZSBjb3B5 L29wPSBpbiBCYWNraW5nU3RvcmVDbGllbnQKLSBkaXNhYmxlIGNvcHkvb3A9IGluIFRpbGVCdWZm ZXIKLSBpZiBzdG9wTm9kZSBpcyBub3QgTlVMTCwgbG9vcCBjb3VsZCBpdGVyYXRlIHBhc3QgTlVM TDsgYWRkZWQgTlVMTCBjaGVjayB0byBsb29wCiAgdG8gbWFrZSB0aGUgY29kZSBtb3JlIHJvYnVz dAoKKiBBcGkvQmFja2luZ1N0b3JlLmg6CiogQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwOgooQmxh Y2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2FsY3VsYXRlSW5SZWdp b25TY3JvbGxhYmxlQXJlYXNGb3JQb2ludCk6CihCbGFja0JlcnJ5OjpXZWJLaXQ6OnBhcmVudExh eWVyKToKKiBBcGkvSW5SZWdpb25TY3JvbGxlci5oOgoqIEFwaS9XZWJQYWdlR3JvdXBMb2FkRGVm ZXJyZXIuaDoKKiBBcGkvV2ViU2V0dGluZ3MuaDoKKiBBcGkvV2ViVmlld3BvcnRBcmd1bWVudHMu aDoKKiBXZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5oOgooQmFja2luZ1N0b3JlQ2xp ZW50KToKKiBXZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZVRpbGUuaDoKKFRpbGVCdWZmZXIpOgoq IFdlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHA6CihCbGFja0JlcnJ5OjpXZWJLaXQ6OkRPTVN1 cHBvcnQ6OnZpc2libGVUZXh0UXVhZHMpOgoKVG9vbHM6CgpBZGRlZCBudWxsIGNoZWNrcyBmb3Ig Zm9wZW4gY2FsbHMsIG5vIHJlY292ZXJ5IGF0dGVtcHRlZDsgYWNjZXNzIGZhdWx0IHByZXZlbnRp b24gb25seS4KCiogRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZS5jcHA6 CihCbGFja0JlcnJ5OjpXZWJLaXQ6OmNyZWF0ZUZpbGUpOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpE dW1wUmVuZGVyVHJlZTo6cnVuVGVzdCk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAxMiArKysrKysrKwogLi4uL3BsdWdpbnMvYmxhY2ti ZXJyeS9QbHVnaW5WaWV3QmxhY2tCZXJyeS5jcHAgICAgfCAgNCArLS0KIFNvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmggICAgICAgIHwgIDIgKysKIFNvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAgIHwgMTMgKysrKysrKy0tCiBT b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuaCAgICB8ICAyICsr CiAuLi4vYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUdyb3VwTG9hZERlZmVycmVyLmggICAgICB8ICAy ICsrCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlNldHRpbmdzLmggICAgICAgICB8 ICAzICstCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlZpZXdwb3J0QXJndW1lbnRzLmgg ICB8ICAzICstCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICB8IDMzICsrKysrKysrKysrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvQmFja2luZ1N0b3JlQ2xpZW50LmggIHwgIDIgKysKIC4uLi9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvQmFja2luZ1N0b3JlVGlsZS5oICAgIHwgIDIgKysKIC4uLi9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwIHwgIDIgKy0KIFRvb2xzL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKysrCiBUb29s cy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcCB8ICA5ICsrKyst LQogMTQgZmlsZXMgY2hhbmdlZCwgOTIgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDIyMzg1NTEuLjc5ZmY0OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxMi0xMi0xNiAgQW50aG9ueSBTY2lhbiAgPGFzY2lhbkByaW0uY29tPgorCisgICAgICAg IFtCbGFja2JlcnJ5XSBTdGF0aWMgY29kZSBhbmFseXNpcyB3YXJuaW5nIGZpeGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUxMjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGFsbG9jYSBjYW4gcmV0 dXJuIE5VTEwsIHJlY29kZWQgdG8ganVzdCB1c2UgYSB0ZW1wIHZhcgorCisgICAgICAgICogcGx1 Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBsdWdpblZpZXc6OnVwZGF0ZUJ1ZmZlcik6CisKIDIwMTItMTItMTYgIFbDrWN0b3IgTWFu dWVsIErDoXF1ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVh bWVyXSBjcmVhdGUgcGxheWJpbiBpbiA6OmxvYWQoKSwgbm90IGluIHBsYXllciBjb25zdHJ1Y3Rv cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZp ZXdCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvYmxhY2tiZXJyeS9QbHVn aW5WaWV3QmxhY2tCZXJyeS5jcHAKaW5kZXggOWFjYWE0Yy4uYTYwNDk3NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdCbGFja0JlcnJ5LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2JsYWNrYmVycnkvUGx1Z2luVmlld0JsYWNr QmVycnkuY3BwCkBAIC0xOTQsMTEgKzE5NCwxMSBAQCB2b2lkIFBsdWdpblZpZXc6OnVwZGF0ZUJ1 ZmZlcihjb25zdCBJbnRSZWN0JiBidWZmZXJSZWN0KQogICAgICAgICBzdGQ6OnZlY3RvcjxCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6SW50UmVjdD4gZXhwb3NlZFJlY3RzID0gZXhwb3NlZFJlZ2lvbi5y ZWN0cygpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZXhwb3NlZFJlY3RzLnNp emUoKTsgKytpKSB7CiAgICAgICAgICAgICBOUERyYXdFdmVudCBkcmF3OworICAgICAgICAgICAg TlBSZWN0IHRlbXBSZWN0ID0gdG9OUFJlY3QoZXhwb3NlZFJlY3RzLmF0KGkpKTsKICAgICAgICAg ICAgIGRyYXcucGx1Z2luUmVjdCA9IHRvTlBSZWN0KG1fd2luZG93UmVjdCk7CiAgICAgICAgICAg ICBkcmF3LmNsaXBSZWN0ID0gdG9OUFJlY3QobV9jbGlwUmVjdCk7Ci0gICAgICAgICAgICBkcmF3 LmRyYXdSZWN0ID0gKE5QUmVjdCopYWxsb2NhKHNpemVvZihOUFJlY3QpKTsKKyAgICAgICAgICAg IGRyYXcuZHJhd1JlY3QgPSAmdGVtcFJlY3Q7CiAgICAgICAgICAgICBkcmF3LmRyYXdSZWN0Q291 bnQgPSAxOwotICAgICAgICAgICAgKmRyYXcuZHJhd1JlY3QgPSB0b05QUmVjdChleHBvc2VkUmVj dHMuYXQoaSkpOwogICAgICAgICAgICAgZHJhdy56b29tRmFjdG9yID0gKChOUFNldFdpbmRvd0Nh bGxiYWNrU3RydWN0KiltX25wV2luZG93LndzX2luZm8pLT56b29tRmFjdG9yOwogCiAgICAgICAg ICAgICBOUEV2ZW50IG5wRXZlbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL0JhY2tpbmdTdG9yZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNr aW5nU3RvcmUuaAppbmRleCBkZGE0NGVhLi5lMTU3MmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmgKQEAgLTIxLDYgKzIxLDcgQEAKIAogI2luY2x1ZGUg IkJsYWNrQmVycnlHbG9iYWwuaCIKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1HcmFwaGlj cy5oPgorI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybU1pc2MuaD4KIAogbmFtZXNwYWNlIFdl YkNvcmUgewogY2xhc3MgQ2hyb21lQ2xpZW50QmxhY2tCZXJyeTsKQEAgLTkwLDYgKzkxLDcgQEAg cHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRCbGFj a0JlcnJ5OwogICAgIGZyaWVuZCBjbGFzcyBXZWJDb3JlOjpHTEVTMkNvbnRleHQ7CiAgICAgQmFj a2luZ1N0b3JlUHJpdmF0ZSAqZDsKKyAgICBESVNBQkxFX0NPUFkoQmFja2luZ1N0b3JlKQogfTsK IH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25T Y3JvbGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Nyb2xs ZXIuY3BwCmluZGV4IGJkMTU3YTcuLjdiYmM1NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyLmNwcApAQCAtMjEwLDYgKzIxMCw4IEBAIHZv aWQgSW5SZWdpb25TY3JvbGxlclByaXZhdGU6OmNhbGN1bGF0ZUluUmVnaW9uU2Nyb2xsYWJsZUFy ZWFzRm9yUG9pbnQoY29uc3QgV2ViCiAgICAgICAgIHJldHVybjsKIAogICAgIFJlbmRlckxheWVy KiBsYXllciA9IG5vZGUtPnJlbmRlcmVyKCktPmVuY2xvc2luZ0xheWVyKCk7CisgICAgaWYgKCFs YXllcikKKyAgICAgICAgcmV0dXJuOwogICAgIGRvIHsKICAgICAgICAgUmVuZGVyT2JqZWN0KiBy ZW5kZXJlciA9IGxheWVyLT5yZW5kZXJlcigpOwogCkBAIC0zOTQsOCArMzk2LDE1IEBAIHN0YXRp YyBSZW5kZXJMYXllciogcGFyZW50TGF5ZXIoUmVuZGVyTGF5ZXIqIGxheWVyKQogICAgICAgICBy ZXR1cm4gbGF5ZXItPnBhcmVudCgpOwogCiAgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IGxh eWVyLT5yZW5kZXJlcigpOwotICAgIGlmIChyZW5kZXJlci0+ZG9jdW1lbnQoKSAmJiByZW5kZXJl ci0+ZG9jdW1lbnQoKS0+b3duZXJFbGVtZW50KCkgJiYgcmVuZGVyZXItPmRvY3VtZW50KCktPm93 bmVyRWxlbWVudCgpLT5yZW5kZXJlcigpKQotICAgICAgICByZXR1cm4gcmVuZGVyZXItPmRvY3Vt ZW50KCktPm93bmVyRWxlbWVudCgpLT5yZW5kZXJlcigpLT5lbmNsb3NpbmdMYXllcigpOworICAg IERvY3VtZW50KiBkb2N1bWVudCA9IHJlbmRlcmVyLT5kb2N1bWVudCgpOworICAgIGlmIChkb2N1 bWVudCkgeworICAgICAgICBIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyRWxlbWVudCA9IGRv Y3VtZW50LT5vd25lckVsZW1lbnQoKTsKKyAgICAgICAgaWYgKG93bmVyRWxlbWVudCkgeworICAg ICAgICAgICAgUmVuZGVyT2JqZWN0KiBzdWJSZW5kZXJlciA9IG93bmVyRWxlbWVudC0+cmVuZGVy ZXIoKTsKKyAgICAgICAgICAgIGlmIChzdWJSZW5kZXJlcikKKyAgICAgICAgICAgICAgICByZXR1 cm4gc3ViUmVuZGVyZXItPmVuY2xvc2luZ0xheWVyKCk7CisgICAgICAgIH0KKyAgICB9CiAKICAg ICByZXR1cm4gMDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv SW5SZWdpb25TY3JvbGxlci5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lv blNjcm9sbGVyLmgKaW5kZXggODE2OGMzYy4uMmNkZTk5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyLmgKQEAgLTIxLDYgKzIxLDcgQEAKIAog I2luY2x1ZGUgIkJsYWNrQmVycnlHbG9iYWwuaCIKIAorI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0 Zm9ybU1pc2MuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1QcmltaXRpdmVzLmg+CiAj aW5jbHVkZSA8aW50ZXJhY3Rpb24vU2Nyb2xsVmlld0Jhc2UuaD4KIApAQCAtNDQsNiArNDUsNyBA QCBwcml2YXRlOgogICAgIGZyaWVuZCBjbGFzcyBXZWJQYWdlUHJpdmF0ZTsKICAgICBmcmllbmQg Y2xhc3MgVG91Y2hFdmVudEhhbmRsZXI7CiAgICAgSW5SZWdpb25TY3JvbGxlclByaXZhdGUgKmQ7 CisgICAgRElTQUJMRV9DT1BZKEluUmVnaW9uU2Nyb2xsZXIpCiB9OwogCiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VHcm91cExvYWREZWZlcnJlci5o IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlR3JvdXBMb2FkRGVmZXJyZXIu aAppbmRleCBjYjY1MWVkLi5mYTdjMjIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2VHcm91cExvYWREZWZlcnJlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZUdyb3VwTG9hZERlZmVycmVyLmgKQEAgLTIwLDYgKzIwLDcg QEAKICNkZWZpbmUgV2ViUGFnZUdyb3VwTG9hZERlZmVycmVyX2gKIAogI2luY2x1ZGUgIkJsYWNr QmVycnlHbG9iYWwuaCIKKyNpbmNsdWRlICJCbGFja0JlcnJ5UGxhdGZvcm1NaXNjLmgiCiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIFBhZ2VHcm91cExvYWREZWZlcnJlcjsKQEAgLTM4LDYg KzM5LDcgQEAgcHVibGljOgogICAgIH5XZWJQYWdlR3JvdXBMb2FkRGVmZXJyZXIoKTsKIHByaXZh dGU6CiAgICAgV2ViQ29yZTo6UGFnZUdyb3VwTG9hZERlZmVycmVyKiBtX3BhZ2VHcm91cExvYWRE ZWZlcnJlcjsKKyAgICBESVNBQkxFX0NPUFkoV2ViUGFnZUdyb3VwTG9hZERlZmVycmVyKQogfTsK IAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlNldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlNldHRpbmdzLmgKaW5kZXggY2UwMDc0My4uM2U4M2YwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJTZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuaApAQCAtMjAsNiArMjAsNyBAQAogI2RlZmluZSBXZWJT ZXR0aW5nc19oCiAKICNpbmNsdWRlICJCbGFja0JlcnJ5R2xvYmFsLmgiCisjaW5jbHVkZSAiQmxh Y2tCZXJyeVBsYXRmb3JtTWlzYy5oIgogCiBuYW1lc3BhY2UgQmxhY2tCZXJyeSB7CiBuYW1lc3Bh Y2UgV2ViS2l0IHsKQEAgLTI0Myw3ICsyNDQsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIFdl YlNldHRpbmdzUHJpdmF0ZSogbV9wcml2YXRlOwogICAgIFdlYlNldHRpbmdzKCk7Ci0gICAgV2Vi U2V0dGluZ3MoY29uc3QgV2ViU2V0dGluZ3MmKTsKKyAgICBESVNBQkxFX0NPUFkoV2ViU2V0dGlu Z3MpOwogfTsKIAogLyohCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L1dlYlZpZXdwb3J0QXJndW1lbnRzLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlZpZXdwb3J0QXJndW1lbnRzLmgKaW5kZXggNDU5OWI5Ny4uODBjNGYwNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJWaWV3cG9ydEFyZ3VtZW50cy5oCisrKyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViVmlld3BvcnRBcmd1bWVudHMuaApAQCAt MjAsNiArMjAsNyBAQAogI2RlZmluZSBXZWJWaWV3cG9ydEFyZ3VtZW50c19oCiAKICNpbmNsdWRl ICJCbGFja0JlcnJ5R2xvYmFsLmgiCisjaW5jbHVkZSAiQmxhY2tCZXJyeVBsYXRmb3JtTWlzYy5o IgogCiAvLyBOb3QgZm9yIHB1YmxpYyBBUEkgcHVycG9zZS4KIG5hbWVzcGFjZSBXZWJDb3JlIHsK QEAgLTc2LDExICs3NywxMSBAQCBwdWJsaWM6CiAgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IFdl YlZpZXdwb3J0QXJndW1lbnRzICZvdGhlcik7CiAKIHByaXZhdGU6Ci0gICAgV2ViVmlld3BvcnRB cmd1bWVudHMoY29uc3QgV2ViVmlld3BvcnRBcmd1bWVudHMmKTsKICAgICBXZWJDb3JlOjpWaWV3 cG9ydEFyZ3VtZW50cyogZDsKIAogcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgV2ViUGFnZTsK KyAgICBESVNBQkxFX0NPUFkoV2ViVmlld3BvcnRBcmd1bWVudHMpCiB9OwogCiB9IC8vIG5hbWVz cGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGI5OGIwMTUuLjU2 OTVlYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisy MDEyLTEyLTE2ICBBbnRob255IFNjaWFuICA8YXNjaWFuQHJpbS5jb20+CisKKyAgICAgICAgW0Js YWNrYmVycnldIFN0YXRpYyBjb2RlIGFuYWx5c2lzIHdhcm5pbmcgZml4ZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTEyOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZGlzYWJsZSBjb3B5L29wPSBp biBCYWNraW5nU3RvcmUKKyAgICAgICAgLSBjYWNoZSBhbmQgY2hlY2sgaW50ZXJtZWRpYXRlIHZh bHVlcyBpbiBwYXJlbnRMYXllcgorICAgICAgICAtIGRpc2FibGUgY29weS9vcD0gaW4gSW5SZWdp b25TY3JvbGxlcgorICAgICAgICAtIGRpc2FibGUgY29weS9vcD0gaW4gV2ViUGFnZUdyb3VwTG9h ZERlZmVycmVyCisgICAgICAgIC0gZGlzYWJsZSBjb3B5L29wPSBpbiBXZWJTZXR0aW5ncworICAg ICAgICAtIGRpc2FibGUgY29weS9vcD0gaW4gV2ViVmlld3BvcnRBcmd1bWVudHMKKyAgICAgICAg LSBkaXNhYmxlIGNvcHkvb3A9IGluIEJhY2tpbmdTdG9yZUNsaWVudAorICAgICAgICAtIGRpc2Fi bGUgY29weS9vcD0gaW4gVGlsZUJ1ZmZlcgorICAgICAgICAtIGlmIHN0b3BOb2RlIGlzIG5vdCBO VUxMLCBsb29wIGNvdWxkIGl0ZXJhdGUgcGFzdCBOVUxMOyBhZGRlZCBOVUxMIGNoZWNrIHRvIGxv b3AKKyAgICAgICAgICB0byBtYWtlIHRoZSBjb2RlIG1vcmUgcm9idXN0CisKKyAgICAgICAgKiBB cGkvQmFja2luZ1N0b3JlLmg6CisgICAgICAgICogQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2Fs Y3VsYXRlSW5SZWdpb25TY3JvbGxhYmxlQXJlYXNGb3JQb2ludCk6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OnBhcmVudExheWVyKToKKyAgICAgICAgKiBBcGkvSW5SZWdpb25TY3JvbGxl ci5oOgorICAgICAgICAqIEFwaS9XZWJQYWdlR3JvdXBMb2FkRGVmZXJyZXIuaDoKKyAgICAgICAg KiBBcGkvV2ViU2V0dGluZ3MuaDoKKyAgICAgICAgKiBBcGkvV2ViVmlld3BvcnRBcmd1bWVudHMu aDoKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5oOgorICAgICAg ICAoQmFja2luZ1N0b3JlQ2xpZW50KToKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0JhY2tpbmdT dG9yZVRpbGUuaDoKKyAgICAgICAgKFRpbGVCdWZmZXIpOgorICAgICAgICAqIFdlYktpdFN1cHBv cnQvRE9NU3VwcG9ydC5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkRPTVN1cHBv cnQ6OnZpc2libGVUZXh0UXVhZHMpOgorCiAyMDEyLTEyLTE1ICBOaW1hIEdoYW5hdmF0aWFuICA8 bmdoYW5hdmF0aWFuQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFBhc3Mga2V5IG1v ZGlmaWVycyB3aXRoIHRvdWNoIGFuZCBtb3VzZSBldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5oIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQmFja2luZ1N0b3JlQ2xpZW50LmgK aW5kZXggMTg1MzM3Mi4uNDlmMjA1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvQmFja2luZ1N0b3JlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQmFja2luZ1N0b3JlQ2xpZW50LmgKQEAgLTE5LDYg KzE5LDcgQEAKICNpZm5kZWYgQmFja2luZ1N0b3JlQ2xpZW50X2gKICNkZWZpbmUgQmFja2luZ1N0 b3JlQ2xpZW50X2gKIAorI2luY2x1ZGUgIkJsYWNrQmVycnlQbGF0Zm9ybU1pc2MuaCIKICNpbmNs dWRlICJXZWJQYWdlX3AuaCIKICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKQEAgLTEwNyw2ICsx MDgsNyBAQCBwcml2YXRlOgogICAgIEJhY2tpbmdTdG9yZSogbV9iYWNraW5nU3RvcmU7CiAgICAg Ym9vbCBtX2lzQ2xpZW50R2VuZXJhdGVkU2Nyb2xsOwogICAgIGJvb2wgbV9pc1Njcm9sbE5vdGlm aWNhdGlvblN1cHByZXNzZWQ7CisgICAgRElTQUJMRV9DT1BZKEJhY2tpbmdTdG9yZUNsaWVudCkK IH07CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBw b3J0L0JhY2tpbmdTdG9yZVRpbGUuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0JhY2tpbmdTdG9yZVRpbGUuaAppbmRleCAyMGRkNGI4Li42ZDljNWVlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9CYWNraW5nU3RvcmVU aWxlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQmFja2lu Z1N0b3JlVGlsZS5oCkBAIC0yMCw2ICsyMCw3IEBACiAjZGVmaW5lIEJhY2tpbmdTdG9yZVRpbGVf aAogCiAjaW5jbHVkZSAiQmxhY2tCZXJyeVBsYXRmb3JtSW50UmVjdFJlZ2lvbi5oIgorI2luY2x1 ZGUgIkJsYWNrQmVycnlQbGF0Zm9ybU1pc2MuaCIKICNpbmNsdWRlICJCbGFja0JlcnJ5UGxhdGZv cm1QcmltaXRpdmVzLmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3 dGYvUmVmQ291bnRlZC5oPgpAQCAtMTA1LDYgKzEwNiw3IEBAIGNsYXNzIFRpbGVCdWZmZXIgewog ICAgICAgICBtdXRhYmxlIFBsYXRmb3JtOjpHcmFwaGljczo6QnVmZmVyKiBtX25hdGl2ZUJ1ZmZl cjsKICAgICAgICAgZG91YmxlIG1fbGFzdFJlbmRlclNjYWxlOwogICAgICAgICBib29sIG1fYmFj a2dyb3VuZFBhaW50ZWQ7CisgICAgICAgIERJU0FCTEVfQ09QWShUaWxlQnVmZmVyKQogfTsKIAog fSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCmluZGV4IDkzYjA1NDYuLjBkMGFiM2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBv cnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1 cHBvcnQuY3BwCkBAIC03NCw3ICs3NCw3IEBAIHZvaWQgdmlzaWJsZVRleHRRdWFkcyhjb25zdCBS YW5nZSYgcmFuZ2UsIFZlY3RvcjxGbG9hdFF1YWQ+JiBxdWFkcywgYm9vbCB1c2VTZWxlCiAgICAg ICAgIHJldHVybjsKIAogICAgIE5vZGUqIHN0b3BOb2RlID0gcmFuZ2UucGFzdExhc3ROb2RlKCk7 Ci0gICAgZm9yIChOb2RlKiBub2RlID0gcmFuZ2UuZmlyc3ROb2RlKCk7IG5vZGUgIT0gc3RvcE5v ZGU7IG5vZGUgPSBub2RlLT50cmF2ZXJzZU5leHROb2RlKCkpIHsKKyAgICBmb3IgKE5vZGUqIG5v ZGUgPSByYW5nZS5maXJzdE5vZGUoKTsgbm9kZSAmJiBub2RlICE9IHN0b3BOb2RlOyBub2RlID0g bm9kZS0+dHJhdmVyc2VOZXh0Tm9kZSgpKSB7CiAgICAgICAgIFJlbmRlck9iamVjdCogciA9IG5v ZGUtPnJlbmRlcmVyKCk7CiAgICAgICAgIGlmICghciB8fCAhci0+aXNUZXh0KCkpCiAgICAgICAg ICAgICBjb250aW51ZTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCAzMDJmMmRjLi5kNzlhNDI5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTItMTYgIEFudGhv bnkgU2NpYW4gIDxhc2NpYW5AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tiZXJyeV0gU3RhdGlj IGNvZGUgYW5hbHlzaXMgd2FybmluZyBmaXhlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbnVsbCBjaGVja3MgZm9yIGZvcGVuIGNhbGxzLCBu byByZWNvdmVyeSBhdHRlbXB0ZWQ7IGFjY2VzcyBmYXVsdCBwcmV2ZW50aW9uIG9ubHkuCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAg ICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6Y3JlYXRlRmlsZSk6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVlOjpydW5UZXN0KToKKwogMjAxMi0xMi0xNSAgTmlt YSBHaGFuYXZhdGlhbiAgPG5naGFuYXZhdGlhbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XSBQYXNzIGtleSBtb2RpZmllcnMgd2l0aCB0b3VjaCBhbmQgbW91c2UgZXZlbnRzCmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNw cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwCmlu ZGV4IGQ0NmIzYzQuLjNhODVjYjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Js YWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Js YWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC0xNTYsNyArMTU2LDggQEAgYm9vbCBEdW1w UmVuZGVyVHJlZTo6c19zZWxlY3RUcmFpbGluZ1doaXRlc3BhY2VFbmFibGVkID0gZmFsc2U7CiBz dGF0aWMgdm9pZCBjcmVhdGVGaWxlKGNvbnN0IFN0cmluZyYgZmlsZU5hbWUpCiB7CiAgICAgRklM RSogZmQgPSBmb3BlbihmaWxlTmFtZS51dGY4KCkuZGF0YSgpLCAid2IiKTsKLSAgICBmY2xvc2Uo ZmQpOworICAgIGlmIChmZCkKKyAgICAgICAgZmNsb3NlKGZkKTsKIH0KIAogRHVtcFJlbmRlclRy ZWU6OkR1bXBSZW5kZXJUcmVlKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZSogcGFnZSkKQEAg LTIwMyw4ICsyMDQsMTAgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZTo6cnVuVGVzdChjb25zdCBTdHJp bmcmIHVybCwgY29uc3QgU3RyaW5nJiBpbWFnZUhhc2gpCiAgICAgICAgIGZyZW9wZW4oc3RkZXJy RmlsZS51dGY4KCkuZGF0YSgpLCAid2IiLCBzdGRlcnIpOwogICAgIH0KICAgICBGSUxFKiBjdXJy ZW50ID0gZm9wZW4obV9jdXJyZW50VGVzdEZpbGUudXRmOCgpLmRhdGEoKSwgInciKTsKLSAgICBm d3JpdGUobV9jdXJyZW50VGVzdC0+dXRmOCgpLmRhdGEoKSwgMSwgbV9jdXJyZW50VGVzdC0+dXRm OCgpLmxlbmd0aCgpLCBjdXJyZW50KTsKLSAgICBmY2xvc2UoY3VycmVudCk7CisgICAgaWYgKGN1 cnJlbnQpIHsKKyAgICAgICAgZndyaXRlKG1fY3VycmVudFRlc3QtPnV0ZjgoKS5kYXRhKCksIDEs IG1fY3VycmVudFRlc3QtPnV0ZjgoKS5sZW5ndGgoKSwgY3VycmVudCk7CisgICAgICAgIGZjbG9z ZShjdXJyZW50KTsKKyAgICB9CiAgICAgbV9wYWdlLT5sb2FkKHVybCwgQmxhY2tCZXJyeTo6UGxh dGZvcm06OlN0cmluZzo6ZW1wdHlTdHJpbmcoKSwgZmFsc2UpOwogfQogCi0tIAoxLjguMC4xCgo=