105116 2012-12-15 15:50:17 -0800 DidHitRelevantRepaintedObjectsAreaThreshold should not use the viewRect since that varies 2012-12-17 16:46:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin ggaren simon.fraser thorton webkit-bug-importer oldest_to_newest 792240 0 bdakin 2012-12-15 15:50:17 -0800 DidHitRelevantRepaintedObjectsAreaThreshold should not use the viewRect since that varies depending on window size. This can lead to a huge amount of variability in the heuristic which is not desired. Instead, we should use a hard-coded rect. 792241 1 webkit-bug-importer 2012-12-15 15:50:42 -0800 <rdar://problem/12889449> 792242 2 bdakin 2012-12-15 15:57:27 -0800 Adding Simon and Tim as CC's since I have discussed making this change with both of them in the past. 792243 3 179629 bdakin 2012-12-15 15:59:26 -0800 Created attachment 179629 Patch 793159 4 179629 ggaren 2012-12-17 16:42:26 -0800 Comment on attachment 179629 Patch r=me with typo fixes. 793166 5 bdakin 2012-12-17 16:46:19 -0800 Thank you!! http://trac.webkit.org/changeset/137959 179629 2012-12-15 15:59:26 -0800 2012-12-17 16:42:26 -0800 Patch for-review.txt text/plain 3956 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzgxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTE1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBEaWRIaXRSZWxldmFudFJlcGFpbnRl ZE9iamVjdHNBcmVhVGhyZXNob2xkIHNob3VsZCBub3QgdXNlIHRoZSB2aWV3UmVjdCBzaW5jZSAK KyAgICAgICAgdGhhdCB2YXJpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNTExNgorICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xMjg4OTQ0OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBEaWRIaXRSZWxldmFudFJlcGFpbnRlZE9iamVjdHNBcmVhVGhy ZXNob2xkIHNob3VsZCBub3QgdXNlIHRoZSB2aWV3UmVjdCBzaW5jZSB0aGF0IAorICAgICAgICB2 YXJpZXMgZGVwZW5kaW5nIG9uIHdpbmRvdyBzaXplLiBUaGlzIGNhbiBsZWFkIHRvIGEgaHVnZSBh bW91bnQgb2YgdmFyaWFiaWxpdHkgaW4gCisgICAgICAgIHRoZSBoZXVyaXN0aWMgd2hpY2ggaXMg bm90IGRlc2lyZWQuIEluc3RlYWQsIHdlIHNob3VsZCB1c2UgYSBoYXJkLWNvZGVkIHJlY3QuCisg ICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlbGV2YW50Vmlld1Jl Y3QpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjphZGRSZWxl dmFudFJlcGFpbnRlZE9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjphZGRSZWxldmFu dFVucGFpbnRlZE9iamVjdCk6CisKIDIwMTItMTItMTUgIE5pbWEgR2hhbmF2YXRpYW4gIDxuZ2hh bmF2YXRpYW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gUGFzcyBrZXkgbW9kaWZp ZXJzIHdpdGggdG91Y2ggYW5kIG1vdXNlIGV2ZW50cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFn ZS9QYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCShy ZXZpc2lvbiAxMzc4MTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMTkxLDYgKzExOTEsMjMgQEAgdm9pZCBQYWdlOjpyZXNldFJlbGV2YW50UGFp bnRlZE9iamVjdENvdQogICAgIG1fcmVsZXZhbnRVbnBhaW50ZWRSZWdpb24gPSBSZWdpb24oKTsK IH0KIAorc3RhdGljIExheW91dFJlY3QgcmVsZXZhbnRWaWV3UmVjdChSZW5kZXJWaWV3KiB2aWV3 KQoreworICAgIC8vIERpZEhpdFJlbGV2YW50UmVwYWludGVkT2JqZWN0c0FyZWFUaHJlc2hvbGQg aXMgYSBMYXlvdXRNaWxlc3RvbmUgaW50ZW5kZWQgdG8gaW5kaWNhdGUgdGhhdAorICAgIC8vIGEg Y2VydGFpbiByZWxldmFudCBhbW91bnQgb2YgY29udGVudCBoYXMgYmVlbiBkcmF3biB0byB0aGUg c2NyZWVuLiBUaGlzIGlzIHRoZSByZWN0IHRoYXQKKyAgICAvLyB3ZSBoYXMgYmVlbiBkZXRlcm1p bmVkIHRvIGJlIHJlbGV2YW50IGluIHRoZSBjb250ZXh0IG9mIHRoaXMgZ29hbC4gV2UgbWF5IGNo b29zZSB0byB0d2VhaworICAgIC8vIHRoZSByZWN0IG92ZXIgdGltZSwgbXVjaCBsaWtlIHdlIG1h eSBjaG9vc2UgdG8gdHdlYWsgZ01pbmltdW1QYWludGVkQXJlYVJhdGlvIGFuZAorICAgIC8vIGdN YXhpbXVtVW5wYWludGVkQXJlYVJhdGlvLiBCdXQgdGhpcyBzZWVtcyB0byB3b3JrIHdlbGwgcmln aHQgbm93LgorICAgIExheW91dFJlY3QgcmVsZXZhbnRWaWV3UmVjdCA9IExheW91dFJlY3QoMCwg MCwgOTgwLCAxMzAwKTsKKworICAgIExheW91dFJlY3Qgdmlld1JlY3QgPSB2aWV3LT52aWV3UmVj dCgpOworICAgIC8vIElmIHRoZSB2aWV3UmVjdCBpcyB3aWRlciB0aGFuIHRoZSByZWxldmFudFZp ZXdSZWN0LCBjZW50ZXIgdGhlIHRoZSByZWxldmFudFZpZXdSZWN0LgorICAgIGlmICh2aWV3UmVj dC53aWR0aCgpID4gcmVsZXZhbnRWaWV3UmVjdC53aWR0aCgpKQorICAgICAgICByZWxldmFudFZp ZXdSZWN0LnNldFgoKHZpZXdSZWN0LndpZHRoKCkgLSByZWxldmFudFZpZXdSZWN0LndpZHRoKCkp IC8gMik7CisKKyAgICByZXR1cm4gcmVsZXZhbnRWaWV3UmVjdDsKK30KKwogdm9pZCBQYWdlOjph ZGRSZWxldmFudFJlcGFpbnRlZE9iamVjdChSZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgTGF5 b3V0UmVjdCYgb2JqZWN0UGFpbnRSZWN0KQogewogICAgIGlmICghaXNDb3VudGluZ1JlbGV2YW50 UmVwYWludGVkT2JqZWN0cygpKQpAQCAtMTIwNCw4ICsxMjIxLDEwIEBAIHZvaWQgUGFnZTo6YWRk UmVsZXZhbnRSZXBhaW50ZWRPYmplY3QoUmUKICAgICBpZiAoIXZpZXcpCiAgICAgICAgIHJldHVy bjsKIAorICAgIExheW91dFJlY3QgcmVsZXZhbnRSZWN0ID0gcmVsZXZhbnRWaWV3UmVjdCh2aWV3 KTsKKwogICAgIC8vIFRoZSBvYmplY3RzIGFyZSBvbmx5IHJlbGV2YW50IGlmIHRoZXkgYXJlIGJl aW5nIHBhaW50ZWQgd2l0aGluIHRoZSB2aWV3UmVjdCgpLgotICAgIGlmICghb2JqZWN0UGFpbnRS ZWN0LmludGVyc2VjdHMocGl4ZWxTbmFwcGVkSW50UmVjdCh2aWV3LT52aWV3UmVjdCgpKSkpCisg ICAgaWYgKCFvYmplY3RQYWludFJlY3QuaW50ZXJzZWN0cyhwaXhlbFNuYXBwZWRJbnRSZWN0KHJl bGV2YW50UmVjdCkpKQogICAgICAgICByZXR1cm47CiAKICAgICBJbnRSZWN0IHNuYXBwZWRQYWlu dFJlY3QgPSBwaXhlbFNuYXBwZWRJbnRSZWN0KG9iamVjdFBhaW50UmVjdCk7CkBAIC0xMjIwLDcg KzEyMzksNyBAQCB2b2lkIFBhZ2U6OmFkZFJlbGV2YW50UmVwYWludGVkT2JqZWN0KFJlCiAKICAg ICBtX3JlbGV2YW50UGFpbnRlZFJlZ2lvbi51bml0ZShzbmFwcGVkUGFpbnRSZWN0KTsKICAgICAK LSAgICBmbG9hdCB2aWV3QXJlYSA9IHZpZXctPnZpZXdSZWN0KCkud2lkdGgoKSAqIHZpZXctPnZp ZXdSZWN0KCkuaGVpZ2h0KCk7CisgICAgZmxvYXQgdmlld0FyZWEgPSByZWxldmFudFJlY3Qud2lk dGgoKSAqIHJlbGV2YW50UmVjdC5oZWlnaHQoKTsKICAgICBmbG9hdCByYXRpb09mVmlld1RoYXRJ c1BhaW50ZWQgPSBtX3JlbGV2YW50UGFpbnRlZFJlZ2lvbi50b3RhbEFyZWEoKSAvIHZpZXdBcmVh OwogICAgIGZsb2F0IHJhdGlvT2ZWaWV3VGhhdElzVW5wYWludGVkID0gbV9yZWxldmFudFVucGFp bnRlZFJlZ2lvbi50b3RhbEFyZWEoKSAvIHZpZXdBcmVhOwogCkBAIC0xMjM3LDkgKzEyNTYsOSBA QCB2b2lkIFBhZ2U6OmFkZFJlbGV2YW50VW5wYWludGVkT2JqZWN0KFJlCiAgICAgaWYgKCFpc0Nv dW50aW5nUmVsZXZhbnRSZXBhaW50ZWRPYmplY3RzKCkpCiAgICAgICAgIHJldHVybjsKIAotICAg IC8vIFRoZSBvYmplY3RzIGFyZSBvbmx5IHJlbGV2YW50IGlmIHRoZXkgYXJlIGJlaW5nIHBhaW50 ZWQgd2l0aGluIHRoZSB2aWV3UmVjdCgpLgorICAgIC8vIFRoZSBvYmplY3RzIGFyZSBvbmx5IHJl bGV2YW50IGlmIHRoZXkgYXJlIGJlaW5nIHBhaW50ZWQgd2l0aGluIHRoZSByZWxldmFudFZpZXdS ZWN0KCkuCiAgICAgaWYgKFJlbmRlclZpZXcqIHZpZXcgPSBvYmplY3QtPnZpZXcoKSkgewotICAg ICAgICBpZiAoIW9iamVjdFBhaW50UmVjdC5pbnRlcnNlY3RzKHBpeGVsU25hcHBlZEludFJlY3Qo dmlldy0+dmlld1JlY3QoKSkpKQorICAgICAgICBpZiAoIW9iamVjdFBhaW50UmVjdC5pbnRlcnNl Y3RzKHBpeGVsU25hcHBlZEludFJlY3QocmVsZXZhbnRWaWV3UmVjdCh2aWV3KSkpKQogICAgICAg ICAgICAgcmV0dXJuOwogICAgIH0KIAo=