105110 2012-12-15 14:38:08 -0800 [BlackBerry] Clean up allocated memory from InputMethodSupport 2012-12-15 15:41:20 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nghanavatian mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 792200 0 nima.ghanavatian 2012-12-15 14:38:08 -0800 We are deep copying the struct sent by IMF as they clean up as soon as we return. Free once we're done with it, since we only need the length and location. 792202 1 179618 nghanavatian 2012-12-15 14:40:34 -0800 Created attachment 179618 Patch 792203 2 179618 rwlbuis 2012-12-15 14:41:51 -0800 Comment on attachment 179618 Patch LGTM. 792206 3 179618 webkit.review.bot 2012-12-15 14:43:36 -0800 Comment on attachment 179618 Patch Rejecting attachment 179618 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp Hunk #1 succeeded at 688 (offset -10 lines). Hunk #2 FAILED at 2270. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15366174 792214 4 179622 nghanavatian 2012-12-15 15:02:01 -0800 Created attachment 179622 Patch 792216 5 179622 rwlbuis 2012-12-15 15:04:45 -0800 Comment on attachment 179622 Patch Looks good. 792234 6 179622 webkit.review.bot 2012-12-15 15:41:16 -0800 Comment on attachment 179622 Patch Clearing flags on attachment: 179622 Committed r137816: <http://trac.webkit.org/changeset/137816> 792235 7 webkit.review.bot 2012-12-15 15:41:20 -0800 All reviewed patches have been landed. Closing bug. 179618 2012-12-15 14:40:34 -0800 2012-12-15 15:01:59 -0800 Patch bug-105110-20121215173218.patch text/plain 2304 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlOTM4YmVlMTRjYTk2YzUxZjNhMjZlN2I1MDNlMGM2YTVjYjhjZjFhLi4wYmNkMjQ4MzUz MWYyOGFiNDk4MDViM2QyZjhiNjk2YjA3NDI3YzIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMi0xNSAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDbGVhbiB1cCBhbGxv Y2F0ZWQgbWVtb3J5IGZyb20gSW5wdXRNZXRob2RTdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUxMTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQUjI2NTkxOQorICAgICAgICBXZSBhcmUgZGVl cCBjb3B5aW5nIHRoZSBzcGFubmFibGVfc3RyaW5nIGZyb20gSU1GIGFuZCBmcmVlaW5nCisgICAg ICAgIGhlcmUgb25jZSB3ZSdyZSBkb25lIHdpdGggaXQuCisKKyAgICAgICAgSW50ZXJuYWxseSBy ZXZpZXdlZCBieSBKZWZmIFJvZ2Vycy4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRI YW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpz cGVsbENoZWNraW5nUmVxdWVzdFByb2Nlc3NlZCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OklucHV0SGFuZGxlcjo6YXR0cmlidXRlVGltZXJGaXJlZCk6CisKIDIwMTItMTItMTMgIFBh cnRoIFBhdGVsICA8cGFycGF0ZWxAcmltLmNvbT4sIE1heCBGZWlsIDxtZmVpbEByaW0uY29tPgog CiAgICAgICAgIEFsbG93IHBsdWdpbnMgdG8gYmUgZGlzYWJsZWQgYnkgc2hhcmVkIGxpYnJhcnkg ZmlsZW5hbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBw b3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDdhNWNlZjAxZDRhYTkzMzhiZWJhYzExZTc5ZTIy MzU4YTE4MjVjNTQuLmY0YzNiYjc1NzQ3YTczZTRjMDkzOTdjNjM3MDRiNDllMDgyNGZhNDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFu ZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5w dXRIYW5kbGVyLmNwcApAQCAtNjk4LDYgKzY5OCwxMCBAQCB2b2lkIElucHV0SGFuZGxlcjo6c3Bl bGxDaGVja2luZ1JlcXVlc3RQcm9jZXNzZWQoaW50MzJfdCB0cmFuc2FjdGlvbklkLCBzcGFubmFi bAogICAgICAgICBzcGFuKys7CiAgICAgfQogCisgICAgLy8gZnJlZSBkYXRhIHRoYXQgd2UgbWFs bG9jJ2VkIGluIElucHV0TWV0aG9kU3VwcG9ydAorICAgIGZyZWUoc3Bhbm5hYmxlU3RyaW5nLT5z cGFucyk7CisgICAgZnJlZShzcGFubmFibGVTdHJpbmcpOworCiAgICAgbV9yZXF1ZXN0LT5kaWRT dWNjZWVkKHJlc3VsdHMpOwogfQogCkBAIC0yMjY2LDcgKzIyNzAsNyBAQCB2b2lkIElucHV0SGFu ZGxlcjo6YXR0cmlidXRlVGltZXJGaXJlZChXZWJDb3JlOjpUaW1lcjxJbnB1dEhhbmRsZXI+KikK IAogICAgIC8vIEFwcGx5IGNhY2hlZCBhdHRyaWJ1dGVzIGlmIHRoZXkgZXhpc3QuCiAgICAgSW5w dXRMb2coTG9nTGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjphdHRyaWJ1dGVUaW1lckZpcmVkIGFw cGx5aW5nIGNhY2hlZCBhdHRyaWJ1dGVzIGNvdW50ICVkIiwgbV9jYWNoZWRTcGFubmFibGVBdHRy aWJ1dGVzLnNpemUoKSk7Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBtX2NhY2hlZFNwYW5uYWJs ZUF0dHJpYnV0ZXMuc2l6ZSgpOyBpKyspCisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1f Y2FjaGVkU3Bhbm5hYmxlQXR0cmlidXRlcy5zaXplKCk7IGkrKykKICAgICAgICAgYWRkQXR0cmli dXRlZFRleHRNYXJrZXIobV9jYWNoZWRTcGFubmFibGVBdHRyaWJ1dGVzW2ldLnN0YXJ0LCBtX2Nh Y2hlZFNwYW5uYWJsZUF0dHJpYnV0ZXNbaV0uZW5kLCB0ZXh0U3R5bGVGcm9tTWFzayhtX2NhY2hl ZFNwYW5uYWJsZUF0dHJpYnV0ZXNbaV0uYXR0cmlidXRlKSk7CiAKICAgICBtX2NhY2hlZFNwYW5u YWJsZUF0dHJpYnV0ZXMuY2xlYXIoKTsK 179622 2012-12-15 15:02:01 -0800 2012-12-15 15:41:15 -0800 Patch bug-105110-20121215175345.patch text/plain 1596 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0NDljNWFhZDJjNzFhN2NkYmVkYzI1OGQzNmJmYTc0ZTBkYTQ3ZWE1Li5lNTk4N2Y2MGVh NDUzYzMzZDI4NmE3MGQ5MTg1OTgyMzYzMTU0MmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMi0xNSAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDbGVhbiB1cCBhbGxv Y2F0ZWQgbWVtb3J5IGZyb20gSW5wdXRNZXRob2RTdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUxMTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQUjI2NTkxOQorICAgICAgICBXZSBhcmUgZGVl cCBjb3B5aW5nIHRoZSBzcGFubmFibGVfc3RyaW5nIGZyb20gSU1GIGFuZCBmcmVlaW5nCisgICAg ICAgIGhlcmUgb25jZSB3ZSdyZSBkb25lIHdpdGggaXQuCisKKyAgICAgICAgSW50ZXJuYWxseSBy ZXZpZXdlZCBieSBKZWZmIFJvZ2Vycy4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRI YW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpz cGVsbENoZWNraW5nUmVxdWVzdFByb2Nlc3NlZCk6CisKIDIwMTItMTItMTQgIFBhcnRoIFBhdGVs ICA8cGFycGF0ZWxAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQWxsb3cgcGx1Z2lu cyB0byBiZSBkaXNhYmxlZCBieSBzaGFyZWQgbGlicmFyeSBmaWxlbmFtZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAK aW5kZXggOWQwYTE3M2QxZmFhYjk2OTA4M2JkZjQ1NjUxYWJlMTc4NDU5ZTE0MS4uOTU4YjdhMDEx OTRhNWM1ZDQ3N2I0MzcyZDk2ZjYyZTExMTA5OTRmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCkBAIC02ODgs NiArNjg4LDEwIEBAIHZvaWQgSW5wdXRIYW5kbGVyOjpzcGVsbENoZWNraW5nUmVxdWVzdFByb2Nl c3NlZChpbnQzMl90IHRyYW5zYWN0aW9uSWQsIHNwYW5uYWJsCiAgICAgICAgIHNwYW4rKzsKICAg ICB9CiAKKyAgICAvLyBmcmVlIGRhdGEgdGhhdCB3ZSBtYWxsb2MnZWQgaW4gSW5wdXRNZXRob2RT dXBwb3J0CisgICAgZnJlZShzcGFubmFibGVTdHJpbmctPnNwYW5zKTsKKyAgICBmcmVlKHNwYW5u YWJsZVN0cmluZyk7CisKICAgICBtX3JlcXVlc3QtPmRpZFN1Y2NlZWQocmVzdWx0cyk7CiB9CiAK