105107 2012-12-15 13:59:49 -0800 DownloadProxy should keep a strong reference to its associated web context 2012-12-15 14:05:13 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 792188 0 andersca 2012-12-15 13:59:49 -0800 DownloadProxy should keep a strong reference to its associated web context 792189 1 179614 andersca 2012-12-15 14:02:15 -0800 Created attachment 179614 Patch 792190 2 andersca 2012-12-15 14:05:13 -0800 Committed r137810: <http://trac.webkit.org/changeset/137810> 179614 2012-12-15 14:02:15 -0800 2012-12-15 14:03:08 -0800 Patch bug-105107-20121215135934.patch text/plain 7449 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDM5MGVkYzdlOWRjZWQ0 NTA1OTk2ZjNiNDA4NzhmZmFmOGVhNDg0My4uY2NhNjk2ZjMyNmU5NGQ1M2E4M2QwYzA5ODhiM2Fj OWQ3MDAwM2QzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTEyLTE1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRG93bmxvYWRQcm94 eSBzaG91bGQga2VlcCBhIHN0cm9uZyByZWZlcmVuY2UgdG8gaXRzIGFzc29jaWF0ZWQgd2ViIGNv bnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NTEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo aWxlIHRoaXMgZG9lcyBjcmVhdGUgYSByZWYtY3ljbGUsIGl0J3MgYnJva2VuIHdoZW4gdGhlIGRv d25sb2FkIGNvbXBsZXRlcywgZmFpbHMsIGlzIGNhbmNlbGVkIG9yCisgICAgICAgIGlmIHRoZSBw cm9jZXNzIHRoYXQncyBkb2luZyB0aGUgZG93bmxvYWQgY3Jhc2hlcy4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRv d25sb2FkUHJveHk6OnByb2Nlc3NEaWRDbG9zZSk6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2Fk UHJveHk6OmRpZFN0YXJ0KToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQcm94eTo6ZGlkUmVj ZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQ cm94eTo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQcm94 eTo6ZGlkUmVjZWl2ZURhdGEpOgorICAgICAgICAoV2ViS2l0OjpEb3dubG9hZFByb3h5OjpzaG91 bGREZWNvZGVTb3VyY2VEYXRhT2ZNSU1FVHlwZSk6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2Fk UHJveHk6OmRlY2lkZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1lKToKKyAgICAgICAg KFdlYktpdDo6RG93bmxvYWRQcm94eTo6ZGlkQ3JlYXRlRGVzdGluYXRpb24pOgorICAgICAgICAo V2ViS2l0OjpEb3dubG9hZFByb3h5OjpkaWRGaW5pc2gpOgorICAgICAgICAoV2ViS2l0OjpEb3du bG9hZFByb3h5OjpkaWRGYWlsKToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQcm94eTo6ZGlk Q2FuY2VsKToKKyAgICAgICAgKiBVSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHkuaDoK KyAgICAgICAgKERvd25sb2FkUHJveHkpOgorCisyMDEyLTEyLTE1ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUmVtb3ZlIFdlYkNvbnRleHQ6OmRvd25s b2FkRmluaXNoZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNTEwNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRG93bmxv YWRzL0Rvd25sb2FkUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Rvd25sb2Fk cy9Eb3dubG9hZFByb3h5LmNwcAppbmRleCBhZWE2MzEzNWJjM2U3ZDgxMWQyOWE3ZDNkNTcwMzFm YWZhOTc1MGZkLi4zZTBhMTA4YWY2ZWVhMzdhYjQ2NTI2YjM3OTNjYWNjMTU5YWE3Y2Q1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHku Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94 eS5jcHAKQEAgLTgyLDcgKzgyLDcgQEAgdm9pZCBEb3dubG9hZFByb3h5Ojpwcm9jZXNzRGlkQ2xv c2UoKQogICAgIGlmICghbV93ZWJDb250ZXh0KQogICAgICAgICByZXR1cm47CiAKLSAgICBtX3dl YkNvbnRleHQtPmRvd25sb2FkQ2xpZW50KCkucHJvY2Vzc0RpZENyYXNoKG1fd2ViQ29udGV4dCwg dGhpcyk7CisgICAgbV93ZWJDb250ZXh0LT5kb3dubG9hZENsaWVudCgpLnByb2Nlc3NEaWRDcmFz aChtX3dlYkNvbnRleHQuZ2V0KCksIHRoaXMpOwogfQogCiB2b2lkIERvd25sb2FkUHJveHk6OmRp ZFJlY2VpdmVNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24sIENvcmVJUEM6 Ok1lc3NhZ2VJRCBtZXNzYWdlSUQsIENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyJiBkZWNvZGVyKQpA QCAtMTAyLDcgKzEwMiw3IEBAIHZvaWQgRG93bmxvYWRQcm94eTo6ZGlkU3RhcnQoY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogICAgIGlmICghbV93ZWJDb250ZXh0KQogICAgICAgICBy ZXR1cm47CiAKLSAgICBtX3dlYkNvbnRleHQtPmRvd25sb2FkQ2xpZW50KCkuZGlkU3RhcnQobV93 ZWJDb250ZXh0LCB0aGlzKTsKKyAgICBtX3dlYkNvbnRleHQtPmRvd25sb2FkQ2xpZW50KCkuZGlk U3RhcnQobV93ZWJDb250ZXh0LmdldCgpLCB0aGlzKTsKIH0KIAogdm9pZCBEb3dubG9hZFByb3h5 OjpkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoY29uc3QgQXV0aGVudGljYXRpb25D aGFsbGVuZ2UmIGF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlLCB1aW50NjRfdCBjaGFsbGVuZ2VJRCkK QEAgLTExMyw3ICsxMTMsNyBAQCB2b2lkIERvd25sb2FkUHJveHk6OmRpZFJlY2VpdmVBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZShjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZQogICAgIC8vIEZJWE1F IChNdWx0aS1XZWJQcm9jZXNzKTogPHJkYXI6Ly9wcm9ibGVtLzEyMjM5NDgzPiBEb3dubG9hZHMg c2hvdWxkbid0IGJlIGhhbmRsZWQgaW4gdGhlIHdlYiBwcm9jZXNzLgogICAgIC8vIE9uY2UgdGhp cyBpcyBmaXhlZCwgcmVtb3ZlIFdlYkNvbnRleHQ6OmRlcHJlY2F0ZWRTaGFyZWRQcm9jZXNzKCku CiAgICAgUmVmUHRyPEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlUHJveHk+IGF1dGhlbnRpY2F0aW9u Q2hhbGxlbmdlUHJveHkgPSBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5OjpjcmVhdGUoYXV0 aGVudGljYXRpb25DaGFsbGVuZ2UsIGNoYWxsZW5nZUlELCBtX3dlYkNvbnRleHQtPmRlcHJlY2F0 ZWRTaGFyZWRQcm9jZXNzKCkpOwotICAgIG1fd2ViQ29udGV4dC0+ZG93bmxvYWRDbGllbnQoKS5k aWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UobV93ZWJDb250ZXh0LCB0aGlzLCBhdXRo ZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5LmdldCgpKTsKKyAgICBtX3dlYkNvbnRleHQtPmRvd25s b2FkQ2xpZW50KCkuZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG1fd2ViQ29udGV4 dC5nZXQoKSwgdGhpcywgYXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eS5nZXQoKSk7CiB9CiAK IHZvaWQgRG93bmxvYWRQcm94eTo6ZGlkUmVjZWl2ZVJlc3BvbnNlKGNvbnN0IFJlc291cmNlUmVz cG9uc2UmIHJlc3BvbnNlKQpAQCAtMTIxLDcgKzEyMSw3IEBAIHZvaWQgRG93bmxvYWRQcm94eTo6 ZGlkUmVjZWl2ZVJlc3BvbnNlKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogICAg IGlmICghbV93ZWJDb250ZXh0KQogICAgICAgICByZXR1cm47CiAKLSAgICBtX3dlYkNvbnRleHQt PmRvd25sb2FkQ2xpZW50KCkuZGlkUmVjZWl2ZVJlc3BvbnNlKG1fd2ViQ29udGV4dCwgdGhpcywg cmVzcG9uc2UpOworICAgIG1fd2ViQ29udGV4dC0+ZG93bmxvYWRDbGllbnQoKS5kaWRSZWNlaXZl UmVzcG9uc2UobV93ZWJDb250ZXh0LmdldCgpLCB0aGlzLCByZXNwb25zZSk7CiB9CiAKIHZvaWQg RG93bmxvYWRQcm94eTo6ZGlkUmVjZWl2ZURhdGEodWludDY0X3QgbGVuZ3RoKQpAQCAtMTI5LDcg KzEyOSw3IEBAIHZvaWQgRG93bmxvYWRQcm94eTo6ZGlkUmVjZWl2ZURhdGEodWludDY0X3QgbGVu Z3RoKQogICAgIGlmICghbV93ZWJDb250ZXh0KQogICAgICAgICByZXR1cm47CiAKLSAgICBtX3dl YkNvbnRleHQtPmRvd25sb2FkQ2xpZW50KCkuZGlkUmVjZWl2ZURhdGEobV93ZWJDb250ZXh0LCB0 aGlzLCBsZW5ndGgpOworICAgIG1fd2ViQ29udGV4dC0+ZG93bmxvYWRDbGllbnQoKS5kaWRSZWNl aXZlRGF0YShtX3dlYkNvbnRleHQuZ2V0KCksIHRoaXMsIGxlbmd0aCk7CiB9CiAKIHZvaWQgRG93 bmxvYWRQcm94eTo6c2hvdWxkRGVjb2RlU291cmNlRGF0YU9mTUlNRVR5cGUoY29uc3QgU3RyaW5n JiBtaW1lVHlwZSwgYm9vbCYgcmVzdWx0KQpAQCAtMTM3LDcgKzEzNyw3IEBAIHZvaWQgRG93bmxv YWRQcm94eTo6c2hvdWxkRGVjb2RlU291cmNlRGF0YU9mTUlNRVR5cGUoY29uc3QgU3RyaW5nJiBt aW1lVHlwZSwgYm9vCiAgICAgaWYgKCFtX3dlYkNvbnRleHQpCiAgICAgICAgIHJldHVybjsKIAot ICAgIHJlc3VsdCA9IG1fd2ViQ29udGV4dC0+ZG93bmxvYWRDbGllbnQoKS5zaG91bGREZWNvZGVT b3VyY2VEYXRhT2ZNSU1FVHlwZShtX3dlYkNvbnRleHQsIHRoaXMsIG1pbWVUeXBlKTsKKyAgICBy ZXN1bHQgPSBtX3dlYkNvbnRleHQtPmRvd25sb2FkQ2xpZW50KCkuc2hvdWxkRGVjb2RlU291cmNl RGF0YU9mTUlNRVR5cGUobV93ZWJDb250ZXh0LmdldCgpLCB0aGlzLCBtaW1lVHlwZSk7CiB9CiAK IHZvaWQgRG93bmxvYWRQcm94eTo6ZGVjaWRlRGVzdGluYXRpb25XaXRoU3VnZ2VzdGVkRmlsZW5h bWUoY29uc3QgU3RyaW5nJiBmaWxlbmFtZSwgU3RyaW5nJiBkZXN0aW5hdGlvbiwgYm9vbCYgYWxs b3dPdmVyd3JpdGUsIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSYgc2FuZGJveEV4dGVuc2lvbkhh bmRsZSkKQEAgLTE0NSw3ICsxNDUsNyBAQCB2b2lkIERvd25sb2FkUHJveHk6OmRlY2lkZURlc3Rp bmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1lKGNvbnN0IFN0cmluZyYgZmlsZW5hbQogICAgIGlm ICghbV93ZWJDb250ZXh0KQogICAgICAgICByZXR1cm47CiAKLSAgICBkZXN0aW5hdGlvbiA9IG1f d2ViQ29udGV4dC0+ZG93bmxvYWRDbGllbnQoKS5kZWNpZGVEZXN0aW5hdGlvbldpdGhTdWdnZXN0 ZWRGaWxlbmFtZShtX3dlYkNvbnRleHQsIHRoaXMsIGZpbGVuYW1lLCBhbGxvd092ZXJ3cml0ZSk7 CisgICAgZGVzdGluYXRpb24gPSBtX3dlYkNvbnRleHQtPmRvd25sb2FkQ2xpZW50KCkuZGVjaWRl RGVzdGluYXRpb25XaXRoU3VnZ2VzdGVkRmlsZW5hbWUobV93ZWJDb250ZXh0LmdldCgpLCB0aGlz LCBmaWxlbmFtZSwgYWxsb3dPdmVyd3JpdGUpOwogCiAgICAgaWYgKCFkZXN0aW5hdGlvbi5pc051 bGwoKSkKICAgICAgICAgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKGRlc3RpbmF0aW9u LCBTYW5kYm94RXh0ZW5zaW9uOjpXcml0ZU9ubHksIHNhbmRib3hFeHRlbnNpb25IYW5kbGUpOwpA QCAtMTU2LDcgKzE1Niw3IEBAIHZvaWQgRG93bmxvYWRQcm94eTo6ZGlkQ3JlYXRlRGVzdGluYXRp b24oY29uc3QgU3RyaW5nJiBwYXRoKQogICAgIGlmICghbV93ZWJDb250ZXh0KQogICAgICAgICBy ZXR1cm47CiAKLSAgICBtX3dlYkNvbnRleHQtPmRvd25sb2FkQ2xpZW50KCkuZGlkQ3JlYXRlRGVz dGluYXRpb24obV93ZWJDb250ZXh0LCB0aGlzLCBwYXRoKTsKKyAgICBtX3dlYkNvbnRleHQtPmRv d25sb2FkQ2xpZW50KCkuZGlkQ3JlYXRlRGVzdGluYXRpb24obV93ZWJDb250ZXh0LmdldCgpLCB0 aGlzLCBwYXRoKTsKIH0KIAogdm9pZCBEb3dubG9hZFByb3h5OjpkaWRGaW5pc2goKQpAQCAtMTY0 LDcgKzE2NCw3IEBAIHZvaWQgRG93bmxvYWRQcm94eTo6ZGlkRmluaXNoKCkKICAgICBpZiAoIW1f d2ViQ29udGV4dCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV93ZWJDb250ZXh0LT5kb3dubG9h ZENsaWVudCgpLmRpZEZpbmlzaChtX3dlYkNvbnRleHQsIHRoaXMpOworICAgIG1fd2ViQ29udGV4 dC0+ZG93bmxvYWRDbGllbnQoKS5kaWRGaW5pc2gobV93ZWJDb250ZXh0LmdldCgpLCB0aGlzKTsK IAogICAgIC8vIFRoaXMgY2FuIGNhdXNlIHRoZSBEb3dubG9hZFByb3h5IG9iamVjdCB0byBiZSBk ZWxldGVkLgogICAgIG1fZG93bmxvYWRQcm94eU1hcC5kb3dubG9hZEZpbmlzaGVkKHRoaXMpOwpA QCAtMTg1LDcgKzE4NSw3IEBAIHZvaWQgRG93bmxvYWRQcm94eTo6ZGlkRmFpbChjb25zdCBSZXNv dXJjZUVycm9yJiBlcnJvciwgY29uc3QgQ29yZUlQQzo6RGF0YVJlZmVyCiAKICAgICBtX3Jlc3Vt ZURhdGEgPSBjcmVhdGVXZWJEYXRhKHJlc3VtZURhdGEpOwogCi0gICAgbV93ZWJDb250ZXh0LT5k b3dubG9hZENsaWVudCgpLmRpZEZhaWwobV93ZWJDb250ZXh0LCB0aGlzLCBlcnJvcik7CisgICAg bV93ZWJDb250ZXh0LT5kb3dubG9hZENsaWVudCgpLmRpZEZhaWwobV93ZWJDb250ZXh0LmdldCgp LCB0aGlzLCBlcnJvcik7CiAKICAgICAvLyBUaGlzIGNhbiBjYXVzZSB0aGUgRG93bmxvYWRQcm94 eSBvYmplY3QgdG8gYmUgZGVsZXRlZC4KICAgICBtX2Rvd25sb2FkUHJveHlNYXAuZG93bmxvYWRG aW5pc2hlZCh0aGlzKTsKQEAgLTE5NSw3ICsxOTUsNyBAQCB2b2lkIERvd25sb2FkUHJveHk6OmRp ZENhbmNlbChjb25zdCBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlJiByZXN1bWVEYXRhKQogewogICAg IG1fcmVzdW1lRGF0YSA9IGNyZWF0ZVdlYkRhdGEocmVzdW1lRGF0YSk7CiAKLSAgICBtX3dlYkNv bnRleHQtPmRvd25sb2FkQ2xpZW50KCkuZGlkQ2FuY2VsKG1fd2ViQ29udGV4dCwgdGhpcyk7Cisg ICAgbV93ZWJDb250ZXh0LT5kb3dubG9hZENsaWVudCgpLmRpZENhbmNlbChtX3dlYkNvbnRleHQu Z2V0KCksIHRoaXMpOwogCiAgICAgLy8gVGhpcyBjYW4gY2F1c2UgdGhlIERvd25sb2FkUHJveHkg b2JqZWN0IHRvIGJlIGRlbGV0ZWQuCiAgICAgbV9kb3dubG9hZFByb3h5TWFwLmRvd25sb2FkRmlu aXNoZWQodGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRG93bmxv YWRzL0Rvd25sb2FkUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMv RG93bmxvYWRQcm94eS5oCmluZGV4IDhlN2YyYzNhYzdiMzcxNjkzZDg0YWQwNjFhN2YzMDgxMzVi OTFiYmQuLjM3ZmRlOTI5MjJiNjVmN2VlOTk1MzA5OTA2YzY1MzExZmQyM2RlODIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eS5oCkBA IC05MSw3ICs5MSw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaWRDYW5jZWwoY29uc3QgQ29yZUlQ Qzo6RGF0YVJlZmVyZW5jZSYgcmVzdW1lRGF0YSk7CiAKICAgICBEb3dubG9hZFByb3h5TWFwJiBt X2Rvd25sb2FkUHJveHlNYXA7Ci0gICAgV2ViQ29udGV4dCogbV93ZWJDb250ZXh0OworICAgIFJl ZlB0cjxXZWJDb250ZXh0PiBtX3dlYkNvbnRleHQ7CiAgICAgdWludDY0X3QgbV9kb3dubG9hZElE OwogCiAgICAgUmVmUHRyPFdlYkRhdGE+IG1fcmVzdW1lRGF0YTsK