105100 2012-12-15 12:26:49 -0800 Get rid of DownloadProxyMap::downloads() 2012-12-15 12:36:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 792166 0 andersca 2012-12-15 12:26:49 -0800 Get rid of DownloadProxyMap::downloads() 792167 1 179606 andersca 2012-12-15 12:28:43 -0800 Created attachment 179606 Patch 792169 2 179606 sam 2012-12-15 12:30:02 -0800 Comment on attachment 179606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179606&action=review > Source/WebKit2/ChangeLog:8 > + Add the needed member functions to DownloadProxymap and remove the downloads() member function. Typo, lowercase m in DownloadProxyMap. 792170 3 andersca 2012-12-15 12:36:55 -0800 Committed r137804: <http://trac.webkit.org/changeset/137804> 179606 2012-12-15 12:28:43 -0800 2012-12-15 12:30:02 -0800 Patch bug-105100-20121215122602.patch text/plain 4613 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTRlMTgxYmVlMGIyM2E3 MDgwOTk4OWYyZTI4NDVjNjYyODljMzFjYy4uMjE4YzU3MzUwYjVmNzA0ZDcyOTMwM2FjOGU0MDAy ZjVmODM4ZWI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEyLTE1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgR2V0IHJpZCBvZiBE b3dubG9hZFByb3h5TWFwOjpkb3dubG9hZHMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSBuZWVkZWQgbWVtYmVyIGZ1bmN0aW9ucyB0byBE b3dubG9hZFByb3h5bWFwIGFuZCByZW1vdmUgdGhlIGRvd25sb2FkcygpIG1lbWJlciBmdW5jdGlv bi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eU1hcC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkUHJveHlNYXA6OmRvd25sb2FkRmluaXNoZWQpOgor ICAgICAgICAoV2ViS2l0OjpEb3dubG9hZFByb3h5TWFwOjpwcm9jZXNzRGlkQ2xvc2UpOgorICAg ICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJv eHlNYXAuaDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQcm94eU1hcDo6aXNFbXB0eSk6Cisg ICAgICAgIChEb3dubG9hZFByb3h5TWFwKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4 dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnNob3VsZFRlcm1pbmF0ZSk6Cisg ICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OmRpc2Nvbm5lY3RQcm9jZXNzKToKKyAgICAgICAg KFdlYktpdDo6V2ViQ29udGV4dDo6ZG93bmxvYWRGaW5pc2hlZCk6CisKKzIwMTItMTItMTUgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBEb3dubG9hZFBy b3h5TWFwIHNob3VsZG4ndCBiZSBhIHNpbmdsZXRvbiBhZnRlciBhbGwKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTA5OQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHlNYXAuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmNwcApp bmRleCA5YmRlZGVhZDRkNjQ2ZTE1M2ViM2EzM2UyMmExZDk5YmJjYzg5ZTVhLi40Nzc3YTQ3MTlk Y2Q4MTZiZGM1M2Y3ZWExM2MyMDVjY2ViMDU1ZTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHlNYXAuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eU1hcC5jcHAKQEAgLTUyLDcg KzUyLDIwIEBAIHZvaWQgRG93bmxvYWRQcm94eU1hcDo6ZG93bmxvYWRGaW5pc2hlZChEb3dubG9h ZFByb3h5KiBkb3dubG9hZFByb3h5KQogewogICAgIEFTU0VSVChtX2Rvd25sb2Fkcy5jb250YWlu cyhkb3dubG9hZFByb3h5LT5kb3dubG9hZElEKCkpKTsKIAorICAgIGRvd25sb2FkUHJveHktPmlu dmFsaWRhdGUoKTsKKwogICAgIG1fZG93bmxvYWRzLnJlbW92ZShkb3dubG9hZFByb3h5LT5kb3du bG9hZElEKCkpOwogfQogCit2b2lkIERvd25sb2FkUHJveHlNYXA6OnByb2Nlc3NEaWRDbG9zZSgp Cit7CisgICAgLy8gSW52YWxpZGF0ZSBhbGwgb3V0c3RhbmRpbmcgZG93bmxvYWRzLgorICAgIGZv ciAoSGFzaE1hcDx1aW50NjRfdCwgUmVmUHRyPERvd25sb2FkUHJveHk+ID46Oml0ZXJhdG9yOjpW YWx1ZXMgaXQgPSBtX2Rvd25sb2Fkcy5iZWdpbigpLnZhbHVlcygpLCBlbmQgPSBtX2Rvd25sb2Fk cy5lbmQoKS52YWx1ZXMoKTsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAgICgqaXQpLT5wcm9j ZXNzRGlkQ2xvc2UoKTsKKyAgICAgICAgKCppdCktPmludmFsaWRhdGUoKTsKKyAgICB9CisKKyAg ICBtX2Rvd25sb2Fkcy5jbGVhcigpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eU1h cC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFw LmgKaW5kZXggOTZlOTI5YmU2M2EwYjI4ODExNmViZDM5YzYyYWRhNzQyODdiY2VlYi4uMTc1MGZk NTJhMjRlZmZjNzM1MmNjMDA1ODhlZjlmMTFlNWU3OTRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmgKQEAgLTQ1LDgg KzQ1LDkgQEAgcHVibGljOgogICAgIERvd25sb2FkUHJveHkqIGNyZWF0ZURvd25sb2FkUHJveHko V2ViQ29udGV4dCopOwogICAgIHZvaWQgZG93bmxvYWRGaW5pc2hlZChEb3dubG9hZFByb3h5Kik7 CiAKLSAgICAvLyBGSVhNRTogRG9uJ3QgZnVsbHkgZXhwb3NlIHRoZSBkb3dubG9hZHMgbWFwIGxp a2UgdGhpcy4KLSAgICBIYXNoTWFwPHVpbnQ2NF90LCBSZWZQdHI8RG93bmxvYWRQcm94eT4gPiYg ZG93bmxvYWRzKCkgeyByZXR1cm4gbV9kb3dubG9hZHM7IH0KKyAgICBib29sIGlzRW1wdHkoKSBj b25zdCB7IHJldHVybiBtX2Rvd25sb2Fkcy5pc0VtcHR5KCk7IH0KKworICAgIHZvaWQgcHJvY2Vz c0RpZENsb3NlKCk7CiAKIHByaXZhdGU6CiAgICAgSGFzaE1hcDx1aW50NjRfdCwgUmVmUHRyPERv d25sb2FkUHJveHk+ID4gbV9kb3dubG9hZHM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29u dGV4dC5jcHAKaW5kZXggMDA2N2E0ZTZkMmY2YWE2NDY3NGM0NDJhMzhjODQxOGQ3NDYzNzgxOC4u ZjY3NDIxN2NlMDU0MzAzYmY5MjZlMTE5Y2Q1ZDJmNzEwOTAxNjMxNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcApAQCAtNTM3LDcgKzUzNyw3IEBAIGJvb2wgV2ViQ29u dGV4dDo6c2hvdWxkVGVybWluYXRlKFdlYlByb2Nlc3NQcm94eSogcHJvY2VzcykKICAgICBpZiAo IW1fcHJvY2Vzc1Rlcm1pbmF0aW9uRW5hYmxlZCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0g ICAgaWYgKCFtX2Rvd25sb2Fkcy5kb3dubG9hZHMoKS5pc0VtcHR5KCkpCisgICAgaWYgKCFtX2Rv d25sb2Fkcy5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmICghbV9h cHBsaWNhdGlvbkNhY2hlTWFuYWdlclByb3h5LT5zaG91bGRUZXJtaW5hdGUocHJvY2VzcykpCkBA IC01OTksMTMgKzU5OSw3IEBAIHZvaWQgV2ViQ29udGV4dDo6ZGlzY29ubmVjdFByb2Nlc3MoV2Vi UHJvY2Vzc1Byb3h5KiBwcm9jZXNzKQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgLy8g SW52YWxpZGF0ZSBhbGwgb3V0c3RhbmRpbmcgZG93bmxvYWRzLgotICAgIGZvciAoSGFzaE1hcDx1 aW50NjRfdCwgUmVmUHRyPERvd25sb2FkUHJveHk+ID46Oml0ZXJhdG9yOjpWYWx1ZXMgaXQgPSBt X2Rvd25sb2Fkcy5kb3dubG9hZHMoKS5iZWdpbigpLnZhbHVlcygpLCBlbmQgPSBtX2Rvd25sb2Fk cy5kb3dubG9hZHMoKS5lbmQoKS52YWx1ZXMoKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAg ICgqaXQpLT5wcm9jZXNzRGlkQ2xvc2UoKTsKLSAgICAgICAgKCppdCktPmludmFsaWRhdGUoKTsK LSAgICB9Ci0KLSAgICBtX2Rvd25sb2Fkcy5kb3dubG9hZHMoKS5jbGVhcigpOworICAgIG1fZG93 bmxvYWRzLnByb2Nlc3NEaWRDbG9zZSgpOwogCiAgICAgbV9hcHBsaWNhdGlvbkNhY2hlTWFuYWdl clByb3h5LT5pbnZhbGlkYXRlKCk7CiAjaWYgRU5BQkxFKEJBVFRFUllfU1RBVFVTKQpAQCAtODQy LDkgKzgzNiw5IEBAIERvd25sb2FkUHJveHkqIFdlYkNvbnRleHQ6OmNyZWF0ZURvd25sb2FkUHJv eHkoKQogCiB2b2lkIFdlYkNvbnRleHQ6OmRvd25sb2FkRmluaXNoZWQoRG93bmxvYWRQcm94eSog ZG93bmxvYWRQcm94eSkKIHsKLSAgICBkb3dubG9hZFByb3h5LT5pbnZhbGlkYXRlKCk7CisgICAg bV9kb3dubG9hZHMuZG93bmxvYWRGaW5pc2hlZChkb3dubG9hZFByb3h5KTsKKwogICAgIHJlbW92 ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6RG93bmxvYWRQcm94eTo6bWVzc2FnZVJlY2VpdmVy TmFtZSgpLCBkb3dubG9hZFByb3h5LT5kb3dubG9hZElEKCkpOwotICAgIG1fZG93bmxvYWRzLmRv d25sb2FkcygpLnJlbW92ZShkb3dubG9hZFByb3h5LT5kb3dubG9hZElEKCkpOwogfQogCiAvLyBG SVhNRTogVGhpcyBpcyBub3QgdGhlIGlkZWFsIHBsYWNlIGZvciB0aGlzIGZ1bmN0aW9uLgo=