105064 2012-12-14 15:56:37 -0800 fast/css/nested-layers-with-hover.html fails on the Mac WK2 bots, and seems to be a bad test 2012-12-14 16:53:40 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin bdakin ggaren sam oldest_to_newest 791934 0 bdakin 2012-12-14 15:56:37 -0800 fast/css/nested-layers-with-hover.html is failing on the Mac WK2 bots, but it is also comparing against expected results that say, "FAIL: Timed out waiting for notifyDone to be called," so that seems bad. Generally, this test seems broken. I know how to fix it. Patch forthcoming. 791937 1 179549 bdakin 2012-12-14 16:01:49 -0800 Created attachment 179549 Patch 791971 2 179549 thorton 2012-12-14 16:51:48 -0800 Comment on attachment 179549 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179549&action=review > LayoutTests/fast/css/nested-layers-with-hover.html:39 > + window.setTimeout(testHoverState, 100); :( 791972 3 bdakin 2012-12-14 16:53:40 -0800 Thank yoooou. http://trac.webkit.org/changeset/137791 179549 2012-12-14 16:01:49 -0800 2012-12-14 16:51:48 -0800 Patch for-review.txt text/plain 5260 bdakin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzNzc4NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEyLTEyLTE0ICBCZXRoIERha2luICA8YmRh a2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA1MDY0CisgICAgICAgIGZhc3QvY3NzL25lc3RlZC1sYXllcnMtd2l0aC1ob3Zl ci5odG1sIGZhaWxzIG9uIHRoZSBNYWMgV0syIGJvdHMsIGFuZCBzZWVtcyB0byBiZSAKKyAgICAg ICAgYSBiYWQgdGVzdAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZXJlIHdlcmUgYSBudW1iZXIgb2YgcHJvYmxlbXMgd2l0aCB0aGlzIHRlc3QsIGFu ZCB0aGlzIHBhdGNoIGF0dGVtcHRzIHRvIGZpeCAKKyAgICAgICAgdGhlbSBhbGwuIFRoZSBwcm9i bGVtcyB3ZXJlOgorICAgICAgICAtVGhpcyB0ZXN0IHdhcyBmYWlsaW5nIG9uIHRoZSBXSzIgYm90 cy4KKyAgICAgICAgLUJ1dCBpdCB3YXMgY29tcGFyaW5nIGFnYWluc3QgZXhwZWN0ZWQgcmVzdWx0 cyB0aGF0IGV4cGVjdGVkIHRvIGZhaWwsIHNvIHRoYXQncyAKKyAgICAgICAgYmFkIQorICAgICAg ICAtSW4gdGhlIGNyb3NzLXBsYXRmb3JtIGRpcmVjdG9yeSB0aGVyZSB3ZXJlIGV4cGVjdGVkIHJl c3VsdHMgY2hlY2tlZCBpbiB0aGF0IGxvb2sgCisgICAgICAgIGZvciBhIHJlbmRlciB0cmVlIGR1 bXAsIGJ1dCB0aG9zZSByZXN1bHRzIGhhdmVuJ3QgbWFkZSBzZW5zZSBmb3IgYSB3aGlsZSBzaW5j ZSAKKyAgICAgICAgdGhhdCB0ZXN0IHdhcyBjb252ZXJ0ZWQgdG8gZHVtcEFzVGV4dCgpIG1vbnRo cyBhZ28uCisKKyAgICAgICAgVGhpcyBwYXRjaCB1cGRhdGVzIHRoZSB0ZXN0IHNvIHRoYXQgaXQg d2lsbCBhY3R1YWxseSB3b3JrLiBUbyBkbyB0aGF0LCB3ZSBuZWVkIHRvIAorICAgICAgICBtYWtl IHN1cmUgbGF5b3V0IGlzIHVwIHRvIGRhdGUgYW5kIGFsc28gdXNlIHdpbmRvdy5zZXRUaW1lb3V0 KCkgdG8gcnVuIHRoZSAKKyAgICAgICAgZnVuY3Rpb24gdG8gYXNzZXNzIG91ciBob3ZlciBzdGF0 ZSByYXRoZXIgdGhhbiByZWx5aW5nIG9uIG9ubW91c2Vtb3ZlLgorICAgICAgICAqIGZhc3QvY3Nz L25lc3RlZC1sYXllcnMtd2l0aC1ob3Zlci1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9j c3MvbmVzdGVkLWxheWVycy13aXRoLWhvdmVyLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFj L2Zhc3QvY3NzL25lc3RlZC1sYXllcnMtd2l0aC1ob3Zlci1leHBlY3RlZC5wbmc6IFJlbW92ZWQu CisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvY3NzL25lc3RlZC1sYXllcnMtd2l0aC1ob3Zl ci1leHBlY3RlZC50eHQ6IFJlbW92ZWQuCisKIDIwMTItMTItMTQgIFl1a2kgU2VraWd1Y2hpICA8 eXVraS5zZWtpZ3VjaGlAYWNjZXNzLWNvbXBhbnkuY29tPgogCiAgICAgICAgIEVtcGhhc2lzIG1h cmsgaXMgcHJpbnRlZCBhZnRlciBpbmxpbmUtYmxvY2sgd2l0aCBqdXN0aWZ5CkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2Nzcy9uZXN0ZWQtbGF5ZXJzLXdpdGgtaG92ZXItZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL25lc3RlZC1sYXllcnMtd2l0aC1ob3Zl ci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEzNzc2MCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3Nz L25lc3RlZC1sYXllcnMtd2l0aC1ob3Zlci1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAg LTEsMTggKzEsMiBAQAotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCi0gIFJlbmRlclZpZXcg YXQgKDAsMCkgc2l6ZSA4MDB4NjAwCi1sYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKLSAgUmVu ZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAotICAgIFJlbmRlckJvZHkge0JP RFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAotICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAs MzYpIHNpemUgNzg0eDE4Ci0gICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXpl IDIyMXgxOQotICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDIyMTogIlBBU1NFRDog VGhlIGhvdmVyIGVmZmVjdCB3b3JrcyEiCi1sYXllciBhdCAoOCw4KSBzaXplIDc4NHgzNiBzY3Jv bGxIZWlnaHQgMzcKLSAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6ZSA3ODR4MzYKLSAg ICBSZW5kZXJUYWJsZSBhdCAoMCwwKSBzaXplIDc4NHgzNgotICAgICAgUmVuZGVyVGFibGVTZWN0 aW9uIChhbm9ueW1vdXMpIGF0ICgwLDApIHNpemUgNzg0eDM2Ci1sYXllciBhdCAoOCw4KSBzaXpl IDc4NHgzNgotICBSZW5kZXJUYWJsZVJvdyB7RElWfSBhdCAoMCwwKSBzaXplIDc4NHgzNiBbYmdj b2xvcj0jMDAwMEZGXQotICAgIFJlbmRlclRhYmxlQ2VsbCAoYW5vbnltb3VzKSBhdCAoMCwwKSBz aXplIDc4NHgzNiBbcj0wIGM9MCBycz0xIGNzPTFdCi0gICAgICBSZW5kZXJUZXh0IHsjdGV4dH0g YXQgKDAsMCkgc2l6ZSA3NzR4MzcKLSAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNzc0 OiAiVG8gdGVzdCB0aGlzIG1hbnVhbGx5LCBmaXJzdCBtYWtlIHN1cmUgeW91IGNhbiBzZWUgdGhp cyB0ZXh0IGF0IGFsbCwgYW5kIHRoZW4gaG92ZXIgb3ZlciBpdCBhbmQgbWFrZSBzdXJlIHRoZSBi YWNrZ3JvdW5kIHR1cm5zIgotICAgICAgICB0ZXh0IHJ1biBhdCAoMCwxOCkgd2lkdGggMzE6ICJi bHVlLiIKK1RvIHRlc3QgdGhpcyBtYW51YWxseSwgZmlyc3QgbWFrZSBzdXJlIHlvdSBjYW4gc2Vl IHRoaXMgdGV4dCBhdCBhbGwsIGFuZCB0aGVuIGhvdmVyIG92ZXIgaXQgYW5kIG1ha2Ugc3VyZSB0 aGUgYmFja2dyb3VuZCB0dXJucyBibHVlLgorUEFTU0VEOiBUaGUgaG92ZXIgZWZmZWN0IHdvcmtz IQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvbmVzdGVkLWxheWVycy13aXRoLWhvdmVyLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvbmVzdGVkLWxheWVycy13aXRo LWhvdmVyLmh0bWwJKHJldmlzaW9uIDEzNzc2MCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL25l c3RlZC1sYXllcnMtd2l0aC1ob3Zlci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zMywxNiArMzMs MTcgQEAKICAgICAgICAgICAgIGZ1bmN0aW9uIHJ1blRlc3QoKSB7CiAgICAgICAgICAgICAgICAg aWYgKCF3aW5kb3cudGVzdFJ1bm5lcikgCiAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgICAgICAgICBkb2N1bWVudC5ib2R5Lm9mZnNldFRvcDsgLy8gRm9yY2UgbGF5b3V0Lgog ICAgICAgICAgICAgICAgIHZhciB0YXJnZXRFbGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3RhYmxlLXJvdycpOwotICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHRh cmdldEVsZW0ub2Zmc2V0TGVmdCArIHRhcmdldEVsZW0ub2Zmc2V0V2lkdGggLyAyLCAKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0YXJnZXRFbGVtLm9mZnNldFRvcCAr IHRhcmdldEVsZW0ub2Zmc2V0SGVpZ2h0IC8gMik7CisgICAgICAgICAgICAgICAgZXZlbnRTZW5k ZXIubW91c2VNb3ZlVG8oNTAsIDE3KTsKKyAgICAgICAgICAgICAgICB3aW5kb3cuc2V0VGltZW91 dCh0ZXN0SG92ZXJTdGF0ZSwgMTAwKTsKICAgICAgICAgICAgIH0KICAgICAgICAgPC9zY3JpcHQ+ CiA8L2hlYWQ+CiAKIDxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KICAgICA8ZGl2IHN0eWxlPSJv dmVyZmxvdzpoaWRkZW4iPgotICAgICAgICA8ZGl2IGlkPSJ0YWJsZS1yb3ciIG9ubW91c2Vtb3Zl PSJ0ZXN0SG92ZXJTdGF0ZSgpIiBzdHlsZT0ib3ZlcmZsb3c6aGlkZGVuOyBkaXNwbGF5OnRhYmxl LXJvdyI+VG8gdGVzdCB0aGlzIG1hbnVhbGx5LCBmaXJzdCBtYWtlIHN1cmUgeW91IGNhbiBzZWUg dGhpcyB0ZXh0IGF0IGFsbCwgYW5kIHRoZW4gaG92ZXIgb3ZlciBpdCBhbmQgbWFrZSBzdXJlIHRo ZSBiYWNrZ3JvdW5kIHR1cm5zIGJsdWUuPC9kaXY+CisgICAgICAgIDxkaXYgaWQ9InRhYmxlLXJv dyIgc3R5bGU9Im92ZXJmbG93OmhpZGRlbjsgZGlzcGxheTp0YWJsZS1yb3ciPlRvIHRlc3QgdGhp cyBtYW51YWxseSwgZmlyc3QgbWFrZSBzdXJlIHlvdSBjYW4gc2VlIHRoaXMgdGV4dCBhdCBhbGws IGFuZCB0aGVuIGhvdmVyIG92ZXIgaXQgYW5kIG1ha2Ugc3VyZSB0aGUgYmFja2dyb3VuZCB0dXJu cyBibHVlLjwvZGl2PgogICAgIDwvZGl2PgogICAgIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2Pgog CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9jc3MvbmVzdGVkLWxheWVycy13 aXRoLWhvdmVyLWV4cGVjdGVkLnBuZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1h cmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWltZS10eXBlID0gaW1hZ2UvcG5nCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9jc3MvbmVzdGVkLWxheWVycy13aXRoLWhvdmVy LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFz dC9jc3MvbmVzdGVkLWxheWVycy13aXRoLWhvdmVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTM3 NzYwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvY3NzL25lc3RlZC1sYXllcnMt d2l0aC1ob3Zlci1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMCwwIEBACi1G QUlMOiBUaW1lZCBvdXQgd2FpdGluZyBmb3Igbm90aWZ5RG9uZSB0byBiZSBjYWxsZWQKLVRvIHRl c3QgdGhpcyBtYW51YWxseSwgZmlyc3QgbWFrZSBzdXJlIHlvdSBjYW4gc2VlIHRoaXMgdGV4dCBh dCBhbGwsIGFuZCB0aGVuIGhvdmVyIG92ZXIgaXQgYW5kIG1ha2Ugc3VyZSB0aGUgYmFja2dyb3Vu ZCB0dXJucyBibHVlLgotCg==