105060 2012-12-14 15:23:00 -0800 Add some unit testing for WTF::clampTo* functions 2012-12-17 22:13:01 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix benjamin darin eae noel.gordon webkit.review.bot oldest_to_newest 791902 0 jchaffraix 2012-12-14 15:23:00 -0800 While investigating bug 83848, I discovered that we don't cover the clampTo functions which are used for the saturated arithmetic logic. We do have some indirect testing as we have some saturated arithmetic layout tests (and some unit testing after 104955) but we may as well cover the functions themselves, at least for some basic coverage. 791929 1 179548 jchaffraix 2012-12-14 15:47:22 -0800 Created attachment 179548 Proposed testing, feedbacks seeked on whether more testing is possible accurately. 791933 2 179548 eae 2012-12-14 15:53:28 -0800 Comment on attachment 179548 Proposed testing, feedbacks seeked on whether more testing is possible accurately. View in context: https://bugs.webkit.org/attachment.cgi?id=179548&action=review > Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:53 > +TEST(WTF, clampToIntLong) This test is identical to the long long one. Using long long should work on all platforms while long won't work work on 32 bit platforms or win x64 as maxInt + 1 will overflow a long on those platforms. > Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:157 > + unsigned long overflowUnsigned = maxUnsigned + 1; This will overflow on certain platforms (where sizeof int == sizeof long) 791948 3 179548 buildbot 2012-12-14 16:18:31 -0800 Comment on attachment 179548 Proposed testing, feedbacks seeked on whether more testing is possible accurately. Attachment 179548 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15315857 791997 4 179548 jchaffraix 2012-12-14 17:47:25 -0800 Comment on attachment 179548 Proposed testing, feedbacks seeked on whether more testing is possible accurately. View in context: https://bugs.webkit.org/attachment.cgi?id=179548&action=review >> Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:53 >> +TEST(WTF, clampToIntLong) > > This test is identical to the long long one. Using long long should work on all platforms while long won't work work on 32 bit platforms or win x64 as maxInt + 1 will overflow a long on those platforms. Great catch. This test only makes sense if sizeof(long) != sizeof(int) or else, we don't test anything and as you point out, we would overflow the long below. >> Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:157 >> + unsigned long overflowUnsigned = maxUnsigned + 1; > > This will overflow on certain platforms (where sizeof int == sizeof long) Same comment here. 792024 5 179574 jchaffraix 2012-12-14 18:58:00 -0800 Created attachment 179574 Updated test for an EWS run. 792991 6 179574 webkit.review.bot 2012-12-17 13:38:35 -0800 Comment on attachment 179574 Updated test for an EWS run. Clearing flags on attachment: 179574 Committed r137936: <http://trac.webkit.org/changeset/137936> 792992 7 webkit.review.bot 2012-12-17 13:38:38 -0800 All reviewed patches have been landed. Closing bug. 793292 8 noel.gordon 2012-12-17 20:04:46 -0800 Broke mac chrome release run-api-tests tests http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/30528 Tests that failed: WTF.clampToUnsigned Note: Google Test filter = WTF.clampToUnsigned [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WTF [ RUN ] WTF.clampToUnsigned /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Tools/TestWebKitAPI/TestWebKitAPI.gyp/../Tests/WTF/MathExtras.cpp:153: Failure Value of: maxUnsigned Actual: 4294967295 Expected: clampTo<unsigned>(overflowUnsigned) Which is: 0 [ FAILED ] WTF.clampToUnsigned (0 ms) [----------] 1 test from WTF (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] WTF.clampToUnsigned 1 FAILED TEST 793360 9 jchaffraix 2012-12-17 22:13:01 -0800 Filed bug 105253 about the failing tests (because there are several, not just one). 179548 2012-12-14 15:47:22 -0800 2012-12-14 18:57:58 -0800 Proposed testing, feedbacks seeked on whether more testing is possible accurately. bug-105060-20121214154442.patch text/plain 5276 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGY0YzQ3NDRiNGM4YmFiMDYxYWVjNWI2OTI3OGMwMzJk ODMzMjk0Ny4uNzI5NDI1MzgwZTkwOGM4OGY5MDY0ZWI0NGE4MjJkZDE1NmZjNmZkZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEyLTE0ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3Jn PgorCisgICAgICAgIEFkZCBzb21lIHVuaXQgdGVzdGluZyBmb3IgV1RGOjpjbGFtcFRvKiBmdW5j dGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NTA2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBuZXcgdGVzdHMgYXJlIHRhcmdldGVkIGF0IGNsYW1waW5nIHRvIGludCAvIHVuc2lnbmVkIGFu ZCBmbG9hdCBhcyB0aG9zZSBhcmUKKyAgICAgICAgdGhlIG9uZSBleHBsaWNpdGVseSBleHBvc2Vk IHRocm91Z2ggbW9yZSBkZWRpY2F0ZWQgZnVuY3Rpb25zIChsaWtlIGNsYW1wVG9JbnRlZ2VyLAor ICAgICAgICBjbGFtcFRvUG9zaXRpdmVJbnRlZ2VyIGFuZCBjbGFtcFRvRmxvYXQpLgorCisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHA6CisKIDIwMTItMTIt MTMgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIExvYWRl cl91bml0dGVzdHMgc2hvdWxkIHJlc2V0IHN0YXRlIGJldHdlZW4gcnVucy4KZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhFeHRyYXMuY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHAKaW5kZXggMDZlNDQyY2U3MmRlNzcw OTgyY2M2ZTg0YTAwODUyMjYxNWMwZmNlNy4uYzYyN2ZmOTBmOTRkODNlMmRmMmZkMGVkNzJlMDU0 ZWZhODQ2Y2FjMCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0 aEV4dHJhcy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJh cy5jcHAKQEAgLTUwLDQgKzUwLDEzMSBAQCBURVNUKFdURiwgTHJpbnQpCiAgICAgfQogfQogCitU RVNUKFdURiwgY2xhbXBUb0ludExvbmcpCit7CisgICAgbG9uZyBsb25nIG1heEludCA9IHN0ZDo6 bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4KCk7CisgICAgbG9uZyBsb25nIG1pbkludCA9IHN0ZDo6 bnVtZXJpY19saW1pdHM8aW50Pjo6bWluKCk7CisgICAgbG9uZyBsb25nIG92ZXJmbG93SW50ID0g bWF4SW50ICsgMTsKKyAgICBsb25nIGxvbmcgdW5kZXJmbG93SW50ID0gbWluSW50IC0gMTsKKwor ICAgIEVYUEVDVF9HVChvdmVyZmxvd0ludCwgbWF4SW50KTsKKyAgICBFWFBFQ1RfTFQodW5kZXJm bG93SW50LCBtaW5JbnQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50PihtYXhJbnQpLCBt YXhJbnQpOworICAgIEVYUEVDVF9FUShjbGFtcFRvPGludD4obWluSW50KSwgbWluSW50KTsKKwor ICAgIEVYUEVDVF9FUShjbGFtcFRvPGludD4ob3ZlcmZsb3dJbnQpLCBtYXhJbnQpOworICAgIEVY UEVDVF9FUShjbGFtcFRvPGludD4odW5kZXJmbG93SW50KSwgbWluSW50KTsKK30KKworVEVTVChX VEYsIGNsYW1wVG9JbnRMb25nTG9uZykKK3sKKyAgICBsb25nIGxvbmcgbWF4SW50ID0gc3RkOjpu dW1lcmljX2xpbWl0czxpbnQ+OjptYXgoKTsKKyAgICBsb25nIGxvbmcgbWluSW50ID0gc3RkOjpu dW1lcmljX2xpbWl0czxpbnQ+OjptaW4oKTsKKyAgICBsb25nIGxvbmcgb3ZlcmZsb3dJbnQgPSBt YXhJbnQgKyAxOworICAgIGxvbmcgbG9uZyB1bmRlcmZsb3dJbnQgPSBtaW5JbnQgLSAxOworCisg ICAgRVhQRUNUX0dUKG92ZXJmbG93SW50LCBtYXhJbnQpOworICAgIEVYUEVDVF9MVCh1bmRlcmZs b3dJbnQsIG1pbkludCk7CisKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQ+KG1heEludCksIG1h eEludCk7CisgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50PihtaW5JbnQpLCBtaW5JbnQpOworCisg ICAgRVhQRUNUX0VRKGNsYW1wVG88aW50PihvdmVyZmxvd0ludCksIG1heEludCk7CisgICAgRVhQ RUNUX0VRKGNsYW1wVG88aW50Pih1bmRlcmZsb3dJbnQpLCBtaW5JbnQpOworfQorCitURVNUKFdU RiwgY2xhbXBUb0ludGVnZXJGbG9hdCkKK3sKKyAgICAvLyBUaGlzIHRlc3QgaXMgaW5hY2N1cmF0 ZSBhcyBmbG9hdHMgd2lsbCByb3VuZCB0aGUgbWluIC8gbWF4IGludGVnZXIKKyAgICAvLyBkdWUg dG8gdGhlIG5hcnJvdyBtYW50aXNzYS4gSG93ZXZlciBpdCB3aWxsIHByb3Blcmx5IGNoZWNrcyB3 aXRoaW4KKyAgICAvLyAoY2xvc2UgdG8gdGhlIGV4dHJlbWUpIGFuZCBvdXRzaWRlIHRoZSBpbnRl Z2VyIHJhbmdlLgorICAgIGZsb2F0IG1heEludCA9IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6 bWF4KCk7CisgICAgZmxvYXQgbWluSW50ID0gc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptaW4o KTsKKyAgICBmbG9hdCBvdmVyZmxvd0ludCA9IG1heEludCAqIDEuMTsKKyAgICBmbG9hdCB1bmRl cmZsb3dJbnQgPSBtaW5JbnQgKiAxLjE7CisKKyAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dJbnQsIG1h eEludCk7CisgICAgRVhQRUNUX0xUKHVuZGVyZmxvd0ludCwgbWluSW50KTsKKworICAgIEVYUEVD VF9FUShjbGFtcFRvSW50ZWdlcihtYXhJbnQpLCBtYXhJbnQpOworICAgIEVYUEVDVF9FUShjbGFt cFRvSW50ZWdlcihtaW5JbnQpLCBtaW5JbnQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG9JbnRl Z2VyKG92ZXJmbG93SW50KSwgbWF4SW50KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0ludGVnZXIo dW5kZXJmbG93SW50KSwgbWluSW50KTsKK30KKworVEVTVChXVEYsIGNsYW1wVG9JbnRlZ2VyRG91 YmxlKQoreworICAgIGRvdWJsZSBtYXhJbnQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1h eCgpOworICAgIGRvdWJsZSBtaW5JbnQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1pbigp OworICAgIGRvdWJsZSBvdmVyZmxvd0ludCA9IG1heEludCArIDE7CisgICAgZG91YmxlIHVuZGVy Zmxvd0ludCA9IG1pbkludCAtIDE7CisKKyAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dJbnQsIG1heElu dCk7CisgICAgRVhQRUNUX0xUKHVuZGVyZmxvd0ludCwgbWluSW50KTsKKworICAgIEVYUEVDVF9F UShjbGFtcFRvSW50ZWdlcihtYXhJbnQpLCBtYXhJbnQpOworICAgIEVYUEVDVF9FUShjbGFtcFRv SW50ZWdlcihtaW5JbnQpLCBtaW5JbnQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG9JbnRlZ2Vy KG92ZXJmbG93SW50KSwgbWF4SW50KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0ludGVnZXIodW5k ZXJmbG93SW50KSwgbWluSW50KTsKK30KKworVEVTVChXVEYsIGNsYW1wVG9GbG9hdCkKK3sKKyAg ICBkb3VibGUgbWF4RmxvYXQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGZsb2F0Pjo6bWF4KCk7Cisg ICAgZG91YmxlIG1pbkZsb2F0ID0gLW1heEZsb2F0OworICAgIGRvdWJsZSBvdmVyZmxvd0Zsb2F0 ID0gbWF4RmxvYXQgKiAxLjE7CisgICAgZG91YmxlIHVuZGVyZmxvd0Zsb2F0ID0gbWluRmxvYXQg KiAxLjE7CisKKyAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dGbG9hdCwgbWF4RmxvYXQpOworICAgIEVY UEVDVF9MVCh1bmRlcmZsb3dGbG9hdCwgbWluRmxvYXQpOworCisgICAgRVhQRUNUX0VRKGNsYW1w VG9GbG9hdChtYXhGbG9hdCksIG1heEZsb2F0KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0Zsb2F0 KG1pbkZsb2F0KSwgbWluRmxvYXQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG9GbG9hdChvdmVy Zmxvd0Zsb2F0KSwgbWF4RmxvYXQpOworICAgIEVYUEVDVF9FUShjbGFtcFRvRmxvYXQodW5kZXJm bG93RmxvYXQpLCBtaW5GbG9hdCk7CisKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0Zsb2F0KHN0ZDo6 bnVtZXJpY19saW1pdHM8ZmxvYXQ+OjppbmZpbml0eSgpKSwgbWF4RmxvYXQpOworICAgIEVYUEVD VF9FUShjbGFtcFRvRmxvYXQoLXN0ZDo6bnVtZXJpY19saW1pdHM8ZmxvYXQ+OjppbmZpbml0eSgp KSwgbWluRmxvYXQpOworfQorCitURVNUKFdURiwgY2xhbXBUb1Vuc2lnbmVkKQoreworICAgIHVu c2lnbmVkIGxvbmcgbWF4VW5zaWduZWQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6 bWF4KCk7CisgICAgdW5zaWduZWQgbG9uZyBvdmVyZmxvd1Vuc2lnbmVkID0gbWF4VW5zaWduZWQg KyAxOworICAgIEVYUEVDVF9FUShjbGFtcFRvPHVuc2lnbmVkPihtYXhVbnNpZ25lZCksIG1heFVu c2lnbmVkKTsKKworICAgIEVYUEVDVF9FUShjbGFtcFRvPHVuc2lnbmVkPihvdmVyZmxvd1Vuc2ln bmVkKSwgbWF4VW5zaWduZWQpOworICAgIEVYUEVDVF9FUShjbGFtcFRvPHVuc2lnbmVkPigtMSks IDApOworfQorCitURVNUKFdURiwgY2xhbXBUb1Vuc2lnbmVkTG9uZykKK3sKKyAgICB1bnNpZ25l ZCBsb25nIG1heFVuc2lnbmVkID0gc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgp OworICAgIHVuc2lnbmVkIGxvbmcgb3ZlcmZsb3dVbnNpZ25lZCA9IG1heFVuc2lnbmVkICsgMTsK KworICAgIEVYUEVDVF9HVChvdmVyZmxvd1Vuc2lnbmVkLCBtYXhVbnNpZ25lZCk7CisKKyAgICBF WFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4obWF4VW5zaWduZWQpLCBtYXhVbnNpZ25lZCk7CisK KyAgICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4ob3ZlcmZsb3dVbnNpZ25lZCksIG1heFVu c2lnbmVkKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4oLTEpLCAwKTsKK30KKwor VEVTVChXVEYsIGNsYW1wVG9VbnNpZ25lZExvbmdMb25nKQoreworICAgIHVuc2lnbmVkIGxvbmcg bG9uZyBtYXhVbnNpZ25lZCA9IHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWduZWQ+OjptYXgoKTsK KyAgICB1bnNpZ25lZCBsb25nIGxvbmcgb3ZlcmZsb3dVbnNpZ25lZCA9IG1heFVuc2lnbmVkICsg MTsKKworICAgIEVYUEVDVF9HVChvdmVyZmxvd1Vuc2lnbmVkLCBtYXhVbnNpZ25lZCk7CisKKyAg ICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4obWF4VW5zaWduZWQpLCBtYXhVbnNpZ25lZCk7 CisKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4ob3ZlcmZsb3dVbnNpZ25lZCksIG1h eFVuc2lnbmVkKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4oLTEpLCAwKTsKK30K KwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQo= 179574 2012-12-14 18:58:00 -0800 2012-12-17 13:38:34 -0800 Updated test for an EWS run. bug-105060-20121214185519.patch text/plain 5404 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NzkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2JlODdiMGQ0MWZkMjEzNjZmOTQ3NzlkYTNhYWZkMDQ0 OTdhYmM3OC4uNDhhZjIwZmYyZmFjMTQ0MDY1ZWVmZWE0ZTdhOTc2MTkxYWVlMzIwZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEyLTE0ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3Jn PgorCisgICAgICAgIEFkZCBzb21lIHVuaXQgdGVzdGluZyBmb3IgV1RGOjpjbGFtcFRvKiBmdW5j dGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NTA2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBuZXcgdGVzdHMgYXJlIHRhcmdldGVkIGF0IGNsYW1waW5nIHRvIGludCAvIHVuc2lnbmVkIGFu ZCBmbG9hdCBhcyB0aG9zZSBhcmUKKyAgICAgICAgdGhlIG9uZSBleHBsaWNpdGVseSBleHBvc2Vk IHRocm91Z2ggbW9yZSBkZWRpY2F0ZWQgZnVuY3Rpb25zIChsaWtlIGNsYW1wVG9JbnRlZ2VyLAor ICAgICAgICBjbGFtcFRvUG9zaXRpdmVJbnRlZ2VyIGFuZCBjbGFtcFRvRmxvYXQpLgorCisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHA6CisKIDIwMTItMTIt MTQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgd2Via2l0 cHk6IG1ha2UgcG9ydF9uYW1lIGEgcmVxdWlyZWQgcGFyYW1ldGVyIHRvIHRoZSBub24tdGVzdCBw b3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJh cy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NYXRoRXh0cmFzLmNwcAppbmRl eCAwNmU0NDJjZTcyZGU3NzA5ODJjYzZlODRhMDA4NTIyNjE1YzBmY2U3Li4yNTRiNWVmMzFiZjlk MzM0Y2EzMDJhNGI5OTk3NDA4Yjc2MmRhYzExIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dURi9NYXRoRXh0cmFzLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9NYXRoRXh0cmFzLmNwcApAQCAtNTAsNCArNTAsMTM3IEBAIFRFU1QoV1RGLCBMcmlu dCkKICAgICB9CiB9CiAKK1RFU1QoV1RGLCBjbGFtcFRvSW50TG9uZykKK3sKKyAgICBpZiAoc2l6 ZW9mKGxvbmcpID09IHNpemVvZihpbnQpKQorICAgICAgICByZXR1cm47CisKKyAgICBsb25nIG1h eEludCA9IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4KCk7CisgICAgbG9uZyBtaW5JbnQg PSBzdGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1pbigpOworICAgIGxvbmcgb3ZlcmZsb3dJbnQg PSBtYXhJbnQgKyAxOworICAgIGxvbmcgdW5kZXJmbG93SW50ID0gbWluSW50IC0gMTsKKworICAg IEVYUEVDVF9HVChvdmVyZmxvd0ludCwgbWF4SW50KTsKKyAgICBFWFBFQ1RfTFQodW5kZXJmbG93 SW50LCBtaW5JbnQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50PihtYXhJbnQpLCBtYXhJ bnQpOworICAgIEVYUEVDVF9FUShjbGFtcFRvPGludD4obWluSW50KSwgbWluSW50KTsKKworICAg IEVYUEVDVF9FUShjbGFtcFRvPGludD4ob3ZlcmZsb3dJbnQpLCBtYXhJbnQpOworICAgIEVYUEVD VF9FUShjbGFtcFRvPGludD4odW5kZXJmbG93SW50KSwgbWluSW50KTsKK30KKworVEVTVChXVEYs IGNsYW1wVG9JbnRMb25nTG9uZykKK3sKKyAgICBsb25nIGxvbmcgbWF4SW50ID0gc3RkOjpudW1l cmljX2xpbWl0czxpbnQ+OjptYXgoKTsKKyAgICBsb25nIGxvbmcgbWluSW50ID0gc3RkOjpudW1l cmljX2xpbWl0czxpbnQ+OjptaW4oKTsKKyAgICBsb25nIGxvbmcgb3ZlcmZsb3dJbnQgPSBtYXhJ bnQgKyAxOworICAgIGxvbmcgbG9uZyB1bmRlcmZsb3dJbnQgPSBtaW5JbnQgLSAxOworCisgICAg RVhQRUNUX0dUKG92ZXJmbG93SW50LCBtYXhJbnQpOworICAgIEVYUEVDVF9MVCh1bmRlcmZsb3dJ bnQsIG1pbkludCk7CisKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQ+KG1heEludCksIG1heElu dCk7CisgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50PihtaW5JbnQpLCBtaW5JbnQpOworCisgICAg RVhQRUNUX0VRKGNsYW1wVG88aW50PihvdmVyZmxvd0ludCksIG1heEludCk7CisgICAgRVhQRUNU X0VRKGNsYW1wVG88aW50Pih1bmRlcmZsb3dJbnQpLCBtaW5JbnQpOworfQorCitURVNUKFdURiwg Y2xhbXBUb0ludGVnZXJGbG9hdCkKK3sKKyAgICAvLyBUaGlzIHRlc3QgaXMgaW5hY2N1cmF0ZSBh cyBmbG9hdHMgd2lsbCByb3VuZCB0aGUgbWluIC8gbWF4IGludGVnZXIKKyAgICAvLyBkdWUgdG8g dGhlIG5hcnJvdyBtYW50aXNzYS4gSG93ZXZlciBpdCB3aWxsIHByb3Blcmx5IGNoZWNrcyB3aXRo aW4KKyAgICAvLyAoY2xvc2UgdG8gdGhlIGV4dHJlbWUpIGFuZCBvdXRzaWRlIHRoZSBpbnRlZ2Vy IHJhbmdlLgorICAgIGZsb2F0IG1heEludCA9IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4 KCk7CisgICAgZmxvYXQgbWluSW50ID0gc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptaW4oKTsK KyAgICBmbG9hdCBvdmVyZmxvd0ludCA9IG1heEludCAqIDEuMTsKKyAgICBmbG9hdCB1bmRlcmZs b3dJbnQgPSBtaW5JbnQgKiAxLjE7CisKKyAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dJbnQsIG1heElu dCk7CisgICAgRVhQRUNUX0xUKHVuZGVyZmxvd0ludCwgbWluSW50KTsKKworICAgIEVYUEVDVF9F UShjbGFtcFRvSW50ZWdlcihtYXhJbnQpLCBtYXhJbnQpOworICAgIEVYUEVDVF9FUShjbGFtcFRv SW50ZWdlcihtaW5JbnQpLCBtaW5JbnQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG9JbnRlZ2Vy KG92ZXJmbG93SW50KSwgbWF4SW50KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0ludGVnZXIodW5k ZXJmbG93SW50KSwgbWluSW50KTsKK30KKworVEVTVChXVEYsIGNsYW1wVG9JbnRlZ2VyRG91Ymxl KQoreworICAgIGRvdWJsZSBtYXhJbnQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1heCgp OworICAgIGRvdWJsZSBtaW5JbnQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1pbigpOwor ICAgIGRvdWJsZSBvdmVyZmxvd0ludCA9IG1heEludCArIDE7CisgICAgZG91YmxlIHVuZGVyZmxv d0ludCA9IG1pbkludCAtIDE7CisKKyAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dJbnQsIG1heEludCk7 CisgICAgRVhQRUNUX0xUKHVuZGVyZmxvd0ludCwgbWluSW50KTsKKworICAgIEVYUEVDVF9FUShj bGFtcFRvSW50ZWdlcihtYXhJbnQpLCBtYXhJbnQpOworICAgIEVYUEVDVF9FUShjbGFtcFRvSW50 ZWdlcihtaW5JbnQpLCBtaW5JbnQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG9JbnRlZ2VyKG92 ZXJmbG93SW50KSwgbWF4SW50KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0ludGVnZXIodW5kZXJm bG93SW50KSwgbWluSW50KTsKK30KKworVEVTVChXVEYsIGNsYW1wVG9GbG9hdCkKK3sKKyAgICBk b3VibGUgbWF4RmxvYXQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGZsb2F0Pjo6bWF4KCk7CisgICAg ZG91YmxlIG1pbkZsb2F0ID0gLW1heEZsb2F0OworICAgIGRvdWJsZSBvdmVyZmxvd0Zsb2F0ID0g bWF4RmxvYXQgKiAxLjE7CisgICAgZG91YmxlIHVuZGVyZmxvd0Zsb2F0ID0gbWluRmxvYXQgKiAx LjE7CisKKyAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dGbG9hdCwgbWF4RmxvYXQpOworICAgIEVYUEVD VF9MVCh1bmRlcmZsb3dGbG9hdCwgbWluRmxvYXQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG9G bG9hdChtYXhGbG9hdCksIG1heEZsb2F0KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0Zsb2F0KG1p bkZsb2F0KSwgbWluRmxvYXQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG9GbG9hdChvdmVyZmxv d0Zsb2F0KSwgbWF4RmxvYXQpOworICAgIEVYUEVDVF9FUShjbGFtcFRvRmxvYXQodW5kZXJmbG93 RmxvYXQpLCBtaW5GbG9hdCk7CisKKyAgICBFWFBFQ1RfRVEoY2xhbXBUb0Zsb2F0KHN0ZDo6bnVt ZXJpY19saW1pdHM8ZmxvYXQ+OjppbmZpbml0eSgpKSwgbWF4RmxvYXQpOworICAgIEVYUEVDVF9F UShjbGFtcFRvRmxvYXQoLXN0ZDo6bnVtZXJpY19saW1pdHM8ZmxvYXQ+OjppbmZpbml0eSgpKSwg bWluRmxvYXQpOworfQorCitURVNUKFdURiwgY2xhbXBUb1Vuc2lnbmVkKQoreworICAgIHVuc2ln bmVkIGxvbmcgbWF4VW5zaWduZWQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4 KCk7CisgICAgdW5zaWduZWQgbG9uZyBvdmVyZmxvd1Vuc2lnbmVkID0gbWF4VW5zaWduZWQgKyAx OworICAgIEVYUEVDVF9FUShjbGFtcFRvPHVuc2lnbmVkPihtYXhVbnNpZ25lZCksIG1heFVuc2ln bmVkKTsKKworICAgIEVYUEVDVF9FUShjbGFtcFRvPHVuc2lnbmVkPihvdmVyZmxvd1Vuc2lnbmVk KSwgbWF4VW5zaWduZWQpOworICAgIEVYUEVDVF9FUShjbGFtcFRvPHVuc2lnbmVkPigtMSksIDB1 KTsKK30KKworVEVTVChXVEYsIGNsYW1wVG9VbnNpZ25lZExvbmcpCit7CisgICAgaWYgKHNpemVv Zih1bnNpZ25lZCBsb25nKSA9PSBzaXplb2YodW5zaWduZWQpKQorICAgICAgICByZXR1cm47CisK KyAgICB1bnNpZ25lZCBsb25nIG1heFVuc2lnbmVkID0gc3RkOjpudW1lcmljX2xpbWl0czx1bnNp Z25lZD46Om1heCgpOworICAgIHVuc2lnbmVkIGxvbmcgb3ZlcmZsb3dVbnNpZ25lZCA9IG1heFVu c2lnbmVkICsgMTsKKworICAgIEVYUEVDVF9HVChvdmVyZmxvd1Vuc2lnbmVkLCBtYXhVbnNpZ25l ZCk7CisKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4obWF4VW5zaWduZWQpLCBtYXhV bnNpZ25lZCk7CisKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4ob3ZlcmZsb3dVbnNp Z25lZCksIG1heFVuc2lnbmVkKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzx1bnNpZ25lZD4oLTEp LCAwdSk7Cit9CisKK1RFU1QoV1RGLCBjbGFtcFRvVW5zaWduZWRMb25nTG9uZykKK3sKKyAgICB1 bnNpZ25lZCBsb25nIGxvbmcgbWF4VW5zaWduZWQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2ln bmVkPjo6bWF4KCk7CisgICAgdW5zaWduZWQgbG9uZyBsb25nIG92ZXJmbG93VW5zaWduZWQgPSBt YXhVbnNpZ25lZCArIDE7CisKKyAgICBFWFBFQ1RfR1Qob3ZlcmZsb3dVbnNpZ25lZCwgbWF4VW5z aWduZWQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG88dW5zaWduZWQ+KG1heFVuc2lnbmVkKSwg bWF4VW5zaWduZWQpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG88dW5zaWduZWQ+KG92ZXJmbG93 VW5zaWduZWQpLCBtYXhVbnNpZ25lZCk7CisgICAgRVhQRUNUX0VRKGNsYW1wVG88dW5zaWduZWQ+ KC0xKSwgMHUpOworfQorCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==