105045 2012-12-14 12:00:41 -0800 Enable video caption controls on Windows. 2012-12-14 14:22:28 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned dino eric.carlson eric feature-media-reviews ojan.autocc roger_fong webkit.review.bot oldest_to_newest 791745 0 roger_fong 2012-12-14 12:00:41 -0800 Now that video tracks have been enabled on Windows, enable controls as well. 791750 1 179510 roger_fong 2012-12-14 12:05:05 -0800 Created attachment 179510 patch controls work manually but video-controls-captions-trackmenu.html times out for some reason. Investigating but enabling controls first for now. 791824 2 179510 eric.carlson 2012-12-14 13:49:59 -0800 Comment on attachment 179510 patch View in context: https://bugs.webkit.org/attachment.cgi?id=179510&action=review > Source/WebCore/rendering/RenderThemeWin.h:28 > +#include <SafariTheme/SafariThemeConstants.h> Is this change needed? 791850 3 roger_fong 2012-12-14 14:12:30 -0800 (In reply to comment #2) > (From update of attachment 179510 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179510&action=review > > > Source/WebCore/rendering/RenderThemeWin.h:28 > > +#include <SafariTheme/SafariThemeConstants.h> > > Is this change needed? Yeah it's to get supportsClosedCaptioning() in RenderThemeWin to return true. It checks to see that SAFARI_THEME_VERSION >= 4 which is defined in the constants file. RenderThemeSafari includes SafariThemeConstants but it looks like it was missed in RenderThemeWin. 791863 4 roger_fong 2012-12-14 14:22:28 -0800 http://trac.webkit.org/changeset/137771 179510 2012-12-14 12:05:05 -0800 2012-12-14 13:49:58 -0800 patch controls.patch text/plain 3122 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzc2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTE0ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIHZpZGVvIGNhcHRp b24gY29udHJvbHMgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNTA0NS4KKworICAgICAgICBOb3cgdGhhdCB2aWRlbyB0cmFja3Mg aGF2ZSBiZWVuIGVuYWJsZWQgb24gV2luZG93cywgZW5hYmxlIGNvbnRyb2xzIGFzIHdlbGwuCisK KyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUb2dnbGVDbG9zZWRDYXB0aW9uc0J1dHRvbkVsZW1lbnQ6 Ok1lZGlhQ29udHJvbFRvZ2dsZUNsb3NlZENhcHRpb25zQnV0dG9uRWxlbWVudCk6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUb2dnbGVDbG9zZWRDYXB0aW9uc0J1dHRvbkVsZW1lbnQ6 OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorICAgICAgICAqIGh0bWwvc2hhZG93L01lZGlhQ29udHJv bEVsZW1lbnRzLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmg6CisKIDIw MTItMTItMTQgIE1pY2hlbGFuZ2VsbyBEZSBTaW1vbmUgIDxtaWNoZWxhbmdlbG9Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBbQ1NTIFNoYWRlcnNdIFJlbW92ZSBjb2RlIGZvciB0aGUgb3RoZXIgbWVz aCBib3ggdHlwZXMgKGJvcmRlci1ib3ggfCBwYWRkaW5nLWJveCB8IGNvbnRlbnQtYm94KQpJbmRl eDogU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1l bnRzLmNwcAkocmV2aXNpb24gMTM3NjUyKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv TWVkaWFDb250cm9sRWxlbWVudHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NDksMTEgKzY0OSwx MSBAQCBjb25zdCBBdG9taWNTdHJpbmcmIE1lZGlhQ29udHJvbFJldHVyblRvCiAKIE1lZGlhQ29u dHJvbFRvZ2dsZUNsb3NlZENhcHRpb25zQnV0dG9uRWxlbWVudDo6TWVkaWFDb250cm9sVG9nZ2xl Q2xvc2VkQ2FwdGlvbnNCdXR0b25FbGVtZW50KERvY3VtZW50KiBkb2N1bWVudCwgTWVkaWFDb250 cm9scyogY29udHJvbHMpCiAgICAgOiBNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQoZG9jdW1lbnQs IE1lZGlhU2hvd0Nsb3NlZENhcHRpb25zQnV0dG9uKQotI2lmIFBMQVRGT1JNKE1BQykKKyNpZiBQ TEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikKICAgICAsIG1fY29udHJvbHMoY29udHJvbHMp CiAjZW5kaWYKIHsKLSNpZiAhUExBVEZPUk0oTUFDKQorI2lmICFQTEFURk9STShNQUMpICYmICFQ TEFURk9STShXSU4pCiAgICAgVU5VU0VEX1BBUkFNKGNvbnRyb2xzKTsKICNlbmRpZgogfQpAQCAt NjgzLDcgKzY4Myw3IEBAIHZvaWQgTWVkaWFDb250cm9sVG9nZ2xlQ2xvc2VkQ2FwdGlvbnNCdXQK ICAgICAgICAgLy8gVUkuIE5vdCBhbGwgcG9ydHMgbWF5IHdhbnQgdGhlIGNsb3NlZCBjYXB0aW9u cyBidXR0b24gdG8gdG9nZ2xlIGEgbGlzdCBvZiB0cmFja3MsIHNvCiAgICAgICAgIC8vIHdlIGhh dmUgdG8gdXNlICNpZi4KICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMTg3NwotI2lmICFQTEFURk9STShNQUMpCisjaWYgIVBMQVRGT1JNKE1BQykg JiYgIVBMQVRGT1JNKFdJTikKICAgICAgICAgbWVkaWFDb250cm9sbGVyKCktPnNldENsb3NlZENh cHRpb25zVmlzaWJsZSghbWVkaWFDb250cm9sbGVyKCktPmNsb3NlZENhcHRpb25zVmlzaWJsZSgp KTsKICAgICAgICAgc2V0Q2hlY2tlZChtZWRpYUNvbnRyb2xsZXIoKS0+Y2xvc2VkQ2FwdGlvbnNW aXNpYmxlKCkpOwogICAgICAgICB1cGRhdGVEaXNwbGF5VHlwZSgpOwpJbmRleDogU291cmNlL1dl YkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5oCShyZXZpc2lv biAxMzc2NTIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVt ZW50cy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNzUsNyArMjc1LDcgQEAgcHJpdmF0ZToKICAgICB2 aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmluZyYgc2hhZG93UHNldWRvSWQoKSBjb25zdCBPVkVSUklE RTsKICAgICB2aXJ0dWFsIHZvaWQgZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCopIE9WRVJSSURF OwogCi0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lO KQogICAgIE1lZGlhQ29udHJvbHMqIG1fY29udHJvbHM7CiAjZW5kaWYKIH07CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaAkocmV2aXNpb24gMTM3NjUyKQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmgJKHdvcmtpbmcgY29w eSkKQEAgLTI1LDYgKzI1LDcgQEAKICNkZWZpbmUgUmVuZGVyVGhlbWVXaW5faAogCiAjaW5jbHVk ZSAiUmVuZGVyVGhlbWUuaCIKKyNpbmNsdWRlIDxTYWZhcmlUaGVtZS9TYWZhcmlUaGVtZUNvbnN0 YW50cy5oPgogCiAjaWYgV0lOMzIKIHR5cGVkZWYgdm9pZCogSEFORExFOwo=