105032 2012-12-14 08:19:37 -0800 Web Inspector: Fix JS compiler warning. 2012-12-16 23:14:48 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov eustas keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 791626 0 eustas 2012-12-14 08:19:37 -0800 JS compiler output: Source/WebCore/inspector/front-end/ElementsTreeOutline.js:484: WARNING - actual parameter 1 of WebInspector.KeyboardShortcut.hasNoModifiers does not match formal parameter found : (Event|null) required: (KeyboardEvent|null) if (!treeElement._editing && WebInspector.KeyboardShortcut.hasNoModifiers(event) && event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code) { 791633 1 179488 eustas 2012-12-14 08:29:35 -0800 Created attachment 179488 Patch 791674 2 179488 pfeldman 2012-12-14 09:53:43 -0800 Comment on attachment 179488 Patch I'd rather cast event to keyboardevent in the handler. 792461 3 179687 eustas 2012-12-16 21:19:45 -0800 Created attachment 179687 Patch 792462 4 eustas 2012-12-16 21:21:41 -0800 (In reply to comment #2) > (From update of attachment 179488 [details]) > I'd rather cast event to keyboardevent in the handler. Done. 792489 5 179687 webkit.review.bot 2012-12-16 23:14:44 -0800 Comment on attachment 179687 Patch Clearing flags on attachment: 179687 Committed r137877: <http://trac.webkit.org/changeset/137877> 792490 6 webkit.review.bot 2012-12-16 23:14:48 -0800 All reviewed patches have been landed. Closing bug. 179488 2012-12-14 08:29:35 -0800 2012-12-16 21:19:40 -0800 Patch bug-105032-20121214202654.patch text/plain 2036 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZiMDdhM2Y0OGM5Zjc5 YjQzNTYyNjU5YzlkNGZhM2I3NWNiMDU3OC4uMDk3NDgwYzljMGIwNzA4ZDViY2RjNDZjMGUwYzM5 ZDg1OTE5YjMyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTE0ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEZpeCBKUyBjb21waWxlciB3YXJuaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MDMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvYmxlbTogZXZlbnQgaGFuZGxlciBwYXJhbWV0ZXIg aGFzIGFjdGlhbCBwYXJhbWV0ZXIKKyAgICAgICAgdHlwZSBLZXlib2FyZEV2ZW50LCBidXQgIi5h ZGRFdmVudExpc3RlbmVyIiByZWZ1c2VzIGxpc3RlbmVycyB3aXRoIHN1Y2gKKyAgICAgICAgc2ln bmF0dXJlLgorCisgICAgICAgIFNvbHV0aW9uOiBleHBsaWNpdGx5IGRvY3R5cGUgKGNvdmFyaWFu dCkgZG93bmNhc3Qgb2YgbGlzdGVuZXIgdHlwZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qczogVXBkYXRlIEpzRG9jcy4KKwogMjAxMi0xMi0x MyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVmYWN0b3Jp bmc6IEZpeCBpbmRlbnRhdGlvbiBvZiBDaHJvbWVDbGllbnQuaApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmlu ZGV4IGMxYzI3NWU5OWI4MjRhYTM5MTg5MDIwY2U2MjMwZmY0NDg1MWM5NWIuLjIwNjdlODJkMjBj MWFiMzUzNmY1ZjliYmIzMmIyYzZmNTQ3ZGY1YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAgLTQ4 LDcgKzQ4LDcgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUgPSBmdW5jdGlvbihv bWl0Um9vdERPTU5vZGUsIHNlbGVjdEVuYWJsZWQsIHNob3cKICAgICB0aGlzLmVsZW1lbnQuYWRk RXZlbnRMaXN0ZW5lcigiZHJhZ2xlYXZlIiwgdGhpcy5fb25kcmFnbGVhdmUuYmluZCh0aGlzKSwg ZmFsc2UpOwogICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJkcm9wIiwgdGhpcy5f b25kcm9wLmJpbmQodGhpcyksIGZhbHNlKTsKICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0 ZW5lcigiZHJhZ2VuZCIsIHRoaXMuX29uZHJhZ2VuZC5iaW5kKHRoaXMpLCBmYWxzZSk7Ci0gICAg dGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImtleWRvd24iLCB0aGlzLl9vbmtleWRvd24u YmluZCh0aGlzKSwgZmFsc2UpOworICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJr ZXlkb3duIiwgLyoqIEB0eXBlIHtmdW5jdGlvbihFdmVudCl9ICovICh0aGlzLl9vbmtleWRvd24u YmluZCh0aGlzKSksIGZhbHNlKTsKIAogICAgIFRyZWVPdXRsaW5lLmNhbGwodGhpcywgdGhpcy5l bGVtZW50KTsKIApAQCAtNDcyLDcgKzQ3Miw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVP dXRsaW5lLnByb3RvdHlwZSA9IHsKICAgICB9LAogCiAgICAgLyoqCi0gICAgICogQHBhcmFtIHtF dmVudH0gZXZlbnQKKyAgICAgKiBAcGFyYW0ge0tleWJvYXJkRXZlbnR9IGV2ZW50CiAgICAgICov CiAgICAgX29ua2V5ZG93bjogZnVuY3Rpb24oZXZlbnQpCiAgICAgewo= 179687 2012-12-16 21:19:45 -0800 2012-12-16 23:14:44 -0800 Patch bug-105032-20121217091703.patch text/plain 2021 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAxM2E3MDAxYjI5NmQx N2RkZTk5OWRmNGU3NjkzZGFiMjdlMjEwOS4uMzc4ODk3NDVjMzA4NjQwM2FkZTQ1ZDBhYTYxOGM5 ZmZhMjVmMWQwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTE0ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEZpeCBKUyBjb21waWxlciB3YXJuaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MDMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvYmxlbTogZXZlbnQgaGFuZGxlciBwYXJhbWV0ZXIg aGFzIGFjdGlhbCBwYXJhbWV0ZXIKKyAgICAgICAgdHlwZSBLZXlib2FyZEV2ZW50LCBidXQgIi5h ZGRFdmVudExpc3RlbmVyIiByZWZ1c2VzIGxpc3RlbmVycyB3aXRoIHN1Y2gKKyAgICAgICAgc2ln bmF0dXJlLgorCisgICAgICAgIFNvbHV0aW9uOiBleHBsaWNpdGx5IHVwY2FzdCBhcmd1bWVudCB0 eXBlLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5l LmpzOiBVcGRhdGUgSnNEb2NzLgorCiAyMDEyLTEyLTE2ICBKb24gTGVlICA8am9ubGVlQGFwcGxl LmNvbT4KIAogICAgICAgICBBbGxvdyBidWlsdC1pbiBQREYgcGx1Z2luIGFuZCBwbHVnaW4gZG9j dW1lbnRzIHRvIGF1dG8tc3RhcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwppbmRleCBjMWMyNzVlOTliODI0 YWEzOTE4OTAyMGNlNjIzMGZmNDQ4NTFjOTViLi4xMDE5NzEyNTAwZDJhMTk5YjZjM2M1MDQ3NjBh YTJjYjY3OTg5YjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCkBAIC00NzYsMTIgKzQ3NiwxMyBAQCBX ZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5wcm90b3R5cGUgPSB7CiAgICAgICovCiAg ICAgX29ua2V5ZG93bjogZnVuY3Rpb24oZXZlbnQpCiAgICAgeworICAgICAgICB2YXIga2V5Ym9h cmRFdmVudCA9IC8qKiBAdHlwZSB7S2V5Ym9hcmRFdmVudH0gKi8gKGV2ZW50KTsKICAgICAgICAg dmFyIG5vZGUgPSB0aGlzLnNlbGVjdGVkRE9NTm9kZSgpOwogICAgICAgICB2YXIgdHJlZUVsZW1l bnQgPSB0aGlzLmdldENhY2hlZFRyZWVFbGVtZW50KG5vZGUpOwogICAgICAgICBpZiAoIXRyZWVF bGVtZW50KQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmICghdHJlZUVsZW1lbnQu X2VkaXRpbmcgJiYgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuaGFzTm9Nb2RpZmllcnMo ZXZlbnQpICYmIGV2ZW50LmtleUNvZGUgPT09IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0 LktleXMuSC5jb2RlKSB7CisgICAgICAgIGlmICghdHJlZUVsZW1lbnQuX2VkaXRpbmcgJiYgV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuaGFzTm9Nb2RpZmllcnMoa2V5Ym9hcmRFdmVudCkg JiYga2V5Ym9hcmRFdmVudC5rZXlDb2RlID09PSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dC5LZXlzLkguY29kZSkgewogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmNzc01vZGVsLnRvZ2ds ZUlubGluZVZpc2liaWxpdHkobm9kZS5pZCk7CiAgICAgICAgICAgICBldmVudC5jb25zdW1lKHRy dWUpOwogICAgICAgICAgICAgcmV0dXJuOwo=