105025 2012-12-14 07:45:58 -0800 Add Anton Vayvod and Tim Volodine as contributors in committers.py 2012-12-17 06:41:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 johnme johnme avayvod peter timvolodine webkit.review.bot oldest_to_newest 791602 0 johnme 2012-12-14 07:45:58 -0800 Add Anton Vayvod and Tim Volodine to commiters.py 791605 1 179482 johnme 2012-12-14 07:50:36 -0800 Created attachment 179482 Patch 792620 2 179482 peter 2012-12-17 04:12:25 -0800 Comment on attachment 179482 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179482&action=review One thing I'd like you to change (add a reason), happy to set cq+ afterwards. > Tools/ChangeLog:3 > + Add Anton Vayvod and Tim Volodine to committers.py nit: It's clearer to also mention in the title that you're adding them as contributors. > Tools/ChangeLog:6 > + Unreviewed. Adds two contributors to committers.py. Please explain why they should be added. Adding "They contribute to the Text Autosizing feature." would be sufficient already. 792683 3 179734 johnme 2012-12-17 06:32:05 -0800 Created attachment 179734 Patch 792684 4 179482 johnme 2012-12-17 06:32:13 -0800 Comment on attachment 179482 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179482&action=review >> Tools/ChangeLog:3 >> + Add Anton Vayvod and Tim Volodine to committers.py > > nit: It's clearer to also mention in the title that you're adding them as contributors. Done. >> Tools/ChangeLog:6 >> + Unreviewed. Adds two contributors to committers.py. > > Please explain why they should be added. Adding "They contribute to the Text Autosizing feature." would be sufficient already. Done. 792685 5 179734 peter 2012-12-17 06:33:34 -0800 Comment on attachment 179734 Patch Seems good to me. Thanks John. 792686 6 179734 webkit.review.bot 2012-12-17 06:35:51 -0800 Comment on attachment 179734 Patch Rejecting attachment 179734 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/common/config/committers.py Hunk #1 FAILED at 116. Hunk #2 succeeded at 166 (offset 2 lines). 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/config/committers.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15371718 792688 7 peter 2012-12-17 06:41:42 -0800 Committed r137904: <http://trac.webkit.org/changeset/137904> 179482 2012-12-14 07:50:36 -0800 2012-12-17 06:32:13 -0800 Patch bug-105025-20121214154756.patch text/plain 2192 johnme U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTU5OGZkMmI3MGY3MTBlNTkzMWFiMWQzYzNmMDUwOTE5 MzgwOGYyMC4uZjY5NzkyYTk0NWY5NTFjYzM5NDcxZTdlZTg4N2EyZjZiMjY1NGNjZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTEyLTE0ICBKb2huIE1lbGxvciAgPGpvaG5tZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgQWRkIEFudG9uIFZheXZvZCBhbmQgVGltIFZvbG9kaW5lIHRvIGNvbW1pdHRlcnMucHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTAyNQor CisgICAgICAgIFVucmV2aWV3ZWQuIEFkZHMgdHdvIGNvbnRyaWJ1dG9ycyB0byBjb21taXR0ZXJz LnB5LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnMucHk6CisKIDIwMTItMTItMDYgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwuY29t PgogCiAgICAgICAgIFtFRkxdIFtXSzJdIGZhc3QvZG9tL3ZlcnRpY2FsLXNjcm9sbGJhci1pbi1y dGwuaHRtbCBtYWtlcyBmYXN0L3JlZ2lvbnMgdGVzdHMgZmxha3kKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkKaW5kZXggN2ExN2YzN2Nj OTQ0MzQ0YjFmYmY0MzI5ZTZkYTIwNzdhMjIyNWFhMC4uOTBmMDc1ZTg3ZmZjZTM1OTk3NmEzZDQ4 ZWM4YzA3ZTE2Njg4MzJhMCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY29uZmlnL2NvbW1pdHRlcnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY29uZmlnL2NvbW1pdHRlcnMucHkKQEAgLTExNiw2ICsxMTYsNyBAQCBjb250cmlidXRvcnNf d2hvX2FyZV9ub3RfY29tbWl0dGVycyA9IFsKICAgICBDb250cmlidXRvcigiQW5kcmVpIEJ1Y3Vy IiwgImFidWN1ckBhZG9iZS5jb20iLCAiYWJ1Y3VyIiksCiAgICAgQ29udHJpYnV0b3IoIkFubmUg dmFuIEtlc3RlcmVuIiwgImFubmV2YW5rZXN0ZXJlbit3ZWJraXRAZ21haWwuY29tIiwgImFubmV2 ayIpLAogICAgIENvbnRyaWJ1dG9yKCJBbm5pZSBTdWxsaXZhbiIsICJzdWxsaXZhbkBjaHJvbWl1 bS5vcmciLCAiYW5uaWUiKSwKKyAgICBDb250cmlidXRvcigiQW50b24gVmF5dm9kIiwgImF2YXl2 b2RAY2hyb21pdW0ub3JnIiwgImF2YXl2b2QiKSwKICAgICBDb250cmlidXRvcigiQXJ5ZWggR3Jl Z29yIiwgImF5Z0BhcnllaC5uYW1lIiwgIkFyeWVoR3JlZ29yIiksCiAgICAgQ29udHJpYnV0b3Io IkJhbGF6cyBBbmtlcyIsICJiYW5rQGluZi51LXN6ZWdlZC5odSIsICJhYmFsYXpzIiksCiAgICAg Q29udHJpYnV0b3IoIkJyaWFuIFNhbG9tb24iLCAiYnNhbG9tb25AZ29vZ2xlLmNvbSIpLApAQCAt MTY0LDYgKzE2NSw3IEBAIGNvbnRyaWJ1dG9yc193aG9fYXJlX25vdF9jb21taXR0ZXJzID0gWwog ICAgIENvbnRyaWJ1dG9yKCJUYWIgQXRraW5zIiwgWyJ0YWJhdGtpbnNAZ29vZ2xlLmNvbSIsICJq YWNrYWxtYWdlQGdtYWlsLmNvbSJdLCAidGFiYXRraW5zIiksCiAgICAgQ29udHJpYnV0b3IoIlRh bWFzIEN6ZW5lIiwgWyJ0Y3plbmVAaW5mLnUtc3plZ2VkLmh1IiwgIkN6ZW5lLlRhbWFzQHN0dWQu dS1zemVnZWQuaHUiXSwgInRjemVuZSIpLAogICAgIENvbnRyaWJ1dG9yKCJUaWVuLVJlbiBDaGVu IiwgInRyY2hlbkBjaHJvbWl1bS5vcmciLCAidHJjaGVuIiksCisgICAgQ29udHJpYnV0b3IoIlRp bSBWb2xvZGluZSIsICJ0aW12b2xvZGluZUBjaHJvbWl1bS5vcmciLCAidGltdm9sb2RpbmUiKSwK ICAgICBDb250cmlidXRvcigiV2ViS2l0IFJldmlldyBCb3QiLCAid2Via2l0LnJldmlldy5ib3RA Z21haWwuY29tIiwgInNoZXJpZmYtYm90IiksCiAgICAgQ29udHJpYnV0b3IoIldlYiBDb21wb25l bnRzIFRlYW0iLCAid2ViY29tcG9uZW50cy1idWd6aWxsYUBjaHJvbWl1bS5vcmciKSwKICAgICBD b250cmlidXRvcigiV3lhdHQgQ2Fyc3MiLCBbIndjYXJzc0BjaHJvbWl1bS5vcmciLCAid2NhcnNz QGdvb2dsZS5jb20iXSwgIndjYXJzcyIpLAo= 179734 2012-12-17 06:32:05 -0800 2012-12-17 06:35:50 -0800 Patch bug-105025-20121217142923.patch text/plain 2301 johnme U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTU5OGZkMmI3MGY3MTBlNTkzMWFiMWQzYzNmMDUwOTE5 MzgwOGYyMC4uNzVmMWNiYWVjNzQ0MTYzZjk5YmZiYTllMmEyNGMzZTBlNDUxOTc1OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTEyLTE0ICBKb2huIE1lbGxvciAgPGpvaG5tZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgQWRkIEFudG9uIFZheXZvZCBhbmQgVGltIFZvbG9kaW5lIGFzIGNvbnRyaWJ1dG9ycyBp biBjb21taXR0ZXJzLnB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDUwMjUKKworICAgICAgICBVbnJldmlld2VkLiBBZGRzIHR3byBjb250cmlidXRv cnMgdG8gY29tbWl0dGVycy5weS4KKyAgICAgICAgVGhleSBhcmUgaW5pdGlhbGx5IGNvbnRyaWJ1 dGluZyB0byB0aGUgVGV4dCBBdXRvc2l6aW5nIGZlYXR1cmUgKG1hc3RlciBidWc6IDg0MTg2KS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5 OgorCiAyMDEyLTEyLTA2ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQGludGVsLmNvbT4KIAog ICAgICAgICBbRUZMXSBbV0syXSBmYXN0L2RvbS92ZXJ0aWNhbC1zY3JvbGxiYXItaW4tcnRsLmh0 bWwgbWFrZXMgZmFzdC9yZWdpb25zIHRlc3RzIGZsYWt5CmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5CmluZGV4IDdhMTdmMzdjYzk0NDM0 NGIxZmJmNDMyOWU2ZGEyMDc3YTIyMjVhYTAuLjkwZjA3NWU4N2ZmY2UzNTk5NzZhM2Q0OGVjOGMw N2UxNjY4ODMyYTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy9jb21taXR0ZXJzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy9jb21taXR0ZXJzLnB5CkBAIC0xMTYsNiArMTE2LDcgQEAgY29udHJpYnV0b3JzX3dob19h cmVfbm90X2NvbW1pdHRlcnMgPSBbCiAgICAgQ29udHJpYnV0b3IoIkFuZHJlaSBCdWN1ciIsICJh YnVjdXJAYWRvYmUuY29tIiwgImFidWN1ciIpLAogICAgIENvbnRyaWJ1dG9yKCJBbm5lIHZhbiBL ZXN0ZXJlbiIsICJhbm5ldmFua2VzdGVyZW4rd2Via2l0QGdtYWlsLmNvbSIsICJhbm5ldmsiKSwK ICAgICBDb250cmlidXRvcigiQW5uaWUgU3VsbGl2YW4iLCAic3VsbGl2YW5AY2hyb21pdW0ub3Jn IiwgImFubmllIiksCisgICAgQ29udHJpYnV0b3IoIkFudG9uIFZheXZvZCIsICJhdmF5dm9kQGNo cm9taXVtLm9yZyIsICJhdmF5dm9kIiksCiAgICAgQ29udHJpYnV0b3IoIkFyeWVoIEdyZWdvciIs ICJheWdAYXJ5ZWgubmFtZSIsICJBcnllaEdyZWdvciIpLAogICAgIENvbnRyaWJ1dG9yKCJCYWxh enMgQW5rZXMiLCAiYmFua0BpbmYudS1zemVnZWQuaHUiLCAiYWJhbGF6cyIpLAogICAgIENvbnRy aWJ1dG9yKCJCcmlhbiBTYWxvbW9uIiwgImJzYWxvbW9uQGdvb2dsZS5jb20iKSwKQEAgLTE2NCw2 ICsxNjUsNyBAQCBjb250cmlidXRvcnNfd2hvX2FyZV9ub3RfY29tbWl0dGVycyA9IFsKICAgICBD b250cmlidXRvcigiVGFiIEF0a2lucyIsIFsidGFiYXRraW5zQGdvb2dsZS5jb20iLCAiamFja2Fs bWFnZUBnbWFpbC5jb20iXSwgInRhYmF0a2lucyIpLAogICAgIENvbnRyaWJ1dG9yKCJUYW1hcyBD emVuZSIsIFsidGN6ZW5lQGluZi51LXN6ZWdlZC5odSIsICJDemVuZS5UYW1hc0BzdHVkLnUtc3pl Z2VkLmh1Il0sICJ0Y3plbmUiKSwKICAgICBDb250cmlidXRvcigiVGllbi1SZW4gQ2hlbiIsICJ0 cmNoZW5AY2hyb21pdW0ub3JnIiwgInRyY2hlbiIpLAorICAgIENvbnRyaWJ1dG9yKCJUaW0gVm9s b2RpbmUiLCAidGltdm9sb2RpbmVAY2hyb21pdW0ub3JnIiwgInRpbXZvbG9kaW5lIiksCiAgICAg Q29udHJpYnV0b3IoIldlYktpdCBSZXZpZXcgQm90IiwgIndlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbSIsICJzaGVyaWZmLWJvdCIpLAogICAgIENvbnRyaWJ1dG9yKCJXZWIgQ29tcG9uZW50cyBU ZWFtIiwgIndlYmNvbXBvbmVudHMtYnVnemlsbGFAY2hyb21pdW0ub3JnIiksCiAgICAgQ29udHJp YnV0b3IoIld5YXR0IENhcnNzIiwgWyJ3Y2Fyc3NAY2hyb21pdW0ub3JnIiwgIndjYXJzc0Bnb29n bGUuY29tIl0sICJ3Y2Fyc3MiKSwK