105019 2012-12-14 06:50:10 -0800 Web Inspector: optional parameters of protocol commands should go after required ones 2012-12-14 09:22:26 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 104074 1 yurys yurys apavlov keishi kkania loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 791574 0 yurys 2012-12-14 06:50:10 -0800 Input.dispatchMouseEvent declaration breaks this rule which leads to the following closure compiler error: .... Source/WebCore/inspector/front-end/protocol-externs.js:2939: WARNING - optional arguments must be at the end InputAgent.dispatchMouseEvent = function(type, opt_modifiers, opt_timestamp, opt_button, opt_clickCount, x, y, opt_callback) {} ^ ... 791575 1 179475 yurys 2012-12-14 06:52:37 -0800 Created attachment 179475 Patch 791576 2 yurys 2012-12-14 06:53:53 -0800 Alternatively we could make CodeGeneratorInspector.py rearrange parameters so that optional would go after required ones. 791659 3 179475 webkit.review.bot 2012-12-14 09:22:22 -0800 Comment on attachment 179475 Patch Clearing flags on attachment: 179475 Committed r137751: <http://trac.webkit.org/changeset/137751> 791660 4 webkit.review.bot 2012-12-14 09:22:26 -0800 All reviewed patches have been landed. Closing bug. 179475 2012-12-14 06:52:37 -0800 2012-12-14 09:22:22 -0800 Patch bug-105019-20121214184956.patch text/plain 5461 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzNmMDczYWUzNjMyMWI3 NWVjZTRkMzJhZWQyMTZhY2I0YjhlOGQxYi4uNzA4MTg0MTc2YzMyZDVlY2I4OGE4MWYwMTM4ODlj ZGQyNDkwMzY4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTEyLTE0ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IG9wdGlvbmFsIHBhcmFtZXRlcnMgb2YgcHJvdG9jb2wgY29tbWFuZHMgc2hvdWxkIGdvIGFm dGVyIHJlcXVpcmVkIG9uZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNTAxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uOiBNb3ZlZCByZXF1aXJlZCB4IGFu ZCB5IHBhcmFtZXRlcnMgZGVjbGFyYXRpb24gYmVmb3JlCisgICAgICAgIG9wdGlvbmFsIG9uZXMu CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvcklucHV0QWdlbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9ySW5wdXRBZ2VudDo6ZGlzcGF0Y2hNb3VzZUV2ZW50KToKKyAgICAg ICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9ySW5wdXRBZ2VudC5oOgorICAgICAgICAoSW5zcGVjdG9y SW5wdXRBZ2VudCk6CisKKzIwMTItMTItMTQgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJv bWl1bS5vcmc+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIGRhdGEgZ3JpZCBmb3IgZXhw bG9yaW5nIG5hdGl2ZSBoZWFwIGdyYXBoCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDUwMTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3Rvci5qc29uIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ci5qc29uCmluZGV4IGNiNTM3NzY2YWRlZTVmNDJiNjk5ZTEyOTNmODkxNDI1NDAxNTRlNGUuLmVl Yjc2MzFmODFkMTE2NWJhYmQ5YTI4ZGRiYzRlZTQ0ZjJjYWI0NjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yLmpzb24KQEAgLTMyOTEsMTIgKzMyOTEsMTIgQEAKICAgICAgICAg ICAgICAgICAibmFtZSI6ICJkaXNwYXRjaE1vdXNlRXZlbnQiLAogICAgICAgICAgICAgICAgICJw YXJhbWV0ZXJzIjogWwogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInR5cGUiLCAidHlw ZSI6ICJzdHJpbmciLCAiZW51bSI6IFsibW91c2VQcmVzc2VkIiwgIm1vdXNlUmVsZWFzZWQiLCAi bW91c2VNb3ZlZCJdLCAiZGVzY3JpcHRpb24iOiAiVHlwZSBvZiB0aGUgbW91c2UgZXZlbnQuIiB9 LAorICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIngiLCAidHlwZSI6ICJpbnRlZ2VyIiwg ImRlc2NyaXB0aW9uIjogIlggY29vcmRpbmF0ZSBvZiB0aGUgZXZlbnQgcmVsYXRpdmUgdG8gdGhl IG1haW4gZnJhbWUncyB2aWV3cG9ydC4ifSwKKyAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6 ICJ5IiwgInR5cGUiOiAiaW50ZWdlciIsICJkZXNjcmlwdGlvbiI6ICJZIGNvb3JkaW5hdGUgb2Yg dGhlIGV2ZW50IHJlbGF0aXZlIHRvIHRoZSBtYWluIGZyYW1lJ3Mgdmlld3BvcnQuIDAgcmVmZXJz IHRvIHRoZSB0b3Agb2YgdGhlIHZpZXdwb3J0IGFuZCBZIGluY3JlYXNlcyBhcyBpdCBwcm9jZWVk cyB0b3dhcmRzIHRoZSBib3R0b20gb2YgdGhlIHZpZXdwb3J0LiJ9LAogICAgICAgICAgICAgICAg ICAgICB7ICJuYW1lIjogIm1vZGlmaWVycyIsICJ0eXBlIjogImludGVnZXIiLCAib3B0aW9uYWwi OiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiQml0IGZpZWxkIHJlcHJlc2VudGluZyBwcmVzc2VkIG1v ZGlmaWVyIGtleXMuIEFsdD0xLCBDdHJsPTIsIE1ldGEvQ29tbWFuZD00LCBTaGlmdD04IChkZWZh dWx0OiAwKS4iIH0sCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAidGltZXN0YW1wIiwg InR5cGUiOiAibnVtYmVyIiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIlRpbWUg YXQgd2hpY2ggdGhlIGV2ZW50IG9jY3VycmVkLiBNZWFzdXJlZCBpbiBVVEMgdGltZSBpbiBzZWNv bmRzIHNpbmNlIEphbnVhcnkgMSwgMTk3MCAoZGVmYXVsdDogY3VycmVudCB0aW1lKS4iIH0sCiAg ICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiYnV0dG9uIiwgInR5cGUiOiAic3RyaW5nIiwg ImVudW0iOiBbIm5vbmUiLCAibGVmdCIsICJtaWRkbGUiLCAicmlnaHQiXSwgIm9wdGlvbmFsIjog dHJ1ZSwgImRlc2NyaXB0aW9uIjogIk1vdXNlIGJ1dHRvbiAoZGVmYXVsdDogXCJub25lXCIpLiIg fSwKLSAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJjbGlja0NvdW50IiwgInR5cGUiOiAi aW50ZWdlciIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJOdW1iZXIgb2YgdGlt ZXMgdGhlIG1vdXNlIGJ1dHRvbiB3YXMgY2xpY2tlZCAoZGVmYXVsdDogMCkuIiB9LAotICAgICAg ICAgICAgICAgICAgICB7ICJuYW1lIjogIngiLCAidHlwZSI6ICJpbnRlZ2VyIiwgImRlc2NyaXB0 aW9uIjogIlggY29vcmRpbmF0ZSBvZiB0aGUgZXZlbnQgcmVsYXRpdmUgdG8gdGhlIG1haW4gZnJh bWUncyB2aWV3cG9ydC4ifSwKLSAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJ5IiwgInR5 cGUiOiAiaW50ZWdlciIsICJkZXNjcmlwdGlvbiI6ICJZIGNvb3JkaW5hdGUgb2YgdGhlIGV2ZW50 IHJlbGF0aXZlIHRvIHRoZSBtYWluIGZyYW1lJ3Mgdmlld3BvcnQuIDAgcmVmZXJzIHRvIHRoZSB0 b3Agb2YgdGhlIHZpZXdwb3J0IGFuZCBZIGluY3JlYXNlcyBhcyBpdCBwcm9jZWVkcyB0b3dhcmRz IHRoZSBib3R0b20gb2YgdGhlIHZpZXdwb3J0LiJ9CisgICAgICAgICAgICAgICAgICAgIHsgIm5h bWUiOiAiY2xpY2tDb3VudCIsICJ0eXBlIjogImludGVnZXIiLCAib3B0aW9uYWwiOiB0cnVlLCAi ZGVzY3JpcHRpb24iOiAiTnVtYmVyIG9mIHRpbWVzIHRoZSBtb3VzZSBidXR0b24gd2FzIGNsaWNr ZWQgKGRlZmF1bHQ6IDApLiIgfQogICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAgICAg ImRlc2NyaXB0aW9uIjogIkRpc3BhdGNoZXMgYSBtb3VzZSBldmVudCB0byB0aGUgcGFnZS4iCiAg ICAgICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9ySW5wdXRBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5w dXRBZ2VudC5jcHAKaW5kZXggMzMxNjg0YjI5ODc4OWIzNTg4MjFmMjYzNmM3OTQ0ZmEyODJhZDAz Yy4uMTkyZmI3OWRhYjQzMTBhZWQzMzA1ZDQ1NTY1Yzk2MWU3NmUxODRiZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvcklucHV0QWdlbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJbnB1dEFnZW50LmNwcApAQCAtOTMsNyAr OTMsNyBAQCB2b2lkIEluc3BlY3RvcklucHV0QWdlbnQ6OmRpc3BhdGNoS2V5RXZlbnQoRXJyb3JT dHJpbmcqIGVycm9yLCBjb25zdCBTdHJpbmcmIHR5cAogICAgIG1fcGFnZS0+bWFpbkZyYW1lKCkt PmV2ZW50SGFuZGxlcigpLT5rZXlFdmVudChldmVudCk7CiB9CiAKLXZvaWQgSW5zcGVjdG9ySW5w dXRBZ2VudDo6ZGlzcGF0Y2hNb3VzZUV2ZW50KEVycm9yU3RyaW5nKiBlcnJvciwgY29uc3QgU3Ry aW5nJiB0eXBlLCBjb25zdCBpbnQqIG1vZGlmaWVycywgY29uc3QgZG91YmxlKiB0aW1lc3RhbXAs IGNvbnN0IFN0cmluZyogYnV0dG9uLCBjb25zdCBpbnQqIGNsaWNrQ291bnQsIGludCB4LCBpbnQg eSkKK3ZvaWQgSW5zcGVjdG9ySW5wdXRBZ2VudDo6ZGlzcGF0Y2hNb3VzZUV2ZW50KEVycm9yU3Ry aW5nKiBlcnJvciwgY29uc3QgU3RyaW5nJiB0eXBlLCBpbnQgeCwgaW50IHksIGNvbnN0IGludCog bW9kaWZpZXJzLCBjb25zdCBkb3VibGUqIHRpbWVzdGFtcCwgY29uc3QgU3RyaW5nKiBidXR0b24s IGNvbnN0IGludCogY2xpY2tDb3VudCkKIHsKICAgICBQbGF0Zm9ybUV2ZW50OjpUeXBlIGNvbnZl cnRlZFR5cGU7CiAgICAgaWYgKHR5cGUgPT0gIm1vdXNlUHJlc3NlZCIpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5wdXRBZ2VudC5oIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvcklucHV0QWdlbnQuaAppbmRleCAyNGEyNjRiYzg1Y2Ez Njc5ZTJhZmE1NWE4Y2VlY2NhMGQzNTQwZDQxLi44Mzc3ZjgxNzNhM2NkMzAxMjIwNzA2ZDEwZDdl ODNlMDU0NTUxMDdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9ySW5wdXRBZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJ bnB1dEFnZW50LmgKQEAgLTU3LDcgKzU3LDcgQEAgcHVibGljOgogCiAgICAgLy8gTWV0aG9kcyBj YWxsZWQgZnJvbSB0aGUgZnJvbnRlbmQgZm9yIHNpbXVsYXRpbmcgaW5wdXQuCiAgICAgdmlydHVh bCB2b2lkIGRpc3BhdGNoS2V5RXZlbnQoRXJyb3JTdHJpbmcqLCBjb25zdCBTdHJpbmcmIHR5cGUs IGNvbnN0IGludCogbW9kaWZpZXJzLCBjb25zdCBkb3VibGUqIHRpbWVzdGFtcCwgY29uc3QgU3Ry aW5nKiB0ZXh0LCBjb25zdCBTdHJpbmcqIHVubW9kaWZpZWRUZXh0LCBjb25zdCBTdHJpbmcqIGtl eUlkZW50aWZpZXIsIGNvbnN0IGludCogd2luZG93c1ZpcnR1YWxLZXlDb2RlLCBjb25zdCBpbnQq IG5hdGl2ZVZpcnR1YWxLZXlDb2RlLCBjb25zdCBpbnQqIG1hY0NoYXJDb2RlLCBjb25zdCBib29s KiBhdXRvUmVwZWF0LCBjb25zdCBib29sKiBpc0tleXBhZCwgY29uc3QgYm9vbCogaXNTeXN0ZW1L ZXkpOwotICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaE1vdXNlRXZlbnQoRXJyb3JTdHJpbmcqLCBj b25zdCBTdHJpbmcmIHR5cGUsIGNvbnN0IGludCogbW9kaWZpZXJzLCBjb25zdCBkb3VibGUqIHRp bWVzdGFtcCwgY29uc3QgU3RyaW5nKiBidXR0b24sIGNvbnN0IGludCogY2xpY2tDb3VudCwgaW50 IHgsIGludCB5KTsKKyAgICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2hNb3VzZUV2ZW50KEVycm9yU3Ry aW5nKiwgY29uc3QgU3RyaW5nJiB0eXBlLCBpbnQgeCwgaW50IHksIGNvbnN0IGludCogbW9kaWZp ZXJzLCBjb25zdCBkb3VibGUqIHRpbWVzdGFtcCwgY29uc3QgU3RyaW5nKiBidXR0b24sIGNvbnN0 IGludCogY2xpY2tDb3VudCk7CiAKIHByaXZhdGU6CiAgICAgSW5zcGVjdG9ySW5wdXRBZ2VudChJ bnN0cnVtZW50aW5nQWdlbnRzKiwgSW5zcGVjdG9yU3RhdGUqLCBQYWdlKik7Cg==