105001 2012-12-14 01:19:28 -0800 Web Inspector: Native Memory Instrumentation: do not validate InlineFlowBox objects agains tcmalloc data 2012-12-14 05:55:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov eric keishi loislo ojan.autocc pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 791453 0 loislo 2012-12-14 01:19:28 -0800 EOM 791457 1 179445 loislo 2012-12-14 01:24:59 -0800 Created attachment 179445 Patch 791478 2 179445 yurys 2012-12-14 02:02:13 -0800 Comment on attachment 179445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179445&action=review > Source/WebCore/rendering/InlineFlowBox.h:302 > + virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE; How does adding the method fixes the problem described in the bug? Does it mean that InlineBox::reportMemoryUsage is not detected on InlineFlowBox which is derived from InlineBox? 791538 3 loislo 2012-12-14 04:43:45 -0800 (In reply to comment #2) > (From update of attachment 179445 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179445&action=review > > > Source/WebCore/rendering/InlineFlowBox.h:302 > > + virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE; > > How does adding the method fixes the problem described in the bug? Does it mean that InlineBox::reportMemoryUsage is not detected on InlineFlowBox which is derived from InlineBox? It happens because our template stuff doesn't detect instrumentation method in a base class. 791563 4 loislo 2012-12-14 05:55:32 -0800 Committed r137741: <http://trac.webkit.org/changeset/137741> 179445 2012-12-14 01:24:59 -0800 2012-12-14 05:49:01 -0800 Patch bug-105001-20121214132218.patch text/plain 2461 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE2ZjNjYTNlODhmOGFl NTE5OGI4NjhkM2Y1YzQ3NDExYjJjMzcxOC4uMzk5NDEzNTEyNTllMWEyMjg0NDY1ZjZiOTdkMjMz ZmQ3NzdhNzUyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTE0ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBOYXRpdmUgTWVtb3J5IEluc3RydW1lbnRhdGlvbjogZG8gbm90IHZhbGlkYXRlIElubGlu ZUZsb3dCb3ggb2JqZWN0cyBhZ2FpbnN0IHRjbWFsbG9jIGRhdGEuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUwMDEKKworICAgICAgICBUaGlzIGlz IGEgZm9sbG93LXVwIGNoYW5nZSBmb3IgcjEzNzU4OS4KKworICAgICAgICAqIHJlbmRlcmluZy9J bmxpbmVGbG93Qm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklubGluZUZsb3dCb3g6OnJlcG9y dE1lbW9yeVVzYWdlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHJlbmRlcmluZy9J bmxpbmVGbG93Qm94Lmg6CisgICAgICAgIChJbmxpbmVGbG93Qm94KToKKwogMjAxMi0xMi0xNCAg QW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIExheWVyVHJlZUFn ZW50IHNob3VsZCBvbmx5IGJlIGVuYWJsZWQgdXBvbiByZXN0b3JlIGlmIGl0IHdhcyBwcmV2aW91 c2x5IGluIHRoZSBlbmFibGVkIHN0YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvSW5saW5lRmxvd0JveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5l Rmxvd0JveC5jcHAKaW5kZXggNjkxYzA3YjQ2OTQwY2NmODIxOGU0YzEwYjExNzZmNDE3YzYwM2Zk Zi4uZGU5ZTM2YWQyZWQ3MjBjZWM2ZTNkNmJkYTFjZDhhYTJkMWZlZDA1MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcApAQCAtMzksNiArMzksNyBAQAogI2lu Y2x1ZGUgIlJlbmRlclZpZXcuaCIKICNpbmNsdWRlICJSb290SW5saW5lQm94LmgiCiAjaW5jbHVk ZSAiVGV4dC5oIgorI2luY2x1ZGUgIldlYkNvcmVNZW1vcnlJbnN0cnVtZW50YXRpb24uaCIKIAog I2luY2x1ZGUgPG1hdGguaD4KIApAQCAtMTYzNSw0ICsxNjM2LDE1IEBAIHZvaWQgSW5saW5lRmxv d0JveDo6Y2hlY2tDb25zaXN0ZW5jeSgpIGNvbnN0CiAKICNlbmRpZgogCit2b2lkIElubGluZUZs b3dCb3g6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdElu Zm8pIGNvbnN0Cit7CisgICAgTWVtb3J5Q2xhc3NJbmZvIGluZm8obWVtb3J5T2JqZWN0SW5mbywg dGhpcywgV2ViQ29yZU1lbW9yeVR5cGVzOjpSZW5kZXJpbmcpOworICAgIElubGluZUJveDo6cmVw b3J0TWVtb3J5VXNhZ2UobWVtb3J5T2JqZWN0SW5mbyk7CisgICAgaW5mby5hZGRNZW1iZXIobV9v dmVyZmxvdyk7CisgICAgaW5mby5hZGRNZW1iZXIobV9maXJzdENoaWxkKTsKKyAgICBpbmZvLmFk ZE1lbWJlcihtX2xhc3RDaGlsZCk7CisgICAgaW5mby5hZGRNZW1iZXIobV9wcmV2TGluZUJveCk7 CisgICAgaW5mby5hZGRNZW1iZXIobV9uZXh0TGluZUJveCk7Cit9CisKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93 Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lRmxvd0JveC5oCmluZGV4IGM0 MjY0YmJhNmZiZWJjZThkYjQ2MWQwZTgxY2YzZGQ0YzFmMDJlYjEuLjNmMDg2YmM4NmYwNmNiZGM0 OGM5ZTM3OWU5NTg0NDBhMDhiMDc2ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9JbmxpbmVGbG93Qm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGlu ZUZsb3dCb3guaApAQCAtMjk5LDYgKzI5OSw4IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHBhcmVu dCgpLT5jbGVhckRlc2NlbmRhbnRzSGF2ZVNhbWVMaW5lSGVpZ2h0QW5kQmFzZWxpbmUoKTsKICAg ICB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5m byopIGNvbnN0IE9WRVJSSURFOworCiBwcml2YXRlOgogICAgIHZvaWQgYWRkQm94U2hhZG93Vmlz dWFsT3ZlcmZsb3coTGF5b3V0UmVjdCYgbG9naWNhbFZpc3VhbE92ZXJmbG93KTsKICAgICB2b2lk IGFkZEJvcmRlck91dHNldFZpc3VhbE92ZXJmbG93KExheW91dFJlY3QmIGxvZ2ljYWxWaXN1YWxP dmVyZmxvdyk7Cg==