104987 2012-12-13 19:54:00 -0800 MediaPlayerPrivateAVFoundation::m_inbandTrackConfigurationPending is unused except when HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) 2012-12-13 20:39:25 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo jberlin msaboff webkit.review.bot oldest_to_newest 791258 0 fpizlo 2012-12-13 19:54:00 -0800 We should conditionally declare and assign it behind the HAVE() guard. 791259 1 179404 fpizlo 2012-12-13 19:55:20 -0800 Created attachment 179404 the patch 791260 2 fpizlo 2012-12-13 19:55:36 -0800 Using cq instead of landing manually because I'm hoping for some additional test coverage on this. 791283 3 179404 webkit.review.bot 2012-12-13 20:39:22 -0800 Comment on attachment 179404 the patch Clearing flags on attachment: 179404 Committed r137707: <http://trac.webkit.org/changeset/137707> 791284 4 webkit.review.bot 2012-12-13 20:39:25 -0800 All reviewed patches have been landed. Closing bug. 179404 2012-12-13 19:55:20 -0800 2012-12-13 20:39:22 -0800 the patch thingy.patch text/plain 2282 fpizlo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzcwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTEzICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uOjptX2luYmFuZFRyYWNrQ29uZmlndXJhdGlvblBlbmRpbmcgaXMgdW51c2VkIGV4 Y2VwdCB3aGVuIEhBVkUoQVZGT1VOREFUSU9OX1RFWFRfVFJBQ0tfU1VQUE9SVCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDk4NworCisgICAgICAg IFJ1YmJlciBzdGFtcGVkIGJ5IE1pY2hhZWwgU2Fib2ZmLgorCisgICAgICAgIE5vIGNoYW5nZSBp biBiZWhhdmlvciBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6TWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmg6CisgICAgICAgIChNZWRpYVBs YXllclByaXZhdGVBVkZvdW5kYXRpb24pOgorCiAyMDEyLTEyLTEzICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjEzNzY5MS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRh dGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb24uY3BwCShyZXZpc2lvbiAxMzc3MDEpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3Vu ZGF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzQsNyArNzQsOSBAQCBNZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb246Ok1lZGlhUGxhCiAgICAgLCBtX2lnbm9yZUxvYWRTdGF0ZUNoYW5n ZXMoZmFsc2UpCiAgICAgLCBtX2hhdmVSZXBvcnRlZEZpcnN0VmlkZW9GcmFtZShmYWxzZSkKICAg ICAsIG1fcGxheVdoZW5GcmFtZXNBdmFpbGFibGUoZmFsc2UpCisjaWYgSEFWRShBVkZPVU5EQVRJ T05fVEVYVF9UUkFDS19TVVBQT1JUKQogICAgICwgbV9pbmJhbmRUcmFja0NvbmZpZ3VyYXRpb25Q ZW5kaW5nKGZhbHNlKQorI2VuZGlmCiB7CiAgICAgTE9HKE1lZGlhLCAiTWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24oJXApIiwgdGhp cyk7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbi5oCShyZXZpc2lvbiAxMzc3MDEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u LmgJKHdvcmtpbmcgY29weSkKQEAgLTI5Niw3ICsyOTYsOSBAQCBwcml2YXRlOgogICAgIGJvb2wg bV9pZ25vcmVMb2FkU3RhdGVDaGFuZ2VzOwogICAgIGJvb2wgbV9oYXZlUmVwb3J0ZWRGaXJzdFZp ZGVvRnJhbWU7CiAgICAgYm9vbCBtX3BsYXlXaGVuRnJhbWVzQXZhaWxhYmxlOworI2lmIEhBVkUo QVZGT1VOREFUSU9OX1RFWFRfVFJBQ0tfU1VQUE9SVCkKICAgICBib29sIG1faW5iYW5kVHJhY2tD b25maWd1cmF0aW9uUGVuZGluZzsKKyNlbmRpZgogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQo=