104978 2012-12-13 17:02:44 -0800 Fix build warning 2012-12-14 10:21:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 sh53.lee webkit-unassigned andersca darin dglazkov haraken ktf.kim webkit-ews webkit.review.bot oldest_to_newest 791128 0 sh53.lee 2012-12-13 17:02:44 -0800 Bug 104936 incorrectly remove code that initialize downloadID. Need to initialize downloadID to fix build warning. Source/WebKit2/WebProcess/Downloads/Download.cpp:47:1: warning: unused parameter ‘downloadID’ [-Wunused-parameter] 791168 1 179387 sh53.lee 2012-12-13 17:48:50 -0800 Created attachment 179387 Patch 791176 2 179387 haraken 2012-12-13 17:57:39 -0800 Comment on attachment 179387 Patch ok 791182 3 179387 webkit-ews 2012-12-13 18:04:21 -0800 Comment on attachment 179387 Patch Attachment 179387 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15310532 791186 4 179387 ryuan.choi 2012-12-13 18:06:50 -0800 Comment on attachment 179387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179387&action=review > Source/WebKit2/WebProcess/Downloads/Download.cpp:49 > + : m_downloadID(downloadID) > : m_downloadManager(downloadManager) Oops, this is wrong. : should be , 791191 5 179391 sh53.lee 2012-12-13 18:09:35 -0800 Created attachment 179391 Patch 791194 6 179391 haraken 2012-12-13 18:10:25 -0800 Comment on attachment 179391 Patch sorry for overlooking the , 791197 7 179391 webkit-ews 2012-12-13 18:14:20 -0800 Comment on attachment 179391 Patch Attachment 179391 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15319487 791202 8 haraken 2012-12-13 18:18:25 -0800 Maybe removing the initializer might be intentional. Let's wait for a comment from the patch author (See https://bugs.webkit.org/show_bug.cgi?id=104936). 791228 9 ktf.kim 2012-12-13 18:54:00 -0800 The build error is because of the order of the initialization list. Please put the initialization of m_downloadID below the initialization of m_downloadManager same with the header. Source/WebKit2/WebProcess/Downloads/Download.cpp: In constructor ‘WebKit::Download::Download(WebKit::DownloadManager&, uint64_t, const WebCore::ResourceRequest&)’: Source/WebKit2/WebProcess/Downloads/Download.cpp:49:5: error: expected identifier before ‘,’ token Source/WebKit2/WebProcess/Downloads/Download.h:128:14: error: ‘WebKit::Download::m_downloadID’ will be initialized after [-Werror=reorder] Source/WebKit2/WebProcess/Downloads/Download.h:127:22: error: ‘WebKit::DownloadManager& WebKit::Download::m_downloadManager’ [-Werror=reorder] Source/WebKit2/WebProcess/Downloads/Download.cpp:47:1: error: when initialized here [-Werror=reorder] 791231 10 179391 webkit.review.bot 2012-12-13 18:58:18 -0800 Comment on attachment 179391 Patch Attachment 179391 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15321467 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 791248 11 179403 sh53.lee 2012-12-13 19:30:34 -0800 Created attachment 179403 Patch 791250 12 179403 haraken 2012-12-13 19:35:19 -0800 Comment on attachment 179403 Patch Let's wait for a comment from the author of the original patch before landing. 791340 13 darin 2012-12-13 22:39:00 -0800 We don’t need to wait to land this. It seems clear this was just an editing error. Please land ASAP. 791345 14 179403 webkit.review.bot 2012-12-13 22:44:16 -0800 Comment on attachment 179403 Patch Rejecting attachment 179403 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 53>At revision 159. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15321537 791348 15 179403 haraken 2012-12-13 22:49:09 -0800 Comment on attachment 179403 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179403&action=review > Source/WebKit2/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). You need to describe a change description here. (OOPS is not allowed) 791355 16 179421 sh53.lee 2012-12-13 22:56:09 -0800 Created attachment 179421 Patch 791372 17 179421 webkit.review.bot 2012-12-13 23:31:54 -0800 Comment on attachment 179421 Patch Clearing flags on attachment: 179421 Committed r137716: <http://trac.webkit.org/changeset/137716> 791373 18 webkit.review.bot 2012-12-13 23:31:58 -0800 All reviewed patches have been landed. Closing bug. 791687 19 andersca 2012-12-14 10:21:26 -0800 Thanks for fixing this! 179387 2012-12-13 17:48:50 -0800 2012-12-13 18:09:26 -0800 Patch bug-104978-20121214104609.patch text/plain 1413 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2EyNjZlZjMzNmNhNDMz NTFlOWRlYmE1YzE5NmMwMWE3OWUwOTk4MS4uNGU4Y2M3NGRlOGNhN2FjYTc1YTMwNTdjZWJlMzI2 ODQ0M2YzM2NhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTEzICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2Fy bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 OTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5p dGlhbGl6ZSBwYXJhbWV0ZXIgJ2Rvd25sb2FkSUQnIHRvIGZpeCAndW51c2VkIHBhcmFtZXRlcicg YnVpbGQgd2FybmluZy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2Fk LmNwcDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWQ6OkRvd25sb2FkKToKKwogMjAxMi0xMi0x MyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTI4MzgzNTQ+IERPTSBjb29raWUgYWNjZXNzIGZ1bmN0aW9ucyBzaG91bGQgcmVz cGVjdCBwcml2YXRlIGJyb3dzaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rv d25sb2Fkcy9Eb3dubG9hZC5jcHAKaW5kZXggNmM1ZGI3ODhiOGZhN2NjY2JkOTUwZjNjMTAwMjI0 NTcyYmQ1YmM5NC4uNWIyNjc3NDI1ZDIyNmVlMzRiOWVmZGI4NWE3YTM2N2M1MTkwMTg0YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWQuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkLmNwcApA QCAtNDUsNiArNDUsNyBAQCBQYXNzT3duUHRyPERvd25sb2FkPiBEb3dubG9hZDo6Y3JlYXRlKERv d25sb2FkTWFuYWdlciYgZG93bmxvYWRNYW5hZ2VyLCB1aW50NjRfdAogfQogCiBEb3dubG9hZDo6 RG93bmxvYWQoRG93bmxvYWRNYW5hZ2VyJiBkb3dubG9hZE1hbmFnZXIsIHVpbnQ2NF90IGRvd25s b2FkSUQsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKKyAgICA6IG1fZG93bmxvYWRJ RChkb3dubG9hZElEKQogICAgIDogbV9kb3dubG9hZE1hbmFnZXIoZG93bmxvYWRNYW5hZ2VyKQog ICAgICwgbV9yZXF1ZXN0KHJlcXVlc3QpCiAjaWYgVVNFKENGTkVUV09SSykK 179391 2012-12-13 18:09:35 -0800 2012-12-13 19:30:26 -0800 Patch bug-104978-20121214110654.patch text/plain 1477 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2EyNjZlZjMzNmNhNDMz NTFlOWRlYmE1YzE5NmMwMWE3OWUwOTk4MS4uNjEyOGE0NWY4ZmZiNjk3MmI4YTBlZDUzNzI1Y2Qy MDI0ODZhMDQ0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEyLTEzICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2Fy bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 OTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgaGFyYWtlbi4KKworICAgICAgICBJbml0aWFsaXpl IHBhcmFtZXRlciAnZG93bmxvYWRJRCcgdG8gZml4ICd1bnVzZWQgcGFyYW1ldGVyJyBidWlsZCB3 YXJuaW5nLgorICAgICAgICAqIFdlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6RG93bmxvYWQ6OkRvd25sb2FkKToKKwogMjAxMi0xMi0xMyAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTI4MzgzNTQ+IERPTSBjb29raWUgYWNjZXNzIGZ1bmN0aW9ucyBzaG91bGQgcmVzcGVjdCBwcml2 YXRlIGJyb3dzaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25s b2Fkcy9Eb3dubG9hZC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9E b3dubG9hZC5jcHAKaW5kZXggNmM1ZGI3ODhiOGZhN2NjY2JkOTUwZjNjMTAwMjI0NTcyYmQ1YmM5 NC4uMTZhYTY3MDBiMmEzZDA3YjdkMDA4Nzg3MzJlYTQwMzllYTBmNTRkMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkLmNwcApAQCAtNDUsNyAr NDUsOCBAQCBQYXNzT3duUHRyPERvd25sb2FkPiBEb3dubG9hZDo6Y3JlYXRlKERvd25sb2FkTWFu YWdlciYgZG93bmxvYWRNYW5hZ2VyLCB1aW50NjRfdAogfQogCiBEb3dubG9hZDo6RG93bmxvYWQo RG93bmxvYWRNYW5hZ2VyJiBkb3dubG9hZE1hbmFnZXIsIHVpbnQ2NF90IGRvd25sb2FkSUQsIGNv bnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKLSAgICA6IG1fZG93bmxvYWRNYW5hZ2VyKGRv d25sb2FkTWFuYWdlcikKKyAgICA6IG1fZG93bmxvYWRJRChkb3dubG9hZElEKQorICAgICwgbV9k b3dubG9hZE1hbmFnZXIoZG93bmxvYWRNYW5hZ2VyKQogICAgICwgbV9yZXF1ZXN0KHJlcXVlc3Qp CiAjaWYgVVNFKENGTkVUV09SSykKICAgICAsIG1fYWxsb3dPdmVyd3JpdGUoZmFsc2UpCg== 179403 2012-12-13 19:30:34 -0800 2012-12-13 22:56:00 -0800 Patch bug-104978-20121214122753.patch text/plain 1427 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTMyZGQ2YTVlYmM1ZGRk MDliYjc3YWY0MjI3MjljZTI5YjlkMGUyZC4uOGUzMDdkZjdiNjJhYjNlNWFmOWUyNDMyOWJlZDI1 MDUwNmI2MWFjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTEzICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2Fy bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 OTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VudGFybyBIYXJhLgorCisgICAgICAgIEFkZGl0 aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25h bGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWQuY3BwOgorICAgICAgICAo V2ViS2l0OjpEb3dubG9hZDo6RG93bmxvYWQpOgorCiAyMDEyLTEyLTEzICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJlc291cmNlIGxvYWRzIHNvbWV0aW1l cyBzdGFsbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMv RG93bmxvYWQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxv YWQuY3BwCmluZGV4IDZjNWRiNzg4YjhmYTdjY2NiZDk1MGYzYzEwMDIyNDU3MmJkNWJjOTQuLjYz OGY2N2NhZGU4ZDhiYTlkNDhmMjNlMzdlYjk4NDY2MDZkYWYzNzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZC5jcHAKQEAgLTQ2LDYgKzQ2LDcg QEAgUGFzc093blB0cjxEb3dubG9hZD4gRG93bmxvYWQ6OmNyZWF0ZShEb3dubG9hZE1hbmFnZXIm IGRvd25sb2FkTWFuYWdlciwgdWludDY0X3QKIAogRG93bmxvYWQ6OkRvd25sb2FkKERvd25sb2Fk TWFuYWdlciYgZG93bmxvYWRNYW5hZ2VyLCB1aW50NjRfdCBkb3dubG9hZElELCBjb25zdCBSZXNv dXJjZVJlcXVlc3QmIHJlcXVlc3QpCiAgICAgOiBtX2Rvd25sb2FkTWFuYWdlcihkb3dubG9hZE1h bmFnZXIpCisgICAgLCBtX2Rvd25sb2FkSUQoZG93bmxvYWRJRCkKICAgICAsIG1fcmVxdWVzdChy ZXF1ZXN0KQogI2lmIFVTRShDRk5FVFdPUkspCiAgICAgLCBtX2FsbG93T3ZlcndyaXRlKGZhbHNl KQo= 179421 2012-12-13 22:56:09 -0800 2012-12-13 23:31:54 -0800 Patch bug-104978-20121214155328.patch text/plain 1384 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTMyZGQ2YTVlYmM1ZGRk MDliYjc3YWY0MjI3MjljZTI5YjlkMGUyZC4uODQzYTNjNzkwYjk0OGNkNjA5YTVlZWYzNjkxMDIx YjUyZGJlZTA5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTEzICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2Fy bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 OTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VudGFybyBIYXJhLgorCisgICAgICAgIEluaXRp YWxpemUgcGFyYW1ldGVyICdkb3dubG9hZElEJyB0byBmaXggJ3VudXNlZCBwYXJhbWV0ZXInIGJ1 aWxkIHdhcm5pbmcuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZC5j cHA6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkOjpEb3dubG9hZCk6CisKIDIwMTItMTItMTMg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVzb3VyY2Ug bG9hZHMgc29tZXRpbWVzIHN0YWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rv d25sb2Fkcy9Eb3dubG9hZC5jcHAKaW5kZXggNmM1ZGI3ODhiOGZhN2NjY2JkOTUwZjNjMTAwMjI0 NTcyYmQ1YmM5NC4uNjM4ZjY3Y2FkZThkOGJhOWQ0OGYyM2UzN2ViOTg0NjYwNmRhZjM3OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWQuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkLmNwcApA QCAtNDYsNiArNDYsNyBAQCBQYXNzT3duUHRyPERvd25sb2FkPiBEb3dubG9hZDo6Y3JlYXRlKERv d25sb2FkTWFuYWdlciYgZG93bmxvYWRNYW5hZ2VyLCB1aW50NjRfdAogCiBEb3dubG9hZDo6RG93 bmxvYWQoRG93bmxvYWRNYW5hZ2VyJiBkb3dubG9hZE1hbmFnZXIsIHVpbnQ2NF90IGRvd25sb2Fk SUQsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKICAgICA6IG1fZG93bmxvYWRNYW5h Z2VyKGRvd25sb2FkTWFuYWdlcikKKyAgICAsIG1fZG93bmxvYWRJRChkb3dubG9hZElEKQogICAg ICwgbV9yZXF1ZXN0KHJlcXVlc3QpCiAjaWYgVVNFKENGTkVUV09SSykKICAgICAsIG1fYWxsb3dP dmVyd3JpdGUoZmFsc2UpCg==