104976 2012-12-13 16:45:02 -0800 [WK2 NetworkProcess] Resource loads sometimes stall 2012-12-14 13:26:54 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap beidson oldest_to_newest 791112 0 ap 2012-12-13 16:45:02 -0800 I don't think that use of condition variables in BlockingResponseMap is correct. There are multiple threads waiting, but only one signal(), so it resource identifier doesn't match, we're stuck forever. We should at least have a broadcast(), but ideally, we should have a design that doesn't wake up all threads. <rdar://problem/12874785> 791122 1 179377 ap 2012-12-13 16:52:17 -0800 Created attachment 179377 quick and dirty fix 791123 2 179377 andersca 2012-12-13 16:54:33 -0800 Comment on attachment 179377 quick and dirty fix View in context: https://bugs.webkit.org/attachment.cgi?id=179377&action=review > Source/WebKit2/ChangeLog:12 > + horibly inefficient, and has a race, but should improve behavior quite a bit. horibly -> horribly. > Source/WebKit2/Shared/BlockingResponseMap.h:57 > + m_condition.broadcast(); Please add a FIXME here so we won't forget about it. 791152 3 ap 2012-12-13 17:30:26 -0800 Landed in <http://trac.webkit.org/changeset/137689>. Will improve later. 791812 4 ap 2012-12-14 13:26:54 -0800 Follow-up in http://trac.webkit.org/changeset/137766 - just applied the same change to the other map. 179377 2012-12-13 16:52:17 -0800 2012-12-13 16:54:33 -0800 quick and dirty fix Broadcast.txt text/plain 1298 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzY4NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTEzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlIGxvYWRzIHNv bWV0aW1lcyBzdGFsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA0OTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUXVpY2sgYW5kIGRpcnR5IHBhcnRpYWwgZml4LgorCisgICAgICAgICogU2hhcmVkL0Js b2NraW5nUmVzcG9uc2VNYXAuaDogKEJsb2NraW5nUmVzcG9uc2VNYXA6OmRpZFJlY2VpdmVSZXNw b25zZSk6CisgICAgICAgIFdha2UgdXAgYWxsIHRocmVhZHMsIHNvIHRoYXQgbm9uLXNlcXVlbnRp YWwgcmVzcG9uc2VzIGRvbid0IGJyZWFrIHVzLiBUaGlzIGlzIHN0aWxsCisgICAgICAgIGhvcmli bHkgaW5lZmZpY2llbnQsIGFuZCBoYXMgYSByYWNlLCBidXQgc2hvdWxkIGltcHJvdmUgYmVoYXZp b3IgcXVpdGUgYSBiaXQuCisKIDIwMTItMTItMTMgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFA Y29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IFJlb3JkZXIg bWVzc2FnZXMgdG8gQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHkKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9CbG9ja2luZ1Jlc3BvbnNlTWFwLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvU2hhcmVkL0Jsb2NraW5nUmVzcG9uc2VNYXAuaAkocmV2aXNpb24gMTM3NjE5KQor KysgU291cmNlL1dlYktpdDIvU2hhcmVkL0Jsb2NraW5nUmVzcG9uc2VNYXAuaAkod29ya2luZyBj b3B5KQpAQCAtNTQsNyArNTQsNyBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVCghbV9yZXNwb25z ZXMuY29udGFpbnMocmVxdWVzdElEKSk7CiAKICAgICAgICAgbV9yZXNwb25zZXMuc2V0KHJlcXVl c3RJRCwgcmVzcG9uc2UpOwotICAgICAgICBtX2NvbmRpdGlvbi5zaWduYWwoKTsKKyAgICAgICAg bV9jb25kaXRpb24uYnJvYWRjYXN0KCk7CiAgICAgfQogCiBwcml2YXRlOgo=