104973 2012-12-13 16:21:19 -0800 [chromium] Remove unnecessary compile guards in WebContentLayerClient.h 2013-01-03 11:02:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 105971 P2 Normal --- 1 alokp alokp abarth dglazkov enne fishd jamesr peter+ews tkent+wkapi webkit.review.bot oldest_to_newest 791074 0 alokp 2012-12-13 16:21:19 -0800 WEBCONTENTLAYERCLIENT_HAS_OPAQUE WEBCONTENTLAYERCLIENT_FLOAT_OPAQUE_RECT WEBCONTENTLAYERCLIENT_HAS_CANPAINTLCDTEXT These are not needed anymore. Chromium patch to remove the dependency on WEBCONTENTLAYERCLIENT_HAS_CANPAINTLCDTEXT is in CQ. 791082 1 179370 alokp 2012-12-13 16:25:10 -0800 Created attachment 179370 Patch 791083 2 179370 enne 2012-12-13 16:26:42 -0800 Comment on attachment 179370 Patch R=me. 791085 3 webkit.review.bot 2012-12-13 16:26:44 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 791096 4 179370 webkit.review.bot 2012-12-13 16:33:46 -0800 Comment on attachment 179370 Patch Attachment 179370 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15311467 791165 5 179370 peter+ews 2012-12-13 17:47:06 -0800 Comment on attachment 179370 Patch Attachment 179370 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15322437 791264 6 jamesr 2012-12-13 20:05:21 -0800 You need to roll the chromium patch into Source/WebKit/chromium/DEPS before this can land safely. 791705 7 alokp 2012-12-14 10:47:40 -0800 (In reply to comment #6) > You need to roll the chromium patch into Source/WebKit/chromium/DEPS before this can land safely. All references to WEBCONTENTLAYERCLIENT_HAS_CANPAINTLCDTEXT in chromium were deleted in chromium r173101. Chromium rev in WebKit has been rolled to 173133. OK to commit? 799470 8 alokp 2013-01-03 10:37:41 -0800 ping! 799477 9 enne 2013-01-03 10:42:51 -0800 (In reply to comment #8) > ping! You're the committer here. :) Go ahead and CQ it or put up another patch for EWS if you're feeling more paranoid. 799480 10 179370 alokp 2013-01-03 10:45:13 -0800 Comment on attachment 179370 Patch I thought I had to wait for fishd/jamesr. Adding to CQ. 799484 11 179370 webkit.review.bot 2013-01-03 10:46:54 -0800 Comment on attachment 179370 Patch Rejecting attachment 179370 from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/Platform/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/Platform/chromium/public/WebContentLayerClient.h Hunk #1 FAILED at 41. 1 out of 1 hunk FAILED -- saving rejects to file Source/Platform/chromium/public/WebContentLayerClient.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adrienne W..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15665159 799492 12 alokp 2013-01-03 11:02:37 -0800 jamesr already committed an equivalent patch in r138687. *** This bug has been marked as a duplicate of bug 105971 *** 179370 2012-12-13 16:25:10 -0800 2013-01-03 10:46:54 -0800 Patch bug-104973-20121213162230.patch text/plain 1772 alokp U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBhN2RlNGU0NzhhYmRj N2MxOWVkNWI1YmQ3NzM2OGQwMzE4YmM2MTA3Li5mMDlkNWExNTg1MGU2NGQ2ZGIwYjJhYzc2YWY4 OWFiODRlNjJhODI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMi0xMyAg QWxvayBQcml5YWRhcnNoaSAgPGFsb2twQGNocm9taXVtLm9yZz4KKworICAgICAgICBEZWxldGUg dW5uZWNlc3NhcnkgY29tcGlsZSBndWFyZHMuCisKKyAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUg dW5uZWNlc3NhcnkgY29tcGlsZSBndWFyZHMgaW4gV2ViQ29udGVudExheWVyQ2xpZW50LmgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDk3MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlbGV0ZWQgZGVw cmVjYXRlZCBkZWZpbmVzOgorICAgICAgICAtIFdFQkNPTlRFTlRMQVlFUkNMSUVOVF9IQVNfT1BB UVVFCisgICAgICAgIC0gV0VCQ09OVEVOVExBWUVSQ0xJRU5UX0ZMT0FUX09QQVFVRV9SRUNUCisg ICAgICAgIC0gV0VCQ09OVEVOVExBWUVSQ0xJRU5UX0hBU19DQU5QQUlOVExDRFRFWFQKKworICAg ICAgICAqIGNocm9taXVtL3B1YmxpYy9XZWJDb250ZW50TGF5ZXJDbGllbnQuaDoKKyAgICAgICAg KFdlYkNvbnRlbnRMYXllckNsaWVudCk6CisKIDIwMTItMTItMTIgIEdhdmluIFBldGVycyAgPGdh dmlucEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBZGQgZGVzdHJ1Y3RvciB0 byBXZWJQcmVyZW5kZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJs aWMvV2ViQ29udGVudExheWVyQ2xpZW50LmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVi bGljL1dlYkNvbnRlbnRMYXllckNsaWVudC5oCmluZGV4IDgyNzRkOWUzOTcwYmQwMjlkNGVlYmZh NWI2NDFkYzE2MjYzNTg3NzIuLjU2NDFhNGViNjc1YzIxNjBiNTg5ZjIwNTAzMTE4Nzc3NTdlNjk0 OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGVu dExheWVyQ2xpZW50LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJD b250ZW50TGF5ZXJDbGllbnQuaApAQCAtNDEsOSArNDEsNiBAQCBwdWJsaWM6CiAgICAgLy8gT3B0 aW9uYWxseSwgdGhlIGltcGxlbWVudGF0aW9uIG1heSBzZXQgfG9wYXF1ZXwgdG8gYSByZWN0IGNv dmVyaW5nIHBpeGVscyB0aGF0CiAgICAgLy8gdGhlIGltcGxlbWVudGF0aW9uIGtub3dzIGFyZSBv cGFxdWUuIFRoaXMgaW5mb3JtYXRpb24gY2FuIGJlIHVzZWQgZm9yIHZhcmlvdXMKICAgICAvLyBv cHRpbWl6YXRpb25zLgotI2RlZmluZSBXRUJDT05URU5UTEFZRVJDTElFTlRfSEFTX09QQVFVRSAx Ci0jZGVmaW5lIFdFQkNPTlRFTlRMQVlFUkNMSUVOVF9GTE9BVF9PUEFRVUVfUkVDVCAxCi0jZGVm aW5lIFdFQkNPTlRFTlRMQVlFUkNMSUVOVF9IQVNfQ0FOUEFJTlRMQ0RURVhUIDEKICAgICB2aXJ0 dWFsIHZvaWQgcGFpbnRDb250ZW50cyhXZWJDYW52YXMqLCBjb25zdCBXZWJSZWN0JiBjbGlwLCBi b29sIGNhblBhaW50TENEVGV4dCwgV2ViRmxvYXRSZWN0JiBvcGFxdWUpID0gMDsKIAogcHJvdGVj dGVkOgo=